From nobody Mon Feb 9 16:50:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1602060938; cv=none; d=zohomail.com; s=zohoarc; b=BjO01rFCI1F4njKA3i/LZL1EL6vgAdTqe4ky/9zOY7dE7S1DqY5TJYYQh8oxQvG269Q1yw2z94y042iuMy74x/HVvX+MC0UZKBZPcDozNXkOXh+mhyG4hcnZoZx9vhifO/3ImjU8rtySnWYeyDTTKwuoicqhrpkdUr//mZkhWh8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1602060938; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=njsge6VVWN2mjMGnCH+l6eIlZKveykFQmKsLEgI2aLc=; b=Yl+LLwzh07vsy+KclfsTz8f3YCgDLqORXJtDkVYnGw2lA7e8pSd4lA15BzozoZGa8vQ1FT3tsYL2+8oqs2Li9zH1WnJvlc5GDHWCyhuFjynRMTlA+C+MUDS7ZAm1DgLwK8VVSQ6sWHoTFDUc0Pc6ifkNreSFc9RfmQm6Icn0Rj0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1602060938175654.2419569776799; Wed, 7 Oct 2020 01:55:38 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-25-tsN6AsvJMyGagT86y5AniA-1; Wed, 07 Oct 2020 04:55:34 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CE63810A02E4; Wed, 7 Oct 2020 08:55:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AABAD5D9F7; Wed, 7 Oct 2020 08:55:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 73293181A07C; Wed, 7 Oct 2020 08:55:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0978t7Mj016906 for ; Wed, 7 Oct 2020 04:55:07 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4756B7664C; Wed, 7 Oct 2020 08:55:07 +0000 (UTC) Received: from work.redhat.com (ovpn-112-213.ams2.redhat.com [10.36.112.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8CCCE76644; Wed, 7 Oct 2020 08:55:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602060936; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=njsge6VVWN2mjMGnCH+l6eIlZKveykFQmKsLEgI2aLc=; b=E7ic/bJs2X05oUzjtkb7hYsRg8XXw0UPNANkoCJ5n1q8wV0bFsBEPa3MFLUC0M/cGizCeb +1D9MUZe8G7vWziEfiflklCT81TxEYA5bXjEP+lcgJ26I9BOIuTBHm1BLITA1U4GzPQknA mpv7vrUBxfvThaOQD7IgF59cU6AY1Qg= X-MC-Unique: tsN6AsvJMyGagT86y5AniA-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH v4 3/5] tests: Rename some test files in cputestdata Date: Wed, 7 Oct 2020 10:54:56 +0200 Message-Id: <20201007085458.231179-4-twiederh@redhat.com> In-Reply-To: <20201007085458.231179-1-twiederh@redhat.com> References: <20201007085458.231179-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The files contained the "-invalid" marker in their filename, marking them as test cases that are supposed to fail. Unfortunately, the "-invalid" marker does not discriminate between different tests the files might be used in. A later patch will introduce a new test validating the XML. This test is not supposed to fail, as the files contain valid XML. Signed-off-by: Tim Wiederhake Reviewed-by: Peter Krempa --- tests/cputest.c | 10 +++++----- ...t-compat-invalid.xml =3D> ppc64-guest-compat-bad.xml} | 0 ...t-legacy-invalid.xml =3D> ppc64-guest-legacy-bad.xml} | 0 ...pat-invalid.xml =3D> ppc64-host+guest-compat-bad.xml} | 0 ...acy-invalid.xml =3D> ppc64-host+guest-legacy-bad.xml} | 0 5 files changed, 5 insertions(+), 5 deletions(-) rename tests/cputestdata/{ppc64-guest-compat-invalid.xml =3D> ppc64-guest-= compat-bad.xml} (100%) rename tests/cputestdata/{ppc64-guest-legacy-invalid.xml =3D> ppc64-guest-= legacy-bad.xml} (100%) rename tests/cputestdata/{ppc64-host+guest-compat-invalid.xml =3D> ppc64-h= ost+guest-compat-bad.xml} (100%) rename tests/cputestdata/{ppc64-host+guest-legacy-invalid.xml =3D> ppc64-h= ost+guest-legacy-bad.xml} (100%) diff --git a/tests/cputest.c b/tests/cputest.c index 78a7f2437a..90f319bf9c 100644 --- a/tests/cputest.c +++ b/tests/cputest.c @@ -1137,10 +1137,10 @@ mymain(void) DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-exact", VIR_CPU_COMPARE= _INCOMPATIBLE); DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-legacy", VIR_CPU_COMPAR= E_IDENTICAL); DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-legacy-incompatible", V= IR_CPU_COMPARE_INCOMPATIBLE); - DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-legacy-invalid", VIR_CP= U_COMPARE_ERROR); + DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-legacy-bad", VIR_CPU_CO= MPARE_ERROR); DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-compat-none", VIR_CPU_C= OMPARE_IDENTICAL); DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-compat-valid", VIR_CPU_= COMPARE_IDENTICAL); - DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-compat-invalid", VIR_CP= U_COMPARE_ERROR); + DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-compat-bad", VIR_CPU_CO= MPARE_ERROR); DO_TEST_COMPARE(VIR_ARCH_PPC64, "host", "guest-compat-incompatible", V= IR_CPU_COMPARE_INCOMPATIBLE); =20 /* guest updates for migration @@ -1158,10 +1158,10 @@ mymain(void) DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-nofallback", VIR_CPU_COM= PARE_INCOMPATIBLE); DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-legacy", VIR_CPU_COMPARE= _IDENTICAL); DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-legacy-incompatible", VI= R_CPU_COMPARE_INCOMPATIBLE); - DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-legacy-invalid", VIR_CPU= _COMPARE_ERROR); + DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-legacy-bad", VIR_CPU_COM= PARE_ERROR); DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-compat-none", VIR_CPU_CO= MPARE_IDENTICAL); DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-compat-valid", VIR_CPU_C= OMPARE_IDENTICAL); - DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-compat-invalid", VIR_CPU= _COMPARE_ERROR); + DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-compat-bad", VIR_CPU_COM= PARE_ERROR); DO_TEST_UPDATE(VIR_ARCH_PPC64, "host", "guest-compat-incompatible", VI= R_CPU_COMPARE_INCOMPATIBLE); =20 /* computing baseline CPUs */ @@ -1216,7 +1216,7 @@ mymain(void) DO_TEST_GUESTCPU(VIR_ARCH_PPC64, "host", "guest-nofallback", ppc_model= s, -1); DO_TEST_GUESTCPU(VIR_ARCH_PPC64, "host", "guest-legacy", ppc_models, 0= ); DO_TEST_GUESTCPU(VIR_ARCH_PPC64, "host", "guest-legacy-incompatible", = ppc_models, -1); - DO_TEST_GUESTCPU(VIR_ARCH_PPC64, "host", "guest-legacy-invalid", ppc_m= odels, -1); + DO_TEST_GUESTCPU(VIR_ARCH_PPC64, "host", "guest-legacy-bad", ppc_model= s, -1); =20 DO_TEST_CPUID(VIR_ARCH_X86_64, "A10-5800K", JSON_HOST); DO_TEST_CPUID(VIR_ARCH_X86_64, "Atom-D510", JSON_NONE); diff --git a/tests/cputestdata/ppc64-guest-compat-invalid.xml b/tests/cpute= stdata/ppc64-guest-compat-bad.xml similarity index 100% rename from tests/cputestdata/ppc64-guest-compat-invalid.xml rename to tests/cputestdata/ppc64-guest-compat-bad.xml diff --git a/tests/cputestdata/ppc64-guest-legacy-invalid.xml b/tests/cpute= stdata/ppc64-guest-legacy-bad.xml similarity index 100% rename from tests/cputestdata/ppc64-guest-legacy-invalid.xml rename to tests/cputestdata/ppc64-guest-legacy-bad.xml diff --git a/tests/cputestdata/ppc64-host+guest-compat-invalid.xml b/tests/= cputestdata/ppc64-host+guest-compat-bad.xml similarity index 100% rename from tests/cputestdata/ppc64-host+guest-compat-invalid.xml rename to tests/cputestdata/ppc64-host+guest-compat-bad.xml diff --git a/tests/cputestdata/ppc64-host+guest-legacy-invalid.xml b/tests/= cputestdata/ppc64-host+guest-legacy-bad.xml similarity index 100% rename from tests/cputestdata/ppc64-host+guest-legacy-invalid.xml rename to tests/cputestdata/ppc64-host+guest-legacy-bad.xml --=20 2.26.2