From nobody Mon Feb 9 10:27:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601923294; cv=none; d=zohomail.com; s=zohoarc; b=a8zzZdCK1POGe92L/Ek3XF9/0EACNVfGbU7UohM3hojmlKWCbX8TI71d6dTwGPExa4AIoLzJdMzAfrFXf1Lya2Il+Hah5vPDJjMz1y5HqNAP1psUXxvhNrR4V94tPN+Z79A/Qw7VLVb/n9hxiixGUJirLMANieqquudHf5NSC+U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601923294; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vsjLq1ps0HUh7Aj5ICSldEb+tnX5jK1WsZ4+4j92yOs=; b=U3YCV5kSfbuCgHSsm5JjoVt+Ub/GR66BM8r9W9hBV7WOttrGbaP10/R2GrdlPEfk1kPvS/mSBq1ffhaWtPJ8dCyHFFYh+qGVaO2suXY/nrXcTuZFEol6aNh5VHCgb9HN0JH7nYwj/f9ITd51c27ohJxiZeSvve2hX3KrxBehoxk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1601923294208310.6860451192322; Mon, 5 Oct 2020 11:41:34 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-225-vgobFBWEOFqvw-j1PA8kHA-1; Mon, 05 Oct 2020 14:41:00 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 67E32191F548; Mon, 5 Oct 2020 18:40:52 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 474D61002EF9; Mon, 5 Oct 2020 18:40:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 0F47A44A75; Mon, 5 Oct 2020 18:40:52 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 095Ied3M022702 for ; Mon, 5 Oct 2020 14:40:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0943F73666; Mon, 5 Oct 2020 18:40:39 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.192.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A01073687 for ; Mon, 5 Oct 2020 18:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601923293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vsjLq1ps0HUh7Aj5ICSldEb+tnX5jK1WsZ4+4j92yOs=; b=W9L/QVYGsed+RGAezbfmKCr2KPrZ6vZDoNbf7TJma1hUUGkQqax6mXWY8AGVoV6V1GevKS j4oG3I5NMoXjBkdRVDXJCi0kHjGUpAvjwOMfCM/6QfBvvr9j1aWXlRQBB6z4NQ1jeRh03f cmZSPmSlCLKxVdPAgexdNTyzZuuhSxE= X-MC-Unique: vgobFBWEOFqvw-j1PA8kHA-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 8/9] spec: Refactor qemu_kvm_arches definition Date: Mon, 5 Oct 2020 20:40:23 +0200 Message-Id: <20201005184024.266109-9-abologna@redhat.com> In-Reply-To: <20201005184024.266109-1-abologna@redhat.com> References: <20201005184024.266109-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" There's no need to set a default for it if we're going to override it immediately afterwards anyway, and setting with_qemu_tcg at the same time only makes things more confusing. Signed-off-by: Andrea Bolognani Reviewed-by: Neal Gompa --- libvirt.spec.in | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index e036307d30..b62b17ee80 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -17,31 +17,31 @@ %define _vpath_builddir %{_target_platform} %endif =20 +%if 0%{?fedora} + %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aar= ch64 +%else + %define qemu_kvm_arches x86_64 %{power64} aarch64 s390x +%endif + # The hypervisor drivers that run in libvirtd %define with_qemu 0%{!?_without_qemu:1} %define with_lxc 0%{!?_without_lxc:1} %define with_libxl 0%{!?_without_libxl:1} %define with_vbox 0%{!?_without_vbox:1} =20 -%define with_qemu_tcg %{with_qemu} - -%define qemu_kvm_arches %{ix86} x86_64 - -%if 0%{?fedora} - %define qemu_kvm_arches %{ix86} x86_64 %{power64} s390x %{arm} aarch64 -%endif - -%if 0%{?rhel} - %define with_qemu_tcg 0 - %define qemu_kvm_arches x86_64 %{power64} aarch64 s390x -%endif - %ifarch %{qemu_kvm_arches} %define with_qemu_kvm %{with_qemu} %else %define with_qemu_kvm 0 %endif =20 +%define with_qemu_tcg %{with_qemu} + +# RHEL disables TCG on all architectures +%if 0%{?rhel} + %define with_qemu_tcg 0 +%endif + %if ! %{with_qemu_tcg} && ! %{with_qemu_kvm} %define with_qemu 0 %endif --=20 2.26.2