From nobody Mon Feb 9 12:24:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1601923257; cv=none; d=zohomail.com; s=zohoarc; b=ni2AqdHgbDLT20XQD0KQTZzalSTxI5YVo26ZaoaG0YgrWur9dTZgP2dLvayWRyQM8szrweVo1NYKqW5mwi9w2Tv4X53AZCzOaW0pCTNlzVZXXc2epotCV39k0BKspeIwBddxCOvKVqPMnuQPEskx9EDdSZZKEap3WSaOBkWCt3Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1601923257; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zONjwe40r10B/s5eLX6FOTYmNYrW4/uHkstjsq6Zzlg=; b=E2lXeI1zkxTMHEJlraxoYtsnr0I3d44GO2WVE68wkZcs4nu3sao6zFoA5T12mIptola7hISCMsI+nl4OwP704kKUZdgOzIIQl8YUsm2ycStUJzI4w9Qgco56RKv47Iq3Nkdz0+I2UhaEwWVm72mE3sOV1MH9HYZQs4dmejrcVMQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1601923257089293.0891892945906; Mon, 5 Oct 2020 11:40:57 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-6fJ7IIzzOfC-J9_NK1-dRg-1; Mon, 05 Oct 2020 14:40:50 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0344F801AE2; Mon, 5 Oct 2020 18:40:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D35B860C11; Mon, 5 Oct 2020 18:40:44 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9F6791826D2E; Mon, 5 Oct 2020 18:40:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 095IeVlV022630 for ; Mon, 5 Oct 2020 14:40:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 22CB173673; Mon, 5 Oct 2020 18:40:31 +0000 (UTC) Received: from harajuku.usersys.redhat.com (unknown [10.40.192.153]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4F36973666 for ; Mon, 5 Oct 2020 18:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601923253; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zONjwe40r10B/s5eLX6FOTYmNYrW4/uHkstjsq6Zzlg=; b=MB9W2Q62psMzht57eA62K6sQ/7XZwRvZdz2AagokCifzTHKCln8gt8xQPiBfwTe/gQgymf MuCWoJJtrxpb/IjjFhdzQMQkbHbRkT1CVRRwfIa7UnqNsZ1RG4hLcybd4RG+pW3wJTg8GL EzoLROskMvO/SqtWSIhwHnWK+r86lbs= X-MC-Unique: 6fJ7IIzzOfC-J9_NK1-dRg-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 2/9] spec: firewalld is always enabled Date: Mon, 5 Oct 2020 20:40:17 +0200 Message-Id: <20201005184024.266109-3-abologna@redhat.com> In-Reply-To: <20201005184024.266109-1-abologna@redhat.com> References: <20201005184024.266109-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Knowing this, we can remove some code. Signed-off-by: Andrea Bolognani Reviewed-by: Neal Gompa --- libvirt.spec.in | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 815ab246e9..4572044d2d 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -88,7 +88,6 @@ %define with_fuse 0 %define with_sanlock 0 %define with_numad 0 -%define with_firewalld 0 %define with_firewalld_zone 0 %define with_libssh2 0 %define with_wireshark 0 @@ -138,8 +137,6 @@ %endif %endif =20 -%define with_firewalld 1 - %if 0%{?fedora} || 0%{?rhel} > 7 %define with_firewalld_zone 0%{!?_without_firewalld_zone:1} %endif @@ -1088,12 +1085,6 @@ exit 1 %define arg_sanlock -Dsanlock=3Ddisabled %endif =20 -%if %{with_firewalld} - %define arg_firewalld -Dfirewalld=3Denabled -%else - %define arg_firewalld -Dfirewalld=3Ddisabled -%endif - %if %{with_firewalld_zone} %define arg_firewalld_zone -Dfirewalld_zone=3Denabled %else @@ -1169,7 +1160,7 @@ export SOURCE_DATE_EPOCH=3D$(stat --printf=3D'%Y' %{_= specdir}/%{name}.spec) -Dlibpcap=3Denabled \ -Daudit=3Denabled \ -Ddtrace=3Denabled \ - %{?arg_firewalld} \ + -Dfirewalld=3Denabled \ %{?arg_firewalld_zone} \ %{?arg_wireshark} \ -Dpm_utils=3Ddisabled \ --=20 2.26.2