From nobody Tue May 7 04:48:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600791393; cv=none; d=zohomail.com; s=zohoarc; b=Wau94hduNOP4v4J8BvTfQZlQPBEB3JWQXuX6hgrLl5+KbX1uQV/P/O1y1RJMMPx0vNa0U1zDw7ckKGw6sYmx3Tlc+lJN1k53s+x+zbzpEdV3c4l6ki/2byVzgirgZNvA3FAzW/eZEfEXxoSU/Bii8NmYeG6Y7b/NpUWCPTz7pWA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600791393; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lqvEqWFLvdt/dk2Iy1EXJEr/nwkIoaFww48chZD0ldU=; b=grJqZvRNcgx6gEqCUOTMqx7gPTVjA7HtPlzER2FUFsUtK/WKjmBIS7bNruPmPKb2iODRJBedw6xPcN6W+HCZ/0dG2lGbDXgDcO1toCgPZA9t/mfbMklvRtj9vzqiXxqLVozp2az47m1X24qTpImxcV7gF64QjCHJT/iiZkhV340= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1600791393711443.15539703101865; Tue, 22 Sep 2020 09:16:33 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-2Mj5XtXZPoidHUpBef0JOA-1; Tue, 22 Sep 2020 12:16:29 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3307B801AB3; Tue, 22 Sep 2020 16:16:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7756E60BF4; Tue, 22 Sep 2020 16:16:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9248718A199A; Tue, 22 Sep 2020 16:16:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08MGGK1I012589 for ; Tue, 22 Sep 2020 12:16:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9795F7368D; Tue, 22 Sep 2020 16:16:20 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-114-64.ams2.redhat.com [10.36.114.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1C59D614F5; Tue, 22 Sep 2020 16:16:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600791392; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=lqvEqWFLvdt/dk2Iy1EXJEr/nwkIoaFww48chZD0ldU=; b=NddEU8YeokjpzHtZxLhBiB/BXq7nNp/Odbvde1GZgyYESOPJtPSek0vDGu5GLe+bWqipUV MHKoJCg8DsRznNkbhlvwilIXOKPt/+UcURBznF4RK1/h25ceFZRaPMHExSgm15r/b4TuA9 e7oWUK/ly2+CxqgAbobp6tbCSWQ7cqc= X-MC-Unique: 2Mj5XtXZPoidHUpBef0JOA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 1/2] block: drop moderated sheepdog mailing list from MAINTAINERS file Date: Tue, 22 Sep 2020 17:16:10 +0100 Message-Id: <20200922161611.2049616-2-berrange@redhat.com> In-Reply-To: <20200922161611.2049616-1-berrange@redhat.com> References: <20200922161611.2049616-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Kevin Wolf , Thomas Huth , sheepdog@lists.wpkg.org, qemu-block@nongnu.org, libvir-list@redhat.com, Max Reitz , Liu Yuan , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The sheepdog mailing list is setup to stop and queue messages from non-subscribers, pending moderator approval. Unfortunately it seems that the moderation queue is not actively dealt with. Even when messages are approved, the sender is never added to the whitelist, so every future mail from the same sender continues to get stopped for moderation. MAINTAINERS entries should be responsive and not unneccessarily block mails from QEMU contributors, so drop the sheepdog mailing list. Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Neal Gompa Reviewed-by: Thomas Huth Reviewed-by: Vladimir Sementsov-Ogievskiy --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3d17cad19a..8e8a4fb0a8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2852,7 +2852,6 @@ F: block/rbd.c Sheepdog M: Liu Yuan L: qemu-block@nongnu.org -L: sheepdog@lists.wpkg.org S: Odd Fixes F: block/sheepdog.c =20 --=20 2.26.2 From nobody Tue May 7 04:48:32 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1600791437; cv=none; d=zohomail.com; s=zohoarc; b=Bq6AcJifWbExKxaH8HWXlbqDO6GN6HYJoTEiBijaAsKde6zwZm4X/wRg3Z1xnYPBUFDlWiEjbz678QB0WCezMg/2rURClkKrN5SSccW2q/rZRy9jazX5PQp78kE4sKVKluutuv7WgpED7vqQXN060wTMucIl1K00GGu4wDcxwro= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600791437; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=iwEQDYfn/Lg+g1mQ9S5XrCxNNdGNw5kmTMOlktUeDoA=; b=V2ob5qBpCtd9GJR0rswzw5kmXv4DNT7dkwPCHlw28WqY3AYZuqwKdp9McmA2blxeTeQDe1t+GwAod+xLg0+ZPuitndSOeC1aZGkQVLC/QCUF8ym5oz0Nx/GBN+OYc/r8Ie3I7iembcvwUDvCbg8V4htnvc+N+KzJT5DhXUu+vqA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1600791437909921.3146652706555; Tue, 22 Sep 2020 09:17:17 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-119-nnUI7nFgNgCx6zNsOic5hA-1; Tue, 22 Sep 2020 12:16:39 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8B41ACE31; Tue, 22 Sep 2020 16:16:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A2D7760C05; Tue, 22 Sep 2020 16:16:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 612F144A46; Tue, 22 Sep 2020 16:16:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08MGGNNN012609 for ; Tue, 22 Sep 2020 12:16:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id AB7CC73684; Tue, 22 Sep 2020 16:16:23 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-114-64.ams2.redhat.com [10.36.114.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0B4F873689; Tue, 22 Sep 2020 16:16:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600791436; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=iwEQDYfn/Lg+g1mQ9S5XrCxNNdGNw5kmTMOlktUeDoA=; b=aCRL1qnQ4RCQpWVXj49BL65YTN2lvbRtnDYJ5b4IPlAJH5xUKXknAWsjnWfKlA/hm/NGf8 2ldNBkAoPO5C2QWtjzloLJWxUCzM4dy95Eh9fkxVUav+N8J4iESWXfCVfev59UHpLkkau4 948vm+8IyYFBzW3NJR93KtauSQzi4dM= X-MC-Unique: nnUI7nFgNgCx6zNsOic5hA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 2/2] block: deprecate the sheepdog block driver Date: Tue, 22 Sep 2020 17:16:11 +0100 Message-Id: <20200922161611.2049616-3-berrange@redhat.com> In-Reply-To: <20200922161611.2049616-1-berrange@redhat.com> References: <20200922161611.2049616-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: Kevin Wolf , Thomas Huth , sheepdog@lists.wpkg.org, qemu-block@nongnu.org, libvir-list@redhat.com, Max Reitz , Liu Yuan X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) This thread from a little over a year ago: http://lists.wpkg.org/pipermail/sheepdog/2019-March/thread.html states that sheepdog is no longer actively developed. The only mentioned users are some companies who are said to have it for legacy reasons with plans to replace it by Ceph. There is talk about cutting out existing features to turn it into a simple demo of how to write a distributed block service. There is no evidence of anyone working on that idea: https://github.com/sheepdog/sheepdog/commits/master No real commits to git since Jan 2018, and before then just some minor technical debt cleanup.. There is essentially no activity on the mailing list aside from patches to QEMU that get CC'd due to our MAINTAINERS entry. Fedora packages for sheepdog failed to build from upstream source because of the more strict linker that no longer merges duplicate global symbols. Fedora patches it to add the missing "extern" annotations and presumably other distros do to, but upstream source remains broken. There is only basic compile testing, no functional testing of the driver. Since there are no build pre-requisites the sheepdog driver is currently enabled unconditionally. This would result in configure issuing a deprecation warning by default for all users. Thus the configure default is changed to disable it, requiring users to pass --enable-sheepdog to build the driver. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Markus Armbruster Reviewed-by: Neal Gompa Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Thomas Huth Reviewed-by: Vladimir Sementsov-Ogievskiy --- block/sheepdog.c | 15 +++++++++++++++ configure | 5 +++-- docs/system/deprecated.rst | 9 +++++++++ 3 files changed, 27 insertions(+), 2 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index cbbebc1aaf..7f68bd6a1a 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -242,6 +242,17 @@ typedef struct SheepdogInode { */ #define FNV1A_64_INIT ((uint64_t)0xcbf29ce484222325ULL) =20 +static void deprecation_warning(void) +{ + static bool warned =3D false; + + if (!warned) { + warn_report("the sheepdog block driver is deprecated and will be " + "removed in a future release"); + warned =3D true; + } +} + /* * 64 bit Fowler/Noll/Vo FNV-1a hash code */ @@ -1548,6 +1559,8 @@ static int sd_open(BlockDriverState *bs, QDict *optio= ns, int flags, char *buf =3D NULL; QemuOpts *opts; =20 + deprecation_warning(); + s->bs =3D bs; s->aio_context =3D bdrv_get_aio_context(bs); =20 @@ -2007,6 +2020,8 @@ static int sd_co_create(BlockdevCreateOptions *option= s, Error **errp) =20 assert(options->driver =3D=3D BLOCKDEV_DRIVER_SHEEPDOG); =20 + deprecation_warning(); + s =3D g_new0(BDRVSheepdogState, 1); =20 /* Steal SocketAddress from QAPI, set NULL to prevent double free */ diff --git a/configure b/configure index 7564479008..c6af83f2e6 100755 --- a/configure +++ b/configure @@ -533,7 +533,7 @@ vdi=3D"yes" vvfat=3D"yes" qed=3D"yes" parallels=3D"yes" -sheepdog=3D"yes" +sheepdog=3D"no" libxml2=3D"" debug_mutex=3D"no" libpmem=3D"" @@ -1941,7 +1941,7 @@ disabled with --disable-FEATURE, default is enabled i= f available: vvfat vvfat image format support qed qed image format support parallels parallels image format support - sheepdog sheepdog block driver support + sheepdog sheepdog block driver support (deprecated) crypto-afalg Linux AF_ALG crypto backend driver capstone capstone disassembler support debug-mutex mutex debugging support @@ -7350,6 +7350,7 @@ if test "$parallels" =3D "yes" ; then echo "CONFIG_PARALLELS=3Dy" >> $config_host_mak fi if test "$sheepdog" =3D "yes" ; then + add_to deprecated_features "sheepdog" echo "CONFIG_SHEEPDOG=3Dy" >> $config_host_mak fi if test "$pty_h" =3D "yes" ; then diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 0cb8b01424..49b9f4b02e 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -405,6 +405,15 @@ The above, converted to the current supported format:: =20 json:{"file.driver":"rbd", "file.pool":"rbd", "file.image":"name"} =20 +``sheepdog`` driver (since 5.2.0) +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ + +The ``sheepdog`` block device driver is deprecated. The corresponding upst= ream +server project is no longer actively maintained. Users are recommended to = switch +to an alternative distributed block device driver such as RBD. The +``qemu-img convert`` command can be used to liberate existing data by movi= ng +it out of sheepdog volumes into an alternative storage backend. + linux-user mode CPUs -------------------- =20 --=20 2.26.2