From nobody Fri Mar 29 00:04:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1600240706; cv=none; d=zohomail.com; s=zohoarc; b=eIUPnGbhCiIw3nWNvFrFc3Gea0/D3a0bI/uT1tsjkk9eeefZgm46A86KWNU/nFUUYVuHVL5Pt+Gu6vfdaOIi/ndGNkKYYBh5R3DzMCpx7ce3W6rJpIoet5RiCIkRZSejgnzzk8PTuuQmy0ONiDyTi1UYkVJ30IWQUH67ZqMmDhg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600240706; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=DqSNURj9Ai2V3TTZcOMHc1cLas/lBuSeSczufk46P5I=; b=lZXvIzJF7g0sxxqQp3VJ+Gl0DwFopcMP6TcHzDnm5Zc2Ru6qDJPccWYoZP7lXcRVAJ8GfzkilV14mixVp1UnNBFoy5jemD01QDcza7UOmpedAMRQHx0yKNUFefo00O2Js9hV01F7JkTOv1It1XvHfi1DU88Cqar5dEWBJmdHUuI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1600240706632960.7810851518058; Wed, 16 Sep 2020 00:18:26 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-1-2H3oEOfPPVyDDHjL_FKyjw-1; Wed, 16 Sep 2020 03:18:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 36448101873E; Wed, 16 Sep 2020 07:18:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 12E3C60CCC; Wed, 16 Sep 2020 07:18:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A175744A65; Wed, 16 Sep 2020 07:18:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08G7I43q022915 for ; Wed, 16 Sep 2020 03:18:04 -0400 Received: by smtp.corp.redhat.com (Postfix) id 609C9F18D2; Wed, 16 Sep 2020 07:18:04 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B7E3F11F9 for ; Wed, 16 Sep 2020 07:18:01 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D2CE101A53F for ; Wed, 16 Sep 2020 07:18:01 +0000 (UTC) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-422-4L0X4qyQPUiA5w-hyGw_tw-1; Wed, 16 Sep 2020 03:17:56 -0400 Received: by mail-wm1-f67.google.com with SMTP id x23so1695115wmi.3; Wed, 16 Sep 2020 00:17:55 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id 9sm3721970wmf.7.2020.09.16.00.17.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 00:17:54 -0700 (PDT) X-MC-Unique: 2H3oEOfPPVyDDHjL_FKyjw-1 X-MC-Unique: 4L0X4qyQPUiA5w-hyGw_tw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DqSNURj9Ai2V3TTZcOMHc1cLas/lBuSeSczufk46P5I=; b=jpZvbw5/d3EP9OiG1oE8fsBcexOKQuIXoUwGRh3UVqJPrDDEtnCSP4pT06CNJIqJgB A/eGdeNujKV7Ju17Ie3yK0B0Wc+/xH24pXEhqI9JmeTxGoKETyj7P5HApVJF8l4cmM9E FdTZX3onk0C2bsoLcHcrLuvoxde1HHrGoVAnCaSfZJwqt/JP7S5+ErgjPvAXqswK3/Zn T04gDbPTeCTf1TCMxK9iSokaUr//3U5k/XYj8Vn3ilYuFDSOI3ZEZZHgyUus1JMiEEla szvrQUws932nFbnWExbBHmMkXUq1KgI94n9+B1nfoQkww+n3n3cRNVkJP3uC16xrcHOW YF/A== X-Gm-Message-State: AOAM5335p/dMh8bbONH7amhou9p7nPHIlzV2RQmI6b2P9wYdtsbhDZnt 8IHnzCKn4x9Z8eHRx6g9rDYDakxNtSRd+Q== X-Google-Smtp-Source: ABdhPJz/ldJ4eOIIA/2kUCoEZ21HKsvcNoVpiBGr+Vy7Q6TdYBqZJuByGajY81PM8VOgeB0UdI6eng== X-Received: by 2002:a1c:4e02:: with SMTP id g2mr2976770wmh.3.1600240674637; Wed, 16 Sep 2020 00:17:54 -0700 (PDT) From: morecache@gmail.com X-Google-Original-From: lma@suse.de To: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 1/4] virsh: net-port-create: log errors for non-existent xml file Date: Wed, 16 Sep 2020 15:17:34 +0800 Message-Id: <20200916071737.22938-2-lma@suse.de> In-Reply-To: <20200916071737.22938-1-lma@suse.de> References: <20200916071737.22938-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: jtomko@redhat.com, Lin Ma , eskultet@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lin Ma Signed-off-by: Lin Ma Reviewed-by: Michal Privoznik --- tools/virsh-network.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index 0351a93f19..24bc9107fc 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -1523,6 +1523,7 @@ cmdNetworkPortCreate(vshControl *ctl, const vshCmd *c= md) =20 ret =3D true; cleanup: + vshSaveLibvirtError(); VIR_FREE(buffer); if (port) virNetworkPortFree(port); --=20 2.26.0 From nobody Fri Mar 29 00:04:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1600240710; cv=none; d=zohomail.com; s=zohoarc; b=VjS/oj14gyWA9Dg7iLdizw9Ev/DxbapNGijUfowiEjvh5eyo+aaC+ovzk86e33GY/QNHQnBpeEIRTaSI78i0PomwNXdc0AnfGApTdmHaB6CYDLMP4p2wgwNj9qtrttqU8pchMxx+t3Uu9KvgscClThVtwJ63+127bRdoELAk1Dc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600240710; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2Q/x0iNsUefpIQ81amgfBtwhBOBfj1fy4ENyHbegK0s=; b=MgYjkPaluCHSDNAzPY/GIk/OyWfEvJy9JBT0gxX5xy0X5d88DlZR3uy707F3XMKOlJD2uHzyYe2TfEJhYegr36/+Elf7t2uicjZADPVtyfdHDcygu0S6BalcYj+iDotBuhZOkJk9A+TLIAYSXqEeni1MTrknG93S8GRpfwWOPyA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1600240710414752.8066848022169; Wed, 16 Sep 2020 00:18:30 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-iwxhZY3QNKePul_JNaNyjA-1; Wed, 16 Sep 2020 03:18:27 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E94AD89CD10; Wed, 16 Sep 2020 07:18:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 963EF1002D52; Wed, 16 Sep 2020 07:18:13 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4CB0D44A6A; Wed, 16 Sep 2020 07:18:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08G7I891022928 for ; Wed, 16 Sep 2020 03:18:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id 337602156A2D; Wed, 16 Sep 2020 07:18:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2D3592156A23 for ; Wed, 16 Sep 2020 07:18:05 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A27C4801220 for ; Wed, 16 Sep 2020 07:18:05 +0000 (UTC) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-386-gWx5mp4wNG2sL5vsNwIJiQ-1; Wed, 16 Sep 2020 03:17:59 -0400 Received: by mail-wr1-f47.google.com with SMTP id k15so5706982wrn.10; Wed, 16 Sep 2020 00:17:59 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id 9sm3721970wmf.7.2020.09.16.00.17.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 00:17:57 -0700 (PDT) X-MC-Unique: iwxhZY3QNKePul_JNaNyjA-1 X-MC-Unique: gWx5mp4wNG2sL5vsNwIJiQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2Q/x0iNsUefpIQ81amgfBtwhBOBfj1fy4ENyHbegK0s=; b=NKqy4E1rlhwzGblswjlIzGWSrlENhTDhocZb4z5fCAZJCp0ntsJC/MqFeNw0XsSXXs KHRaIS6bqmqOGurm8LR25aq28mjS5iABd6voQXuYTcKDYS4vfWXWZXVuAa/6axmsmykB qyPq5nEembWlgRbKYISFADLzm7Hd4+T5ZI2r376/w62fIP7FK7YESJXS4BOMPgWR4Fau Emyq7kP6zPqrxoE6WWg/oTHY/OLL3dTvICCrqJJHBez1XnJvkprFQbx8EVqhZ0WKNoOR 2jUCnWvEQcwnER3DrzFWkmmuQHwvgPM7QDEcY7FbEeRc5bqhMmWwYu6ISUCqFXKqmBSB a9Ow== X-Gm-Message-State: AOAM530y9iU7w0t1wLmwBCO6gqUiewhdHQXhMu3d5TrSnj5vOiNpRAC+ ivySaFfFSSnVbUF+PurugFZdvTfqKaXuSQ== X-Google-Smtp-Source: ABdhPJzXev7WYac8AfOXup+524iR2e87nRadIg6lkJZVEGYyyuXrr/sNsTveVTinwU/rPzZyLJbzWw== X-Received: by 2002:adf:e304:: with SMTP id b4mr24304476wrj.141.1600240677909; Wed, 16 Sep 2020 00:17:57 -0700 (PDT) From: morecache@gmail.com X-Google-Original-From: lma@suse.de To: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 2/4] virsh: event: options --list, --all and --event are mutually exclusive Date: Wed, 16 Sep 2020 15:17:35 +0800 Message-Id: <20200916071737.22938-3-lma@suse.de> In-Reply-To: <20200916071737.22938-1-lma@suse.de> References: <20200916071737.22938-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: jtomko@redhat.com, Lin Ma , eskultet@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lin Ma Signed-off-by: Lin Ma Reviewed-by: Michal Privoznik --- tools/virsh-domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index f0ca6f7b83..32edfc0398 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -13710,6 +13710,10 @@ cmdEvent(vshControl *ctl, const vshCmd *cmd) int count =3D 0; virshControlPtr priv =3D ctl->privData; =20 + VSH_EXCLUSIVE_OPTIONS("all", "event"); + VSH_EXCLUSIVE_OPTIONS("list", "all"); + VSH_EXCLUSIVE_OPTIONS("list", "event"); + if (vshCommandOptBool(cmd, "list")) { for (event =3D 0; event < VIR_DOMAIN_EVENT_ID_LAST; event++) vshPrint(ctl, "%s\n", virshDomainEventCallbacks[event].name); --=20 2.26.0 From nobody Fri Mar 29 00:04:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1600240705; cv=none; d=zohomail.com; s=zohoarc; b=J2BEbM9Myt5Of0pxTAFQPj+hIU6FZZtFhjs2KQ1nDQRdKhRQNebXZquAYJLzjuQm4pa+zfK0pUXtIcGUy34Fk98FOR7ldjWnkAYJUWhp5+at0GK9N6z5uFec7n4IwJj1+yGEUl8Z5756xdTM2ltdQgp1zEmohXtmR7QgXoz+9lQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600240705; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vY01mRTXKl6Db2Hz7ZL893y86HQkZMY8P5ma3BIthq4=; b=SuSBwLDXBQc1hxOouoQvsc0H4ZJ1LeDbfSAVVbLMQyENcua2q7oYmgPKpw0/oxzq18dRRDqbhts2/cPOySNjYHlYiqydu9uGDnP9w+cGe4oORPL4VosWCuazBL81tqc00B4NeiuLixc/fHjROJ9FHwdr4Dh8M++tGBg6+yEqHmk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1600240705524290.86433232654747; Wed, 16 Sep 2020 00:18:25 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-486-jThWE6XBNL-mCIsxBD3UzQ-1; Wed, 16 Sep 2020 03:18:22 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1A0B2801AFD; Wed, 16 Sep 2020 07:18:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E87DF610F2; Wed, 16 Sep 2020 07:18:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B4FC644A68; Wed, 16 Sep 2020 07:18:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08G7I8SE022927 for ; Wed, 16 Sep 2020 03:18:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id 325942156A30; Wed, 16 Sep 2020 07:18:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2DA502156A2D for ; Wed, 16 Sep 2020 07:18:05 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BC9F0801224 for ; Wed, 16 Sep 2020 07:18:05 +0000 (UTC) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-136-la7xRWhGNn2oXFCfNjuIWQ-1; Wed, 16 Sep 2020 03:18:03 -0400 Received: by mail-wr1-f68.google.com with SMTP id s12so5685060wrw.11; Wed, 16 Sep 2020 00:18:02 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id 9sm3721970wmf.7.2020.09.16.00.17.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 00:18:00 -0700 (PDT) X-MC-Unique: jThWE6XBNL-mCIsxBD3UzQ-1 X-MC-Unique: la7xRWhGNn2oXFCfNjuIWQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vY01mRTXKl6Db2Hz7ZL893y86HQkZMY8P5ma3BIthq4=; b=WkJDvKAjLLUUgTBnlBINUCd7TFxXS/u4pxzeYCah8XT0dRnjeNN1q1hwh1w2Dh9v/8 X7IqyLQOE1sIBvsdba54phPo5o1AcqmVPgDHRmANe47159dWw4Rksp6W6y8gdTLUchqK SRgSc+VdMU39eTmLcBvdS68Pnlrp1f7qsjYJokttskex0NKYq70S35iS8CY5WhunFfpG 6y0yin6chzFG9Yt3Tw/rpUG1Y6/yNNE+OfSGpL9UC0oN49Vkat09vwtMzGDMgrTpYx/1 CryTJB4ngJmMFfmDLAa1hOJqANzNH2L285sfL7RP4N4r7VCvwh4hXPr7v6ySBlvrSYIV qsww== X-Gm-Message-State: AOAM530e0gshB9KOpqADbC3p6B/PJ4E2t0ykLC0x8jiUpt6rqvA8URie 0Xm43/FREQxOUik0o3qw8utTyByUtJaDug== X-Google-Smtp-Source: ABdhPJwr3Hon59HvmzXalUqysdwIXqwmrfD7nUV+p2nnGWgRinsu4o1J+XEo02331K2DqYtNyEOUew== X-Received: by 2002:adf:f7d0:: with SMTP id a16mr24065827wrq.381.1600240681034; Wed, 16 Sep 2020 00:18:01 -0700 (PDT) From: morecache@gmail.com X-Google-Original-From: lma@suse.de To: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 3/4] docs: virsh: Document the IO mode 'io_uring' Date: Wed, 16 Sep 2020 15:17:36 +0800 Message-Id: <20200916071737.22938-4-lma@suse.de> In-Reply-To: <20200916071737.22938-1-lma@suse.de> References: <20200916071737.22938-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: jtomko@redhat.com, Lin Ma , eskultet@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lin Ma Signed-off-by: Lin Ma Reviewed-by: Michal Privoznik --- docs/manpages/virsh.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index 9fd5efed0f..bf84f95678 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4521,7 +4521,8 @@ within the existing virtual cdrom or floppy device; c= onsider using *sourcetype* can indicate the type of source (block|file) *cache* can be one of "default", "none", "writethrough", "writeback", "directsync" or "unsafe". -*io* controls specific policies on I/O; QEMU guests support "threads" and = "native". +*io* controls specific policies on I/O; QEMU guests support "threads", +"native" and "io_uring". *iothread* is the number within the range of domain IOThreads to which this disk may be attached (QEMU only). *serial* is the serial of disk device. *wwn* is the wwn of disk device. --=20 2.26.0 From nobody Fri Mar 29 00:04:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1600240709; cv=none; d=zohomail.com; s=zohoarc; b=h/OhZOwz79hIcVkMTZkom9GB/4gfaF1XSBJyhiJWvlDcBTOwiO/o7Hchvq5ywBAvWeWC7IfmoNMz6nNmHAigjJtlbWiNhiY0ICU3WbgVaC3jPjbYi7DnTbCtKILM4ky3gjYeiQyGk6kz9l68cRVXkD2iThMuVkcEtheN0O+/K2s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1600240709; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rmnHMkm1wHnoj3ZXKG67rOzriwPMjMY2FcszTQW5m4A=; b=J7URP7LlZZG5T97UWnaGMhFU5GJqVmn6w39/YwlowDZ4E9wh72cXz1+uVMvZr0/MMWpxtkCXTnhJFyBie/a+AhHKt62luTBO+iHJmHXfmQbaQLPO0GiGEre+MfdiAwvoRHrXb8QNhttl3neLLPba3szMJgJdCYgUi9oHmsBnnZc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 160024070989971.20106401937846; Wed, 16 Sep 2020 00:18:29 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-588-SGxdH7LbNRKu9UVG_aVWWg-1; Wed, 16 Sep 2020 03:18:26 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42011100CFD9; Wed, 16 Sep 2020 07:18:14 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 19BA91002397; Wed, 16 Sep 2020 07:18:14 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D1540183D028; Wed, 16 Sep 2020 07:18:13 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08G7IDS4022949 for ; Wed, 16 Sep 2020 03:18:13 -0400 Received: by smtp.corp.redhat.com (Postfix) id 28D04F11E4; Wed, 16 Sep 2020 07:18:13 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 24739F11E0 for ; Wed, 16 Sep 2020 07:18:13 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0BBF185828E for ; Wed, 16 Sep 2020 07:18:13 +0000 (UTC) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-BTMNgNnJPqGicmbXVJZfUw-1; Wed, 16 Sep 2020 03:18:09 -0400 Received: by mail-wm1-f66.google.com with SMTP id z9so1808540wmk.1; Wed, 16 Sep 2020 00:18:08 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id 9sm3721970wmf.7.2020.09.16.00.18.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 00:18:03 -0700 (PDT) X-MC-Unique: SGxdH7LbNRKu9UVG_aVWWg-1 X-MC-Unique: BTMNgNnJPqGicmbXVJZfUw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rmnHMkm1wHnoj3ZXKG67rOzriwPMjMY2FcszTQW5m4A=; b=Y4+m6fTSPqj8a5EOYA5KTRNy+qAiyU1HwO/augcMiUQQQrn4TeOMwqU1js9yHSkqyR EnW0OcExKal28rHJXW0JJMzdkCCrWR4o5sKGry1XXh4eiBRY6n3vVfSmzHpgDAo8R0OV Zi6yGFR4tpI06xs8C9v7vskAzGX3v+T6eFpw6h53/V/Elit3nkAcmtvaRmwEC3LDvP2N irpWgWL9oITFrV7MMSTRbQMcdBcoG4YdDsgVsfGlevYCoPveDFv3+nXOzNp09r+Fseld +900cncD2a8rNUBzEqwdwbODYtk8b9Ykz84Uf0sT+UsU4Y2sXLf3mfEB2KfXz84aeZU/ Li0g== X-Gm-Message-State: AOAM531y0KgZnMd9XvOXaniQ8MtGWrPl1hvGXi+FPxxvNxE4917Z4y2X UgAz7OuWsuYI1PwAXFxbUZZrge7NIW8+KA== X-Google-Smtp-Source: ABdhPJyQWdg2Gg5HVQekMGkJl5SvKYNfvHpM4F+lRp0jEM9RrN7wGVaM43TH7ryEbsr/eJCcLxoiKQ== X-Received: by 2002:a7b:cb97:: with SMTP id m23mr3021871wmi.173.1600240684241; Wed, 16 Sep 2020 00:18:04 -0700 (PDT) From: morecache@gmail.com X-Google-Original-From: lma@suse.de To: libvir-list@redhat.com Subject: [libvirt] [PATCH v2 4/4] network: Check for active network during networkGetDHCPLeases Date: Wed, 16 Sep 2020 15:17:37 +0800 Message-Id: <20200916071737.22938-5-lma@suse.de> In-Reply-To: <20200916071737.22938-1-lma@suse.de> References: <20200916071737.22938-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: jtomko@redhat.com, Lin Ma , eskultet@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lin Ma It doesn't make sense querying dhcp leases for interfaces against an inacti= ve network, This patch adds a check to see if the network is active. Signed-off-by: Lin Ma Reviewed-by: Michal Privoznik --- src/network/bridge_driver.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 87d7acab06..1dffc2309f 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -4068,6 +4068,13 @@ networkGetDHCPLeases(virNetworkPtr net, if (virNetworkGetDHCPLeasesEnsureACL(net->conn, def) < 0) goto cleanup; =20 + if (!virNetworkObjIsActive(obj)) { + virReportError(VIR_ERR_OPERATION_INVALID, + _("network '%s' is not active"), + def->name); + goto error; + } + /* Retrieve custom leases file location */ custom_lease_file =3D networkDnsmasqLeaseFileNameCustom(driver, def->b= ridge); =20 --=20 2.26.0