From nobody Mon Feb 9 12:43:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599824586; cv=none; d=zohomail.com; s=zohoarc; b=B0GY/o6NJr9Z7pTntq0VxeYW8fEJyLqHQ5LsDHTv5G7MXAudK/DU6qB+6O3xed0qhmenCQbFvwQtVNmbx0Y2YAF3Plvgz6SgbBduvz8T2SkRaAvF8PLb5cFFDYIZoFi4IzgplaxPk7AP3BOMvnrreFsagelTNDfVcEOdY/XKrFU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599824586; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Vqe7gkM+4RPB9usx5171OtbwQmkY34GQ6cg1aCygsfA=; b=mordJMeRgXk80N/89VUtHjetKkZ0tCCJRu1PjJnI2ZdKoT8bvfakEEBjBVreYJPNgB4ckxT2l/ZslRU/RzrgvsgMP8OSiGdr2RVwnhL7Ahr1RrJWkGXfZZzkZpiSF9TA4qHnzvd5BlLzrCuC5XXMd7whc+hD0CDDLEKMZf+3elc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 159982458692729.973538861624547; Fri, 11 Sep 2020 04:43:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-576-PaFz6A4iNRqB4y84HywYBg-1; Fri, 11 Sep 2020 07:42:41 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42DB781CAFF; Fri, 11 Sep 2020 11:42:33 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1FCEF60C15; Fri, 11 Sep 2020 11:42:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DA197180BAFF; Fri, 11 Sep 2020 11:42:32 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08BBgSpn010636 for ; Fri, 11 Sep 2020 07:42:28 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7E1B25D9F3; Fri, 11 Sep 2020 11:42:28 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-163.ams2.redhat.com [10.36.112.163]) by smtp.corp.redhat.com (Postfix) with ESMTP id C4CAB5D9E8; Fri, 11 Sep 2020 11:42:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599824585; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Vqe7gkM+4RPB9usx5171OtbwQmkY34GQ6cg1aCygsfA=; b=Zj8BTM2zDlXHb/jmLQEJr7EiUy/zpoZRmlLvMhwVeE8M9Iozk0qvq0WtxhkLcI3oO/lKZS GQzIddWXWLhAIhrB1lUqoxqhddTIZWzD1E0kjJ64hkHzSt+1tW6I44TAd6GYFGLetCnuiQ /zwb9DgzX4ISoPJijSL8M0ytVEQq0WM= X-MC-Unique: PaFz6A4iNRqB4y84HywYBg-1 From: Tim Wiederhake To: libvir-list@redhat.com Subject: [libvirt PATCH 05/21] util: Use glib memory functions in virLastErrorObject Date: Fri, 11 Sep 2020 13:42:02 +0200 Message-Id: <20200911114218.489636-6-twiederh@redhat.com> In-Reply-To: <20200911114218.489636-1-twiederh@redhat.com> References: <20200911114218.489636-1-twiederh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: Tim Wiederhake X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Tim Wiederhake --- src/util/virerror.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/util/virerror.c b/src/util/virerror.c index 4ba99defbb..99a0855b51 100644 --- a/src/util/virerror.c +++ b/src/util/virerror.c @@ -237,15 +237,17 @@ virErrorCopyNew(virErrorPtr err) static virErrorPtr virLastErrorObject(void) { - virErrorPtr err; + g_autoptr(virError) err =3D NULL; + err =3D virThreadLocalGet(&virLastErr); - if (!err) { - if (VIR_ALLOC_QUIET(err) < 0) - return NULL; - if (virThreadLocalSet(&virLastErr, err) < 0) - VIR_FREE(err); - } - return err; + if (err) + return g_steal_pointer(&err); + + err =3D g_new0(virError, 1); + if (virThreadLocalSet(&virLastErr, err) < 0) + return NULL; + + return g_steal_pointer(&err); } =20 =20 --=20 2.26.2