From nobody Sat Apr 27 00:46:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599813878; cv=none; d=zohomail.com; s=zohoarc; b=nEej17/8OQ66y68S0uOPGqZg05MEuUXtJkBhwiaz5zANEzO8nhnFfgUwPQuHAjorw7aW+Q5UFzAAkG0aCbpLkDKTWTgjo9sgmIcG7XM6V904LFZxhWMAWNXiNcj5ztbhIb3ucqaINHe7oSqM8qVfn8bWjYxATnCmQHL7VFi90NM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599813878; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KBd0C8LuolAhad1lykaPUtrv9y0Jq8U8K1UY+QjAydE=; b=AGEpGPgJCVjvrcOQiCGpvsQv+WlPQsBykObtwaV3BVw9I0icwZyHrF5Vi1wLG2HVNAjaCux+tJfJOZLaoPBMIPbd6v4ukxZuVqEZdDR5gT2dPGG/2vHS02JShRK6jftaKenzcl+rbbSNOQQmlGbLbqHTa4TCc1aSEBQsJWiIHho= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1599813878255813.744576955372; Fri, 11 Sep 2020 01:44:38 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-240-HxbjIWb7M6WASBwGksJtwA-1; Fri, 11 Sep 2020 04:44:34 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B20D318B9F02; Fri, 11 Sep 2020 08:44:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 93C0981C44; Fri, 11 Sep 2020 08:44:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 24C6D180B656; Fri, 11 Sep 2020 08:44:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B8iPEN020592 for ; Fri, 11 Sep 2020 04:44:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id 3760B81C4C; Fri, 11 Sep 2020 08:44:25 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6EC6481C44; Fri, 11 Sep 2020 08:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599813876; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=KBd0C8LuolAhad1lykaPUtrv9y0Jq8U8K1UY+QjAydE=; b=GC2f8ABz1YDB6N4uKpDspQiYPAOR9ovTVLIb4I5Slka+zL8zS5ncTZu1wvjh+CDQkEr3V0 VIJadBf64ITuFPB/8V8K4Y/LyH+SdRE8GKS9Z9CSsSNRmLlkU38PsZ6+tRg054zZeulM86 fp6wy3MLWjpMCbyVt+CsU04Hjxncxd4= X-MC-Unique: HxbjIWb7M6WASBwGksJtwA-1 From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH 1/3] numa: drop support for '-numa node' (without memory specified) Date: Fri, 11 Sep 2020 04:44:08 -0400 Message-Id: <20200911084410.788171-2-imammedo@redhat.com> In-Reply-To: <20200911084410.788171-1-imammedo@redhat.com> References: <20200911084410.788171-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: ehabkost@redhat.com, mst@redhat.com, libvir-list@redhat.com, qemu-ppc@nongnu.org, pbonzini@redhat.com, david@gibson.dropbear.id.au, rth@twiddle.net X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" it was deprecated since 4.1 commit 4bb4a2732e (numa: deprecate implict memory distribution between node= s) Users of existing VMs, wishing to preserve the same RAM distribution, should configure it explicitly using ``-numa node,memdev`` options. Current RAM distribution can be retrieved using HMP command `info numa` and if separate memory devices (pc|nv-dimm) are present use `info memory-device` and subtract device memory from output of `info numa`. Signed-off-by: Igor Mammedov --- include/hw/boards.h | 2 -- include/sysemu/numa.h | 4 --- docs/system/deprecated.rst | 23 +++++++++------- hw/core/machine.c | 1 - hw/core/numa.c | 55 -------------------------------------- hw/i386/pc_piix.c | 1 - hw/i386/pc_q35.c | 1 - hw/ppc/spapr.c | 1 - 8 files changed, 14 insertions(+), 74 deletions(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index bc5b82ad20..15fc1a2bac 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h @@ -208,8 +208,6 @@ struct MachineClass { strList *allowed_dynamic_sysbus_devices; bool auto_enable_numa_with_memhp; bool auto_enable_numa_with_memdev; - void (*numa_auto_assign_ram)(MachineClass *mc, NodeInfo *nodes, - int nb_nodes, ram_addr_t size); bool ignore_boot_device_suffixes; bool smbus_no_migration_support; bool nvdimm_supported; diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h index ad58ee88f7..4173ef2afa 100644 --- a/include/sysemu/numa.h +++ b/include/sysemu/numa.h @@ -106,10 +106,6 @@ void parse_numa_hmat_cache(MachineState *ms, NumaHmatC= acheOptions *node, void numa_complete_configuration(MachineState *ms); void query_numa_node_mem(NumaNodeMem node_mem[], MachineState *ms); extern QemuOptsList qemu_numa_opts; -void numa_legacy_auto_assign_ram(MachineClass *mc, NodeInfo *nodes, - int nb_nodes, ram_addr_t size); -void numa_default_auto_assign_ram(MachineClass *mc, NodeInfo *nodes, - int nb_nodes, ram_addr_t size); void numa_cpu_pre_plug(const struct CPUArchId *slot, DeviceState *dev, Error **errp); bool numa_uses_legacy_mem(void); diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 851dbdeb8a..6f9441005a 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -104,15 +104,6 @@ error in the future. The ``-realtime mlock=3Don|off`` argument has been replaced by the ``-overcommit mem-lock=3Don|off`` argument. =20 -``-numa`` node (without memory specified) (since 4.1) -''''''''''''''''''''''''''''''''''''''''''''''''''''' - -Splitting RAM by default between NUMA nodes has the same issues as ``mem`` -parameter described above with the difference that the role of the user pl= ays -QEMU using implicit generic or board specific splitting rule. -Use ``memdev`` with *memory-backend-ram* backend or ``mem`` (if -it's supported by used machine type) to define mapping explictly instead. - ``-mem-path`` fallback to RAM (since 4.1) ''''''''''''''''''''''''''''''''''''''''' =20 @@ -602,6 +593,20 @@ error when ``-u`` is not used. Command line options -------------------- =20 +``-numa`` node (without memory specified) (removed 5.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +Splitting RAM by default between NUMA nodes had the same issues as ``mem`` +parameter with the difference that the role of the user plays QEMU using +implicit generic or board specific splitting rule. +Use ``memdev`` with *memory-backend-ram* backend or ``mem`` (if +it's supported by used machine type) to define mapping explictly instead. +Users of existing VMs, wishing to preserve the same RAM distribution, shou= ld +configure it explicitly using ``-numa node,memdev`` options. Current RAM +distribution can be retrieved using HMP command ``info numa`` and if separ= ate +memory devices (pc|nv-dimm) are present use ``info memory-device`` and sub= tract +device memory from output of ``info numa``. + ``-numa node,mem=3D``\ *size* (removed in 5.1) '''''''''''''''''''''''''''''''''''''''''''' =20 diff --git a/hw/core/machine.c b/hw/core/machine.c index ea26d61237..f70d388e86 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -797,7 +797,6 @@ static void machine_class_init(ObjectClass *oc, void *d= ata) * On Linux, each node's border has to be 8MB aligned */ mc->numa_mem_align_shift =3D 23; - mc->numa_auto_assign_ram =3D numa_default_auto_assign_ram; =20 object_class_property_add_str(oc, "kernel", machine_get_kernel, machine_set_kernel); diff --git a/hw/core/numa.c b/hw/core/numa.c index f9593ec716..706c1e84c6 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -611,42 +611,6 @@ static void complete_init_numa_distance(MachineState *= ms) } } =20 -void numa_legacy_auto_assign_ram(MachineClass *mc, NodeInfo *nodes, - int nb_nodes, ram_addr_t size) -{ - int i; - uint64_t usedmem =3D 0; - - /* Align each node according to the alignment - * requirements of the machine class - */ - - for (i =3D 0; i < nb_nodes - 1; i++) { - nodes[i].node_mem =3D (size / nb_nodes) & - ~((1 << mc->numa_mem_align_shift) - 1); - usedmem +=3D nodes[i].node_mem; - } - nodes[i].node_mem =3D size - usedmem; -} - -void numa_default_auto_assign_ram(MachineClass *mc, NodeInfo *nodes, - int nb_nodes, ram_addr_t size) -{ - int i; - uint64_t usedmem =3D 0, node_mem; - uint64_t granularity =3D size / nb_nodes; - uint64_t propagate =3D 0; - - for (i =3D 0; i < nb_nodes - 1; i++) { - node_mem =3D (granularity + propagate) & - ~((1 << mc->numa_mem_align_shift) - 1); - propagate =3D granularity + propagate - node_mem; - nodes[i].node_mem =3D node_mem; - usedmem +=3D node_mem; - } - nodes[i].node_mem =3D size - usedmem; -} - static void numa_init_memdev_container(MachineState *ms, MemoryRegion *ram) { int i; @@ -717,25 +681,6 @@ void numa_complete_configuration(MachineState *ms) ms->numa_state->num_nodes =3D MAX_NODES; } =20 - /* If no memory size is given for any node, assume the default case - * and distribute the available memory equally across all nodes - */ - for (i =3D 0; i < ms->numa_state->num_nodes; i++) { - if (numa_info[i].node_mem !=3D 0) { - break; - } - } - if (i =3D=3D ms->numa_state->num_nodes) { - assert(mc->numa_auto_assign_ram); - mc->numa_auto_assign_ram(mc, numa_info, - ms->numa_state->num_nodes, ram_size); - if (!qtest_enabled()) { - warn_report("Default splitting of RAM between nodes is dep= recated," - " Use '-numa node,memdev' to explictly define = RAM" - " allocation per node"); - } - } - numa_total =3D 0; for (i =3D 0; i < ms->numa_state->num_nodes; i++) { numa_total +=3D numa_info[i].node_mem; diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 32b1453e6a..5507812c13 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -565,7 +565,6 @@ static void pc_i440fx_2_9_machine_options(MachineClass = *m) pc_i440fx_2_10_machine_options(m); compat_props_add(m->compat_props, hw_compat_2_9, hw_compat_2_9_len); compat_props_add(m->compat_props, pc_compat_2_9, pc_compat_2_9_len); - m->numa_auto_assign_ram =3D numa_legacy_auto_assign_ram; } =20 DEFINE_I440FX_MACHINE(v2_9, "pc-i440fx-2.9", NULL, diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c index 0cb9c18cd4..4a37bc3e6d 100644 --- a/hw/i386/pc_q35.c +++ b/hw/i386/pc_q35.c @@ -494,7 +494,6 @@ static void pc_q35_2_10_machine_options(MachineClass *m) pc_q35_2_11_machine_options(m); compat_props_add(m->compat_props, hw_compat_2_10, hw_compat_2_10_len); compat_props_add(m->compat_props, pc_compat_2_10, pc_compat_2_10_len); - m->numa_auto_assign_ram =3D numa_legacy_auto_assign_ram; m->auto_enable_numa_with_memhp =3D false; } =20 diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 9bce1892b5..12fd92373d 100644 --- a/hw/ppc/spapr.c +++ b/hw/ppc/spapr.c @@ -4737,7 +4737,6 @@ static void spapr_machine_2_9_class_options(MachineCl= ass *mc) spapr_machine_2_10_class_options(mc); compat_props_add(mc->compat_props, hw_compat_2_9, hw_compat_2_9_len); compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); - mc->numa_auto_assign_ram =3D numa_legacy_auto_assign_ram; smc->pre_2_10_has_unused_icps =3D true; smc->resize_hpt_default =3D SPAPR_RESIZE_HPT_DISABLED; } --=20 2.27.0 From nobody Sat Apr 27 00:46:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599813879; cv=none; d=zohomail.com; s=zohoarc; b=VSuLD2hq7E0ylfRYZIYD1dayn2QnIW+nJcYSEK3NIpn/am4e3V4sHEWxHUW1wQ6rjMdog42cC/Js5kH8y2aQQdyBd0VfwAkPvI2X8B3CToGytVk2L3UAcyrtQVVXCXrHS8IWe9RCldFUG+FLXlkVGxvKJtvqkUtFdNCn+kXfc+E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599813879; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5Ul0LxVebiw5sWSzU7HFK0sjEAUbfdx5vqwM/Vw1sus=; b=G0x3mYkdtg1nTXCvv1EV66IiEpZNg809mjLULFz1uI6h9mBUhaW8oNcyIxL5i3e/cmoFqe0K+sAEPsskmbeeRwbK9a+YAk1WN4+FdPDwQt3QWJhETdj90ExHw16u5+u4ERiDAcrooRpI3qH5fsBpleYSblAH+Vsk/y34in47TrE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1599813879374840.6015277640008; Fri, 11 Sep 2020 01:44:39 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-497-1Qrf75W_NWi-hslZ37YQRg-1; Fri, 11 Sep 2020 04:44:35 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B4262108E8A2; Fri, 11 Sep 2020 08:44:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F6B675125; Fri, 11 Sep 2020 08:44:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B71D8180B657; Fri, 11 Sep 2020 08:44:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B8iRq2020605 for ; Fri, 11 Sep 2020 04:44:27 -0400 Received: by smtp.corp.redhat.com (Postfix) id 255F981C4C; Fri, 11 Sep 2020 08:44:27 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82E8681C44; Fri, 11 Sep 2020 08:44:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599813877; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5Ul0LxVebiw5sWSzU7HFK0sjEAUbfdx5vqwM/Vw1sus=; b=SG9TL7zpRoiy5zAO2v58PWZ/URLF/hc1OY0cy8kS0jE6bkoUGOyknHzVyRd+ucZrkUiIub ygwvsThbWAn7NBvlTpmYGp060BZENMbiwOVF0hFuRNfSpQiEzl7WXwJOLArz6i5TTLN22M f1JKzSO071bEil25eyUT6TrK/Y1qB6w= X-MC-Unique: 1Qrf75W_NWi-hslZ37YQRg-1 From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH 2/3] doc: Cleanup "'-mem-path' fallback to RAM" deprecation text Date: Fri, 11 Sep 2020 04:44:09 -0400 Message-Id: <20200911084410.788171-3-imammedo@redhat.com> In-Reply-To: <20200911084410.788171-1-imammedo@redhat.com> References: <20200911084410.788171-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: ehabkost@redhat.com, mst@redhat.com, libvir-list@redhat.com, qemu-ppc@nongnu.org, pbonzini@redhat.com, david@gibson.dropbear.id.au, rth@twiddle.net X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" it was actually removed in 5.0, commit 68a86dc15c (numa: remove deprecated -mem-path fallback to anonymous = RAM) clean up forgotten remnants in docs. Signed-off-by: Igor Mammedov --- docs/system/deprecated.rst | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 6f9441005a..f252c92901 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -104,17 +104,6 @@ error in the future. The ``-realtime mlock=3Don|off`` argument has been replaced by the ``-overcommit mem-lock=3Don|off`` argument. =20 -``-mem-path`` fallback to RAM (since 4.1) -''''''''''''''''''''''''''''''''''''''''' - -Currently if guest RAM allocation from file pointed by ``mem-path`` -fails, QEMU falls back to allocating from RAM, which might result -in unpredictable behavior since the backing file specified by the user -is ignored. In the future, users will be responsible for making sure -the backing storage specified with ``-mem-path`` can actually provide -the guest RAM configured with ``-m`` and QEMU will fail to start up if -RAM allocation is unsuccessful. - RISC-V ``-bios`` (since 5.1) '''''''''''''''''''''''''''' =20 @@ -624,6 +613,16 @@ New machine versions (since 5.1) will not accept the o= ption but it will still work with old machine types. User can check the QAPI schema to see if the = legacy option is supported by looking at MachineInfo::numa-mem-supported property. =20 +``-mem-path`` fallback to RAM (remove 5.0) +'''''''''''''''''''''''''''''''''''''''''' + +If guest RAM allocation from file pointed by ``mem-path`` failed, +QEMU was falling back to allocating from RAM, which might have resulted +in unpredictable behavior since the backing file specified by the user +as ignored. Currently, users are responsible for making sure the backing s= torage +specified with ``-mem-path`` can actually provide the guest RAM configured= with +``-m`` and QEMU fails to start up if RAM allocation is unsuccessful. + Block devices ------------- =20 --=20 2.27.0 From nobody Sat Apr 27 00:46:53 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599813888; cv=none; d=zohomail.com; s=zohoarc; b=MZwVX4pNyIeXQu0QwB0l+jolX+WFCjHDxU/l2Vjh46xExoorruxqR/kBfn5ACkRjj+dKKbbOAy1R2wi60BPBEtWICx4zEz4vuft5gOkZJi3cpEu0jiboZWYYWlgNx9I39xiV0dQlLLPHGTG2LXWa75ogvhrLCXR30/vgtesfK3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599813888; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=9TTA9MZ8aUIl276MUEBXq81ro2HhgcO3JcrlnA45PJU=; b=SsAbjNFZfqRI7IJUDMMO7gergx7DfxwlgdeppDxS7M5WFLSjUfFphUxBpSL3YLvS5XaK0f8jBVHMWSp1kShcTiFQinEdSGuUfSQgKIcNT807DwqZ1FxvKVb6wovLteb/fOXbbvwRrb9hOxkLHY7ZamavscvksD3xXyPQrN5BWx0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1599813888266646.0725294318063; Fri, 11 Sep 2020 01:44:48 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-319-Br00xoX5MNqztDTlHAresg-1; Fri, 11 Sep 2020 04:44:44 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id ACD2B108E8A2; Fri, 11 Sep 2020 08:44:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87A601002D41; Fri, 11 Sep 2020 08:44:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5B3C792304; Fri, 11 Sep 2020 08:44:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B8iTaf020616 for ; Fri, 11 Sep 2020 04:44:29 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1262581C47; Fri, 11 Sep 2020 08:44:29 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq.redhat.com (dell-r430-03.lab.eng.brq.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6FEB581C44; Fri, 11 Sep 2020 08:44:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1599813886; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=9TTA9MZ8aUIl276MUEBXq81ro2HhgcO3JcrlnA45PJU=; b=JSLcoeyPL1BFuE2Z+pJMKh7/a9QEJNIi+lnawa/PQN/Q6VPOIHw642HWNYsW930SOw36TX C6MIwLFv3Y+wHVs/gazUvY6PU3Q5E0GJyl4kAAyquSnSS5WHUPxqFhX1Smo2KX0gA/F9dL 6i67DRx/EH+/H2ukR+FtL23oEYXnHGY= X-MC-Unique: Br00xoX5MNqztDTlHAresg-1 From: Igor Mammedov To: qemu-devel@nongnu.org Subject: [PATCH 3/3] numa: remove fixup numa_state->num_nodes to MAX_NODES Date: Fri, 11 Sep 2020 04:44:10 -0400 Message-Id: <20200911084410.788171-4-imammedo@redhat.com> In-Reply-To: <20200911084410.788171-1-imammedo@redhat.com> References: <20200911084410.788171-1-imammedo@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: ehabkost@redhat.com, mst@redhat.com, libvir-list@redhat.com, qemu-ppc@nongnu.org, pbonzini@redhat.com, david@gibson.dropbear.id.au, rth@twiddle.net X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" current code permits only nodeids in [0..MAX_NODES) range due to nodeid check in parse_numa_node() if (nodenr >=3D MAX_NODES) { error_setg(errp, "Max number of NUMA nodes reached: %" so subj fixup is not reachable, drop it. Signed-off-by: Igor Mammedov --- hw/core/numa.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index 706c1e84c6..7d5d413001 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -677,10 +677,6 @@ void numa_complete_configuration(MachineState *ms) if (ms->numa_state->num_nodes > 0) { uint64_t numa_total; =20 - if (ms->numa_state->num_nodes > MAX_NODES) { - ms->numa_state->num_nodes =3D MAX_NODES; - } - numa_total =3D 0; for (i =3D 0; i < ms->numa_state->num_nodes; i++) { numa_total +=3D numa_info[i].node_mem; --=20 2.27.0