From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808159; cv=none; d=zohomail.com; s=zohoarc; b=FNBA1OIj0tU8k2mYdEXpaupA8sOadY/3wWsE5dPRK8ctIxfZvYuxAqoOHc4viORJ46ieVTpuXWgjLVj1zB6F9m1U4K496xpk5Th3Gk58oNTpGbyaEIOnkF+uT4GHnrNVXUGjMw7D+iAHLfNn8Lwe+E99GP72vEKOEs/BvbnD6BE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808159; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+v3ogoRkcESEFdL+Uc4E79Fda9fvo5v1HBW33tM9kNA=; b=Y7pSHGSn5B1NcF540dbcds0Sy17aw8Y/83Wb2N/8e1bmy7M5GBlh39rCJvl87Ox3g71IBmvGbyHmMD0wLgWMKgKw6mS0s+xRINqjO+Kwy3dT2l/k3kC0kZmWzGtA1S8yWq+dJXgDJJnGN1xvGzNU+EkilP2g45cCkManq1HXDR0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1599808159055961.4710494197028; Fri, 11 Sep 2020 00:09:19 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-512-UDP3NhltOyiZsyEuWD6cqA-1; Fri, 11 Sep 2020 03:09:15 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7E4AE64088; Fri, 11 Sep 2020 07:09:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5E8AE81C44; Fri, 11 Sep 2020 07:09:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2C1CC181A06D; Fri, 11 Sep 2020 07:09:10 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B76mPf006908 for ; Fri, 11 Sep 2020 03:06:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id EFFF710F9AD; Fri, 11 Sep 2020 07:06:47 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA58A10F9B5 for ; Fri, 11 Sep 2020 07:06:44 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BF085186E135 for ; Fri, 11 Sep 2020 07:06:44 +0000 (UTC) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-87-oJ7xWwJkPtuUEqmwE-ICmw-1; Fri, 11 Sep 2020 03:06:39 -0400 Received: by mail-pg1-f194.google.com with SMTP id 34so5952511pgo.13 for ; Fri, 11 Sep 2020 00:06:39 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:37 -0700 (PDT) X-MC-Unique: UDP3NhltOyiZsyEuWD6cqA-1 X-MC-Unique: oJ7xWwJkPtuUEqmwE-ICmw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+v3ogoRkcESEFdL+Uc4E79Fda9fvo5v1HBW33tM9kNA=; b=Nm5N9Qnry6EUQjGsoDQG9FDS1yZFfIKzALCX6+kcVXDt3STativ0qT4FjzP6pD0rGh iqdULkurGPDlRB5Xu1Hylf+MBt2OC/p9fa1w3gHoYbZfLYJE3NWr2addN/du3Jj2Mk7L rk2dQFUkGOXlXYc909upFVizOer50YHQT8xZNJ6UyajkgGVDVaSK0tIHMHWj9ckpCCAf 2RV23IqqVqKPvpImKy9pZDGdH2pvWmyjNrOVQ1thXsBW8QITEmJyIsywoy/gmQlqc/oF xUSJ8MTti5wc360P9X3f/YJQSQ8/E2edRsvrUISvFaYbdNDJ+d816MadZUCn5HvZWX0a xAFQ== X-Gm-Message-State: AOAM532BWcrytjtb5ECNulJ5qXTkzzPvTZy1AaXCi7RiZTgGZqCT5XDY gokMpv3/qj6oGdrSDwBPWQqP4gi+Q/uc4g== X-Google-Smtp-Source: ABdhPJxUfDl6EWoa3honkbN/zyMHaZP5JxKZ/VhSUICaf+5ugAUOYRBYCWq4kX1a8MYx1m7p9SrVFQ== X-Received: by 2002:a62:19c4:0:b029:13e:d13d:a081 with SMTP id 187-20020a6219c40000b029013ed13da081mr914549pfz.24.1599807997957; Fri, 11 Sep 2020 00:06:37 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 01/12] qemu: qemuDomainPMSuspendForDuration: Check availability of agent Date: Fri, 11 Sep 2020 15:06:08 +0800 Message-Id: <20200911070619.12325-2-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It requires a guest agent configured and running in the domain's guest OS, So check qemu agent during qemuDomainPMSuspendForDuration(). Signed-off-by: Lin Ma Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 2e46931c71..bd287f259e 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -16820,6 +16820,9 @@ qemuDomainPMSuspendForDuration(virDomainPtr dom, if (virDomainPMSuspendForDurationEnsureACL(dom->conn, vm->def) < 0) goto cleanup; =20 + if (!qemuDomainAgentAvailable(vm, true)) + goto cleanup; + /* * The case we want to handle here is when QEMU has the API (i.e. * QEMU_CAPS_QUERY_CURRENT_MACHINE is set). Otherwise, do not interfere --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808045; cv=none; d=zohomail.com; s=zohoarc; b=V2+7dpN+ls7RqkpAxHBms1/YbEX0Iga1IOH1Lt7+UpRdoVifL/OgogdEhLczMD883r/T/29m9hCeQQDttsZdi2tgBR2ZD5v7PT/mIVEOhRMvQsDoNAsESZYCmkEnh+wCE8l22IZIM61b7g6DKYtic+reBHa/1FmchL3e5u2aTvo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808045; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rAv9qDouKzgQ2RAzWu7onGatVkFQtGn72LSAL1tQiWI=; b=d0IDLSewVwAmgL2ac759niYOTgSKshhQcl4WVQoJT3YLVVAq/9MSf+yq3W6I+uIa/R4MG7jNH+3qlXY1FiycJaNZ4UvgEOV72TPpuGjHZnXp72808/b1rRiWz+VoiQLT5LHuI+J3VGuYw6TGzB7P7/NA4f9bnWeLgeDpjanfMUg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1599808045149585.7854158530879; Fri, 11 Sep 2020 00:07:25 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-tF4DaVVJPoiEjOvCWEJNlw-1; Fri, 11 Sep 2020 03:07:21 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5225F393B7; Fri, 11 Sep 2020 07:07:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 796E31A835; Fri, 11 Sep 2020 07:07:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9010092300; Fri, 11 Sep 2020 07:07:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B76lbv006896 for ; Fri, 11 Sep 2020 03:06:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id EBADB2144B2F; Fri, 11 Sep 2020 07:06:46 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E6F132166B27 for ; Fri, 11 Sep 2020 07:06:44 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8DEC3101AA41 for ; Fri, 11 Sep 2020 07:06:44 +0000 (UTC) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-292-YGHzj8_JNh-vgHPt2rc_9w-1; Fri, 11 Sep 2020 03:06:42 -0400 Received: by mail-pg1-f193.google.com with SMTP id f2so3956955pgd.3 for ; Fri, 11 Sep 2020 00:06:41 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:39 -0700 (PDT) X-MC-Unique: tF4DaVVJPoiEjOvCWEJNlw-1 X-MC-Unique: YGHzj8_JNh-vgHPt2rc_9w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rAv9qDouKzgQ2RAzWu7onGatVkFQtGn72LSAL1tQiWI=; b=kUbxq00w46KR+zvQkvjRhWjNX6GhWlZStTOXdJ2tUf6YD+VwMCkhrn+qwY6MwUNhhy TBBR5iw/nZz8byUkk9Phw9w9BxNY8viU5FaMWeU7Iahz5HAan69ht+OhAG78S81B0kDB v2mPMkcFMNvAcRx5fMw4ybILQ8cIu+oGKNU2biLUH5vS8ay9upoHBZx9IpuzThkHyK/H rkIaGgs+7C3ZY0TV/ZjD1wptt2vXkDKrYY93ktqPNEzH2GbRJNJDvdrs+Lqk1lq+znW8 6JAwLr0nTrW7uBtJaMn+f+iLTu20blY3GnICAqfuUHi0VYLjk4rJqJo8EawvRxAgIdwd X20g== X-Gm-Message-State: AOAM5339c0udy489wcfilxZwMXxDA3p7NVmLhGlnEcilfpQPRdVOgoyG JPyauUvClEjtFnUu+/O2/++JSn+m9WUo4Q== X-Google-Smtp-Source: ABdhPJwxZna9loNs7zj3yW3EK6ZSSDNthlweJIBN4Aq36I55ARKniQl0ELIPm2D3l6hAOcGg8aIBmg== X-Received: by 2002:a17:902:9b95:: with SMTP id y21mr654586plp.97.1599807999942; Fri, 11 Sep 2020 00:06:39 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 02/12] qemu: Return perf status that affect next boot for shutoff domains Date: Fri, 11 Sep 2020 15:06:09 +0800 Message-Id: <20200911070619.12325-3-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" While we set up perf events for a shutoff domain and check the settings, All of perf events are reported as 'disabled', unless we add --config, This is redundant for a shutoff domain. # virsh domstate $GUEST shut off # virsh perf --domain $GUEST cmt : disabled mbmt : disabled mbml : disabled ...... # virsh perf --domain $GUEST --enable mbmt mbmt : enabled # virsh perf --domain $GUEST cmt : disabled mbmt : disabled mbml : disabled ...... Use virDomainObjGetOneDefState instead of virDomainObjGetOneDef to fix the issue. After patch, The perf event status of a shutoff domain is reported correctly: # virsh domstate $GUEST shut off # virsh perf --domain $GUEST cmt : disabled mbmt : disabled mbml : disabled ...... # virsh perf --domain $GUEST --enable mbmt mbmt : enabled # virsh perf --domain $GUEST cmt : disabled mbmt : enabled mbml : disabled ...... Signed-off-by: Lin Ma Reviewed-by: Erik Skultety Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_driver.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index bd287f259e..717afcd34d 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -9109,6 +9109,7 @@ qemuDomainGetPerfEvents(virDomainPtr dom, int npar =3D 0; size_t i; int ret =3D -1; + bool live =3D false; =20 virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | VIR_DOMAIN_AFFECT_CONFIG | @@ -9123,7 +9124,7 @@ qemuDomainGetPerfEvents(virDomainPtr dom, if (qemuDomainObjBeginJob(driver, vm, QEMU_JOB_QUERY) < 0) goto cleanup; =20 - if (!(def =3D virDomainObjGetOneDef(vm, flags))) + if (!(def =3D virDomainObjGetOneDefState(vm, flags, &live))) goto endjob; =20 priv =3D vm->privateData; @@ -9131,7 +9132,7 @@ qemuDomainGetPerfEvents(virDomainPtr dom, for (i =3D 0; i < VIR_PERF_EVENT_LAST; i++) { bool perf_enabled; =20 - if (flags & VIR_DOMAIN_AFFECT_CONFIG) + if ((flags & VIR_DOMAIN_AFFECT_CONFIG) || !live) perf_enabled =3D def->perf.events[i] =3D=3D VIR_TRISTATE_BOOL_= YES; else perf_enabled =3D virPerfEventIsEnabled(priv->perf, i); --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808153; cv=none; d=zohomail.com; s=zohoarc; b=HuygsUyV7peJp3mTr626GReCedTvLtpYG4m0bPdqK15/9vSDGb6x9pif923RssQa0h1eT3m/fNtewSocZXXNQt28+QbIIvIETXgU9UUvk+o7ZuxiFUA3xLyJ5GKSMyNs7ivH+gjcypfAQ1Myyo8i6BjuNocM1OLqtIZCfjTXyKI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808153; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5hhvsq8TdlSnVenH8lGxsn50U5QKW3G7jDzQGU8Ify0=; b=M2FFagkA98JH80zCrV237UbdRoLwuynLvDo7KS9NwjycgfTmSfSNnMpHvmuCInM33MA5vwV65HS/x94VDH9F80OSYeKgYi+r1rUijf0M1KoRDusLQT7CWG8swRpPup9hlEvAOjS456D6qoL8RNGYrofkqgiBY5SmEr9ghJ4dnnY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1599808153774369.1940997863943; Fri, 11 Sep 2020 00:09:13 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-244-aXk7MgRtMdi4Z36F9TleSw-1; Fri, 11 Sep 2020 03:09:10 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 824C818BE166; Fri, 11 Sep 2020 07:09:05 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 60E1A75125; Fri, 11 Sep 2020 07:09:05 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2A51B181A06B; Fri, 11 Sep 2020 07:09:05 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B76kAk006891 for ; Fri, 11 Sep 2020 03:06:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id DDC9311921AB; Fri, 11 Sep 2020 07:06:45 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D97EA11921AA for ; Fri, 11 Sep 2020 07:06:45 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C0FE2811E76 for ; Fri, 11 Sep 2020 07:06:45 +0000 (UTC) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-4vs16OfjOt6LJhd4aj0eOg-1; Fri, 11 Sep 2020 03:06:43 -0400 Received: by mail-pg1-f196.google.com with SMTP id w186so5971037pgb.8 for ; Fri, 11 Sep 2020 00:06:43 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:41 -0700 (PDT) X-MC-Unique: aXk7MgRtMdi4Z36F9TleSw-1 X-MC-Unique: 4vs16OfjOt6LJhd4aj0eOg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5hhvsq8TdlSnVenH8lGxsn50U5QKW3G7jDzQGU8Ify0=; b=mw9GgZZlz13APHYLBxjbqaYliUmf2lVlptjMqR3kibgaQfDkaWDauEwebQIC+lNCEm ZCGdXW3E0OFqF+STU9nItckIo0aMqqu4EOhasF3ysEA0nxJfsWThG3dDY8CoeijoQaeq gbzRWm1dBCst/0P4A1E3XX0+jc1Kfp7tkEHpJyyMTAbVbAwTa1gfGC6p1A1o4m69dfpL QIAbIee+dz4c4v7cEejT9lrpulihR5h0NqW3ZSlQjfa3iybmxtGeF0fvGv32MPBnesDk GoRra+mTPzv3XQ8iEJSd8as7gneT40j1CathEsQzb5kZ7k8BrP04YEePejN1L1YsKn45 MNpA== X-Gm-Message-State: AOAM531afa+NWWORlj7AJ1HjOM4NHi34PtiacvoTjnbsgOKuCGbpK5JV ct/XaPxkHx8oC/W3WNphlxpA/ArI2cKvPg== X-Google-Smtp-Source: ABdhPJyp8dHqnwp/vu27y82qvlL1f/X3vIhG2wHLXcM3wfjoem/JR4RQPY9YtpDtxd6DaB9Rsos5lw== X-Received: by 2002:a17:902:8509:b029:d0:cbe1:e746 with SMTP id bj9-20020a1709028509b02900d0cbe1e746mr952729plb.33.1599808001887; Fri, 11 Sep 2020 00:06:41 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 03/12] network: Check for active network during networkGetDHCPLeases Date: Fri, 11 Sep 2020 15:06:10 +0800 Message-Id: <20200911070619.12325-4-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It doesn't make sense querying dhcp leases for interfaces against an inacti= ve network, This patch adds a check to see if the network is active. Signed-off-by: Lin Ma Reviewed-by: Erik Skultety --- src/network/bridge_driver.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 87d7acab06..1dffc2309f 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -4068,6 +4068,13 @@ networkGetDHCPLeases(virNetworkPtr net, if (virNetworkGetDHCPLeasesEnsureACL(net->conn, def) < 0) goto cleanup; =20 + if (!virNetworkObjIsActive(obj)) { + virReportError(VIR_ERR_OPERATION_INVALID, + _("network '%s' is not active"), + def->name); + goto error; + } + /* Retrieve custom leases file location */ custom_lease_file =3D networkDnsmasqLeaseFileNameCustom(driver, def->b= ridge); =20 --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808156; cv=none; d=zohomail.com; s=zohoarc; b=oBuc2dONEGHBsqyH989MQEGhnYAWFdyuh9Fl9oTVxPFb00o9aa3fztfSXquX1gyq2CCuuo2OxUq8DKxp9A+Fd5jqAl5TXXGNwgs32kvQBghp20Yyzf1riqPS52RpTMYf58QkQMWoFP7vuYPCftGYwQLuQj5YVxyG5uqXqJpr6s0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808156; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=u2yMh5vL7mm7lphv7Oniuhr1d91glYTnyQPEkKIIL68=; b=dayhm/yvcZDSnmd8Fz1XJ7MFGX8ODSBu26va64hWYII3XHnlyTDJkwSOlIKNTPGKxh6avKDUfrTS8Qb6Fsu7bezMTIiCidSyVVegWuq+3NOTQY/jWqtJfDNe3efJGRvzkCan+6perASG8RNNQWSiXxyJhBWN/AeIB+AtZVCg0Wk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1599808156314339.32768378881246; Fri, 11 Sep 2020 00:09:16 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-DlSonMMyMu6bQjBaOyky1A-1; Fri, 11 Sep 2020 03:09:12 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 263D3800470; Fri, 11 Sep 2020 07:09:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 01F717512C; Fri, 11 Sep 2020 07:09:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C51B492300; Fri, 11 Sep 2020 07:09:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B76msT006907 for ; Fri, 11 Sep 2020 03:06:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id F029210F9B4; Fri, 11 Sep 2020 07:06:47 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA7AF10FAA2 for ; Fri, 11 Sep 2020 07:06:47 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A05A6801225 for ; Fri, 11 Sep 2020 07:06:47 +0000 (UTC) Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-68-AAz0GgEpNlaTjhXKTC2EAQ-1; Fri, 11 Sep 2020 03:06:45 -0400 Received: by mail-pj1-f68.google.com with SMTP id kk9so1254513pjb.2 for ; Fri, 11 Sep 2020 00:06:45 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:43 -0700 (PDT) X-MC-Unique: DlSonMMyMu6bQjBaOyky1A-1 X-MC-Unique: AAz0GgEpNlaTjhXKTC2EAQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=u2yMh5vL7mm7lphv7Oniuhr1d91glYTnyQPEkKIIL68=; b=WoWkC/adtCOr/bj4xBnqkBd43K0oQm2DyST7HUEPxvp647xRl99HhPx3NfI2QePXqF ORwoJeu07CKiOEjKtE7ZvzXMRKKFVSXZafoV4drhqdzxzyGn/VmF0FWoSUU6138i/JaY AuMc8Ia1hhjUhAXLPypgX7l4QMKrb4gsa8H0Gj6FtdWJ79gkzAOOzlh4txCO8ibA/0+b BZo0Pz/1/UnA3UTqXm7/CwRmT2cJG3YlfzFMf2Qnd3b/NBtUwbFVqY5Kk1xV7GLB4ZuA FXQ4oZ2X7D4Uu4DxnwgqXfLWzgQLYibOzbHbfpGcgzo1jK4nrf9EkOzv1hrf83tVGuG1 W+nw== X-Gm-Message-State: AOAM530uRa+2Psgb8umzRTtfaGgZJoAa78dTANQOHLbbEd7rbZPnFgZT 3tLJx5w+eX0vC1D4lWfSHt17ibX6I2SaJw== X-Google-Smtp-Source: ABdhPJwg9EYzB98X4dy8VgB+RJQB4I4bzZIgtkuyO8EMZTrIcJeRP7upDMBXjHnqBpUKBNxoqcE2pQ== X-Received: by 2002:a17:90a:49c8:: with SMTP id l8mr960663pjm.24.1599808003888; Fri, 11 Sep 2020 00:06:43 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 04/12] virsh: domid: Error out if domain is not active Date: Fri, 11 Sep 2020 15:06:11 +0800 Message-Id: <20200911070619.12325-5-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- tools/virsh-domain.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index d1d3f8e566..86152a53b1 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -10458,18 +10458,21 @@ cmdDomid(vshControl *ctl, const vshCmd *cmd) { virDomainPtr dom; unsigned int id; + bool ret =3D false; =20 if (!(dom =3D virshCommandOptDomainBy(ctl, cmd, NULL, VIRSH_BYNAME|VIRSH_BYUUID))) - return false; + return ret; =20 id =3D virDomainGetID(dom); - if (id =3D=3D ((unsigned int)-1)) - vshPrint(ctl, "%s\n", "-"); - else + if (id =3D=3D ((unsigned int)-1)) { + vshError(ctl, "%s", _("Domain is not active")); + } else { vshPrint(ctl, "%d\n", id); + ret =3D true; + } virshDomainFree(dom); - return true; + return ret; } =20 /* --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808060; cv=none; d=zohomail.com; s=zohoarc; b=Chg3wtLTDsWqMQdN0gp/ipmzSA6TPPl7qekLVb4PhApL7AHjxy2FvCT41+l4slwsr3mAEswlJjgM824Cqryi8kJKrISbDFihqoRc4N+l4c0WZhO5Wql+RQkeDbrSlFrhvwE2sGVr3siWe3TrGDx1EAK6UE/boQro/qQLjtGigZ4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808060; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2G6jaMI5HP9Gy4gQ4O3v+mwJNyX3hsrTVYoXHxNvytw=; b=mLUZG8lEe2252pGYZR+lSvN61ThFdzyCX80eMiItyCGqc3y8Pbng/1FJwwafnKCTaa9wiwBQiIW0TmsQk+cAmtvtTqeNwDD6HKksMin66CWsyxG7hAgA2unj3mqyrPdURhOxGIpOJvIGNogLfWs3vOqQYmfHcZQbsiawAH/SegI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1599808060931286.12287866433235; Fri, 11 Sep 2020 00:07:40 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-438-zDzZjutmOlyk-MEhM7alhQ-1; Fri, 11 Sep 2020 03:07:37 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 60546393B7; Fri, 11 Sep 2020 07:07:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05EF560C07; Fri, 11 Sep 2020 07:07:32 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B348692300; Fri, 11 Sep 2020 07:07:31 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B76qtO006950 for ; Fri, 11 Sep 2020 03:06:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id 15D7A2028DC0; Fri, 11 Sep 2020 07:06:52 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F81A201EA97 for ; Fri, 11 Sep 2020 07:06:49 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AAC2C801779 for ; Fri, 11 Sep 2020 07:06:49 +0000 (UTC) Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-449-LEMfUDRRMXmrYRHrsV7JYg-1; Fri, 11 Sep 2020 03:06:47 -0400 Received: by mail-pg1-f177.google.com with SMTP id 67so5961495pgd.12 for ; Fri, 11 Sep 2020 00:06:47 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:45 -0700 (PDT) X-MC-Unique: zDzZjutmOlyk-MEhM7alhQ-1 X-MC-Unique: LEMfUDRRMXmrYRHrsV7JYg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2G6jaMI5HP9Gy4gQ4O3v+mwJNyX3hsrTVYoXHxNvytw=; b=HeOaL5a0aVTIMAPh+lMbTX5dm/8NdilympfEplK4cAhqjasiWU1icVQqPWxFZzv+qr HhreGPupwbSzXqNIOdQuYjyYsf/Hgr1KmAlZzDkmL6tkbMVTJzzJNdS+SLSj0szpf4om wgfDMQTbgQlXkG4jsMv8eJ+rwih4fqGsniAjCvfz0ZZ8TD4O+1298rL1LKSZzKZkG/Z0 eDkwwV/nAQzd66zIV5qNq0sR6X/el93CtXqxS7iXfj0rMAgQ6elt9yBB6LGvNf1S7Dko BwczTvN6rzJEssaFXMm4AJIH0t2SQq8OWYebnZfG5fN/rDoz3bH+SCUpGoDYyMTNv2fq xmbw== X-Gm-Message-State: AOAM533aGnJHe4BX8jfbCm5BjmyAnLFgNtF2/O6ztuq5XZYVmnGdtJ8Y xPhXGbo7oNbZFIkmj5SkEhop+Ei5B2qesA== X-Google-Smtp-Source: ABdhPJxkMv0fV1FcIOOvu0bvpXbRN/F53eRDJPYIfaOkFiCXFU6oATFA735lHvAJpUyVDRFlvui+rg== X-Received: by 2002:a17:902:7896:b029:d0:b9dd:edae with SMTP id q22-20020a1709027896b02900d0b9ddedaemr1016420pll.0.1599808005838; Fri, 11 Sep 2020 00:06:45 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 05/12] virsh: net-port-create: log errors for non-existent xml file Date: Fri, 11 Sep 2020 15:06:12 +0800 Message-Id: <20200911070619.12325-6-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- tools/virsh-network.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/virsh-network.c b/tools/virsh-network.c index f0f5358625..ce67e3f19b 100644 --- a/tools/virsh-network.c +++ b/tools/virsh-network.c @@ -1522,6 +1522,7 @@ cmdNetworkPortCreate(vshControl *ctl, const vshCmd *c= md) =20 ret =3D true; cleanup: + vshReportError(ctl); VIR_FREE(buffer); if (port) virNetworkPortFree(port); --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808096; cv=none; d=zohomail.com; s=zohoarc; b=DRo6G4titdvBVSteFmEZ4/ASZmvtdwy9lBd+EiRSPxR0MLFc04KHWLMQzdBx2WxCkZTvyV0CG09I753i6L8vFUnUWeeecR+hOpItgkwDfefwURo7COUaH38va6tf3b7ZRBhlTjjRz/mldS1VbdI2XedaGwYKzc8QBZkRicrXiII= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808096; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D9sppOthrTjsllC2NTSuzn58CgkQBNHYTEwG2e/FsCU=; b=TT4HI7PBiqxBBWWPG3tMBWjqpWruBR0djBzY+G7uxsOSMrQ9ScYT+oF+lQDJ1Lsn/fEiw37i/UhE5qjy/WgAY9zy8oO+Y5OXZ2Aq7vr5TON2TFoUYStoKv4wyNStZH6fzRZm5aW2ZKAy37X1wm9BH/MXSLKS5RNv64+RwgxWdKE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1599808096486321.9592675626801; Fri, 11 Sep 2020 00:08:16 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-3rXXLfOIMsaILRGg5XaSKw-1; Fri, 11 Sep 2020 03:08:12 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1114D1009455; Fri, 11 Sep 2020 07:08:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD0F827CC6; Fri, 11 Sep 2020 07:08:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A99271800BB2; Fri, 11 Sep 2020 07:08:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B76p6M006945 for ; Fri, 11 Sep 2020 03:06:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8E7FD10F9AB; Fri, 11 Sep 2020 07:06:51 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89C1710F030 for ; Fri, 11 Sep 2020 07:06:51 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7128A85828A for ; Fri, 11 Sep 2020 07:06:51 +0000 (UTC) Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-hiBWXm7HPDalVmfepj_iaA-1; Fri, 11 Sep 2020 03:06:49 -0400 Received: by mail-pf1-f195.google.com with SMTP id w7so6596923pfi.4 for ; Fri, 11 Sep 2020 00:06:49 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:47 -0700 (PDT) X-MC-Unique: 3rXXLfOIMsaILRGg5XaSKw-1 X-MC-Unique: hiBWXm7HPDalVmfepj_iaA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=D9sppOthrTjsllC2NTSuzn58CgkQBNHYTEwG2e/FsCU=; b=YmP03LQO9hsaMOQpgXu/sJOev+/dvfQSH/5SiypNoD/oNtfoh10umUl4rA4pe2Qs2z iO/ooMhlitVAAW3lmwOSSH7SZsd2uNrIBoJhvxsBn6vgrFekXWi6zSUX9f+xytP8ZBoz nUtljaIv9+IL+k+IVFEKVU20EsspCY93lcXQUxc1eN16gDudgJfrD2E0xw2q++VqsHs3 mBlpQurz6Bc8Sp7d7ReYfygaNHePi6aNC21BmgmsCUMbR+OWnM38Ps2RYMj45gmVRJ/l HlkCnO4B2SKf1qVKhPCis1uYAkrJsAh82G2rWpoxEcG/b/YeWmv3sdEqr5gvLUGDxcbW U33g== X-Gm-Message-State: AOAM532Y73BV5KJQAYAwgx45TLzldrrk+Cr/xCCKvZOdewJHmakFjlzJ ODoJyhOagkkgqf+kOttko2VhfrqQLKEA2A== X-Google-Smtp-Source: ABdhPJy36U3E38Z4UQRJLE3b3LBB5TGG3pOchm1r+dshvcq9VAItBzN3P6+xilXrFqbeb8rUa5WVKg== X-Received: by 2002:aa7:80d3:0:b029:13c:1611:66ba with SMTP id a19-20020aa780d30000b029013c161166bamr912058pfn.5.1599808007804; Fri, 11 Sep 2020 00:06:47 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 06/12] virsh: event: options --all and --event are mutually exclusive Date: Fri, 11 Sep 2020 15:06:13 +0800 Message-Id: <20200911070619.12325-7-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- tools/virsh-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 86152a53b1..657a0532db 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -13696,6 +13696,8 @@ cmdEvent(vshControl *ctl, const vshCmd *cmd) int count =3D 0; virshControlPtr priv =3D ctl->privData; =20 + VSH_EXCLUSIVE_OPTIONS("all", "event"); + if (vshCommandOptBool(cmd, "list")) { for (event =3D 0; event < VIR_DOMAIN_EVENT_ID_LAST; event++) vshPrint(ctl, "%s\n", virshDomainEventCallbacks[event].name); --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808065; cv=none; d=zohomail.com; s=zohoarc; b=ELNmsSxhl4jwd9kdJiBgMZb9B6xmZ48SXU6IAAOtSEOzjwHvSpOFVnHWgN843RAI4k8PXssntAJ64Tx86cy23S7NN70yZo4PfLeltFDe4Eo6dhZelliSAwxSu3mN7L+C8k7Sjte6Xqt7YUXBp+85H3iuqRSCXsYlXbt3FW1LvrI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808065; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CnPAgehWs9SmVUpVSNtod96cAMXROkvc4EoaYFuz+/w=; b=n3nfIC7pS7LePp896aKjZAoK3fZiZbMYkqZPR+WguiqoGcY0F8pHW1upLa1L8vtXCO/bsIrhJcEtAqSJ7rKkQitRPWBbQZSV/dXVLn6wDXJ/VblbJiQzJvJlZfGK7nSQIciiPXl2Qw1SqCDoFf0VJeiRgukx+DzEC8vX0K9S2+w= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1599808065080505.39770985303596; Fri, 11 Sep 2020 00:07:45 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-412-0EUj2y4nNmOuspeVRsR8Eg-1; Fri, 11 Sep 2020 03:07:41 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 235AE1005E73; Fri, 11 Sep 2020 07:07:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F18EA1A835; Fri, 11 Sep 2020 07:07:35 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B3A6C180B656; Fri, 11 Sep 2020 07:07:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B76sSp006961 for ; Fri, 11 Sep 2020 03:06:54 -0400 Received: by smtp.corp.redhat.com (Postfix) id 1A05D2144B2F; Fri, 11 Sep 2020 07:06:54 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 150502166B27 for ; Fri, 11 Sep 2020 07:06:54 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EEF3A848522 for ; Fri, 11 Sep 2020 07:06:53 +0000 (UTC) Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-591-rO7pGpZ4PmiW8y-5nrsc5A-1; Fri, 11 Sep 2020 03:06:51 -0400 Received: by mail-pg1-f170.google.com with SMTP id f2so3957227pgd.3 for ; Fri, 11 Sep 2020 00:06:50 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:49 -0700 (PDT) X-MC-Unique: 0EUj2y4nNmOuspeVRsR8Eg-1 X-MC-Unique: rO7pGpZ4PmiW8y-5nrsc5A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CnPAgehWs9SmVUpVSNtod96cAMXROkvc4EoaYFuz+/w=; b=tEz6oT7/K/0bIlQWZYR+xr70oGgAoJqa1a+p9c7hkyqU7OOs/LM9gLP97lgC+xFn1k 6JHSs3PT25BSMRxM0rgyJmbsN3Q3ecyMBdU6cgqwDzCOF6XuSJVnT0UmJBnUqrwEfGbf nVxQFfl7J96Af9U1Zw2AVfGFx+kKvlTf/H17CCJBW6+oOufLxkKipf+6GK2oP5DRZIpw kAunHWTEa9Pctp2+xw2MG738c3x+szC8azX7kDwcLVltWnXOqVw6s1/KZf+CicYPq3YT fvRN2rzVJLD71Ja/EyMjJSzU11Ncwtq4uZrFQz9syIs46p5Yw0iYCcu1+Z+cFuNgILAW hLcQ== X-Gm-Message-State: AOAM533lExYXwcGXF/v6s0FHl2rZq54mxmHHq2rhx8lsCngqM5qj35wG QftNWp+J/xFb0jnPoyxxaRFVS5iQkant/A== X-Google-Smtp-Source: ABdhPJyvzfiUiSj4DVwJ8qgZDlus/UbARrHiZeqm8cmcGKpKqpirHuwDSnzo/7owuNtZt79jZTWyeQ== X-Received: by 2002:a17:902:ac85:: with SMTP id h5mr687819plr.50.1599808009767; Fri, 11 Sep 2020 00:06:49 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 07/12] virsh: domblkinfo: options --all and --device are mutually exclusive Date: Fri, 11 Sep 2020 15:06:14 +0800 Message-Id: <20200911070619.12325-8-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma Reviewed-by: J=C3=A1n Tomko --- tools/virsh-domain-monitor.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c index 0111116885..a813476936 100644 --- a/tools/virsh-domain-monitor.c +++ b/tools/virsh-domain-monitor.c @@ -469,6 +469,8 @@ cmdDomblkinfo(vshControl *ctl, const vshCmd *cmd) char *phy =3D NULL; vshTablePtr table =3D NULL; =20 + VSH_EXCLUSIVE_OPTIONS("all", "device"); + if (!(dom =3D virshCommandOptDomain(ctl, cmd, NULL))) return false; =20 --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808161; cv=none; d=zohomail.com; s=zohoarc; b=CVZTLb28g9FbOr8RTsd9GVPCnO5ArTNfG0hyD2fcOiVjduQpyJ+JFP8Kajd0Ezfp9JemDI39ucjBfBwydPbEkY5iymGzxBtLueQ6hJmDdiXzwjDuFTiisOEO4thSz9rg5qOmMtYpKwChGKA3dzObfxvnuDAmv13PkfTFZVwNmuk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808161; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=CFeXn+hrF+w3qnLDxgnkNwiqh47u3obixxrQRR54Nto=; b=Plw6ysrJJWv+xMvUsLO31xVTvYQ6AXmMeSWuV7NqgvvTL+1iVaZDntR8fsO1YgFOsOYNdb3043NsRErKTnRmLQWDpMElzkwbMhH94FFX6OitlABxTH9Xan3toyjv8EK5GRTZYOfDVM++N7Ja/KGAnqQalgkhCI8/3oW1KjVe2Z8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1599808161068900.1464607913955; Fri, 11 Sep 2020 00:09:21 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-584-aSxokkpuNNS7rjEkGbm-yg-1; Fri, 11 Sep 2020 03:09:18 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0D2CC800471; Fri, 11 Sep 2020 07:09:13 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DDFE4100238C; Fri, 11 Sep 2020 07:09:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id AD9C9181A07C; Fri, 11 Sep 2020 07:09:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B76u5f006981 for ; Fri, 11 Sep 2020 03:06:56 -0400 Received: by smtp.corp.redhat.com (Postfix) id 4567610F030; Fri, 11 Sep 2020 07:06:56 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4128C10F9AB for ; Fri, 11 Sep 2020 07:06:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 28B06848520 for ; Fri, 11 Sep 2020 07:06:56 +0000 (UTC) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-557-DeRTnSugMX6Wq2wJyDPrlw-1; Fri, 11 Sep 2020 03:06:53 -0400 Received: by mail-pj1-f48.google.com with SMTP id kk9so1254687pjb.2 for ; Fri, 11 Sep 2020 00:06:53 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:51 -0700 (PDT) X-MC-Unique: aSxokkpuNNS7rjEkGbm-yg-1 X-MC-Unique: DeRTnSugMX6Wq2wJyDPrlw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CFeXn+hrF+w3qnLDxgnkNwiqh47u3obixxrQRR54Nto=; b=ImOPXqRmsly28wiS7x3U38yhAHK07+7W2PUe0rW3g4JJjLZKw8rTWKD6Uxc9QsFVxJ vREMJzolszQKsZuL2TFcZVJXgy2MwufukToRgtYJ6Cew4BzNgICq9NXmmdwBm46ttnWg biAoCf1BgNzDcvyNQgeSrYvlosc2gZCC1o2Nbye0L7E4kBkBsGdeERqkkb9zZlE4EyOs AgHJXAEB3Ug3NaaQfxUX6y6MyfR/73pXCLjo6oqa/xNBE9/1WmoTLomBtUBjyjztF3ol uvinBObTDQVy2kBVQWN22Vy393T7h7tJCWRW2JnFVMjNSd0+A/yW90EH1USuIhkDRLl7 W3Eg== X-Gm-Message-State: AOAM532QAuOv628+j2+A3Q7BN/ZUZx/WbuzS0kganbhHsurz6RRUMaey XY3vyS1Od8Dn6qE+lDxzS8fq/4brQ62mOw== X-Google-Smtp-Source: ABdhPJwMvxw+1pc9iAzuUbGuaMZ2fK7bzMTSqfIR0HwHcBF1Xn0pXmK8TjbsF52xb1UScZ06pPuuHA== X-Received: by 2002:a17:90a:f010:: with SMTP id bt16mr939538pjb.143.1599808012558; Fri, 11 Sep 2020 00:06:52 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 08/12] virsh: domdisplay: options --all and --type are mutually exclusive Date: Fri, 11 Sep 2020 15:06:15 +0800 Message-Id: <20200911070619.12325-9-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma Reviewed-by: J=C3=A1n Tomko --- tools/virsh-domain.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c index 657a0532db..8d7f45091c 100644 --- a/tools/virsh-domain.c +++ b/tools/virsh-domain.c @@ -11526,6 +11526,8 @@ cmdDomDisplay(vshControl *ctl, const vshCmd *cmd) const char *xpath_fmt =3D "string(/domain/devices/graphics[@type=3D'%s= ']/%s)"; virSocketAddr addr; =20 + VSH_EXCLUSIVE_OPTIONS("all", "type"); + if (!(dom =3D virshCommandOptDomain(ctl, cmd, NULL))) return false; =20 --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808068; cv=none; d=zohomail.com; s=zohoarc; b=IZwM85KVPT2HJRlamXXl66HfnW8kFWA0bcSVGGpPEwR2vnuFz35RFx7Ui7wlzkEeulm/0n2gcdLQK49sA3f8ajlsruVMydNZw4+ufa0cncxzEPrnFIfGW1zI2Khg48rYRyvmXYLlIngurChyoCAE42xUXjfEAvUXe1cR+mV3CKY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808068; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Dcu9SxRwR13pNTubXnTYLeCiEZqyQvDDvi7LvW90XvM=; b=nsAu9F1dFXPlT72rS2RoSv+KbQqKq4QthBoeSTLpwYral8+ohT9Ve70yWtZtClebDncS86TopzXy0B9s210HJMpeN9zRHWdI2YTaXtEk3CleSHOWPjCYZ9gNvDbjdiB79MFLVNZBuAXAIhEY+vWLGgKv88TcQXklII3YxdGBUnU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1599808068104361.76499197646774; Fri, 11 Sep 2020 00:07:48 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-273--EZiau68PZOeMr_BbYkaug-1; Fri, 11 Sep 2020 03:07:44 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F2FC9802B78; Fri, 11 Sep 2020 07:07:38 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CD8BB7512C; Fri, 11 Sep 2020 07:07:38 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9645F180B658; Fri, 11 Sep 2020 07:07:38 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B76wZp006990 for ; Fri, 11 Sep 2020 03:06:58 -0400 Received: by smtp.corp.redhat.com (Postfix) id 80E9E2144B2F; Fri, 11 Sep 2020 07:06:58 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7CA642166B27 for ; Fri, 11 Sep 2020 07:06:58 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6319B906380 for ; Fri, 11 Sep 2020 07:06:58 +0000 (UTC) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-147-tvjDv4diN9aBtxfT8FsvFQ-1; Fri, 11 Sep 2020 03:06:55 -0400 Received: by mail-pf1-f196.google.com with SMTP id d9so6592509pfd.3 for ; Fri, 11 Sep 2020 00:06:55 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:53 -0700 (PDT) X-MC-Unique: -EZiau68PZOeMr_BbYkaug-1 X-MC-Unique: tvjDv4diN9aBtxfT8FsvFQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Dcu9SxRwR13pNTubXnTYLeCiEZqyQvDDvi7LvW90XvM=; b=R1lpSevf4gmO80465suLfl9GDwbTkMiPlAkwaElhlwepFzFIZNkQ+fl3S+0gvqoSSg rGrrcjVRgcnHTbbPD7pnke8SMBFTqJBepGRz6HZIotsjLavEmEI7Oq/J+s82wP5NxrJS 8QMgb+FQZn0hZCjnHqhwtX96mgoO6QP3gzhg41KomiDTfQeVEwwPHXu9zKP7cjI9ujAy SZj+UFkh3pwaP7+rXqK+c8B2z7M4nZJRObh+6uMd9wGAnfOOUVmKnNIce7v0c6kQDwEJ DSP0WlHD8wAfKXWfqyyDKBYIn3uXzXtnLTG+z8E40H7XCVsUgMqD8bYnVfA6ml6ZqL8Q BMYw== X-Gm-Message-State: AOAM530j0rQ/0YGEOswsK3Pt3Qdv2ur0VmHZBwcA++u9oY8m8D50TqN2 bD18FiQf3C3bpcZje+CRasJndjFKX3Dhpw== X-Google-Smtp-Source: ABdhPJweXo5NQjgjOKg6tc5QDgyYFz9X0wy1TgxB/TM0DooaD9O1Kh0Q+a0SfpqdDCoEz9b9dIzQrw== X-Received: by 2002:a65:6913:: with SMTP id s19mr698711pgq.116.1599808014512; Fri, 11 Sep 2020 00:06:54 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 09/12] virsh: iface-list: options --all and --inactive are mutually exclusive Date: Fri, 11 Sep 2020 15:06:16 +0800 Message-Id: <20200911070619.12325-10-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma Reviewed-by: J=C3=A1n Tomko --- tools/virsh-interface.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index a6b52726c9..2bca2483dd 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -351,6 +351,8 @@ cmdInterfaceList(vshControl *ctl, const vshCmd *cmd G_G= NUC_UNUSED) bool ret =3D false; vshTablePtr table =3D NULL; =20 + VSH_EXCLUSIVE_OPTIONS_VAR(all, inactive); + if (inactive) flags =3D VIR_CONNECT_LIST_INTERFACES_INACTIVE; if (all) --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808164; cv=none; d=zohomail.com; s=zohoarc; b=d+i2ng7L9PxVjYHwo3QjWW58q69K3FIGIbn8BlT7bR3QoWGEeuYyxDUlMlg8ARqKdhxn2mw2w1m0mIQux3wcUoAmyC3fJpV1NyU2v2D/ZOnRHv0WsN5AnlIR2U43iKVrBSisqAPpof3OQwHk2Nf1IXZVGLu45ZynCiaQdHZIC6M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808164; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hhhDAimGLe83Z4ToUzw1WzPVw+P6WY+9wQbgLEe0Bhw=; b=emV2bIwmiaP68B4VkOTiig/xUSusjJ5lOHOSUeu2yrvcgKuCzuxaooId5iHV3e+6fFzgKx5irzH/hD50andBqFVBXvMmgh+ZSSP5wzJSwfvO+GkXWaSOKZRrWpfUsvsXkK515mJkC4qGbIEXZH8VlLkKQUvMQDAVcq+OaeNddWE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1599808164198407.9082587714771; Fri, 11 Sep 2020 00:09:24 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-tlO_uLsDPGSP_Y5s8FFweQ-1; Fri, 11 Sep 2020 03:09:20 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7512A81F00B; Fri, 11 Sep 2020 07:09:15 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 51FAA10013BD; Fri, 11 Sep 2020 07:09:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2145B92301; Fri, 11 Sep 2020 07:09:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B778Dk007041 for ; Fri, 11 Sep 2020 03:07:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id 8C62111921AB; Fri, 11 Sep 2020 07:07:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8679B11921AA for ; Fri, 11 Sep 2020 07:07:06 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0B1A6101AA48 for ; Fri, 11 Sep 2020 07:07:06 +0000 (UTC) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-80-icZkA6oeOBerbAbJ4fn8tA-1; Fri, 11 Sep 2020 03:06:57 -0400 Received: by mail-pg1-f194.google.com with SMTP id u13so5997347pgh.1 for ; Fri, 11 Sep 2020 00:06:57 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:55 -0700 (PDT) X-MC-Unique: tlO_uLsDPGSP_Y5s8FFweQ-1 X-MC-Unique: icZkA6oeOBerbAbJ4fn8tA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hhhDAimGLe83Z4ToUzw1WzPVw+P6WY+9wQbgLEe0Bhw=; b=NSZjZSUC7w141xJgOr7HAzgqbSoaK3RZduQ405USBJXuSnzuY/I8zK7fOGMqt6r2+2 +pY0Xk40GP5D+0AQWgFhfMdlkufLKbL11nsgH+jjzIAUn9sJTR7sXqtM0iWx4Q+RieC9 7hfe/V22iVZ197wsE6OIUTyIGZsB51JtUrcWYaRtazcM93VUN2Lv9a5s6Ix1hPNAmHcY 5KtZHyS6vcDh8pcqOWgL3lZCgebGreSQOa6ejKyfJmlIVgA7BtBP96D1HCbBe+BbDMql s+F0ZNRCIUASNcD22UW6rypEr16BkFGwhTbhjcYxATWz+U7B5QPJFFuzlc3skUe6gyuY LQNw== X-Gm-Message-State: AOAM532qrRCAVVoj70u+CZEWH1TsxBFvDJwzh6FtY1m7XTKi2C2vrjBs 21NFSF+mm+dcf+VtS0aTPkxTw3jQ+3f7wg== X-Google-Smtp-Source: ABdhPJzxRiA0oQGYkApZmdoDbuBx8MLTTuAcAItqQdE0iIOhe4MyMaOXy7RjKI4K23IeYZwoHImHww== X-Received: by 2002:a63:d4a:: with SMTP id 10mr679796pgn.175.1599808016477; Fri, 11 Sep 2020 00:06:56 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 10/12] virsh: pool-list: options --all and --inactive are mutually exclusive Date: Fri, 11 Sep 2020 15:06:17 +0800 Message-Id: <20200911070619.12325-11-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma Reviewed-by: J=C3=A1n Tomko --- tools/virsh-pool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c index 9fac590ec3..634e9ac8cd 100644 --- a/tools/virsh-pool.c +++ b/tools/virsh-pool.c @@ -1146,6 +1146,8 @@ cmdPoolList(vshControl *ctl, const vshCmd *cmd G_GNUC= _UNUSED) inactive =3D vshCommandOptBool(cmd, "inactive"); all =3D vshCommandOptBool(cmd, "all"); =20 + VSH_EXCLUSIVE_OPTIONS_VAR(all, inactive); + if (inactive) flags =3D VIR_CONNECT_LIST_STORAGE_POOLS_INACTIVE; =20 --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808087; cv=none; d=zohomail.com; s=zohoarc; b=g4EES7z8yP70X1iCE4sSJnYF0itpqlbaaCnSpzhZJPWFNsAbJvRJxS6PX5LHgIiJuFJcS+EKUvV+qWMV7X6sXAiODrkSDXR+4dIyuO7Gigd5BRnvmsTnBn+9XcfNP5iVCZWSoOsQzuMO2gEbiyigQjHvuzYjD4kYYu1wMeRDAvw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808087; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WgJfqZ5fwWAcELcM7/XuDI+V64QTBKVwpaFdLtA9myg=; b=hZqPPo9Q2BAxs3CGS9C1m63+bK2rYI9wYIDSAbgtyVrQJBTRlICR4iRLbDrPE40hnEl60nFcMo95CDcbs1uMRHh9sfvfcADDpt2QlO6mGgWAHXVMTSYIM2YcQdt6yTBVcpsLCKwh3k2ofcnVQfTG9RC0KvRl3sDhFWpfVgF4pww= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1599808087948938.6040456118939; Fri, 11 Sep 2020 00:08:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-354-pWWJTSNmPeWaER51iMbwHQ-1; Fri, 11 Sep 2020 03:07:46 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 902E481F009; Fri, 11 Sep 2020 07:07:41 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6C9A660C07; Fri, 11 Sep 2020 07:07:41 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3C33C92300; Fri, 11 Sep 2020 07:07:41 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B77259007008 for ; Fri, 11 Sep 2020 03:07:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id 527FD202450A; Fri, 11 Sep 2020 07:07:02 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4DE18201EA97 for ; Fri, 11 Sep 2020 07:07:02 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 33D2F802D3D for ; Fri, 11 Sep 2020 07:07:02 +0000 (UTC) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-Bsb6xlZ_OTG53IE7CdY4yA-1; Fri, 11 Sep 2020 03:06:59 -0400 Received: by mail-pg1-f196.google.com with SMTP id 5so5988052pgl.4 for ; Fri, 11 Sep 2020 00:06:59 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:57 -0700 (PDT) X-MC-Unique: pWWJTSNmPeWaER51iMbwHQ-1 X-MC-Unique: Bsb6xlZ_OTG53IE7CdY4yA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WgJfqZ5fwWAcELcM7/XuDI+V64QTBKVwpaFdLtA9myg=; b=YZd3Uj0EIZRztedxlQffaAt5fknk9ZbncKVm2/Kf+z+5X6Ydm0K7XHSmLQKMsjHhOX cwPZ+RhIlacnZ+Akn+niY7VSvMEL3d3NyR725cxLSoiRQqG6ToEy1B8hnh9GMaN/4gN9 valddF8lI8Hw0KEyB5cxPGAGwoprhx05Pbrwq/+sTs5uDbY0Yp7CYtqDCFaeXhyxt0ud rHr6M/ygzinbuwyLCM5KAV1tUgoMPWsrjxaXxPCmR7+yCONocr+n03HiZ0mNyanA1/6v FhBu5V2B9NSYoD142s3dJWoFPRMG/uWR2EluC2k7QeR0bP0gJEnI90tM7mjf1IrtsoXQ njTA== X-Gm-Message-State: AOAM532UYQukpp/c7mwSeNOQJrSimY1VdcPsHubHMhTwBJRLyanbVvtN lBwkXY7NySAxBG0cvM/AHYFE8RhftcKhDw== X-Google-Smtp-Source: ABdhPJwKb9TJLj6Hij4kYya0WchPZSA2rA2XiSJp5dUt0hsiy0v2TZY/ePKzUEiEo13SLr6y10wajw== X-Received: by 2002:a17:902:9a06:b029:d0:cb2d:f276 with SMTP id v6-20020a1709029a06b02900d0cb2df276mr977858plp.15.1599808018451; Fri, 11 Sep 2020 00:06:58 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 11/12] docs: virsh: Document the IO mode 'io_uring' Date: Fri, 11 Sep 2020 15:06:18 +0800 Message-Id: <20200911070619.12325-12-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma --- docs/manpages/virsh.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index ca5acf84ca..b8206205f6 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -4521,7 +4521,8 @@ within the existing virtual cdrom or floppy device; c= onsider using *sourcetype* can indicate the type of source (block|file) *cache* can be one of "default", "none", "writethrough", "writeback", "directsync" or "unsafe". -*io* controls specific policies on I/O; QEMU guests support "threads" and = "native". +*io* controls specific policies on I/O; QEMU guests support "threads", +"native", "io_uring" since kernel 5.1 and qemu 5.0. *iothread* is the number within the range of domain IOThreads to which this disk may be attached (QEMU only). *serial* is the serial of disk device. *wwn* is the wwn of disk device. --=20 2.26.0 From nobody Thu Apr 25 08:59:46 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1599808075; cv=none; d=zohomail.com; s=zohoarc; b=MDEF7ykjWX8U/ig+o4MjQc+96Kmah1SHkJb/CslMaaTwvCHEHG/O+GXwxGLwmhWqMNd/fXZB8mSSjZreg3x76BDlPoCHayKcAlanFr4QTzlOwk86O0WyYhojpP+kDf7a6UWCZJUWGzR0JAxzA/hW7IYnt0sXg7o74YEqPb/n9S8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599808075; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fCp2eGdgptcGDQiuYCKQlrOQ9YUojQVP4EUzSXYs8tk=; b=iR14KcnKAoGT/kvbWeZx54ExCsf++cI37HIyCtrl/DKPLKDUKzzHG7JzaHplhjBcvu6Z2ra6fAVgPNtwzMoJcfsnU+7marYIvhR3mc2LU1ntuMjrmt7/bITtY5p+a9195CMVezbs91O+vr4r4tuTATOKEa+EzqGZbSanmiQlmm8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1599808074860492.29761940876347; Fri, 11 Sep 2020 00:07:54 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-519-F5hj9CiHPnaQVMOh-VUo2Q-1; Fri, 11 Sep 2020 03:07:49 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EDFC880F04E; Fri, 11 Sep 2020 07:07:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C836160C07; Fri, 11 Sep 2020 07:07:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 96C2F180B791; Fri, 11 Sep 2020 07:07:43 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 08B776Rq007027 for ; Fri, 11 Sep 2020 03:07:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id BB96D2142F4A; Fri, 11 Sep 2020 07:07:06 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AACAC2142F50 for ; Fri, 11 Sep 2020 07:07:04 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 497CA811E7F for ; Fri, 11 Sep 2020 07:07:04 +0000 (UTC) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-409-yO8LGVlxOdiCRTX6WcG0Bw-1; Fri, 11 Sep 2020 03:07:01 -0400 Received: by mail-pf1-f193.google.com with SMTP id d9so6592715pfd.3 for ; Fri, 11 Sep 2020 00:07:01 -0700 (PDT) Received: from t440p.suse.asia (60-251-47-115.HINET-IP.hinet.net. [60.251.47.115]) by smtp.gmail.com with ESMTPSA id a19sm1252037pfn.10.2020.09.11.00.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2020 00:06:59 -0700 (PDT) X-MC-Unique: F5hj9CiHPnaQVMOh-VUo2Q-1 X-MC-Unique: yO8LGVlxOdiCRTX6WcG0Bw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fCp2eGdgptcGDQiuYCKQlrOQ9YUojQVP4EUzSXYs8tk=; b=YiLELywezy2dJ579O2Cfrcf59Fsae8Sf01pJ9s0l+LyJEtX5gKmS5Mok2b+RPSCuj6 NE8Dl0lH72EppZOn+LETmxIWNh1us6ZfFrcksbghdTCosfqAnP94ZRoUdNBAM74vWok6 LIU5JL+cUfsh5ZOn68W/YjuPOsOBzYwqyRnCvDLL6uhaU+fyz7KvbImGFULSZPiTI73y bfg+tvfJ+fymsbr6rQTgm0TLJmHNwpYuKgpSD95ZIMQ4epFnR+BfjTVYci+MOkxrdESv n8bs/fU5lQLq6NDc0X9oBluM+UQzV6KJZWflQpTWcIy5Le78jIHM0R6fS/h4tQoJeQKP ZkHw== X-Gm-Message-State: AOAM532Ynday6t9dEFZBHA8y1xfhln+kj81NLfz5GZxCIq2HK6yFbiiP lOlm6SM+BRU6+d0YjZmLkEdRlP+ISYYa2w== X-Google-Smtp-Source: ABdhPJzpURlx4yfrBNAFUV4WGn9bq06Yl/9A1yAIij2E0Ondkz0R+kVHLAie04rSsdIDmPC3/kkZ1A== X-Received: by 2002:a63:4404:: with SMTP id r4mr658227pga.29.1599808020408; Fri, 11 Sep 2020 00:07:00 -0700 (PDT) From: Lin Ma X-Google-Original-From: Lin Ma To: libvir-list@redhat.com Subject: [libvirt] [PATCH 12/12] docs: virsh: Drop duplicate spelling for dompmwakeup Date: Fri, 11 Sep 2020 15:06:19 +0800 Message-Id: <20200911070619.12325-13-lma@suse.de> In-Reply-To: <20200911070619.12325-1-lma@suse.de> References: <20200911070619.12325-1-lma@suse.de> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Lin Ma X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Lin Ma Reviewed-by: J=C3=A1n Tomko --- docs/manpages/virsh.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst index b8206205f6..963a27c031 100644 --- a/docs/manpages/virsh.rst +++ b/docs/manpages/virsh.rst @@ -2156,7 +2156,7 @@ dompmwakeup Wakeup a domain from pmsuspended state (either suspended by dompmsuspend or from the guest itself). Injects a wakeup into the guest that is in pmsuspe= nded state, rather than waiting for the previously requested duration (if any) = to -elapse. This operation doesn't not necessarily fail if the domain is runni= ng. +elapse. This operation does not necessarily fail if the domain is running. =20 =20 domrename --=20 2.26.0