From nobody Tue Feb 10 04:14:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1599191210; cv=none; d=zohomail.com; s=zohoarc; b=grWOXKY4KYkskM97P75Ummsq+6yrflEIfknFg/CMMJLVVB4WZuW2KHEXFbnOiG0EyXQwqQfVvgHixPjARM0AWgTgWS2kRU43e6BXSIerTnHBKas41kd7o59OAZC3fB0iOLPNYRntjukBwHIbkBagllFfCniT+XMYW+FXvNMS/9Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1599191210; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wLRtD+rrXDx3qZMOMhsFXdiZO6tIMdpHkgdFGsEioms=; b=bnaQ29urO5KRhs8QeOlunbg0ut7lO7d0MShzSiinKq5j/FiIqK0swN7W402P0nWJi3YgI2g9VUMg8PMqjKbyEVtVH5e6xgehxGu8AA0vcngJSiHZDhrbxUOYAEbHGCVEBynr9gbBowenJYod8Pwd4TPdbBLtgKcVSwszzJTNlHA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.zohomail.com with SMTPS id 1599191210042487.9222753753347; Thu, 3 Sep 2020 20:46:50 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-531-9nzoHzr2P_Wyg4ypbzfg-A-1; Thu, 03 Sep 2020 23:46:46 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75A028015A5; Fri, 4 Sep 2020 03:46:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C4D37EED4; Fri, 4 Sep 2020 03:46:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5E84D972E1; Fri, 4 Sep 2020 03:46:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0843kcem032370 for ; Thu, 3 Sep 2020 23:46:38 -0400 Received: by smtp.corp.redhat.com (Postfix) id 60CDB202451D; Fri, 4 Sep 2020 03:46:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A89F20244F7 for ; Fri, 4 Sep 2020 03:46:35 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 30256101A540 for ; Fri, 4 Sep 2020 03:46:35 +0000 (UTC) Received: from mail-proxy25222.qiye.163.com (mail-proxy25222.qiye.163.com [103.129.252.22]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-364-Bmj2IbepNCq6HFwDzleMUQ-1; Thu, 03 Sep 2020 23:46:32 -0400 Received: from localhost.localdomain (unknown [58.56.27.130]) by smtp4 (Coremail) with SMTP id JedpCgAHcNgStlFfYHYgCg--.1426S36; Fri, 04 Sep 2020 11:35:56 +0800 (CST) X-MC-Unique: 9nzoHzr2P_Wyg4ypbzfg-A-1 X-MC-Unique: Bmj2IbepNCq6HFwDzleMUQ-1 From: Shi Lei To: libvir-list@redhat.com Subject: [RFCv2 34/46] conf: Generate virDomainGraphicsDesktopDefFormatAttr Date: Fri, 4 Sep 2020 11:35:26 +0800 Message-Id: <20200904033538.418579-35-shi_lei@massclouds.com> In-Reply-To: <20200904033538.418579-1-shi_lei@massclouds.com> References: <20200904033538.418579-1-shi_lei@massclouds.com> MIME-Version: 1.0 X-CM-TRANSID: JedpCgAHcNgStlFfYHYgCg--.1426S36 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjTR5CzNUUUUU X-Originating-IP: [58.56.27.130] X-CM-SenderInfo: pvklsz1hl6ztxvvfz0xxgvhudrp/1tbiUB2VT1f4qIyqjAAAs6 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Signed-off-by: Shi Lei --- src/conf/domain_conf.c | 8 ++------ src/conf/domain_conf.h | 2 +- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index ad129e9..bc42068 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -28177,12 +28177,8 @@ virDomainGraphicsDefFormat(virBufferPtr buf, break; =20 case VIR_DOMAIN_GRAPHICS_TYPE_DESKTOP: - if (def->data.desktop.display) - virBufferEscapeString(buf, " display=3D'%s'", - def->data.desktop.display); - - if (def->data.desktop.fullscreen) - virBufferAddLit(buf, " fullscreen=3D'yes'"); + if (virDomainGraphicsDesktopDefFormatAttr(buf, &def->data.desktop,= def, NULL) < 0) + return -1; =20 break; =20 diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index ec08bdd..08af9e1 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -1703,7 +1703,7 @@ struct _virDomainGraphicsRDPDef { /* genparse:withh= ook, genformat:separate */ char *_listen; /* xmlattr:listen, formathook */ }; =20 -struct _virDomainGraphicsDesktopDef { /* genparse */ +struct _virDomainGraphicsDesktopDef { /* genparse, genformat:separate */ char *display; /* xmlattr */ bool fullscreen; /* xmlattr */ }; --=20 2.25.1