From nobody Fri May 3 18:33:37 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1598746340; cv=none; d=zohomail.com; s=zohoarc; b=MN3sF71FqqhdLxc34bQ89n7XyKv933EbEPqtav1YOhZg87/p7dv6+y+SvLqinBgYod5HsFFJYAFdYIKol6oABf4OiCwJQWUFlQ3cEgnic0s+vaPr6xwYubSLFYPA2JUHjdCmV8GCoTy8Fadw3JyOKGqeAdOUXErO69Th2Gu4Lrk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598746340; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=yhKlETOqWx99NjqlBYVNiAHqVAkNZ0nJ9CcSdaM48Uc=; b=Bb+hR6wScmrKMTcaq5p1WYME9rFTYiSsbxziQNRVGV6GfzCdCNCm2Ptzr8joDMZIB5LZ5z7q4uZ322iwKTYCuRwYhTEEARNquVr8xWch969XbRHeftOgnEDmphCrzdTpsXJgqdiORJJzZKazMx0Qq2iEzV5sxxajhsrGYQk90e8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 15987463400111008.3479071542042; Sat, 29 Aug 2020 17:12:20 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-38-MvPhQulIMfaJA_uX7ytjKw-1; Sat, 29 Aug 2020 20:12:15 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C375D802B79; Sun, 30 Aug 2020 00:12:06 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 338187E72E; Sun, 30 Aug 2020 00:12:04 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 2705C183D020; Sun, 30 Aug 2020 00:11:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 07U0A3hi020969 for ; Sat, 29 Aug 2020 20:10:03 -0400 Received: by smtp.corp.redhat.com (Postfix) id DBAC25AB87; Sun, 30 Aug 2020 00:10:02 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D67235EDE1 for ; Sun, 30 Aug 2020 00:10:00 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 525AE101A53F for ; Sun, 30 Aug 2020 00:10:00 +0000 (UTC) Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-109-iaUKSRaiPz6fwvh25M4MJQ-1; Sat, 29 Aug 2020 20:09:57 -0400 Received: by mail-qt1-f194.google.com with SMTP id b3so2340077qtg.13 for ; Sat, 29 Aug 2020 17:09:57 -0700 (PDT) Received: from localhost.localdomain (ool-18e49371.dyn.optonline.net. [24.228.147.113]) by smtp.gmail.com with ESMTPSA id e13sm1844204qtr.85.2020.08.29.17.09.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Aug 2020 17:09:56 -0700 (PDT) X-MC-Unique: MvPhQulIMfaJA_uX7ytjKw-1 X-MC-Unique: iaUKSRaiPz6fwvh25M4MJQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yhKlETOqWx99NjqlBYVNiAHqVAkNZ0nJ9CcSdaM48Uc=; b=UYYw+4eu3m3vUPAS0WSldh6U5OIqHONGouaAEunFsNLCy8yUTOY2o0O1Roh8qJGrGV NEwkFxyVJAZ5Qzin7CAUrAZPDDGq4t8HH+Ydms875l3lUQYYmIs8LH2CG5wjcO0FaVzi QIVi6jz3XkSI61BN6zRXeLfAxaNy8k7wJcNN6vj4lIFf8Vn5Fgf84jxGNK1eidlNyMVq 6y6LgDQLaZdJC6tEwCSYB1267Sr0iKp6b119rUxW+HYzHfztR0jh9AZh1aTL6Sg22aEG I8Z8oLrzCDdXOcv4bkTc3s8hR6TA5VbKyqARY8/QAyVNLJeY3d9BdlhoxqO53oEV5pgm 6rbg== X-Gm-Message-State: AOAM5307KZohyMrqaqySa9S5ZOTPjk7ctjlo7MbUBAfiAZ0Oh4TLhZqD 9wLfGaR0EgWxqO/Go/XNVKMcwOUOiqaHLA== X-Google-Smtp-Source: ABdhPJz/lIXW/+Jjjl6mgWo+lopoHtxr+8Rl964G0YQz+0KcNW99UyQYlm28ai+sToWhnZGYOtqEdw== X-Received: by 2002:ac8:6c49:: with SMTP id z9mr7735939qtu.110.1598746197052; Sat, 29 Aug 2020 17:09:57 -0700 (PDT) From: Neal Gompa To: libvir-list@redhat.com Subject: [PATCH] rpm: Fix conditional for defining %_vpath_builddir for RHEL <= 7 Date: Sat, 29 Aug 2020 20:09:18 -0400 Message-Id: <20200830000918.11431-1-ngompa13@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: libvir-list@redhat.com Cc: Neal Gompa X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The conditional was incorrectly overriding %_vpath_builddir when %rhel is not defined, which led to surprising behavior when the global %_vpath_builddir path is set on Fedora already. Signed-off-by: Neal Gompa Reviewed-by: Jiri Denemark --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index bb74443484..4b9e04ae61 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -32,7 +32,7 @@ %endif =20 # On RHEL 7 and older macro _vpath_builddir is not defined. -%if 0%{?rhel} <=3D 7 +%if 0%{?rhel} && 0%{?rhel} <=3D 7 %define _vpath_builddir %{_target_platform} %endif =20 --=20 2.26.2