From nobody Mon Feb 9 06:48:23 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1598623874; cv=none; d=zohomail.com; s=zohoarc; b=hjK8rn9zc3+H6OpfqpCFu3ozziU7eQNy0Snih03fL6g07AxqyIXSpXvQz1aoTF+jmiWVIuw7LKvc7zYeq9OphgBEqa+ZmbTrKMp0vLbfhQzaMAXdSz7GmFoXNuli3l4f6loJW/RRzznov0Pdzz3gf7I2wArosWsPaT72qWFSTnY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598623874; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=yVf0fWOn6OMKCxD5WqaF+MpfG/JuMj495c80z6qsJjg=; b=K/GiVFkMAg2awG/DQ8zw3G9qwzmI8FUJyuJeoYgdSb+kCnyyLtjyfDrE0rY+pL8NenXh1udarc08a1ErzipWOtPp0b1/aE9m2j2lRawtur7VzjatcElGYA1FJwdRCLq01WhJS4ByV5cVxBPcEWTEU/uTQ5rEWZ8KCKeTEpiuzpM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1598623874609421.182072578226; Fri, 28 Aug 2020 07:11:14 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-80-cuveRlMNO5SvRsCnnBDcyQ-1; Fri, 28 Aug 2020 10:11:11 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3CC9EAE412; Fri, 28 Aug 2020 14:11:00 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1C4745C1DA; Fri, 28 Aug 2020 14:11:00 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DC012181A06D; Fri, 28 Aug 2020 14:10:59 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 07SEAphT028134 for ; Fri, 28 Aug 2020 10:10:51 -0400 Received: by smtp.corp.redhat.com (Postfix) id 81753110C575; Fri, 28 Aug 2020 14:10:51 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BEA2110C573 for ; Fri, 28 Aug 2020 14:10:51 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 64301101A56B for ; Fri, 28 Aug 2020 14:10:51 +0000 (UTC) Received: from mail-qk1-f193.google.com (mail-qk1-f193.google.com [209.85.222.193]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-276-9USDJM96PH6QpGMq3FY4GQ-1; Fri, 28 Aug 2020 10:10:46 -0400 Received: by mail-qk1-f193.google.com with SMTP id o196so1019836qke.8; Fri, 28 Aug 2020 07:10:46 -0700 (PDT) Received: from localhost (209-6-122-159.s2973.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [209.6.122.159]) by smtp.gmail.com with ESMTPSA id j140sm852701qke.110.2020.08.28.07.10.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 28 Aug 2020 07:10:45 -0700 (PDT) X-MC-Unique: cuveRlMNO5SvRsCnnBDcyQ-1 X-MC-Unique: 9USDJM96PH6QpGMq3FY4GQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yVf0fWOn6OMKCxD5WqaF+MpfG/JuMj495c80z6qsJjg=; b=oIQiPN9o2slI82Prgir4LHI+vUP5Sb/qlkWQ0qGUz2pijAvmxJ86KUd7mUaSHwpx+c 3whjgC3NZnRXAiGEuWEY7RZkWeI7SqwQx5tjq9uQBN6U9vSTHFWoPaPQ4R/GYzzIKmwV M35qBxnWXQJkWFRBiP8eLeIBrh0hJbe+GDjMiidjimdVEZ64v7h/xZlcX/rNWB597f4q bGofmrJhkKGaDj2cojHuKStkYAl2McSc/DvsRZJQPchEa5BOpMv2AHhFj0Ce3wR+3zyn zhLynWxJzE4gsofhUEPRwzzn85T//DekMZpvT1UK5f5VQWOEx/8EylqVaSlI6S9+hRat mE7A== X-Gm-Message-State: AOAM533M/LO666/Y6GrhAzzaCl5HIyUZEkBzWqHc2bFYvp/7gB60i9i9 kPCx5/IxxgOsPhI9z4agjQcXYTRjchz/ X-Google-Smtp-Source: ABdhPJyQ3wifksajJT/VeYDqLqjuUhfO3jfX8IScVpaQeALzXAPpwQzUDhSG3NQ4gdqwB0kTsbIvdw== X-Received: by 2002:a05:620a:22b5:: with SMTP id p21mr1214300qkh.119.1598623846310; Fri, 28 Aug 2020 07:10:46 -0700 (PDT) From: Masayoshi Mizuma To: libvirt-list@redhat.com, Eric Blake , Peter Krempa Subject: [PATCH v2 4/7] qemu: Transient option gets avaiable for qcow2 and raw format disk Date: Fri, 28 Aug 2020 10:08:33 -0400 Message-Id: <20200828140836.14266-5-msys.mizuma@gmail.com> In-Reply-To: <20200828140836.14266-1-msys.mizuma@gmail.com> References: <20200828140836.14266-1-msys.mizuma@gmail.com> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: Masayoshi Mizuma , Masayoshi Mizuma , qemu-block@nongnu.org X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 2.002 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Masayoshi Mizuma Signed-off-by: Masayoshi Mizuma --- src/qemu/qemu_validate.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 488f258d00..82818a4fdc 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -2166,9 +2166,12 @@ qemuValidateDomainDeviceDefDiskFrontend(const virDom= ainDiskDef *disk, } =20 if (disk->transient) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("transient disks not supported yet")); - return -1; + if ((disk->src->format !=3D VIR_STORAGE_FILE_QCOW2) && + (disk->src->format !=3D VIR_STORAGE_FILE_RAW)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("transient disks not supported yet")); + return -1; + } } =20 if (disk->iomode =3D=3D VIR_DOMAIN_DISK_IO_NATIVE && --=20 2.27.0