From nobody Sat May 4 00:48:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) client-ip=63.128.21.124; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-124.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1598474138; cv=none; d=zohomail.com; s=zohoarc; b=e5o911t15vR8Qlmx88C4ME3Np63RvjIJ6WXipCsHmtFaLVvehpFrUjWN9Wqm2BSHEUE+P9xF25Zb3GXPtnG62BI6fXr/T0OfgRaMA9e4Cu/xCl2VwWlAu2BqAsdwakYuzJsPLz53Dpddb0ja+HK7M0ECvYu1RRiw0YXMcE7wcE0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1598474138; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vc0chyR7JV/nSXPY3ZtZ1uNnBgOWxh2rrJ4Zhb3O8bs=; b=LivEiwTsUvk5jmUXk6KCxLFb22HYRK9U0xrk825+SBwdhgN5Uwd+tt2CIG7ipNbmRS4rSkJaqGQ0Uh/Nf5GRZTuLQEa8v/b2p7HmjYvkc/prqEMOSyYeUyTEQ/ymCpBKjuYCUPdIg7CgZJo7E6akwoCnFI5uSwIcws4FZxYmwAM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.zohomail.com with SMTPS id 1598474138799281.6751772036465; Wed, 26 Aug 2020 13:35:38 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-222-G8-S81_2Nd-GcaZC0Lr6BA-1; Wed, 26 Aug 2020 16:35:34 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7401F5200; Wed, 26 Aug 2020 20:35:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4E6C65D9E8; Wed, 26 Aug 2020 20:35:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C5501181A869; Wed, 26 Aug 2020 20:35:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 07QKZIIj015651 for ; Wed, 26 Aug 2020 16:35:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id D427A72E4F; Wed, 26 Aug 2020 20:35:18 +0000 (UTC) Received: from vhost2.laine.org (ovpn-112-68.phx2.redhat.com [10.3.112.68]) by smtp.corp.redhat.com (Postfix) with ESMTP id E902175261; Wed, 26 Aug 2020 20:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598474137; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vc0chyR7JV/nSXPY3ZtZ1uNnBgOWxh2rrJ4Zhb3O8bs=; b=XSvDzNWpG/LtcV0bboboutdaYSpwbgJegLZt1G/TG1z+mMKJiyhCrlBg/jL2/yGlUTIZNc 9BuNdr4XgvyOA+oFA+34zhQAosFsYfa55YnL9Fhl6uVoxeBe1c6a67DY3iMqX14R30pwvG ojtyHi6BpJHSWT8STEmAXJ0aoMpvqYk= X-MC-Unique: G8-S81_2Nd-GcaZC0Lr6BA-1 From: Laine Stump To: libvir-list@redhat.com Subject: [libvirt PATCH 0.5/2] meson: link libm Date: Wed, 26 Aug 2020 16:35:10 -0400 Message-Id: <20200826203510.211592-1-laine@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, jtomko@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0.0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" **************** (So here is a separate patch to add linking of libm. Care to ACK it? Also, what are peoples' opinions of pushing these patches now, so that they'll be in the upcoming release? I've put them on a private gitlab branch so that the CI is run (and found two mingw build problems :-)), except I haven't been able to make the cirrus-ci thing that builds freebsd and macos to work.) **************** On some platforms libm (needed for the pow() function) isn't being linked in somehow. This patch adds the necessary bits to assure that it's linked in when necessary. Suggested-by: Michal Privoznik Signed-off-by: Laine Stump Reviewed-by: Daniel P. Berrang=C3=A9 --- meson.build | 3 +++ src/util/meson.build | 1 + 2 files changed, 4 insertions(+) diff --git a/meson.build b/meson.build index dabd4196e6..81668a6681 100644 --- a/meson.build +++ b/meson.build @@ -1176,6 +1176,9 @@ endif libxml_version =3D '2.9.1' libxml_dep =3D dependency('libxml-2.0', version: '>=3D' + libxml_version) =20 +cc =3D meson.get_compiler('c') +m_dep =3D cc.find_library('m', required : false) + use_macvtap =3D false if not get_option('macvtap').disabled() if (cc.has_header_symbol('linux/if_link.h', 'MACVLAN_MODE_BRIDGE') and diff --git a/src/util/meson.build b/src/util/meson.build index a7017f459f..f7092cc3f1 100644 --- a/src/util/meson.build +++ b/src/util/meson.build @@ -188,6 +188,7 @@ virt_util_lib =3D static_library( devmapper_dep, gnutls_dep, libnl_dep, + m_dep, numactl_dep, secdriver_dep, src_dep, --=20 2.26.2