From nobody Sat Feb 7 11:05:09 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1596720973; cv=none; d=zohomail.com; s=zohoarc; b=nxK0kylXunuEuBjObh1Uh5lzlLs4DskofrrhCHGO6YYItG5X4qus2EtcOJlS4Y2w64/Me4I/OqSdCOhPTYcT2dgcAxM8yUK+BMMA4s7EcrtQDxt3Xoi3LMgnSUiIuxYbIvDZ3QAcBLj/0gtHjvfDK1mjsRL0zBJoTFV7yrjjHCM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596720973; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WAq0GU5DS0K5llJ6d/+w3J2UpjLSToRbyNHeqa+WsFA=; b=ObXVk/lRo2ukZGibhtXPhzYRzFsMtsS/PwtV1qC6uimfWBzUPupB+9IZCSn6fv1x4es0ZfPOqbMYMMpYG+R7cBhiHXQX2eFUhlqjIH1EjOYfdrdYxbHyJyJCxGt+5/stkVsSKpB+/ApZUtkAN6hs4rhumpOpDe8ICFW5h9zCypE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 159672097313578.91735272687538; Thu, 6 Aug 2020 06:36:13 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-472-NCl6fJWCP_eCIP5jxA-Wzw-1; Thu, 06 Aug 2020 09:36:08 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 427E8101C8AA; Thu, 6 Aug 2020 13:36:03 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F39997B90B; Thu, 6 Aug 2020 13:36:02 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 572FB1800B72; Thu, 6 Aug 2020 13:36:02 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 076DZA6P029919 for ; Thu, 6 Aug 2020 09:35:10 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0ADD92156A4A; Thu, 6 Aug 2020 13:35:10 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05B3B2157F26 for ; Thu, 6 Aug 2020 13:35:07 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 785A78E69A2 for ; Thu, 6 Aug 2020 13:35:07 +0000 (UTC) Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-469-WMgXMPVONRSWCgMAqq5G6Q-1; Thu, 06 Aug 2020 09:35:04 -0400 Received: by mail-qk1-f194.google.com with SMTP id g26so44952564qka.3 for ; Thu, 06 Aug 2020 06:35:04 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:fd11:1a0d:8347:b5a1:341]) by smtp.gmail.com with ESMTPSA id g55sm4800285qta.94.2020.08.06.06.35.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 06:35:02 -0700 (PDT) X-MC-Unique: NCl6fJWCP_eCIP5jxA-Wzw-1 X-MC-Unique: WMgXMPVONRSWCgMAqq5G6Q-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WAq0GU5DS0K5llJ6d/+w3J2UpjLSToRbyNHeqa+WsFA=; b=TmZR8HKAnyYzWNg23iDtkWc1BXsGK6nSVhZcxuJkBAnwdo19m4RUYTNatR52ZV1ZlS lmvi/1HC3atgLajvI67Tq2cJDxboZifizP+i8mcWtahesrfWjhfpwzNBlSfmP2xorh/v u4dc3quwOq5/R1mqHm/5fa6KgxxbTObTWtoBLPST36ggbewLeBy5xlij7oEVP8Qodoiq ha2oXDCJ867SlOI8Z7UNjJ1UFg81uNkkbhMXCiL2+COZhgBKgZ3sDyX21HEljiWKe0UG oNNAO6/LB8HZWNaYCCvNUMrGDqLvMbm6RyHRSXDeZ7pZMU2JNXPfSaEcqsZFcrEjxGjg AC0Q== X-Gm-Message-State: AOAM530ZG/+Fxf3ov05iFFwSduPD1M3tERbPfsJ0AiKxpFfaijC2lajN 07AORXOHvYWh/DcohN26kkFw4WNhJJ0= X-Google-Smtp-Source: ABdhPJzSA6zEn6NaGYHiHdRKnPIb4UF8aZy0DBM5jqNaL5aEg+eAv9VkFeXksymkk/GtwVTL4wnTqA== X-Received: by 2002:a05:620a:68a:: with SMTP id f10mr8598938qkh.281.1596720903191; Thu, 06 Aug 2020 06:35:03 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 1/4] docs: get rid of 'make check' references Date: Thu, 6 Aug 2020 10:34:51 -0300 Message-Id: <20200806133454.1075044-2-danielhb413@gmail.com> In-Reply-To: <20200806133454.1075044-1-danielhb413@gmail.com> References: <20200806133454.1075044-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false; X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Update the remaining 'make check' references after the switch to meson/ninja. The reference in testsuites.html.in was kept with a note that it is the process for Libvirt 6.6.0 and older. Signed-off-by: Daniel Henrique Barboza --- docs/advanced-tests.rst | 2 +- docs/api_extension.html.in | 9 ++++----- docs/testsuites.html.in | 3 ++- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/advanced-tests.rst b/docs/advanced-tests.rst index bc20bbf4d9..458a9105b6 100644 --- a/docs/advanced-tests.rst +++ b/docs/advanced-tests.rst @@ -90,7 +90,7 @@ location where the file is stored. $ VIR_TEST_FILE_ACCESS=3D1 VIR_TEST_FILE_ACCESS_OUTPUT=3D"/tmp/file_acce= ss.txt" ./qemuxml2argvtest =20 #. The Valgrind test should produce similar output to -``make check``. If the output has traces within libvirt API's, +``ninja test``. If the output has traces within libvirt API's, then investigation is required in order to determine the cause of the issue. Output such as the following indicates some sort of leak: diff --git a/docs/api_extension.html.in b/docs/api_extension.html.in index 79e7913c1a..6c64e83314 100644 --- a/docs/api_extension.html.in +++ b/docs/api_extension.html.in @@ -361,11 +361,10 @@

=20

- Once you have working functionality, run make check and make - syntax-check on each patch of the series before submitting - patches. It may also be worth writing tests for the libvirt-TCK - testsuite to exercise your new API, although those patches are - not kept in the libvirt repository. + Once you have working functionality, run ninja test on each patch + of the series before submitting patches. It may also be worth + writing tests for the libvirt-TCK testsuite to exercise your new API, + although those patches are not kept in the libvirt repository.

diff --git a/docs/testsuites.html.in b/docs/testsuites.html.in index a619e6d000..cd9cad9160 100644 --- a/docs/testsuites.html.in +++ b/docs/testsuites.html.in @@ -10,7 +10,8 @@ by developers before submitting patches upstream, it is also suggested to have it run and pass as part of the packaging process for distributions. It is run by launching: - 
make check
+ 
make check (libvirt 6.6.0 and older)
+ 
ninja test (libvirt 6.7.0 and newer)
in a source tree after compilation has finished. It doesn't really make functional testing but checks that large portions of the code not interacting directly with virtualization --=20 2.26.2