From nobody Thu May 2 14:06:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1596547265; cv=none; d=zohomail.com; s=zohoarc; b=MIY/9WEJEa+YRVYBGjA5ipH1XAEdsjVF9slxRTFZG5e5G0IiXs4jG9HTU1/ryrYaOEcG8C23a3JVw13hfd4vqGmY4EWJsBgkY2QwYO8Q4RN6EaErBsZEoRmAt6/47EbTL0tDvUtdRl0JLZL6rrsNq0VsyOZL5my9yO1dvedW1Hg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1596547265; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=85na+H8McOhjk1g+310w+BPggeZIJ1YVa7iqi4xpyQY=; b=PIVwP3abD+/p87YROIJQDCqNCexkcjQF0223aVMKoE5hhLUqS/rMP47H0w+FVvvVXoMBbJ++sE9nhaDkL3GUiVjKogLBWeaKGX1B4JLtjo4DgxcQMQeyjQZ4NEUpnLcdGRnqNcsGdHV0/qc6HbJeR2TADIeORGEWkg+3Fh6KH8s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1596547265481143.9886807642049; Tue, 4 Aug 2020 06:21:05 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-166-DY8ARzRtNxC_RlHLX2hliA-1; Tue, 04 Aug 2020 09:21:01 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B53E8015F3; Tue, 4 Aug 2020 13:20:53 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8B84099005; Tue, 4 Aug 2020 13:20:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 833741809554; Tue, 4 Aug 2020 13:20:44 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 074DKha1032229 for ; Tue, 4 Aug 2020 09:20:43 -0400 Received: by smtp.corp.redhat.com (Postfix) id 67A47756AD; Tue, 4 Aug 2020 13:20:43 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.43]) by smtp.corp.redhat.com (Postfix) with ESMTP id 90DD270C37; Tue, 4 Aug 2020 13:20:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596547264; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=85na+H8McOhjk1g+310w+BPggeZIJ1YVa7iqi4xpyQY=; b=Kc657Gj64Hi71r9ZWFrr8RH6n2iDk9Ko0u/bSPRVd3mCJNPBBIYPmGgamx5LlnDZQN2w4C EDDbjmyRajJh1P6Iq2kN5SakipNjhYDJGj6FnEvxIItRmZXhV+jZULiG3GBCFXvugqXNoR 96Qw5NGDXGDUUFxsm9ffZKGSPKeZkDc= X-MC-Unique: DY8ARzRtNxC_RlHLX2hliA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH] build-aux: remove some syntax-check cruft Date: Tue, 4 Aug 2020 14:20:33 +0100 Message-Id: <20200804132033.4073300-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) sc_proper_name_utf8_requires_ICONV looks for Makefile.am files, so is not going to work correctly with meson. The 'today' variable is not referenced anywhere. The 'writable-files' target is not used anywhere sc_prohibit_reversed_compare_failure only checks 'init.sh' which does not exist in libvirt. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: J=C3=A1n Tomko --- build-aux/syntax-check.mk | 54 --------------------------------------- 1 file changed, 54 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 9256532ab3..6eb59cf90e 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -72,10 +72,6 @@ VC_LIST_EXCEPT =3D \ | $(GREP) -Ev -e '($(VC_LIST_ALWAYS_EXCLUDE_REGEX)|$(_sc_excl))' \ $(_prepend_srcdir_prefix) =20 -# Override this in syntax-check.mk if you are using a different format in = your -# NEWS file. -today =3D $(shell date +%Y-%m-%d) - # Prevent programs like 'sort' from considering distinct strings to be equ= al. # Doing it here saves us from having to set LC_ALL elsewhere in this file. export LC_ALL =3D C @@ -1744,29 +1740,6 @@ sc_prohibit_test_double_equal: halt=3D'use "test x =3D x", not "test x =3D''=3D x"' \ $(_sc_search_regexp) =20 -# Each program that uses proper_name_utf8 must link with one of the -# ICONV libraries. Otherwise, some ICONV library must appear in LDADD. -# The perl -0777 invocation below extracts the possibly-multi-line -# definition of LDADD from the appropriate Makefile.am and exits 0 -# when it contains "ICONV". -sc_proper_name_utf8_requires_ICONV: - @progs=3D$$($(VC_LIST_EXCEPT) \ - | xargs $(GREP) -l 'proper_name_utf8 ''("'); \ - if test "x$$progs" !=3D x; then \ - fail=3D0; \ - for p in $$progs; do \ - dir=3D$$(dirname "$$p"); \ - perl -0777 \ - -ne 'exit !(/^LDADD =3D(.+?[^\\]\n)/ms && $$1 =3D~ /ICONV/)' \ - $$dir/Makefile.am && continue; \ - base=3D$$(basename "$$p" .c); \ - $(GREP) "$${base}_LDADD.*ICONV)" $$dir/Makefile.am > /dev/null \ - || { fail=3D1; echo 1>&2 "$(ME): $$p uses proper_name_utf8"; }; \ - done; \ - test $$fail =3D 1 && \ - { echo 1>&2 '$(ME): the above do not link with any ICONV library'; \ - exit 1; } || :; \ - fi =20 # Warn about "c0nst struct Foo const foo[]", # but not about "char const *const foo" or "#define const const". @@ -1828,33 +1801,6 @@ sc_po_check: rm -f $@-1 $@-2; \ fi =20 -# Check that 'make alpha' will not fail at the end of the process, -# i.e., when pkg-M.N.tar.xz already exists (either in "." or in ../release) -# and is read-only. -writable-files: - $(AM_V_GEN)if test -d $(release_archive_dir); then \ - for file in $(DIST_ARCHIVES); do \ - for p in ./ $(release_archive_dir)/; do \ - test -e $$p$$file || continue; \ - test -w $$p$$file \ - || { echo ERROR: $$p$$file is not writable; fail=3D1; }; \ - done; \ - done; \ - test "$$fail" && exit 1 || : ; \ - else :; \ - fi - - -# BRE regex of file contents to identify a test script. -_test_script_regex ?=3D \ - -# In tests, use "compare expected actual", not the reverse. -sc_prohibit_reversed_compare_failure: - @prohibit=3D'\