[libvirt PATCH 0/2] util: avoid race in glib event loop which causes crashes

Daniel P. Berrangé posted 2 patches 1 week ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200729161017.2714210-1-berrange@redhat.com
src/rpc/virnetclient.c       | 27 ++++++-----
src/util/vireventglib.c      | 91 +++++++++++++++++++++++++-----------
src/util/vireventglibwatch.c | 19 ++++----
src/util/vireventglibwatch.h | 13 +++---
4 files changed, 97 insertions(+), 53 deletions(-)

[libvirt PATCH 0/2] util: avoid race in glib event loop which causes crashes

Posted by Daniel P. Berrangé 1 week ago
A while ago Cole reported that libvirt is exposing a long
term bug in GLib's event loop that results in non-deterministic
crashes:

  https://www.redhat.com/archives/libvir-list/2020-February/msg00422.html

I kept forgetting to investigate it until now.

Daniel P. Berrangé (2):
  util: keep track of full GSource object not source ID number
  util: avoid crash due to race in glib event loop code

 src/rpc/virnetclient.c       | 27 ++++++-----
 src/util/vireventglib.c      | 91 +++++++++++++++++++++++++-----------
 src/util/vireventglibwatch.c | 19 ++++----
 src/util/vireventglibwatch.h | 13 +++---
 4 files changed, 97 insertions(+), 53 deletions(-)

-- 
2.24.1

Re: [libvirt PATCH 0/2] util: avoid race in glib event loop which causes crashes

Posted by Michal Privoznik 1 week ago
On 7/29/20 6:10 PM, Daniel P. Berrangé wrote:
> A while ago Cole reported that libvirt is exposing a long
> term bug in GLib's event loop that results in non-deterministic
> crashes:
> 
>    https://www.redhat.com/archives/libvir-list/2020-February/msg00422.html
> 
> I kept forgetting to investigate it until now.
> 
> Daniel P. Berrangé (2):
>    util: keep track of full GSource object not source ID number
>    util: avoid crash due to race in glib event loop code
> 
>   src/rpc/virnetclient.c       | 27 ++++++-----
>   src/util/vireventglib.c      | 91 +++++++++++++++++++++++++-----------
>   src/util/vireventglibwatch.c | 19 ++++----
>   src/util/vireventglibwatch.h | 13 +++---
>   4 files changed, 97 insertions(+), 53 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

Michal