[libvirt PATCH] ci: Run 'make distcheck' on FreeBSD

Andrea Bolognani posted 1 patch 3 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200723092231.42335-1-abologna@redhat.com
ci/cirrus/build.yml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

[libvirt PATCH] ci: Run 'make distcheck' on FreeBSD

Posted by Andrea Bolognani 3 weeks ago
The Cirrus CI integration was modeled after the Travis CI jobs,
but those were limited to macOS where the test suite is currently
still broken. FreeBSD can run the full distcheck just fine, so
let's do that.

Fixes: 6190c14151c3e2cf5c30b9df9131697f5c3b64b9
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
---
Test pipeline:

  https://gitlab.com/abologna/libvirt/-/pipelines/169877021

 ci/cirrus/build.yml | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/ci/cirrus/build.yml b/ci/cirrus/build.yml
index 893e13d724..b7524021b4 100644
--- a/ci/cirrus/build.yml
+++ b/ci/cirrus/build.yml
@@ -21,6 +21,5 @@ build_task:
     - mkdir build
     - cd build
     - ../autogen.sh --prefix=$(pwd)/install-root
-    - $MAKE -j3
-    - $MAKE -j3 install
-    - $MAKE -j3 dist
+    - if test "$(uname)" = "FreeBSD"; then $MAKE -j3 distcheck; fi
+    - if test "$(uname)" = "Darwin"; then $MAKE -j3 && $MAKE -j3 install && $MAKE -j3 dist; fi
-- 
2.25.4

Re: [libvirt PATCH] ci: Run 'make distcheck' on FreeBSD

Posted by Ján Tomko 3 weeks ago
On a Thursday in 2020, Andrea Bolognani wrote:
>The Cirrus CI integration was modeled after the Travis CI jobs,
>but those were limited to macOS where the test suite is currently
>still broken. FreeBSD can run the full distcheck just fine, so
>let's do that.
>
>Fixes: 6190c14151c3e2cf5c30b9df9131697f5c3b64b9
>Signed-off-by: Andrea Bolognani <abologna@redhat.com>
>---
>Test pipeline:
>
>  https://gitlab.com/abologna/libvirt/-/pipelines/169877021
>
> ci/cirrus/build.yml | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko@redhat.com>

Thanks for fixing this.

Jano