From nobody Sun Feb 8 05:40:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1595439022; cv=none; d=zohomail.com; s=zohoarc; b=inPLlZTrh7QYHy+HNtWQft0a2pHPC9mQRdEWUbbd7P4V5BV0lRE9E8aHObKSt3+nEou/RbFEV6+Nxn8mLwjonW/9uGEyONLUURmyWQOyfc3iDpnb34WuREBnYN2nJJIzNemy7V1z2pPU947JK5QcxD3aOtmrU+KHPrKskRNbgyU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1595439022; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ivcM8f9pN0SkhbvUUyl0YEA3uL3N8mKrfFFMSmecblk=; b=GjrkoId0fD1YMqtEGh01Q8GYcahqAOeGbN0s61xmCb3DnCCYSB0arQMFWEgD+BN62QRr0YD4X4H1x9EkGsy0pbUkuqFQlLctq+F5sN3jCbd6oUQRPOo7BIY2/IoXueeysQ8NIb2122mei9ppBmxD0lt5rjMGaSUQlLdD9h3wH3Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1595439022309856.7745073819955; Wed, 22 Jul 2020 10:30:22 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-514-lxxAJMGFMoe-t9xOPtJuNQ-1; Wed, 22 Jul 2020 13:30:18 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 93686185BDEA; Wed, 22 Jul 2020 17:30:12 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 732C188D41; Wed, 22 Jul 2020 17:30:12 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3D73D730FF; Wed, 22 Jul 2020 17:30:12 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 06MHLqKX028423 for ; Wed, 22 Jul 2020 13:21:52 -0400 Received: by smtp.corp.redhat.com (Postfix) id AC58C1017CD3; Wed, 22 Jul 2020 17:21:52 +0000 (UTC) Received: from domokun.gsslab.fab.redhat.com (unknown [10.33.8.110]) by smtp.corp.redhat.com (Postfix) with ESMTP id 19E4A1010403; Wed, 22 Jul 2020 17:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595439021; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ivcM8f9pN0SkhbvUUyl0YEA3uL3N8mKrfFFMSmecblk=; b=QP8/6/FyGuMoI8BVdWaXTzrZIrjeBiSTH7oYdwMCeSv9V0g6C9ZYap9hRfBtl9vyPlMIEe glVXyDIPN3ozdvbFptIrKvZVgq43jjJMMLej2ab5OoWlEWD9SE6jj17Op7u6tyHuxaQQkl t2v8R+XPCMcoeXV01dNrse/X2fvyX6c= X-MC-Unique: lxxAJMGFMoe-t9xOPtJuNQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH 4/4] tools: be more paranoid about possibly NULL description Date: Wed, 22 Jul 2020 18:21:42 +0100 Message-Id: <20200722172142.1847640-5-berrange@redhat.com> In-Reply-To: <20200722172142.1847640-1-berrange@redhat.com> References: <20200722172142.1847640-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) GCC 10 complains about "desc" possibly being a NULL dereference. Even though it is a false positive, we can easily avoid it. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Laine Stump Reviewed-by: Michal Privoznik --- tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index 527c135424..b65e99cbd2 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -689,7 +689,7 @@ vshCmddefHelp(vshControl *ctl, const vshCmdDef *def) fputc('\n', stdout); =20 desc =3D vshCmddefGetInfo(def, "desc"); - if (*desc) { + if (desc && *desc) { /* Print the description only if it's not empty. */ fputs(_("\n DESCRIPTION\n"), stdout); fprintf(stdout, " %s\n", _(desc)); --=20 2.24.1