From nobody Sat Feb 7 15:15:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1594663467; cv=none; d=zohomail.com; s=zohoarc; b=lcuOgfWSRFyKK8BlUPmJmausYMMwgw4dyaXJNWHsbEZVymP/C4dVxIvhjO9mb6ezEuwVJSp/cdxHur/5GK51nNdhNdPQGTKwkPAKLuC30V7LsuYrwKtrtf2gDBUyAAC+X6NLI2QVxA1MVNhlcSBBpo5jTCav1qeHRE1mePrRoAc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594663467; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=r7hrXqhbspxCl/Aro1gFoH8gqp+RaMSK/IzcI6O9eag=; b=Hc5iqWwEi83DGehGR6Ra0lGsYMDKQlrWCxC+QF51/o/GXFf1TyXnx4gKav7C39nBCa+xoNuwR60PVyS14kS2KU2rfZrjDufp3dQKnrJrPzXmcpb4ahBIvQQyxdudCs/7Y8CtleD4cxRQitsPGVSoVmSrlW17qXnBP9z7pJqa73w= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1594663467763158.43431341478663; Mon, 13 Jul 2020 11:04:27 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-20-PQZPuq_dPT2HCjhQs7meTw-1; Mon, 13 Jul 2020 14:04:23 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 75DFF18C63D2; Mon, 13 Jul 2020 18:04:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 50FC0797E8; Mon, 13 Jul 2020 18:04:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EA5321800B72; Mon, 13 Jul 2020 18:04:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 06DI426O007703 for ; Mon, 13 Jul 2020 14:04:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7255E2166BA4; Mon, 13 Jul 2020 18:04:02 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 38E372157F26 for ; Mon, 13 Jul 2020 18:04:02 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1A328100E7C6 for ; Mon, 13 Jul 2020 18:04:02 +0000 (UTC) Received: from mail-pj1-f66.google.com (mail-pj1-f66.google.com [209.85.216.66]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-Qa6csQujPvOecwS1L-xiFg-1; Mon, 13 Jul 2020 14:03:59 -0400 Received: by mail-pj1-f66.google.com with SMTP id f16so227352pjt.0 for ; Mon, 13 Jul 2020 11:03:59 -0700 (PDT) Received: from localhost.localdomain ([116.72.84.11]) by smtp.gmail.com with ESMTPSA id q11sm238552pjj.17.2020.07.13.11.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jul 2020 11:03:57 -0700 (PDT) X-MC-Unique: PQZPuq_dPT2HCjhQs7meTw-1 X-MC-Unique: Qa6csQujPvOecwS1L-xiFg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=r7hrXqhbspxCl/Aro1gFoH8gqp+RaMSK/IzcI6O9eag=; b=ANKUxKcS0DR3GNg8Tv47N9AsJv4NdHJ1pf1eBi+HdERQErT8j5MG/vpHQKu00Bjm8f FF2C66Oxg2BkzJC3mz28FxQzKwejbTwEGWq60v+x7Hd9oYKRwGnjZisc2KoioAVEc/+2 mIyfBvd0KQ9/X+dRM7sM7e7Cyym1t1JYIwTHPHR+USevqIGlAd0M559iQ9ZjHGVGCW8h QaC27/Ae44fA0R4B+DIzijCWU31reZHse/itH4PWpiQYwOS8z4aX+xRZgM+tPQEzJf4V mfEdoxKS3pQZ9SN5j676JIpQ16KvAv2/1sCLP8cWT8q+Gpbd45NGgO7q5qMDlI5EYPET G5fQ== X-Gm-Message-State: AOAM530pGvS60giz3y34RQQWs+Z88nqwpgbo3+fvdNtmzL8j7utDY+f7 KJnALh+BIMfBhBGKZrFrM5gRDJyy9jo= X-Google-Smtp-Source: ABdhPJyKFxQGEKP4KStTlhViF7cse7pV1J2LPaoI/0GIMdqsBAzy53D536EHcDuQSb9j33AE4EEPcQ== X-Received: by 2002:a17:90a:6acb:: with SMTP id b11mr573046pjm.71.1594663437805; Mon, 13 Jul 2020 11:03:57 -0700 (PDT) From: Prathamesh Chavan To: libvir-list@redhat.com Subject: [GSoC][PATCH v4 4/4] qemu_domainjob: introduce `privateData` for `qemuDomainJobInfo` Date: Mon, 13 Jul 2020 23:33:41 +0530 Message-Id: <20200713180341.173183-5-pc44800@gmail.com> In-Reply-To: <20200713180341.173183-1-pc44800@gmail.com> References: <20200713180341.173183-1-pc44800@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Prathamesh Chavan X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To remove dependecy of `qemuDomainJobInfo` on job specific paramters, a `privateData` pointer is introduced. To handle it, structure of callback functions is also introduced. Signed-off-by: Prathamesh Chavan --- src/qemu/qemu_backup.c | 15 +++-- src/qemu/qemu_domain.h | 18 ++++++ src/qemu/qemu_domainjob.c | 98 +++++++++++++++++++++++++------- src/qemu/qemu_domainjob.h | 31 +++++----- src/qemu/qemu_driver.c | 18 +++--- src/qemu/qemu_migration.c | 14 +++-- src/qemu/qemu_migration_cookie.c | 7 ++- src/qemu/qemu_process.c | 11 +++- 8 files changed, 154 insertions(+), 58 deletions(-) diff --git a/src/qemu/qemu_backup.c b/src/qemu/qemu_backup.c index b711f8f623..a0832b4587 100644 --- a/src/qemu/qemu_backup.c +++ b/src/qemu/qemu_backup.c @@ -529,6 +529,7 @@ qemuBackupJobTerminate(virDomainObjPtr vm, =20 { qemuDomainObjPrivatePtr priv =3D vm->privateData; + qemuDomainJobInfoPrivatePtr jobInfoPriv; size_t i; =20 qemuDomainJobInfoUpdateTime(priv->job.current); @@ -536,10 +537,13 @@ qemuBackupJobTerminate(virDomainObjPtr vm, g_clear_pointer(&priv->job.completed, qemuDomainJobInfoFree); priv->job.completed =3D qemuDomainJobInfoCopy(priv->job.current); =20 - priv->job.completed->stats.backup.total =3D priv->backup->push_total; - priv->job.completed->stats.backup.transferred =3D priv->backup->push_t= ransferred; - priv->job.completed->stats.backup.tmp_used =3D priv->backup->pull_tmp_= used; - priv->job.completed->stats.backup.tmp_total =3D priv->backup->pull_tmp= _total; + + jobInfoPriv =3D priv->job.completed->privateData; + + jobInfoPriv->stats.backup.total =3D priv->backup->push_total; + jobInfoPriv->stats.backup.transferred =3D priv->backup->push_transferr= ed; + jobInfoPriv->stats.backup.tmp_used =3D priv->backup->pull_tmp_used; + jobInfoPriv->stats.backup.tmp_total =3D priv->backup->pull_tmp_total; =20 priv->job.completed->status =3D jobstatus; priv->job.completed->errmsg =3D g_strdup(priv->backup->errmsg); @@ -1069,7 +1073,8 @@ qemuBackupGetJobInfoStats(virQEMUDriverPtr driver, virDomainObjPtr vm, qemuDomainJobInfoPtr jobInfo) { - qemuDomainBackupStats *stats =3D &jobInfo->stats.backup; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; + qemuDomainBackupStats *stats =3D &jobInfoPriv->stats.backup; qemuDomainObjPrivatePtr priv =3D vm->privateData; qemuMonitorJobInfoPtr *blockjobs =3D NULL; size_t nblockjobs =3D 0; diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index bb9b414a46..7fcbefd0c0 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -502,6 +502,24 @@ struct _qemuDomainJobPrivate { qemuMigrationParamsPtr migParams; }; =20 +typedef struct _qemuDomainBackupStats qemuDomainBackupStats; +struct _qemuDomainBackupStats { + unsigned long long transferred; + unsigned long long total; + unsigned long long tmp_used; + unsigned long long tmp_total; +}; + +typedef struct _qemuDomainJobInfoPrivate qemuDomainJobInfoPrivate; +typedef qemuDomainJobInfoPrivate *qemuDomainJobInfoPrivatePtr; +struct _qemuDomainJobInfoPrivate { + union { + qemuMonitorMigrationStats mig; + qemuMonitorDumpStats dump; + qemuDomainBackupStats backup; + } stats; +}; + int qemuDomainObjStartWorker(virDomainObjPtr dom); void qemuDomainObjStopWorker(virDomainObjPtr dom); =20 diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c index fe160afe79..bb086db2b7 100644 --- a/src/qemu/qemu_domainjob.c +++ b/src/qemu/qemu_domainjob.c @@ -63,6 +63,7 @@ VIR_ENUM_IMPL(qemuDomainAsyncJob, "backup", ); =20 + const char * qemuDomainAsyncJobPhaseToString(qemuDomainAsyncJob job, int phase G_GNUC_UNUSED) @@ -115,27 +116,78 @@ qemuDomainAsyncJobPhaseFromString(qemuDomainAsyncJob = job, return -1; } =20 +static void +qemuJobInfoFreePrivateData(qemuDomainJobInfoPrivatePtr priv) +{ + g_free(&priv->stats); +} + +static void +qemuJobInfoFreePrivate(void *opaque) +{ + qemuDomainJobInfoPtr jobInfo =3D (qemuDomainJobInfoPtr) opaque; + qemuJobInfoFreePrivateData(jobInfo->privateData); +} =20 void qemuDomainJobInfoFree(qemuDomainJobInfoPtr info) { + info->cb->freeJobInfoPrivate(info); g_free(info->errmsg); g_free(info); } =20 +static void * +qemuDomainJobInfoPrivateAlloc(void) +{ + qemuDomainJobInfoPrivatePtr retPriv =3D g_new0(qemuDomainJobInfoPrivat= e, 1); + return (void *)retPriv; +} + +static void +qemuDomainJobInfoPrivateCopy(qemuDomainJobInfoPtr src, + qemuDomainJobInfoPtr dest) +{ + memcpy(dest->privateData, src->privateData, + sizeof(qemuDomainJobInfoPrivate)); +} + +static qemuDomainJobInfoPtr +qemuDomainJobInfoAlloc(qemuDomainObjPrivateJobInfoCallbacksPtr cb) +{ + qemuDomainJobInfoPtr ret =3D g_new0(qemuDomainJobInfo, 1); + ret->cb =3D cb; + ret->privateData =3D ret->cb->allocJobInfoPrivate(); + return ret; +} + +static void +qemuDomainCurrentJobInfoInit(qemuDomainJobObjPtr job, + qemuDomainObjPrivateJobInfoCallbacksPtr cb) +{ + job->current =3D qemuDomainJobInfoAlloc(cb); + job->current->status =3D QEMU_DOMAIN_JOB_STATUS_ACTIVE; +} =20 qemuDomainJobInfoPtr qemuDomainJobInfoCopy(qemuDomainJobInfoPtr info) { - qemuDomainJobInfoPtr ret =3D g_new0(qemuDomainJobInfo, 1); + qemuDomainJobInfoPtr ret =3D qemuDomainJobInfoAlloc(info->cb); =20 memcpy(ret, info, sizeof(*info)); =20 + ret->cb->copyJobInfoPrivate(info, ret); ret->errmsg =3D g_strdup(info->errmsg); =20 return ret; } =20 +static qemuDomainObjPrivateJobInfoCallbacks qemuJobInfoPrivateCallbacks = =3D { + .allocJobInfoPrivate =3D &qemuDomainJobInfoPrivateAlloc, + .freeJobInfoPrivate =3D &qemuJobInfoFreePrivate, + .copyJobInfoPrivate =3D &qemuDomainJobInfoPrivateCopy, +}; + void qemuDomainEventEmitJobCompleted(virQEMUDriverPtr driver, virDomainObjPtr vm) @@ -285,6 +337,7 @@ int qemuDomainJobInfoUpdateDowntime(qemuDomainJobInfoPtr jobInfo) { unsigned long long now; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; =20 if (!jobInfo->stopped) return 0; @@ -298,8 +351,8 @@ qemuDomainJobInfoUpdateDowntime(qemuDomainJobInfoPtr jo= bInfo) return 0; } =20 - jobInfo->stats.mig.downtime =3D now - jobInfo->stopped; - jobInfo->stats.mig.downtime_set =3D true; + jobInfoPriv->stats.mig.downtime =3D now - jobInfo->stopped; + jobInfoPriv->stats.mig.downtime_set =3D true; return 0; } =20 @@ -334,38 +387,39 @@ int qemuDomainJobInfoToInfo(qemuDomainJobInfoPtr jobInfo, virDomainJobInfoPtr info) { + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; info->type =3D qemuDomainJobStatusToType(jobInfo->status); info->timeElapsed =3D jobInfo->timeElapsed; =20 switch (jobInfo->statsType) { case QEMU_DOMAIN_JOB_STATS_TYPE_MIGRATION: - info->memTotal =3D jobInfo->stats.mig.ram_total; - info->memRemaining =3D jobInfo->stats.mig.ram_remaining; - info->memProcessed =3D jobInfo->stats.mig.ram_transferred; - info->fileTotal =3D jobInfo->stats.mig.disk_total + + info->memTotal =3D jobInfoPriv->stats.mig.ram_total; + info->memRemaining =3D jobInfoPriv->stats.mig.ram_remaining; + info->memProcessed =3D jobInfoPriv->stats.mig.ram_transferred; + info->fileTotal =3D jobInfoPriv->stats.mig.disk_total + jobInfo->mirrorStats.total; - info->fileRemaining =3D jobInfo->stats.mig.disk_remaining + + info->fileRemaining =3D jobInfoPriv->stats.mig.disk_remaining + (jobInfo->mirrorStats.total - jobInfo->mirrorStats.transferred); - info->fileProcessed =3D jobInfo->stats.mig.disk_transferred + + info->fileProcessed =3D jobInfoPriv->stats.mig.disk_transferred + jobInfo->mirrorStats.transferred; break; =20 case QEMU_DOMAIN_JOB_STATS_TYPE_SAVEDUMP: - info->memTotal =3D jobInfo->stats.mig.ram_total; - info->memRemaining =3D jobInfo->stats.mig.ram_remaining; - info->memProcessed =3D jobInfo->stats.mig.ram_transferred; + info->memTotal =3D jobInfoPriv->stats.mig.ram_total; + info->memRemaining =3D jobInfoPriv->stats.mig.ram_remaining; + info->memProcessed =3D jobInfoPriv->stats.mig.ram_transferred; break; =20 case QEMU_DOMAIN_JOB_STATS_TYPE_MEMDUMP: - info->memTotal =3D jobInfo->stats.dump.total; - info->memProcessed =3D jobInfo->stats.dump.completed; + info->memTotal =3D jobInfoPriv->stats.dump.total; + info->memProcessed =3D jobInfoPriv->stats.dump.completed; info->memRemaining =3D info->memTotal - info->memProcessed; break; =20 case QEMU_DOMAIN_JOB_STATS_TYPE_BACKUP: - info->fileTotal =3D jobInfo->stats.backup.total; - info->fileProcessed =3D jobInfo->stats.backup.transferred; + info->fileTotal =3D jobInfoPriv->stats.backup.total; + info->fileProcessed =3D jobInfoPriv->stats.backup.transferred; info->fileRemaining =3D info->fileTotal - info->fileProcessed; break; =20 @@ -387,7 +441,8 @@ qemuDomainMigrationJobInfoToParams(qemuDomainJobInfoPtr= jobInfo, virTypedParameterPtr *params, int *nparams) { - qemuMonitorMigrationStats *stats =3D &jobInfo->stats.mig; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; + qemuMonitorMigrationStats *stats =3D &jobInfoPriv->stats.mig; qemuDomainMirrorStatsPtr mirrorStats =3D &jobInfo->mirrorStats; virTypedParameterPtr par =3D NULL; int maxpar =3D 0; @@ -564,7 +619,8 @@ qemuDomainDumpJobInfoToParams(qemuDomainJobInfoPtr jobI= nfo, virTypedParameterPtr *params, int *nparams) { - qemuMonitorDumpStats *stats =3D &jobInfo->stats.dump; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; + qemuMonitorDumpStats *stats =3D &jobInfoPriv->stats.dump; virTypedParameterPtr par =3D NULL; int maxpar =3D 0; int npar =3D 0; @@ -607,7 +663,8 @@ qemuDomainBackupJobInfoToParams(qemuDomainJobInfoPtr jo= bInfo, virTypedParameterPtr *params, int *nparams) { - qemuDomainBackupStats *stats =3D &jobInfo->stats.backup; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; + qemuDomainBackupStats *stats =3D &jobInfoPriv->stats.backup; g_autoptr(virTypedParamList) par =3D g_new0(virTypedParamList, 1); =20 if (virTypedParamListAddInt(par, jobInfo->operation, @@ -890,8 +947,7 @@ qemuDomainObjBeginJobInternal(virQEMUDriverPtr driver, qemuDomainAsyncJobTypeToString(asyncJob), obj, obj->def->name); qemuDomainObjResetAsyncJob(&priv->job); - priv->job.current =3D g_new0(qemuDomainJobInfo, 1); - priv->job.current->status =3D QEMU_DOMAIN_JOB_STATUS_ACTIVE; + qemuDomainCurrentJobInfoInit(&priv->job, &qemuJobInfoPrivateCa= llbacks); priv->job.asyncJob =3D asyncJob; priv->job.asyncOwner =3D virThreadSelfID(); priv->job.asyncOwnerAPI =3D virThreadJobGet(); diff --git a/src/qemu/qemu_domainjob.h b/src/qemu/qemu_domainjob.h index b0e840adc8..3c55cf29ed 100644 --- a/src/qemu/qemu_domainjob.h +++ b/src/qemu/qemu_domainjob.h @@ -107,16 +107,22 @@ struct _qemuDomainMirrorStats { unsigned long long total; }; =20 -typedef struct _qemuDomainBackupStats qemuDomainBackupStats; -struct _qemuDomainBackupStats { - unsigned long long transferred; - unsigned long long total; - unsigned long long tmp_used; - unsigned long long tmp_total; -}; - typedef struct _qemuDomainJobInfo qemuDomainJobInfo; typedef qemuDomainJobInfo *qemuDomainJobInfoPtr; + +typedef void *(*qemuDomainObjJobInfoPrivateAlloc)(void); +typedef void (*qemuDomainObjJobInfoPrivateFree)(void *); +typedef void (*qemuDomainObjJobInfoPrivateCopy)(qemuDomainJobInfoPtr, + qemuDomainJobInfoPtr); + +typedef struct _qemuDomainObjPrivateJobInfoCallbacks qemuDomainObjPrivateJ= obInfoCallbacks; +typedef qemuDomainObjPrivateJobInfoCallbacks *qemuDomainObjPrivateJobInfoC= allbacksPtr; +struct _qemuDomainObjPrivateJobInfoCallbacks { + qemuDomainObjJobInfoPrivateAlloc allocJobInfoPrivate; + qemuDomainObjJobInfoPrivateFree freeJobInfoPrivate; + qemuDomainObjJobInfoPrivateCopy copyJobInfoPrivate; +}; + struct _qemuDomainJobInfo { qemuDomainJobStatus status; virDomainJobOperation operation; @@ -136,14 +142,11 @@ struct _qemuDomainJobInfo { bool timeDeltaSet; /* Raw values from QEMU */ qemuDomainJobStatsType statsType; - union { - qemuMonitorMigrationStats mig; - qemuMonitorDumpStats dump; - qemuDomainBackupStats backup; - } stats; qemuDomainMirrorStats mirrorStats; - char *errmsg; /* optional error message for failed completed jobs */ + + void *privateData; /* job specific collection of info */ + qemuDomainObjPrivateJobInfoCallbacksPtr cb; }; =20 void diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index d9c5f21f21..058e15e864 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3702,6 +3702,7 @@ qemuDumpWaitForCompletion(virDomainObjPtr vm) { qemuDomainObjPrivatePtr priv =3D vm->privateData; qemuDomainJobPrivatePtr jobPriv =3D priv->job.privateData; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D priv->job.current->private= Data; =20 VIR_DEBUG("Waiting for dump completion"); while (!jobPriv->dumpCompleted && !priv->job.abortJob) { @@ -3709,7 +3710,7 @@ qemuDumpWaitForCompletion(virDomainObjPtr vm) return -1; } =20 - if (priv->job.current->stats.dump.status =3D=3D QEMU_MONITOR_DUMP_STAT= US_FAILED) { + if (jobInfoPriv->stats.dump.status =3D=3D QEMU_MONITOR_DUMP_STATUS_FAI= LED) { if (priv->job.error) virReportError(VIR_ERR_OPERATION_FAILED, _("memory-only dump failed: %s"), @@ -13527,6 +13528,7 @@ qemuDomainGetJobInfoDumpStats(virQEMUDriverPtr driv= er, { qemuDomainObjPrivatePtr priv =3D vm->privateData; qemuMonitorDumpStats stats =3D { 0 }; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; int rc; =20 if (qemuDomainObjEnterMonitorAsync(driver, vm, QEMU_ASYNC_JOB_NONE) < = 0) @@ -13537,33 +13539,33 @@ qemuDomainGetJobInfoDumpStats(virQEMUDriverPtr dr= iver, if (qemuDomainObjExitMonitor(driver, vm) < 0 || rc < 0) return -1; =20 - jobInfo->stats.dump =3D stats; + jobInfoPriv->stats.dump =3D stats; =20 if (qemuDomainJobInfoUpdateTime(jobInfo) < 0) return -1; =20 - switch (jobInfo->stats.dump.status) { + switch (jobInfoPriv->stats.dump.status) { case QEMU_MONITOR_DUMP_STATUS_NONE: case QEMU_MONITOR_DUMP_STATUS_FAILED: case QEMU_MONITOR_DUMP_STATUS_LAST: virReportError(VIR_ERR_OPERATION_FAILED, _("dump query failed, status=3D%d"), - jobInfo->stats.dump.status); + jobInfoPriv->stats.dump.status); return -1; break; =20 case QEMU_MONITOR_DUMP_STATUS_ACTIVE: jobInfo->status =3D QEMU_DOMAIN_JOB_STATUS_ACTIVE; VIR_DEBUG("dump active, bytes written=3D'%llu' remaining=3D'%llu'", - jobInfo->stats.dump.completed, - jobInfo->stats.dump.total - - jobInfo->stats.dump.completed); + jobInfoPriv->stats.dump.completed, + jobInfoPriv->stats.dump.total - + jobInfoPriv->stats.dump.completed); break; =20 case QEMU_MONITOR_DUMP_STATUS_COMPLETED: jobInfo->status =3D QEMU_DOMAIN_JOB_STATUS_COMPLETED; VIR_DEBUG("dump completed, bytes written=3D'%llu'", - jobInfo->stats.dump.completed); + jobInfoPriv->stats.dump.completed); break; } =20 diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 2c7bf349c3..0c4136ef8a 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -1439,7 +1439,8 @@ qemuMigrationSrcWaitForSpice(virDomainObjPtr vm) static void qemuMigrationUpdateJobType(qemuDomainJobInfoPtr jobInfo) { - switch ((qemuMonitorMigrationStatus) jobInfo->stats.mig.status) { + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; + switch ((qemuMonitorMigrationStatus) jobInfoPriv->stats.mig.status) { case QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY: jobInfo->status =3D QEMU_DOMAIN_JOB_STATUS_POSTCOPY; break; @@ -1486,6 +1487,7 @@ qemuMigrationAnyFetchStats(virQEMUDriverPtr driver, char **error) { qemuDomainObjPrivatePtr priv =3D vm->privateData; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; qemuMonitorMigrationStats stats; int rv; =20 @@ -1497,7 +1499,7 @@ qemuMigrationAnyFetchStats(virQEMUDriverPtr driver, if (qemuDomainObjExitMonitor(driver, vm) < 0 || rv < 0) return -1; =20 - jobInfo->stats.mig =3D stats; + jobInfoPriv->stats.mig =3D stats; =20 return 0; } @@ -1539,12 +1541,13 @@ qemuMigrationJobCheckStatus(virQEMUDriverPtr driver, { qemuDomainObjPrivatePtr priv =3D vm->privateData; qemuDomainJobInfoPtr jobInfo =3D priv->job.current; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; char *error =3D NULL; bool events =3D virQEMUCapsGet(priv->qemuCaps, QEMU_CAPS_MIGRATION_EVE= NT); int ret =3D -1; =20 if (!events || - jobInfo->stats.mig.status =3D=3D QEMU_MONITOR_MIGRATION_STATUS_ERR= OR) { + jobInfoPriv->stats.mig.status =3D=3D QEMU_MONITOR_MIGRATION_STATUS= _ERROR) { if (qemuMigrationAnyFetchStats(driver, vm, asyncJob, jobInfo, &err= or) < 0) return -1; } @@ -3013,6 +3016,7 @@ qemuMigrationSrcConfirmPhase(virQEMUDriverPtr driver, /* Update times with the values sent by the destination daemon */ if (mig->jobInfo && jobInfo) { int reason; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D mig->jobInfo->privateD= ata; =20 /* We need to refresh migration statistics after a completed post-= copy * migration since priv->job.completed contains obsolete data from= the @@ -3027,8 +3031,8 @@ qemuMigrationSrcConfirmPhase(virQEMUDriverPtr driver, qemuDomainJobInfoUpdateTime(jobInfo); jobInfo->timeDeltaSet =3D mig->jobInfo->timeDeltaSet; jobInfo->timeDelta =3D mig->jobInfo->timeDelta; - jobInfo->stats.mig.downtime_set =3D mig->jobInfo->stats.mig.downti= me_set; - jobInfo->stats.mig.downtime =3D mig->jobInfo->stats.mig.downtime; + jobInfoPriv->stats.mig.downtime_set =3D jobInfoPriv->stats.mig.dow= ntime_set; + jobInfoPriv->stats.mig.downtime =3D jobInfoPriv->stats.mig.downtim= e; } =20 if (flags & VIR_MIGRATE_OFFLINE) diff --git a/src/qemu/qemu_migration_cookie.c b/src/qemu/qemu_migration_coo= kie.c index 81b557e0a8..a3e3ff95e8 100644 --- a/src/qemu/qemu_migration_cookie.c +++ b/src/qemu/qemu_migration_cookie.c @@ -641,7 +641,8 @@ static void qemuMigrationCookieStatisticsXMLFormat(virBufferPtr buf, qemuDomainJobInfoPtr jobInfo) { - qemuMonitorMigrationStats *stats =3D &jobInfo->stats.mig; + qemuDomainJobInfoPrivatePtr jobInfoPriv =3D jobInfo->privateData; + qemuMonitorMigrationStats *stats =3D &jobInfoPriv->stats.mig; =20 virBufferAddLit(buf, "\n"); virBufferAdjustIndent(buf, 2); @@ -1043,14 +1044,16 @@ qemuMigrationCookieStatisticsXMLParse(xmlXPathConte= xtPtr ctxt) { qemuDomainJobInfoPtr jobInfo =3D NULL; qemuMonitorMigrationStats *stats; + qemuDomainJobInfoPrivatePtr jobInfoPriv; VIR_XPATH_NODE_AUTORESTORE(ctxt); =20 if (!(ctxt->node =3D virXPathNode("./statistics", ctxt))) return NULL; =20 jobInfo =3D g_new0(qemuDomainJobInfo, 1); + jobInfoPriv =3D jobInfo->privateData; =20 - stats =3D &jobInfo->stats.mig; + stats =3D &jobInfoPriv->stats.mig; jobInfo->status =3D QEMU_DOMAIN_JOB_STATUS_COMPLETED; =20 virXPathULongLong("string(./started[1])", ctxt, &jobInfo->started); diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index af060b3180..eb9b980a6a 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1641,6 +1641,7 @@ qemuProcessHandleMigrationStatus(qemuMonitorPtr mon G= _GNUC_UNUSED, virQEMUDriverPtr driver =3D opaque; virObjectEventPtr event =3D NULL; g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); + qemuDomainJobInfoPrivatePtr jobInfoPriv; int reason; =20 virObjectLock(vm); @@ -1650,12 +1651,14 @@ qemuProcessHandleMigrationStatus(qemuMonitorPtr mon= G_GNUC_UNUSED, qemuMonitorMigrationStatusTypeToString(status)); =20 priv =3D vm->privateData; + jobInfoPriv =3D priv->job.current->privateData; + if (priv->job.asyncJob =3D=3D QEMU_ASYNC_JOB_NONE) { VIR_DEBUG("got MIGRATION event without a migration job"); goto cleanup; } =20 - priv->job.current->stats.mig.status =3D status; + jobInfoPriv->stats.mig.status =3D status; virDomainObjBroadcast(vm); =20 if (status =3D=3D QEMU_MONITOR_MIGRATION_STATUS_POSTCOPY && @@ -1723,6 +1726,7 @@ qemuProcessHandleDumpCompleted(qemuMonitorPtr mon G_G= NUC_UNUSED, { qemuDomainObjPrivatePtr priv; qemuDomainJobPrivatePtr jobPriv; + qemuDomainJobInfoPrivatePtr jobInfoPriv; =20 virObjectLock(vm); =20 @@ -1731,18 +1735,19 @@ qemuProcessHandleDumpCompleted(qemuMonitorPtr mon G= _GNUC_UNUSED, =20 priv =3D vm->privateData; jobPriv =3D priv->job.privateData; + jobInfoPriv =3D priv->job.current->privateData; if (priv->job.asyncJob =3D=3D QEMU_ASYNC_JOB_NONE) { VIR_DEBUG("got DUMP_COMPLETED event without a dump_completed job"); goto cleanup; } jobPriv->dumpCompleted =3D true; - priv->job.current->stats.dump =3D *stats; + jobInfoPriv->stats.dump =3D *stats; priv->job.error =3D g_strdup(error); =20 /* Force error if extracting the DUMP_COMPLETED status failed */ if (!error && status < 0) { priv->job.error =3D g_strdup(virGetLastErrorMessage()); - priv->job.current->stats.dump.status =3D QEMU_MONITOR_DUMP_STATUS_= FAILED; + jobInfoPriv->stats.dump.status =3D QEMU_MONITOR_DUMP_STATUS_FAILED; } =20 virDomainObjBroadcast(vm); --=20 2.25.1