From nobody Mon Feb 9 19:06:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594007214; cv=none; d=zohomail.com; s=zohoarc; b=W/Oi55UMH09+E+WnHmwPnBJAlrx1MZG3FfhzgUfUGNAmQQfeXpRgq8KmVEeV3b7wrYfPl3u8wmNZo2vXUkfVJc9gtCd6dxZL8um4oOMX0OcMlpfXmkfbMjF0EQfy/CxXeKtwiB5kXx3aVGl8M94HLrT8zRWJuCwqXvdkxF1+9No= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594007214; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6u8xx1hroVng6VCDonx4VeqQOgGOtkHr17cPvK7lglI=; b=bvUnpIYHAL0Kf3I9t51n9GTIrKYesdYREugf47qWvCERemm6v8kepb5b5Da/Q9mXIGaIV8DAT+PER9PESyD7BE5Cwiy0+Q27XCHGggvF/RLb8zS0DW9K/zyCBzqd6AsM1SCxi0RqSm7etccDfg3dw7U0gQx7PhhUujxRqLll4iU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1594007214739660.4041111648252; Sun, 5 Jul 2020 20:46:54 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-26-L3t_ZXBJMtaE0GwYCGE0Rw-1; Sun, 05 Jul 2020 23:42:17 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AC0518005B0; Mon, 6 Jul 2020 03:42:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8FEB8B3A61; Mon, 6 Jul 2020 03:42:11 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5F4E393F62; Mon, 6 Jul 2020 03:42:11 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0663fmb5004554 for ; Sun, 5 Jul 2020 23:41:48 -0400 Received: by smtp.corp.redhat.com (Postfix) id DC8167AC9F; Mon, 6 Jul 2020 03:41:48 +0000 (UTC) Received: from vhost2.laine.org (ovpn-112-194.phx2.redhat.com [10.3.112.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 91FD3275E25 for ; Mon, 6 Jul 2020 03:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594007213; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=6u8xx1hroVng6VCDonx4VeqQOgGOtkHr17cPvK7lglI=; b=QdwGXouVgzNTBbR/wgk9aHVDkJ8TUKOcFnHJGUol7r+HQBAa5wEbh2UzOHOD8AlCQPj17U VP+etJWLjDAnLQ4viDm+DxCd1MpeuxUXtnp3idea0McNXif4Yuw3w+QSYHvWldmn5Zc9UO bAMuZZ21ErDVfAzru3bF53G7lVwBjGU= X-MC-Unique: L3t_ZXBJMtaE0GwYCGE0Rw-1 From: Laine Stump To: libvir-list@redhat.com Subject: [PATCH 17/32] conf: consistently check for error when calling virSysinfoFormat() Date: Sun, 5 Jul 2020 23:41:12 -0400 Message-Id: <20200706034127.1117504-18-laine@redhat.com> In-Reply-To: <20200706034127.1117504-1-laine@redhat.com> References: <20200706034127.1117504-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Every other caller of this function checks for an error return and ends their formatting early if there is an error. This function happily continues on its way. Signed-off-by: Laine Stump Reviewed-by: J=C3=A1n Tomko --- src/conf/domain_conf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index c02d1c8bd2..33bf0a1727 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -29649,8 +29649,10 @@ virDomainDefFormatInternalSetRootName(virDomainDef= Ptr def, if (def->resource) virDomainResourceDefFormat(buf, def->resource); =20 - for (i =3D 0; i < def->nsysinfo; i++) - virSysinfoFormat(buf, def->sysinfo[i]); + for (i =3D 0; i < def->nsysinfo; i++) { + if (virSysinfoFormat(buf, def->sysinfo[i]) < 0) + goto error; + } =20 if (def->os.bootloader) { virBufferEscapeString(buf, "%s\n", --=20 2.25.4