From nobody Tue Feb 10 16:18:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1594007172; cv=none; d=zohomail.com; s=zohoarc; b=eBVp2M9FGPQx6a4W5kxrKSRDlhep5IAmtGPJ51UkQWHX/JTTmu6qu4wP1k9BX5o5kYgczFIr/QnTfKMy3XwI4GAFddnFv4WC+eAModLZR0cDmtn4x9z166VJl+RwkwCkge3ye7NXpkISYfk10hZsxajCSgeqlLGRi84lhdygcBo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1594007172; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vBNeBp4f5/gO1ck4Zc+ed+WoKRRBR7TVoWDEMfez0wY=; b=UEaM2y5g2UJ6HhFHtVarcjO5sXFdy9hjKdpqcalpXcLjLGssn7KUXMXzI182s80IY9X2CY6btAPAIFok3YkLN0wu0MhOnS6XXKS79mARcuDpdOpnQ61l2cHVisjmYWNKJKFlLm7UDjEmgJesciEw3xgDxHt/p9LLHgXohmoJuYE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1594007172895817.8457404439691; Sun, 5 Jul 2020 20:46:12 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-488-oQ3sTcUFMOusSrsZMxiz9A-1; Sun, 05 Jul 2020 23:42:31 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 245EC6EAF8; Mon, 6 Jul 2020 03:42:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05EB94AC; Mon, 6 Jul 2020 03:42:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id CC4FD93F8E; Mon, 6 Jul 2020 03:42:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0663fl67004520 for ; Sun, 5 Jul 2020 23:41:47 -0400 Received: by smtp.corp.redhat.com (Postfix) id 61E497AC9F; Mon, 6 Jul 2020 03:41:47 +0000 (UTC) Received: from vhost2.laine.org (ovpn-112-194.phx2.redhat.com [10.3.112.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1823771678 for ; Mon, 6 Jul 2020 03:41:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594007171; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=vBNeBp4f5/gO1ck4Zc+ed+WoKRRBR7TVoWDEMfez0wY=; b=Bv1CEHVFZNM5AHHL4fftAzKGvafJXk6FGX9r2ldBpIt9/9sWY8CB7EsrotMpn2iVcYoc+n 4Os17RQBsg0PSJfT88flp0/RkelYLQiWbYjWcGBdOe8v4P/iXtCSTRzB9BiQkgnJNyXkuP +YWYNlPzbz+HqaacfdgUnTtGgUwknAs= X-MC-Unique: oQ3sTcUFMOusSrsZMxiz9A-1 From: Laine Stump To: libvir-list@redhat.com Subject: [PATCH 14/32] network: use g_auto() for all virBuffers Date: Sun, 5 Jul 2020 23:41:09 -0400 Message-Id: <20200706034127.1117504-15-laine@redhat.com> In-Reply-To: <20200706034127.1117504-1-laine@redhat.com> References: <20200706034127.1117504-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=libvir-list-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Laine Stump Reviewed-by: J=C3=A1n Tomko --- src/network/bridge_driver.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 0f5212ce04..9f37d8f558 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -332,7 +332,7 @@ networkRunHook(virNetworkObjPtr obj, int sub_op) { virNetworkDefPtr def; - virBuffer buf =3D VIR_BUFFER_INITIALIZER; + g_auto(virBuffer) buf =3D VIR_BUFFER_INITIALIZER; char *xml =3D NULL; int hookret; int ret =3D -1; @@ -370,7 +370,6 @@ networkRunHook(virNetworkObjPtr obj, =20 ret =3D 0; cleanup: - virBufferFreeAndReset(&buf); VIR_FREE(xml); return ret; } @@ -1093,7 +1092,7 @@ networkDnsmasqConfContents(virNetworkObjPtr obj, dnsmasqCapsPtr caps G_GNUC_UNUSED) { virNetworkDefPtr def =3D virNetworkObjGetDef(obj); - virBuffer configbuf =3D VIR_BUFFER_INITIALIZER; + g_auto(virBuffer) configbuf =3D VIR_BUFFER_INITIALIZER; int r, ret =3D -1; int nbleases =3D 0; size_t i; @@ -1577,7 +1576,6 @@ networkDnsmasqConfContents(virNetworkObjPtr obj, cleanup: VIR_FREE(saddr); VIR_FREE(eaddr); - virBufferFreeAndReset(&configbuf); return ret; } =20 @@ -1843,7 +1841,7 @@ networkRadvdConfContents(virNetworkObjPtr obj, char **configstr) { virNetworkDefPtr def =3D virNetworkObjGetDef(obj); - virBuffer configbuf =3D VIR_BUFFER_INITIALIZER; + g_auto(virBuffer) configbuf =3D VIR_BUFFER_INITIALIZER; int ret =3D -1; size_t i; virNetworkIPDefPtr ipdef; @@ -1907,7 +1905,6 @@ networkRadvdConfContents(virNetworkObjPtr obj, =20 ret =3D 0; cleanup: - virBufferFreeAndReset(&configbuf); return ret; } =20 --=20 2.25.4