[libvirt PATCH] tools: fix misleading comments about command names

Daniel P. Berrangé posted 1 patch 1 week ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200630112146.1413510-1-berrange@redhat.com
tools/virt-admin.c | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)

[libvirt PATCH] tools: fix misleading comments about command names

Posted by Daniel P. Berrangé 1 week ago
The srv-XXX commands were renamed to server-XXX, with the old
name being a undocumented back compat alias only.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 tools/virt-admin.c | 42 +++++++++++++++++++++---------------------
 1 file changed, 21 insertions(+), 21 deletions(-)

diff --git a/tools/virt-admin.c b/tools/virt-admin.c
index 6ff9729f66..fef0332a0d 100644
--- a/tools/virt-admin.c
+++ b/tools/virt-admin.c
@@ -315,9 +315,9 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd)
 }
 
 
-/* ---------------
- * Command srv-list
- * ---------------
+/* -------------------
+ * Command server-list
+ * -------------------
  */
 
 static const vshCmdInfo info_srv_list[] = {
@@ -380,9 +380,9 @@ cmdSrvList(vshControl *ctl, const vshCmd *cmd G_GNUC_UNUSED)
 }
 
 
-/* ---------------------------
- * Command srv-threadpool-info
- * ---------------------------
+/* ------------------------------
+ * Command server-threadpool-info
+ * ------------------------------
  */
 
 static const vshCmdInfo info_srv_threadpool_info[] = {
@@ -441,9 +441,9 @@ cmdSrvThreadpoolInfo(vshControl *ctl, const vshCmd *cmd)
     return ret;
 }
 
-/* --------------------------
- * Command srv-threadpool-set
- * --------------------------
+/* -----------------------------
+ * Command server-threadpool-set
+ * -----------------------------
  */
 
 static const vshCmdInfo info_srv_threadpool_set[] = {
@@ -550,9 +550,9 @@ cmdSrvThreadpoolSet(vshControl *ctl, const vshCmd *cmd)
     goto cleanup;
 }
 
-/* ------------------------
- * Command srv-clients-list
- * ------------------------
+/* ---------------------------
+ * Command server-clients-list
+ * ---------------------------
  */
 
 static const vshCmdInfo info_srv_clients_list[] = {
@@ -793,9 +793,9 @@ cmdClientDisconnect(vshControl *ctl, const vshCmd *cmd)
     return ret;
 }
 
-/* ------------------------
- * Command srv-clients-info
- * ------------------------
+/* ---------------------------
+ * Command server-clients-info
+ * ---------------------------
  */
 
 static const vshCmdInfo info_srv_clients_info[] = {
@@ -852,9 +852,9 @@ cmdSrvClientsInfo(vshControl *ctl, const vshCmd *cmd)
     return ret;
 }
 
-/* -----------------------
- * Command srv-clients-set
- * -----------------------
+/* --------------------------
+ * Command server-clients-set
+ * --------------------------
  */
 
 static const vshCmdInfo info_srv_clients_set[] = {
@@ -957,9 +957,9 @@ cmdSrvClientsSet(vshControl *ctl, const vshCmd *cmd)
     goto cleanup;
 }
 
-/* ------------------------
- *  Command srv-update-tls
- * ------------------------
+/* --------------------------
+ *  Command server-update-tls
+ * --------------------------
  */
 static const vshCmdInfo info_srv_update_tls_file[] = {
     {.name = "help",
-- 
2.26.2

Re: [libvirt PATCH] tools: fix misleading comments about command names

Posted by Erik Skultety 1 week ago
On Tue, Jun 30, 2020 at 12:21:46PM +0100, Daniel P. Berrangé wrote:
> The srv-XXX commands were renamed to server-XXX, with the old
> name being a undocumented back compat alias only.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet@redhat.com>