[libvirt PATCH v3 0/2] Refuse PCI Address for ramfb device definition

Jonathon Jongsma posted 2 patches 2 weeks ago
Test syntax-check failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/libvirt tags/patchew/20200625201823.17424-1-jjongsma@redhat.com
src/qemu/qemu_validate.c                      |  8 +++++
...video-ramfb-display-device-pci-address.xml | 30 +++++++++++++++++++
tests/qemuxml2argvtest.c                      |  7 +++++
3 files changed, 45 insertions(+)
create mode 100644 tests/qemuxml2argvdata/video-ramfb-display-device-pci-address.xml

[libvirt PATCH v3 0/2] Refuse PCI Address for ramfb device definition

Posted by Jonathon Jongsma 2 weeks ago
Changes in this version:
 - Add the test case input file
 - modify the test itself to properly fail when an input file is missing.

Jonathon Jongsma (2):
  qemu: ramfb video device doesn't support PCI address
  tests: ensure failure if input file doesn't exist

 src/qemu/qemu_validate.c                      |  8 +++++
 ...video-ramfb-display-device-pci-address.xml | 30 +++++++++++++++++++
 tests/qemuxml2argvtest.c                      |  7 +++++
 3 files changed, 45 insertions(+)
 create mode 100644 tests/qemuxml2argvdata/video-ramfb-display-device-pci-address.xml

-- 
2.21.3

Re: [libvirt PATCH v3 0/2] Refuse PCI Address for ramfb device definition

Posted by Laine Stump 2 weeks ago
On 6/25/20 4:18 PM, Jonathon Jongsma wrote:
> Changes in this version:
>   - Add the test case input file
>   - modify the test itself to properly fail when an input file is missing.
> 
> Jonathon Jongsma (2):
>    qemu: ramfb video device doesn't support PCI address
>    tests: ensure failure if input file doesn't exist
> 
>   src/qemu/qemu_validate.c                      |  8 +++++
>   ...video-ramfb-display-device-pci-address.xml | 30 +++++++++++++++++++
>   tests/qemuxml2argvtest.c                      |  7 +++++
>   3 files changed, 45 insertions(+)
>   create mode 100644 tests/qemuxml2argvdata/video-ramfb-display-device-pci-address.xml
> 

For both:

Reviewed-by: Laine Stump <laine@redhat.com>

and pushed (...aaaand I just realized I forgot to add the Reviewed-by: 
tag before pushing :-/. Ah well, it shows me as the committer, so you 
won't have to *totally* take the fall if something blows up :-))