From nobody Sun Feb 8 16:50:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1593011866; cv=none; d=zohomail.com; s=zohoarc; b=eRzPzo76MEULFOySXr5QKsFjI7MzmdKX9G30Xu8NH3xZOWe3havR+stAlYMujRZ3w4GyismNJGUkIOfBk4QTiYfAJqKNptXUS49wvud9z3RGC7PLdAImANaYpYrDrIOSrANtA/QP3FbEg/qnBYjzLGaRVlxQ93/hXaSiYQxjgKo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1593011866; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A2WHkebu0XCV89XHGdY2nofCDoNnLPkfsCXIJTGVULo=; b=HWqzexSmJ8db1fLG28zgKqihUSN/Zm9ThmDNTxrEAQn417B7VfPWGboco0Vcphn53Pbz3tyLlyeDF7n7vwfSptpwdfUE4MFDgnO2POkkffSBOCOBQmOQP0euM7swC5JXpsqF/NDSrwwXnxSz5huHCmKqRHn2yOyabY7zfXqHWWE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1593011866218119.48930214473751; Wed, 24 Jun 2020 08:17:46 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-264-Agv7L1M3N5OOBmJLNXl8FA-1; Wed, 24 Jun 2020 11:17:42 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8D55018585A1; Wed, 24 Jun 2020 15:17:36 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5BF8C10013D7; Wed, 24 Jun 2020 15:17:36 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C072D833DC; Wed, 24 Jun 2020 15:17:35 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05OFHYVk027534 for ; Wed, 24 Jun 2020 11:17:34 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6BE5A5BADF; Wed, 24 Jun 2020 15:17:34 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.66]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D66B5BACB; Wed, 24 Jun 2020 15:17:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593011865; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=A2WHkebu0XCV89XHGdY2nofCDoNnLPkfsCXIJTGVULo=; b=chSXXrgjGctAQpHddG6KGjcnaNLwQA3LWZT1C0yecDa4/qphpHA55d689uM51ehhI8fjTd V5OXlC8ViZbPuSWeev71Ja4xDc3F/qdygu2a+/PQq1VHzdmA8O4WrL9Btg3XqS4msY0Uns lJSzJrdRl1GwPs2VtIQHykAaW1e3LBk= X-MC-Unique: Agv7L1M3N5OOBmJLNXl8FA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [PATCH libvirt-dbus 1/3] src: fix double free of virDomain object Date: Wed, 24 Jun 2020 16:17:00 +0100 Message-Id: <20200624151700.918786-2-berrange@redhat.com> In-Reply-To: <20200624151700.918786-1-berrange@redhat.com> References: <20200624151700.918786-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) The virDomainSnapshotGetDomain() method does NOT increment the refcount on the returned virDomain, so it must not be unrefed. This double free is responsible for random failures of the test_snapshot.py tests. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Andrea Bolognani --- src/domainsnapshot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/domainsnapshot.c b/src/domainsnapshot.c index f3571a1..78a9f9a 100644 --- a/src/domainsnapshot.c +++ b/src/domainsnapshot.c @@ -63,7 +63,7 @@ virtDBusDomainSnapshotGetParent(GVariant *inArgs, g_autoptr(virDomainSnapshot) domainSnapshot =3D NULL; g_autoptr(virDomainSnapshot) parent =3D NULL; guint flags; - g_autoptr(virDomain) domain =3D NULL; + virDomainPtr domain =3D NULL; g_autofree gchar *parentPath =3D NULL; =20 g_variant_get(inArgs, "(u)", &flags); @@ -159,7 +159,7 @@ virtDBusDomainSnapshotListAllChildren(GVariant *inArgs, guint flags; GVariantBuilder builder; GVariant *gdomainSnapshots; - g_autoptr(virDomain) domain =3D NULL; + virDomainPtr domain =3D NULL; =20 g_variant_get(inArgs, "(u)", &flags); =20 --=20 2.26.2