From nobody Sun May 5 09:33:54 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1592318085; cv=none; d=zohomail.com; s=zohoarc; b=UGpu2k8MKgLDlTGRsZKN/i+A6FVk5a0+TDAUc+JHGFL0NG0QJw/IKucIIIlcamgA7kwUMabBp1rrocFSbhct/00oL4CO6cwoOsUKA1932slbOCdDnDUf68iEy+FGGapOmE3ZCBOwxNJSZBskwP/yLUoQbaI0NYsyLaoHvVukhoI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592318085; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=BIiDp77StlyEcQdc1Cj+hnI+/7vfl9VegcydZfwylsI=; b=SZF37emrHaL4AQk9cfBkAUbYb/d4KOC3wUR5y100RjeoXdZzugf1YNfaiMVhmmk4ZiaIJy9GVO9Rei5GzwQLtLemrST/xI6RgotSdkh5YcLGm6R52EzvLfB8OJyEjKaGyJaiz5ptbSgURVFvIKa/j86+qkb9/QLKWctLc6p3MSU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1592318084593898.8473317802604; Tue, 16 Jun 2020 07:34:44 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-301--HrOlEG8M9amrCDT33VnHw-1; Tue, 16 Jun 2020 10:32:32 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 63A268735C5; Tue, 16 Jun 2020 14:32:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 44F945D9D3; Tue, 16 Jun 2020 14:32:24 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 16CCB833BD; Tue, 16 Jun 2020 14:32:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05GEWMQ8020836 for ; Tue, 16 Jun 2020 10:32:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id A91BA2157F25; Tue, 16 Jun 2020 14:32:22 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A4B5B2166BA3 for ; Tue, 16 Jun 2020 14:32:19 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9FC378007CD for ; Tue, 16 Jun 2020 14:32:19 +0000 (UTC) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-fG8mkM-aMByDd9-w8R1Krw-1; Tue, 16 Jun 2020 10:32:17 -0400 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05GEVb7H169276 for ; Tue, 16 Jun 2020 10:32:16 -0400 Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0b-001b2d01.pphosted.com with ESMTP id 31pg44u4ce-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Jun 2020 10:32:16 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05GETqZd024171 for ; Tue, 16 Jun 2020 14:32:14 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma01fra.de.ibm.com with ESMTP id 31mpe7j80w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 16 Jun 2020 14:32:13 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05GEWBME7340082 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 16 Jun 2020 14:32:11 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9DC824204B for ; Tue, 16 Jun 2020 14:32:11 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6310742041 for ; Tue, 16 Jun 2020 14:32:11 +0000 (GMT) Received: from normandy.boeblingen.de.ibm.com (unknown [9.145.189.87]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP for ; Tue, 16 Jun 2020 14:32:11 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592317955; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BIiDp77StlyEcQdc1Cj+hnI+/7vfl9VegcydZfwylsI=; b=Y1SUxHq/IdKbwzu+O7JPKhygZuj8/7HNNYpNYHN8et7t5QvNfGyDnDI5dVxpMaGKmJ6E6V 5yqdxezKKQt+pOTDA7Nx8MTd4to9S+lhqQzCDBoMBWF5obQwFgs7xpixaVKSty58ppaBkQ wYYZkboMja/jxtiw7TsRwJPYqiqxgVw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592318082; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BIiDp77StlyEcQdc1Cj+hnI+/7vfl9VegcydZfwylsI=; b=VDA0Y5p+LzDM+ykymteULsyVQum6+asSFojozgpIBKpod2/V8uQyEWRLUZIQTtqHVFiu63 HHnJQ4Kg1OuBl/1mLsT6YYf1ZRoyNagXJotGpk0kxzeebCtCnoYEZIQBgarQ3LC5oe6seS uDWSRfdD00LPLLTF4I/lLmcEbUFtpms= X-MC-Unique: -HrOlEG8M9amrCDT33VnHw-1 X-MC-Unique: fG8mkM-aMByDd9-w8R1Krw-1 From: Paulo de Rezende Pinatti To: libvir-list@redhat.com Subject: [PATCH] qemu: do not add model when actual iface type is hostdev Date: Tue, 16 Jun 2020 16:32:10 +0200 Message-Id: <20200616143210.116527-1-ppinatti@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216, 18.0.687 definitions=2020-06-16_04:2020-06-16, 2020-06-16 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 cotscore=-2147483648 bulkscore=0 malwarescore=0 impostorscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 suspectscore=1 priorityscore=1501 phishscore=0 adultscore=0 mlxlogscore=799 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006160104 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) (identity @redhat.com) Content-Type: text/plain; charset="utf-8" No default model should be added to the interface entry at post parse when its actual network type is hostdev as doing so might cause a mismatch between the interface definition and its actual device type. Reviewed-by: Laine Stump --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 2dad823a86..33ce0ad992 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5831,6 +5831,7 @@ qemuDomainDeviceNetDefPostParse(virDomainNetDefPtr ne= t, virQEMUCapsPtr qemuCaps) { if (net->type !=3D VIR_DOMAIN_NET_TYPE_HOSTDEV && + virDomainNetResolveActualType(net) !=3D VIR_DOMAIN_NET_TYPE_HOSTDE= V && !virDomainNetGetModelString(net)) net->model =3D qemuDomainDefaultNetModel(def, qemuCaps); =20 --=20 2.26.2