From nobody Mon Nov 25 22:32:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592309289; cv=none; d=zohomail.com; s=zohoarc; b=GBYX3/veQy1v1/6TuDNndtSYyvIp0Yx55NaYpm9R836/34IsbICoWfHMzI8Orx1+zaVlJNI8u5gJb7wZelA0bQB60ZTerDB2/dcTTnYeEZ1ECupXIT+sVwIq9fHNUAEwm/tloh7KeaV+FzgD1B7vxaKUsnOgNiG3YdRnlWQoSF4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592309289; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XEsBxZnK8kWDui33e3xM8ChWCW6J3H9JfPtm2WgP5/w=; b=WThxWeA+ZmQdJEyP4ygZl/V5EmrZLezl5GoW9hYzrqCzVFkQj0/vxz6tNTQ5KLrvY0ZW/vhTv0lyVM4BM3zpry9kXCCqxBNG5Inojgsmzoa9glWaFgXSba6wlpy8Bej3i1mpG7TpxmCicbJNq/TrDrrZPd5H1qwrdu/n6ELzhaQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1592309289712267.0407438655817; Tue, 16 Jun 2020 05:08:09 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-253-jo9_-ertP8Wla4L6A7IH5Q-1; Tue, 16 Jun 2020 08:07:41 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 934A9E922; Tue, 16 Jun 2020 12:07:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62C6E5D9D5; Tue, 16 Jun 2020 12:07:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E66B5180BACF; Tue, 16 Jun 2020 12:07:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05GC7J9R001151 for ; Tue, 16 Jun 2020 08:07:19 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2FFEF5D9D5; Tue, 16 Jun 2020 12:07:19 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.com (ovpn-112-147.phx2.redhat.com [10.3.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id E52AA5D9DD for ; Tue, 16 Jun 2020 12:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592309288; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XEsBxZnK8kWDui33e3xM8ChWCW6J3H9JfPtm2WgP5/w=; b=RpjB1LVsCftl1de44viwQuC9oymjch0Nn+rXhhgE6wybyTD2GiotlnRFH8ruFVr335MmNz LgeoBpQqkdzrh1/EHL4Rgf+/ofFMVgzlko/n1y5SKl0yLUIPhn6SMi4Qarvyow7w6LNLCL TW2csa5Tzjy9s+1pG0woH/M6nZ6WMH8= X-MC-Unique: jo9_-ertP8Wla4L6A7IH5Q-1 From: John Ferlan To: libvir-list@redhat.com Subject: [PATCH 8/9] conf: Fix memory leak in virCPUDefParseXML Date: Tue, 16 Jun 2020 08:07:09 -0400 Message-Id: <20200616120710.2628344-9-jferlan@redhat.com> In-Reply-To: <20200616120710.2628344-1-jferlan@redhat.com> References: <20200616120710.2628344-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since a08669c31, @tsc is not automatically free'd by any g_auto* method. Found by Coverity. Signed-off-by: John Ferlan --- src/conf/cpu_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c index b40737e407..e1b0a5653f 100644 --- a/src/conf/cpu_conf.c +++ b/src/conf/cpu_conf.c @@ -335,7 +335,7 @@ virCPUDefParseXML(xmlXPathContextPtr ctxt, g_autofree char *vendor_id =3D NULL; g_autofree char *tscScaling =3D NULL; g_autofree char *migratable =3D NULL; - virHostCPUTscInfoPtr tsc =3D NULL; + g_autofree virHostCPUTscInfoPtr tsc =3D NULL; =20 *cpu =3D NULL; =20 --=20 2.25.4