From nobody Mon Nov 25 22:54:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592309261; cv=none; d=zohomail.com; s=zohoarc; b=O1QiAMJyVwYJaURoe2dDnTT52zvrQA/KGQnBbPaDBSAckGXoXpu8PzfunpMaBKFjFWBmkxx2CKVzm1tYPvmrinIKcjf/DNcxyBZgFpSLi8/j+Ep+TvS90m+gVwQsz4/UNtnw5QucH1nYCtbWshIMKFSjSN3rFh+2QKuYhzwM2uI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592309261; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cLx14MU5pjqTKJIqd0WGmJ3dU2BZmwz6AgmqSvgLLyc=; b=hgz3DINEYFshxkvp79sy4aJbva++7IQJmgRROMVg830A0kc3Xl6EtCs6+hUibRgZWLQL/Sv3UPd6XJ87ATxwdkH7HED6thhpAKxCvaQqhIt9p1mcFyM7YX49ytbmOPqpVtlsloMSW+fUP8qKCprD0w0Q7ZVz98vCWrfDM75kUtE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1592309261809712.8525509631963; Tue, 16 Jun 2020 05:07:41 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-ZqqSGDM_Ovy3oV_lj-CEnA-1; Tue, 16 Jun 2020 08:07:38 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA203873014; Tue, 16 Jun 2020 12:07:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA7DF100164C; Tue, 16 Jun 2020 12:07:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6744A1809547; Tue, 16 Jun 2020 12:07:29 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05GC7IeG001144 for ; Tue, 16 Jun 2020 08:07:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id BD9C45D9DA; Tue, 16 Jun 2020 12:07:18 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.com (ovpn-112-147.phx2.redhat.com [10.3.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7EA4A5D9D5 for ; Tue, 16 Jun 2020 12:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592309260; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=cLx14MU5pjqTKJIqd0WGmJ3dU2BZmwz6AgmqSvgLLyc=; b=KHG/gMVsTprn3MXtwg52nKfw2F12mOZtTgyTjtHjQ1BNjiRDnCaMplgBjuKQwxZDV0xABg PfMLkcjR3t0LVS1NaVTtJyPbmwFWCsLIFekeszAqu8+Ko++c+WbJfxfntyt7ALtpeaMUSk uhPePjR/yd7cSt44vtZhEtXDHBTBxQA= X-MC-Unique: ZqqSGDM_Ovy3oV_lj-CEnA-1 From: John Ferlan To: libvir-list@redhat.com Subject: [PATCH 7/9] conf: Fix memory leak in openvzReadFSConf Date: Tue, 16 Jun 2020 08:07:08 -0400 Message-Id: <20200616120710.2628344-8-jferlan@redhat.com> In-Reply-To: <20200616120710.2628344-1-jferlan@redhat.com> References: <20200616120710.2628344-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since 1f5deed9, @veid_str has been leaked in the error path. Found by Coverity. Signed-off-by: John Ferlan --- src/openvz/openvz_conf.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index c06bfa13e3..190c57b622 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -330,7 +330,7 @@ openvzReadFSConf(virDomainDefPtr def, { int ret; virDomainFSDefPtr fs =3D NULL; - char *veid_str =3D NULL; + g_autofree char *veid_str =3D NULL; char *temp =3D NULL; const char *param; unsigned long long barrier, limit; @@ -365,8 +365,6 @@ openvzReadFSConf(virDomainDefPtr def, fs->type =3D VIR_DOMAIN_FS_TYPE_MOUNT; if (!(fs->src->path =3D virStringReplace(temp, "$VEID", veid_str))) goto error; - - VIR_FREE(veid_str); } =20 fs->dst =3D g_strdup("/"); --=20 2.25.4