From nobody Mon Nov 25 23:44:43 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592309263; cv=none; d=zohomail.com; s=zohoarc; b=ClEqGo0o1j3v7S56XjLOhKwX9NJw+Lm9yQHDCx/nNOIarit1S6oepuTbwRS+GEW8JabOTGucIzoAEbl6rob9jB7zZtFlahdsBGGvMWtzAdDxO6APXGGcpYwepMn1oKcMgtemd/alotEX7QTqld5zt7mynqSCmCijAI9ukaBUgdY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592309263; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=A8oDm0hgfj0008bCSGzj42fyjRf5x3ZHde05cDOR0kQ=; b=YOAU/DCngAfb99bgBHMBz21W6SY4unbEd06oMS+3KJ+5xt/AP7UNolKMu0vug2RdtTpCkZBbE5mLPhuKNRZfvk/T44QFclOa7RHoYs4TfvO/homzHT5Ggm1U1pXytDbG+DwZKAehoscrQRj7uPzE/qsd39+4rgVK5ULZuBHj+zU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1592309263450489.25011726876903; Tue, 16 Jun 2020 05:07:43 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-207-L74vFkkWOQmFh9b5CRl9OA-1; Tue, 16 Jun 2020 08:07:38 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C63A3106B247; Tue, 16 Jun 2020 12:07:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9115D7930C; Tue, 16 Jun 2020 12:07:30 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3C29E1806B0B; Tue, 16 Jun 2020 12:07:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05GC7IrV001136 for ; Tue, 16 Jun 2020 08:07:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id 571A75D9DA; Tue, 16 Jun 2020 12:07:18 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.com (ovpn-112-147.phx2.redhat.com [10.3.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 187B95D9D5 for ; Tue, 16 Jun 2020 12:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592309262; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=A8oDm0hgfj0008bCSGzj42fyjRf5x3ZHde05cDOR0kQ=; b=WV4sYS+J9MJp3V0NJGZn04DZ/rqfO65dz2uIM1XlNOeAkB8XlGTbgGbmsgzwX+LO+COPJZ ncws6IsOb9OZjUy11Cj7IMinVtbmtfNxX49XRLFoElDFLpA94kjN7KLpo3NdyIRYCEUpFE qNwH3nTmC6BPDp/Rx5ZZdf53b7xozKs= X-MC-Unique: L74vFkkWOQmFh9b5CRl9OA-1 From: John Ferlan To: libvir-list@redhat.com Subject: [PATCH 6/9] conf: Fix memory leak in openvzWriteConfigParam Date: Tue, 16 Jun 2020 08:07:07 -0400 Message-Id: <20200616120710.2628344-7-jferlan@redhat.com> In-Reply-To: <20200616120710.2628344-1-jferlan@redhat.com> References: <20200616120710.2628344-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since 60623a7c, @temp_file was not properly free'd on the non error path. Found by Coverity. Signed-off-by: John Ferlan --- src/openvz/openvz_conf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/openvz/openvz_conf.c b/src/openvz/openvz_conf.c index 78547b8b28..c06bfa13e3 100644 --- a/src/openvz/openvz_conf.c +++ b/src/openvz/openvz_conf.c @@ -616,7 +616,7 @@ int openvzLoadDomains(struct openvz_driver *driver) static int openvzWriteConfigParam(const char * conf_file, const char *param, const ch= ar *value) { - char * temp_file =3D NULL; + g_autofree char *temp_file =3D NULL; int temp_fd =3D -1; FILE *fp; char *line =3D NULL; @@ -666,7 +666,6 @@ openvzWriteConfigParam(const char * conf_file, const ch= ar *param, const char *va VIR_FORCE_CLOSE(temp_fd); if (temp_file) unlink(temp_file); - VIR_FREE(temp_file); return -1; } =20 --=20 2.25.4