From nobody Mon Nov 25 22:26:04 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592309258; cv=none; d=zohomail.com; s=zohoarc; b=Zglb6ZiCh+JQc7laqPh2MDY2bMBGTXTxjZaM7RLZHME/vj3XnvlrvPdaCGySQgzULG81ySBnDMBI/hYAkon3sscuoXl2czBFUwxYvmdAjB5qFi0dOLlA++lxqzDvAb0ccps/t0MLQh+tGxjmQH/SLre5D6hC06scwKPQz+3MSP4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592309258; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TccH1N4MInVnBy/VUJ6MSQ3QDoHGQHiw1qSL/WQQoRs=; b=bbRYm//v1cbbNKSjPjdjYLF029ffSvS5oozdZso11pvCKGTFhP9nugvOruud9KRqdvfECxlwUsAa5ft3s+iJefix+nxoYJWuJk2z4YLZ/mZ2Zxx/88c6l0M1ldmrqk/1trgDXyw64nIiL1V4uuW/wbSLZ1l0V8OeeX0BhRfJ56M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1592309258364892.0245674366454; Tue, 16 Jun 2020 05:07:38 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-148-LmONZ775O7CCDobGVYnDvQ-1; Tue, 16 Jun 2020 08:07:34 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 28F5D84B8A4; Tue, 16 Jun 2020 12:07:27 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id F25C05D9E4; Tue, 16 Jun 2020 12:07:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B6CD987428; Tue, 16 Jun 2020 12:07:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05GC7Hsg001129 for ; Tue, 16 Jun 2020 08:07:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id E56A35D9DA; Tue, 16 Jun 2020 12:07:17 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.com (ovpn-112-147.phx2.redhat.com [10.3.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id A64E45D9D5 for ; Tue, 16 Jun 2020 12:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592309256; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TccH1N4MInVnBy/VUJ6MSQ3QDoHGQHiw1qSL/WQQoRs=; b=i/Cu7y9DFlEX6xMP8LVLeLI5SBMIGIHy0uEByYgjVdL55PBPNwTiLBj9hwjx0LQeHnD4gq PYbHjGF3VMWLwHbOxTLi9wJWDo8BKFtcdxChndTddRtD5aqyyFR3K2xYzHq62noiEyXbOz YpNO24Gu4HqStodK7JHfE+vnFUbDaYA= X-MC-Unique: LmONZ775O7CCDobGVYnDvQ-1 From: John Ferlan To: libvir-list@redhat.com Subject: [PATCH 5/9] test: Fix memory leak in testParseXMLDocFromFile Date: Tue, 16 Jun 2020 08:07:06 -0400 Message-Id: <20200616120710.2628344-6-jferlan@redhat.com> In-Reply-To: <20200616120710.2628344-1-jferlan@redhat.com> References: <20200616120710.2628344-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since ceb3255c, @absFile could be leaked if we jumped to error. Found by Coverity. Signed-off-by: John Ferlan --- src/test/test_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 7a1db21718..993f405f3c 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -781,7 +781,7 @@ testParseXMLDocFromFile(xmlNodePtr node, const char *fi= le, const char *type) { xmlNodePtr ret =3D NULL; xmlDocPtr doc =3D NULL; - char *absFile =3D NULL; + g_autofree char *absFile =3D NULL; g_autofree char *relFile =3D NULL; =20 if ((relFile =3D virXMLPropString(node, "file"))) { --=20 2.25.4