From nobody Mon Nov 25 22:43:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592309250; cv=none; d=zohomail.com; s=zohoarc; b=GzZo2/biBoujt91XgrXDPyCdB4ogLSbczBq97xKEJ1GGiGkFIHQ3YJMCM2iOOpf/jp4dcex6GgXnOFFamdhFRKc+8FoVfOMA7nnoJC5BwjyBHUqjHZTbCkhbvjxfuEwnErZFUg7I/mV3E4xqaHGZiIp75Lx3yQklgAPeorNL34s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592309250; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=W7mrsaqRvKrAtkU7NRdXjBDNYu7pW7phZW7U4ZuexEI=; b=WnwzXOnrfQh7XnEE9OBpS0e8Jksgj1fToJs/NImyP+f0aXBXBRf9DiP8gCyKo2mmv5APh6miZmSHeC/QZ0rgaednpyuOur+VXVIr5dHXxlm3/LnUkoBOimIYsa/gKFvy8zuR9xW5xuDJyDkP7S2n+f8qgeyI3cvavn+qpNjFeaY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1592309250262137.70938765011192; Tue, 16 Jun 2020 05:07:30 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-447-LvsIKDRZM6aRf-553MNB8w-1; Tue, 16 Jun 2020 08:07:26 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BD92610082EB; Tue, 16 Jun 2020 12:07:20 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 904EA5D9DD; Tue, 16 Jun 2020 12:07:20 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 41D871809554; Tue, 16 Jun 2020 12:07:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05GC7HIV001119 for ; Tue, 16 Jun 2020 08:07:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id 7E0395D9DA; Tue, 16 Jun 2020 12:07:17 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.com (ovpn-112-147.phx2.redhat.com [10.3.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3F7F25D9D5 for ; Tue, 16 Jun 2020 12:07:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592309248; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=W7mrsaqRvKrAtkU7NRdXjBDNYu7pW7phZW7U4ZuexEI=; b=VNk0J9hvsPEIYabIc+pBg4wt7vb6Z1nIZIYtmMmFlhmbaeFxgVhaLpnNiQ/zAH90zspns6 b23oYWmcKEq5seeM06qsxrcbJjFarQJ7MzmTYvAEi0YYr7uC8GAsnaIpaPO5ATVWrgOYZJ le9jsijgGIan79IqwajpkaxjOKsJ+cQ= X-MC-Unique: LvsIKDRZM6aRf-553MNB8w-1 From: John Ferlan To: libvir-list@redhat.com Subject: [PATCH 4/9] util: Fix memory leak in virPCIProbeStubDriver Date: Tue, 16 Jun 2020 08:07:05 -0400 Message-Id: <20200616120710.2628344-5-jferlan@redhat.com> In-Reply-To: <20200616120710.2628344-1-jferlan@redhat.com> References: <20200616120710.2628344-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since 9ea90206, @drvpath could be overwritten if we jumped to recheck Found by Coverity. Signed-off-by: John Ferlan --- src/util/virpci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virpci.c b/src/util/virpci.c index 6c7e6bbcab..16936c4be9 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -1018,6 +1018,7 @@ virPCIProbeStubDriver(virPCIStubDriver driver) goto cleanup; } =20 + g_free(drvpath); goto recheck; } =20 --=20 2.25.4