From nobody Mon Nov 25 23:20:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592309317; cv=none; d=zohomail.com; s=zohoarc; b=WAwqjrs/B6sahGBomQROB320ajHNGNPq7z8JMk89pS1LHCOcJd1+XARTPLDyNB0GF17/ms6GnDT/OI2QUdLiDOxOAJTOCccPx+lu58Az77/0P59A814eszEgmBph1XdAU8WZJmxY25QnbZX0bSbTwZRbK28MihA5xvzrKSAsWpI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592309317; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=HhRo7DzMySAvORyhu2xEAnf2gefgU27yfxROoL8zM1M=; b=YERbUQ5DKGznz0ByG4flGR8LqT+0LSUnVuKTCcr66dU57/5Qe0uuHaBAoBu+T060wRSFv/zSmFpDza6WmU7oP5MxwWvqKCblgK2dYFHAUbaoDBQrTMfBRa7jUQOHNvfSxIDxwNjG6zefqHrkG1Qpk3vZK28l49Vv1YIVbgQaY5Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1592309317408268.66516143260696; Tue, 16 Jun 2020 05:08:37 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-71-97VUY6a7MzSjB0FH5mfmyg-1; Tue, 16 Jun 2020 08:07:35 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BDED5E91B; Tue, 16 Jun 2020 12:07:26 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8F72719C79; Tue, 16 Jun 2020 12:07:26 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4AB6287425; Tue, 16 Jun 2020 12:07:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05GC7HnY001110 for ; Tue, 16 Jun 2020 08:07:17 -0400 Received: by smtp.corp.redhat.com (Postfix) id 184445D9DA; Tue, 16 Jun 2020 12:07:17 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.com (ovpn-112-147.phx2.redhat.com [10.3.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id CCE185D9D5 for ; Tue, 16 Jun 2020 12:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592309316; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=HhRo7DzMySAvORyhu2xEAnf2gefgU27yfxROoL8zM1M=; b=hw/p5AhjAPUnLcZvcTUjcwV2GeuQL+IjGoxNA5L8LrV4mBjoE6HYx6v4gH3Kb6DqMTY2HQ B+4owPPlDBItDunBo3yshxWdsbQen1k4XCqLxTqSxFfAKr5YxxX46Dch35GjHvw9xXEtT9 ypx7/HSh6iGumX1buQK4GbBLBckq2c0= X-MC-Unique: 97VUY6a7MzSjB0FH5mfmyg-1 From: John Ferlan To: libvir-list@redhat.com Subject: [PATCH 3/9] lxc: Fix memory leak in virLXCControllerPopulateDevices Date: Tue, 16 Jun 2020 08:07:04 -0400 Message-Id: <20200616120710.2628344-4-jferlan@redhat.com> In-Reply-To: <20200616120710.2628344-1-jferlan@redhat.com> References: <20200616120710.2628344-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since 5b82f7f3, @path should have been placed inside the for loop since it'd need to be free'd for each pass through the loop; otherwise, we'd leak like a sieve. Found by Coverity. Signed-off-by: John Ferlan --- src/lxc/lxc_controller.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index 4672920574..734ac73210 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -1474,7 +1474,6 @@ static int virLXCControllerSetupDev(virLXCControllerP= tr ctrl) static int virLXCControllerPopulateDevices(virLXCControllerPtr ctrl) { size_t i; - g_autofree char *path =3D NULL; const struct { int maj; int min; @@ -1494,6 +1493,8 @@ static int virLXCControllerPopulateDevices(virLXCCont= rollerPtr ctrl) =20 /* Populate /dev/ with a few important bits */ for (i =3D 0; i < G_N_ELEMENTS(devs); i++) { + g_autofree char *path =3D NULL; + path =3D g_strdup_printf("/%s/%s.dev/%s", LXC_STATE_DIR, ctrl->def= ->name, devs[i].path); =20 --=20 2.25.4