From nobody Mon Nov 25 22:22:45 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592309248; cv=none; d=zohomail.com; s=zohoarc; b=OrQd5lxiomeIClt48oWY+MQBemadSnL1sN50m5T6jh5rc3z4tCzpzbIauTmf2kKsks/q5/HFJwEV4bh+nzpSJaIo5aN4yVNfoVytOl74xlcOxW6nFucOlt2FWLVZMe6OkwssKmmLNvexFpKMCvW3qyDftgxG35wba/9lr+KDiZE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592309248; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+rkkeZZKWfeOBaGEsW2fjgraFbECdNig/HPGf1rqIZI=; b=FJgpCMfurAReluR3Bg6jKEI23RLVBLSgdDJkylTVTqqAeJ016H/AfhZ5+Ha5nikNqGrwml/8p2lXzDvuMYkSpWaF5/majp5HXKrbFPObobgfmUZT1NjPiZ1InyZIiD5vFC5crnHfUmXpTXrVuKkuQ0SO8UQHmKZvYZ/KKoLxXh4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1592309248820107.53858655699833; Tue, 16 Jun 2020 05:07:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-167-cTVzLKfoMr20mEHvYxJOow-1; Tue, 16 Jun 2020 08:07:25 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 073D8803316; Tue, 16 Jun 2020 12:07:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9208B100164C; Tue, 16 Jun 2020 12:07:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3004087422; Tue, 16 Jun 2020 12:07:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05GC7GYh001100 for ; Tue, 16 Jun 2020 08:07:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id A52665D9DA; Tue, 16 Jun 2020 12:07:16 +0000 (UTC) Received: from unknown0050b6a41c42.attlocal.com (ovpn-112-147.phx2.redhat.com [10.3.112.147]) by smtp.corp.redhat.com (Postfix) with ESMTP id 65F365D9D5 for ; Tue, 16 Jun 2020 12:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592309247; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+rkkeZZKWfeOBaGEsW2fjgraFbECdNig/HPGf1rqIZI=; b=JM955TjVZNR+06yYEg2dRJV/1pP2Ad8dAOfrfWhqVqRYjyDoe+TKrER/x+XFTdkqS0o/c8 e4N814ZLL4nGP+trx1/oF8OWEG1/x7K0vMDxx1iVnrWH1/ZXeLexACh9PAJilKcBTGJIkp UiV/uNRZtEBVnFaiDHpxMvC9JnfJAyo= X-MC-Unique: cTVzLKfoMr20mEHvYxJOow-1 From: John Ferlan To: libvir-list@redhat.com Subject: [PATCH 2/9] util: Fix memory leak in virAuthConfigLookup Date: Tue, 16 Jun 2020 08:07:03 -0400 Message-Id: <20200616120710.2628344-3-jferlan@redhat.com> In-Reply-To: <20200616120710.2628344-1-jferlan@redhat.com> References: <20200616120710.2628344-1-jferlan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since 5084091a, @authcred is filled by a g_key_file_get_string which is now an allocated string as opposed to some hash table lookup value, so we need to treat it as so. Found by Coverity Signed-off-by: John Ferlan --- src/util/virauthconfig.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virauthconfig.c b/src/util/virauthconfig.c index 8289b28d34..2e50609531 100644 --- a/src/util/virauthconfig.c +++ b/src/util/virauthconfig.c @@ -103,7 +103,7 @@ int virAuthConfigLookup(virAuthConfigPtr auth, { g_autofree char *authgroup =3D NULL; g_autofree char *credgroup =3D NULL; - const char *authcred; + g_autofree char *authcred =3D NULL; =20 *value =3D NULL; =20 --=20 2.25.4