From nobody Thu May 2 13:15:06 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1592212175; cv=none; d=zohomail.com; s=zohoarc; b=buc6C2mHq8RP9KPkqezRXEac6T/WSSjBMjRhs/NNPKZTSSlS0tOVxxBoqJT2VfZ2hD/jmSmNMVhFCP7SF2Ky1QlDSQV8gPH+FtnnAatzr+Mrxog9C1J86UfvnjK23ftUTXPAWm29Mn9xCuJnNCJmcknXoJi2CNA9tBAga75yf6M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1592212175; h=Content-Type:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:Sender:Subject:To; bh=zFioJXMeQ3wv0ZNUdrXBBTh1ZJdeVrihVh0mxLJKO+M=; b=cLSuQg3EFk21LpSNm+Sf15zqHk5Bqm621nqtbGp9vs98M7I4TWS+mU0pfCJkCtyW5IX5lWVE7dmcVlHMO6WfHMyoDgFZ9FruVh2RIxADhDqEdZd8MQRzY183SFPVs9BYWJnh5/2h8dXdGARI27w0xoNDx4l7o8vVmYz5MUp7L2M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1592212175009854.2865582014077; Mon, 15 Jun 2020 02:09:35 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-141-SdYr3jXmN7-KGQ4sl6qTbA-1; Mon, 15 Jun 2020 05:09:31 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98D7818A0724; Mon, 15 Jun 2020 09:09:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D960768DC; Mon, 15 Jun 2020 09:09:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A7351833CA; Mon, 15 Jun 2020 09:09:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05C6IejI003380 for ; Fri, 12 Jun 2020 02:18:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 370CE2016F32; Fri, 12 Jun 2020 06:18:40 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 328542026971 for ; Fri, 12 Jun 2020 06:18:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EFFDC858EE7 for ; Fri, 12 Jun 2020 06:18:37 +0000 (UTC) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-I6-Y0hedMQ2EV7K4BfUfBw-1; Fri, 12 Jun 2020 02:18:33 -0400 Received: by mail-pf1-f193.google.com with SMTP id b16so3809309pfi.13 for ; Thu, 11 Jun 2020 23:18:32 -0700 (PDT) Received: from localhost.localdomain.com ([47.75.244.237]) by smtp.gmail.com with ESMTPSA id z11sm5154351pfk.141.2020.06.11.23.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2020 23:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1592212173; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:content-type:content-type:list-id: list-help:list-unsubscribe:list-subscribe:list-post; bh=zFioJXMeQ3wv0ZNUdrXBBTh1ZJdeVrihVh0mxLJKO+M=; b=SkckTNvqs/0ZCcXLcBrfRPRYFh5UCjXuk+KYXKz0Nw/HLuNlk78mvhQVoVomvUj4J4xMqv t/DmH62qe+iON1krF/EvyFx3g0o3euBG5/uhHFv2+wpiaI3zdgpINIErjdDu2rn7sQtSNC AM2OIAjlRjOjJkeymfBXAbqoROj1Zk4= X-MC-Unique: SdYr3jXmN7-KGQ4sl6qTbA-1 X-MC-Unique: I6-Y0hedMQ2EV7K4BfUfBw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zFioJXMeQ3wv0ZNUdrXBBTh1ZJdeVrihVh0mxLJKO+M=; b=WXyhJUAyUPQDkfaasxShJ0w6e/fRJTzDw6kZe0CIOjio2P7daIZ8Z/XecdwnMfujZV TLtgVOGM2jos35C6PJZqp8YaTmJOhzGA4skCi18XG2BOmwDSfd3lAivTjdJsqouwDBrG JXIOyC+jPjIiiSF5BwhQrJqJecG+W6FGhpUqc4Yyg6LxkkxDJdeY+e8y6/5ub/ktl9sK kQYkYAsrwZMYxIA6n24u2DZWM9iqqdmgru+rdR7EB2hGhzqMGSCoA2qXnq55ztJCf4RN CKoPR7ZkskEI1xqx80/8pqanxp/dvQqeGjl7sjXGn0qySAxbMv7nL1WIwl2ZRtpSlJh4 AYlg== X-Gm-Message-State: AOAM533w9P+6Ge3g7w2G9nTRmkPicMFp9h7jV8B1YqapQcPzdUOvT9AV Vh5N45fqamioP8yW/389MA1dYGPfPww= X-Google-Smtp-Source: ABdhPJxvUovZieKNcXmtRb4DQkKQiapNM1HLXTiigo5AeprGCXqp535jpRnsq/83EOlpoUGjRs2Vbw== X-Received: by 2002:a63:4b0a:: with SMTP id y10mr9726736pga.57.1591942711543; Thu, 11 Jun 2020 23:18:31 -0700 (PDT) From: gongwei@smartx.com To: libvir-list@redhat.com Subject: [PATCH] Fixed missing VM vport when batch start or migration partially failed Date: Fri, 12 Jun 2020 02:18:09 -0400 Message-Id: <20200612061809.163313-1-gongwei@smartx.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: libvir-list@redhat.com X-Mailman-Approved-At: Mon, 15 Jun 2020 05:09:19 -0400 Cc: gongwei X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 2 X-Mimecast-Originator: redhat.com X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: gongwei start to failed will not remove the openvswitch port, the port recycling in this case lets openvswitch handle it by itself Signed-off-by: gongwei --- src/qemu/qemu_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index d36088ba98..439bd5b396 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -7482,7 +7482,8 @@ void qemuProcessStop(virQEMUDriverPtr driver, if (vport) { if (vport->virtPortType =3D=3D VIR_NETDEV_VPORT_PROFILE_MIDONE= T) { ignore_value(virNetDevMidonetUnbindPort(vport)); - } else if (vport->virtPortType =3D=3D VIR_NETDEV_VPORT_PROFILE= _OPENVSWITCH) { + } else if (vport->virtPortType =3D=3D VIR_NETDEV_VPORT_PROFILE= _OPENVSWITCH && + reason !=3D VIR_DOMAIN_SHUTOFF_FAILED) { ignore_value(virNetDevOpenvswitchRemovePort( virDomainNetGetActualBridgeName(net), net->ifname)); --=20 2.18.2