From nobody Sun Feb 8 01:33:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1591814183; cv=none; d=zohomail.com; s=zohoarc; b=nMRfq2MP2wsA9B7GwOOwBat8GQBDwOzL3fV5cKHvagCbglwRwU9cwbGo7y0UNGzuE5jg0r/vXiZeVOiUuanaR940ddTA3pRIkhxqXogH8VTkGO2nDJuqmfrsZJJA4Bss0rIKVkuS/3hD4wPWknRzgd1Q+hpdzJgXjn5Pg39BD48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591814183; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PPqEhwKTm2fu8INzxOrvtwfOKOLOE0/P+OnOOv+IHcE=; b=F/tz1wtu7YmkCONyUOOGFv4OlyivxZda4QjVX1NPVSqQUVr1lHJ1zl6cTlQajqFeZ5B2L1mKZ0eaUvl2nIyzK3BfXSHBkwpmbv9oVFgRPEI8ZM4g6e7/nViewzFgXViYXCVUZ8e7YHTtdNzJDbH/fnYN7i9DxL9rvxmCKpcabq0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 15918141833441019.5002486266465; Wed, 10 Jun 2020 11:36:23 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-lGZrsFGgNU2G_cvKjjXhQA-1; Wed, 10 Jun 2020 14:36:16 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 01687801503; Wed, 10 Jun 2020 18:36:11 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A267F100238D; Wed, 10 Jun 2020 18:36:10 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id C7BA51809547; Wed, 10 Jun 2020 18:36:09 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 05AIa88a024063 for ; Wed, 10 Jun 2020 14:36:08 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9E1B910F26F6; Wed, 10 Jun 2020 18:36:08 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 99ABE10F26F4 for ; Wed, 10 Jun 2020 18:36:06 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A56111859160 for ; Wed, 10 Jun 2020 18:36:06 +0000 (UTC) Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-mC3N-B8zNCiUoDFzVNjnqg-1; Wed, 10 Jun 2020 14:36:04 -0400 Received: by mail-qt1-f194.google.com with SMTP id z1so2610114qtn.2 for ; Wed, 10 Jun 2020 11:36:03 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:b081:e954:9388:2ec6:d6f4]) by smtp.gmail.com with ESMTPSA id k20sm599033qtu.16.2020.06.10.11.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jun 2020 11:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591814182; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=PPqEhwKTm2fu8INzxOrvtwfOKOLOE0/P+OnOOv+IHcE=; b=KbtXBPglSk3YHH8vrh8cyK5Tld1V1KBpbeX9HgHAVb+YvUVLLoYH4URb9Y9FR8PiwiRLvy HzAivkXi/4FyJkzkk0WvJ8qI3MTyVB5gC8vAYU9l56cKbtekk0r+EmUpEzG6zd90Xa0Ss4 +6RoZGdOWc13bkmgVIelJreXaCc1OtI= X-MC-Unique: lGZrsFGgNU2G_cvKjjXhQA-1 X-MC-Unique: mC3N-B8zNCiUoDFzVNjnqg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PPqEhwKTm2fu8INzxOrvtwfOKOLOE0/P+OnOOv+IHcE=; b=SVlGGiAbubXsqEpwPraUlc1Lgp8dLydkvYvRfAIrmNOvSWAe1XQC+SVEIek1NRx+mL /1qtW/AVBXeGV99IgYJ3pq1gpzcqL/7UPFC66/JI2HE52VYxaE4PR2SPtsnTJjBaUaPZ far+AIWQGl5uSOrbny8CE7UuIWQDYkbcukD2SQp6STmYkkemNJbL8+3UmmzsMq06S1LT HX8VVJXIOd585he0DUHXowGdRwu8AoapDFs4b/m86CRQWyP4IEoev0CjPMNx00Ohkxkx WV6N3gW9eMBQd1j/4+YOV3TRTE9oF7QgMuUjnZENejS2O2RJVQ3UgVsOlwtvJQFXWK+c hnSA== X-Gm-Message-State: AOAM530ggpTa00QHWmz3Zp/ckzQTlAXWCcU/HWwr5di5kIj83CXseOdJ +u3PVZ65d4WJsdM98ie6yfRAFSjo X-Google-Smtp-Source: ABdhPJyL0efuaxqsAOD1ijVCfA4uDYH3bq0yNUvcuouJcD8OO8tmJfAfzJc2iCMrA9S7wfbAEzW5FA== X-Received: by 2002:aed:2d23:: with SMTP id h32mr4721011qtd.69.1591814163282; Wed, 10 Jun 2020 11:36:03 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v2 1/4] numa_conf.c: add helper functions for cpumap operations Date: Wed, 10 Jun 2020 15:35:50 -0300 Message-Id: <20200610183553.466611-2-danielhb413@gmail.com> In-Reply-To: <20200610183553.466611-1-danielhb413@gmail.com> References: <20200610183553.466611-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" These helpers will be used in an auto-fill feature for incomplete NUMA topologies in the next patch. Signed-off-by: Daniel Henrique Barboza --- src/conf/numa_conf.c | 46 ++++++++++++++++++++++++++++++++++++++++ src/conf/numa_conf.h | 3 +++ src/libvirt_private.syms | 1 + 3 files changed, 50 insertions(+) diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 09811cb51b..d022685284 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c @@ -1372,3 +1372,49 @@ virDomainNumaGetMemorySize(virDomainNumaPtr numa) =20 return ret; } + + +static int +virDomainNumaRemoveCPUsFromMap(virBitmapPtr result, virBitmapPtr exclude) +{ + size_t i; + + for (i =3D 0; i < virBitmapSize(exclude); i++) { + if (!virBitmapIsBitSet(exclude, i)) + continue; + + if (virBitmapClearBitExpand(result, i) < 0) + return -1; + } + + return 0; +} + + +int +virDomainNumaFillCPUsInNode(virDomainNumaPtr numa, size_t node, + unsigned int maxCpus) +{ + g_autoptr(virBitmap) maxCPUsBitmap =3D virBitmapNew(maxCpus); + size_t i; + + if (node >=3D virDomainNumaGetNodeCount(numa)) + return -1; + + virBitmapSetAll(maxCPUsBitmap); + + for (i =3D 0; i < numa->nmem_nodes; i++) { + virBitmapPtr nodeCpus =3D virDomainNumaGetNodeCpumask(numa, i); + + if (i =3D=3D node) + continue; + + if (virDomainNumaRemoveCPUsFromMap(maxCPUsBitmap, nodeCpus) < 0) + return -1; + } + + virBitmapFree(numa->mem_nodes[node].cpumask); + numa->mem_nodes[node].cpumask =3D g_steal_pointer(&maxCPUsBitmap); + + return 0; +} diff --git a/src/conf/numa_conf.h b/src/conf/numa_conf.h index ae3599bb8b..cdf87a87e8 100644 --- a/src/conf/numa_conf.h +++ b/src/conf/numa_conf.h @@ -185,3 +185,6 @@ int virDomainNumaDefCPUParseXML(virDomainNumaPtr def, x= mlXPathContextPtr ctxt); int virDomainNumaDefCPUFormatXML(virBufferPtr buf, virDomainNumaPtr def); =20 unsigned int virDomainNumaGetCPUCountTotal(virDomainNumaPtr numa); + +int virDomainNumaFillCPUsInNode(virDomainNumaPtr numa, size_t node, + unsigned int maxCpus); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a6af44fe1c..788e08045a 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -834,6 +834,7 @@ virDomainMemoryAccessTypeFromString; virDomainMemoryAccessTypeToString; virDomainNumaCheckABIStability; virDomainNumaEquals; +virDomainNumaFillCPUsInNode; virDomainNumaFree; virDomainNumaGetCPUCountTotal; virDomainNumaGetMaxCPUID; --=20 2.26.2