[PATCH 0/2] Add support for IOMMU address width

Menno Lageman posted 2 patches 3 years, 9 months ago
Test syntax-check failed
Failed in applying to current master (apply log)
docs/formatdomain.html.in                     |  9 +++++
docs/schemas/domaincommon.rng                 |  5 +++
src/conf/domain_conf.c                        | 21 +++++++++++
src/conf/domain_conf.h                        |  1 +
src/qemu/qemu_capabilities.c                  |  6 ++++
src/qemu/qemu_capabilities.h                  |  4 +++
src/qemu/qemu_command.c                       |  6 ++++
src/qemu/qemu_validate.c                      |  9 ++++-
.../caps_2.12.0.x86_64.xml                    |  1 +
.../caps_3.0.0.x86_64.xml                     |  1 +
.../caps_3.1.0.x86_64.xml                     |  1 +
.../caps_4.0.0.x86_64.xml                     |  1 +
.../caps_4.1.0.x86_64.xml                     |  1 +
.../caps_4.2.0.x86_64.xml                     |  1 +
.../caps_5.0.0.x86_64.xml                     |  1 +
.../caps_5.1.0.x86_64.xml                     |  1 +
.../intel-iommu-aw-bits.x86_64-latest.args    | 33 +++++++++++++++++
.../qemuxml2argvdata/intel-iommu-aw-bits.xml  | 35 +++++++++++++++++++
tests/qemuxml2argvtest.c                      |  1 +
.../intel-iommu-aw-bits.x86_64-latest.xml     |  1 +
tests/qemuxml2xmltest.c                       |  1 +
21 files changed, 139 insertions(+), 1 deletion(-)
create mode 100644 tests/qemuxml2argvdata/intel-iommu-aw-bits.x86_64-latest.args
create mode 100644 tests/qemuxml2argvdata/intel-iommu-aw-bits.xml
create mode 120000 tests/qemuxml2xmloutdata/intel-iommu-aw-bits.x86_64-latest.xml
[PATCH 0/2] Add support for IOMMU address width
Posted by Menno Lageman 3 years, 9 months ago
Since commit 37f51384ae05 ('intel-iommu: Extend address width to 48
bits') QEMU supports setting the address width of the IOMMU. This patch
adds a new 'aw_bits' attribute to the iommu in libvirtd to configure
this.

Menno Lageman (2):
  conf: add address width attribute to iommu
  qemu: format address wdith on intel-iommu command line

 docs/formatdomain.html.in                     |  9 +++++
 docs/schemas/domaincommon.rng                 |  5 +++
 src/conf/domain_conf.c                        | 21 +++++++++++
 src/conf/domain_conf.h                        |  1 +
 src/qemu/qemu_capabilities.c                  |  6 ++++
 src/qemu/qemu_capabilities.h                  |  4 +++
 src/qemu/qemu_command.c                       |  6 ++++
 src/qemu/qemu_validate.c                      |  9 ++++-
 .../caps_2.12.0.x86_64.xml                    |  1 +
 .../caps_3.0.0.x86_64.xml                     |  1 +
 .../caps_3.1.0.x86_64.xml                     |  1 +
 .../caps_4.0.0.x86_64.xml                     |  1 +
 .../caps_4.1.0.x86_64.xml                     |  1 +
 .../caps_4.2.0.x86_64.xml                     |  1 +
 .../caps_5.0.0.x86_64.xml                     |  1 +
 .../caps_5.1.0.x86_64.xml                     |  1 +
 .../intel-iommu-aw-bits.x86_64-latest.args    | 33 +++++++++++++++++
 .../qemuxml2argvdata/intel-iommu-aw-bits.xml  | 35 +++++++++++++++++++
 tests/qemuxml2argvtest.c                      |  1 +
 .../intel-iommu-aw-bits.x86_64-latest.xml     |  1 +
 tests/qemuxml2xmltest.c                       |  1 +
 21 files changed, 139 insertions(+), 1 deletion(-)
 create mode 100644 tests/qemuxml2argvdata/intel-iommu-aw-bits.x86_64-latest.args
 create mode 100644 tests/qemuxml2argvdata/intel-iommu-aw-bits.xml
 create mode 120000 tests/qemuxml2xmloutdata/intel-iommu-aw-bits.x86_64-latest.xml

-- 
2.26.2

Re: [PATCH 0/2] Add support for IOMMU address width
Posted by Menno Lageman 3 years, 9 months ago
On 04-06-2020 09:42, Menno Lageman wrote:
> Since commit 37f51384ae05 ('intel-iommu: Extend address width to 48
> bits') QEMU supports setting the address width of the IOMMU. This patch
> adds a new 'aw_bits' attribute to the iommu in libvirtd to configure
> this.
> 
> Menno Lageman (2):
>    conf: add address width attribute to iommu
>    qemu: format address wdith on intel-iommu command line
> 
>   docs/formatdomain.html.in                     |  9 +++++
>   docs/schemas/domaincommon.rng                 |  5 +++
>   src/conf/domain_conf.c                        | 21 +++++++++++
>   src/conf/domain_conf.h                        |  1 +
>   src/qemu/qemu_capabilities.c                  |  6 ++++
>   src/qemu/qemu_capabilities.h                  |  4 +++
>   src/qemu/qemu_command.c                       |  6 ++++
>   src/qemu/qemu_validate.c                      |  9 ++++-
>   .../caps_2.12.0.x86_64.xml                    |  1 +
>   .../caps_3.0.0.x86_64.xml                     |  1 +
>   .../caps_3.1.0.x86_64.xml                     |  1 +
>   .../caps_4.0.0.x86_64.xml                     |  1 +
>   .../caps_4.1.0.x86_64.xml                     |  1 +
>   .../caps_4.2.0.x86_64.xml                     |  1 +
>   .../caps_5.0.0.x86_64.xml                     |  1 +
>   .../caps_5.1.0.x86_64.xml                     |  1 +
>   .../intel-iommu-aw-bits.x86_64-latest.args    | 33 +++++++++++++++++
>   .../qemuxml2argvdata/intel-iommu-aw-bits.xml  | 35 +++++++++++++++++++
>   tests/qemuxml2argvtest.c                      |  1 +
>   .../intel-iommu-aw-bits.x86_64-latest.xml     |  1 +
>   tests/qemuxml2xmltest.c                       |  1 +
>   21 files changed, 139 insertions(+), 1 deletion(-)
>   create mode 100644 tests/qemuxml2argvdata/intel-iommu-aw-bits.x86_64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/intel-iommu-aw-bits.xml
>   create mode 120000 tests/qemuxml2xmloutdata/intel-iommu-aw-bits.x86_64-latest.xml
> 

Ping?

After an initial comment this seems to be stuck in limbo.

Thanks,

Menno

Re: [PATCH 0/2] Add support for IOMMU address width
Posted by Michal Privoznik 3 years, 9 months ago
On 6/4/20 9:42 AM, Menno Lageman wrote:
> Since commit 37f51384ae05 ('intel-iommu: Extend address width to 48
> bits') QEMU supports setting the address width of the IOMMU. This patch
> adds a new 'aw_bits' attribute to the iommu in libvirtd to configure
> this.
> 
> Menno Lageman (2):
>    conf: add address width attribute to iommu
>    qemu: format address wdith on intel-iommu command line
> 
>   docs/formatdomain.html.in                     |  9 +++++
>   docs/schemas/domaincommon.rng                 |  5 +++
>   src/conf/domain_conf.c                        | 21 +++++++++++
>   src/conf/domain_conf.h                        |  1 +
>   src/qemu/qemu_capabilities.c                  |  6 ++++
>   src/qemu/qemu_capabilities.h                  |  4 +++
>   src/qemu/qemu_command.c                       |  6 ++++
>   src/qemu/qemu_validate.c                      |  9 ++++-
>   .../caps_2.12.0.x86_64.xml                    |  1 +
>   .../caps_3.0.0.x86_64.xml                     |  1 +
>   .../caps_3.1.0.x86_64.xml                     |  1 +
>   .../caps_4.0.0.x86_64.xml                     |  1 +
>   .../caps_4.1.0.x86_64.xml                     |  1 +
>   .../caps_4.2.0.x86_64.xml                     |  1 +
>   .../caps_5.0.0.x86_64.xml                     |  1 +
>   .../caps_5.1.0.x86_64.xml                     |  1 +
>   .../intel-iommu-aw-bits.x86_64-latest.args    | 33 +++++++++++++++++
>   .../qemuxml2argvdata/intel-iommu-aw-bits.xml  | 35 +++++++++++++++++++
>   tests/qemuxml2argvtest.c                      |  1 +
>   .../intel-iommu-aw-bits.x86_64-latest.xml     |  1 +
>   tests/qemuxml2xmltest.c                       |  1 +
>   21 files changed, 139 insertions(+), 1 deletion(-)
>   create mode 100644 tests/qemuxml2argvdata/intel-iommu-aw-bits.x86_64-latest.args
>   create mode 100644 tests/qemuxml2argvdata/intel-iommu-aw-bits.xml
>   create mode 120000 tests/qemuxml2xmloutdata/intel-iommu-aw-bits.x86_64-latest.xml
> 

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>

and pushed. Congratulations on your first libvirt contribution!
And sorry it took so long.

Michal