From nobody Sun Feb 8 07:07:46 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1591034142; cv=none; d=zohomail.com; s=zohoarc; b=BfLBdXmQj6axirFdg6Miq9nB8rmIp2ZqPYiWvurHEyZfSn2+6n0AgzuunfEr02Er8h0AYTKQDENUps23uSZ5jipYrrO/+GQ+0NDHabtbCafJbfbnQUHDZFE8BAhfRurUSWElJsApwjEQQ6fGE6cZYQ4/yKFaSWo0AVd2BrdTC5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1591034142; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JKT59lsVEgpivLUax0U03O5BZl5mbag7uXCJS8dZ66E=; b=SYzoMSLFai1fyunxzzaj69OONs4nN2xHNpmkG3iiDAOw6OmsfgO6oZi3XXe4vLc9SQ5ZNCm+e2CMkaEEmPqSBjSzE5OThlAx0dm20D2+O/w7Dwy0uns/DyuZCuKSOt1MpDlZD4EDbCF1S9MdnDv24V/YiyAAIDlnlus2JR9FAUc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1591034142556210.7931779852587; Mon, 1 Jun 2020 10:55:42 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-177-7umh1PFNP0m0S7wzuG52HQ-1; Mon, 01 Jun 2020 13:55:39 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3E60C100CCC0; Mon, 1 Jun 2020 17:55:34 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66B9A5C1B2; Mon, 1 Jun 2020 17:55:33 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 875CE180954D; Mon, 1 Jun 2020 17:55:30 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 051Hp2mQ009408 for ; Mon, 1 Jun 2020 13:51:02 -0400 Received: by smtp.corp.redhat.com (Postfix) id BC44D2156A2D; Mon, 1 Jun 2020 17:51:02 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B8AD92157F25 for ; Mon, 1 Jun 2020 17:51:02 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9F8508007D4 for ; Mon, 1 Jun 2020 17:51:02 +0000 (UTC) Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-703ZN9S4OeGKRETNxIvTeQ-1; Mon, 01 Jun 2020 13:51:00 -0400 Received: by mail-qt1-f195.google.com with SMTP id b11so8411617qtt.3; Mon, 01 Jun 2020 10:51:00 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c7:9da7:da03:b92e:aafb:831c]) by smtp.gmail.com with ESMTPSA id h22sm9519021qtk.63.2020.06.01.10.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2020 10:50:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591034141; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JKT59lsVEgpivLUax0U03O5BZl5mbag7uXCJS8dZ66E=; b=MPFahwfQefRFLfKTlTL+pz/4WkpQZpz3mZNNx9vMPys8n7kVQCBX5fdT8jCCXTMgPN7Ciw CwGMAv7bUg01lQe9bdBW+c4jclrP8EJ9jBY5oamU5ASfK+7Rj41Ki5e7MVfCpPZc2lHi/o 1DwIYFCYlkHPh9ny5l5jtIO7rKsepWA= X-MC-Unique: 7umh1PFNP0m0S7wzuG52HQ-1 X-MC-Unique: 703ZN9S4OeGKRETNxIvTeQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JKT59lsVEgpivLUax0U03O5BZl5mbag7uXCJS8dZ66E=; b=GKreThLedhplh95gntSdump2ZHbgdRpczXzOYbJ6LVmOJyJ3Lh32cHhl2BXQLTakyE OlbX3N3wEGEwgBvTMWJRVVRTGfOCepjdSiY3BBf3vkKShQNjc3eAG74FRRWs02FDl5Hs 3KGfrPCAddcT8or5/V1E/yVssnEnJa+3+U/VGCFZRgI00LE6bL0BI5g178hWNVY2tDfE dDGQTFgzeDPXE4cDLhg8NlgUXN0wvSFxtT63hEhDGqp0P8wFSGd4zVnebbXALtQRIlHi hGA6AO32QErYt3cto4ypUw/BjL+7OCqkr/zVFqruzQ+buk7DqQatdgbw84F0ZFVpIrU/ HG/g== X-Gm-Message-State: AOAM533O0krbiq57AP2nzkALarjD+hs9edCp45AdhIbfaqQQS2te42x+ oSe9wZZqiYCYM8lbcnP1N4Dulm/Ats4= X-Google-Smtp-Source: ABdhPJwy8TH1bH2sj+AAqr4b1cWl+NVHLlRtZfzCclR8fIv1gtkKMqHduvZcyd/FM2hSFqEmJhJL2A== X-Received: by 2002:ac8:1416:: with SMTP id k22mr22957914qtj.205.1591033859510; Mon, 01 Jun 2020 10:50:59 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 5/5] qemu_validate.c: revert NUMA CPU range user warning Date: Mon, 1 Jun 2020 14:50:41 -0300 Message-Id: <20200601175041.1607723-6-danielhb413@gmail.com> In-Reply-To: <20200601175041.1607723-1-danielhb413@gmail.com> References: <20200601175041.1607723-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza , pkrempa@redhat.com, "Maxiwell S . Garcia" X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Now that we have the auto-fill code in place, and with proper documentation to let the user know that (1) we will auto-fill the NUMA cpus up to the number to maximum VCPUs number if QEMU supports it and (2) the user is advised to always supply a complete NUMA topology, this warning is unneeded. This reverts commit 38d2e033686b5cc274f8f55075ce1985b71e329a. CC: Maxiwell S. Garcia Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_validate.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 584d1375b8..14d614934d 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -895,24 +895,15 @@ qemuValidateDomainDef(const virDomainDef *def, if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_HOTPLUGGABLE_CPUS)) { unsigned int topologycpus; unsigned int granularity; - unsigned int numacpus; =20 /* Starting from QEMU 2.5, max vCPU count and overall vCPU topology * must agree. We only actually enforce this with QEMU 2.7+, due * to the capability check above */ - if (virDomainDefGetVcpusTopology(def, &topologycpus) =3D=3D 0) { - if (topologycpus !=3D virDomainDefGetVcpusMax(def)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("CPU topology doesn't match maximum vcpu = count")); - return -1; - } - - numacpus =3D virDomainNumaGetCPUCountTotal(def->numa); - if ((numacpus !=3D 0) && (topologycpus !=3D numacpus)) { - VIR_WARN("CPU topology doesn't match numa CPU count; " - "partial NUMA mapping is obsoleted and will " - "be removed in future"); - } + if (virDomainDefGetVcpusTopology(def, &topologycpus) =3D=3D 0 && + topologycpus !=3D virDomainDefGetVcpusMax(def)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("CPU topology doesn't match maximum vcpu coun= t")); + return -1; } =20 /* vCPU hotplug granularity must be respected */ --=20 2.26.2