From nobody Fri May 3 10:40:02 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588833452; cv=none; d=zohomail.com; s=zohoarc; b=fcvrEvhCfcADVaS9zglwiqIe0hZEaHoysVMuJgIFEAtwdIE0XDB0WwahswtDw4PemKdUrgTaJtTuP/ZdtFBp2SIlPqh/QvJ/we72/vSqm5vZMAK3LqF/lIrEoE5eOW5V0YezZQMjJExwWXJInu31uv+6cPHYFGDBGzZIoR1ylSc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588833452; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=gqda3gl90AGYIQSzy42W3GZ/7GUuGg+5ixO78kRjmtI=; b=TBRRmcbVr4G8ZiHp4BVH9Jf9HpyONmgGoaU8L4Kxr5KaJyzvpgdJuR2NCpObeB5CgAsKfHNS42S1Y3rQZDM5BrjTkrQbvbHInty7zD54lZLLe5RXtAB/929EwmEke+Z8zLNO0bZzx0Wr56J6nUTUYC/CtwQS7uyNzUlfzuhMsRM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1588833452908969.8857764113122; Wed, 6 May 2020 23:37:32 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-e4ylr9DXMjKjEw_bJQoRIQ-1; Thu, 07 May 2020 02:37:29 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 88C7F107ACCA; Thu, 7 May 2020 06:37:23 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C778A10021B3; Thu, 7 May 2020 06:37:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 6307D4CAA0; Thu, 7 May 2020 06:37:20 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0476bIeO018290 for ; Thu, 7 May 2020 02:37:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id E48F81FBCD; Thu, 7 May 2020 06:37:18 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-13-91.pek2.redhat.com [10.72.13.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8F9182E041; Thu, 7 May 2020 06:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588833451; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=gqda3gl90AGYIQSzy42W3GZ/7GUuGg+5ixO78kRjmtI=; b=OE22dUM+IthbdqZLDnuzcrJG/a25u5aYzZD+4SmFQTzHEwS77Jvy0575r64SjsUj4dD7Js 2jMgMYWrKHcffy0E3XVdKSHu357p4QbVX64VjAknx7u31vW9zbiXOD+vOxdhUvGR9y3zoG t6jKxdcQ2P/slcJ80+MzrVmRI/Z0Tro= X-MC-Unique: e4ylr9DXMjKjEw_bJQoRIQ-1 From: Han Han To: libvir-list@redhat.com Subject: [libvirt PATCH] qemu: Skip pre-creation of NVME disk Date: Thu, 7 May 2020 14:37:11 +0800 Message-Id: <20200507063711.53516-1-hhan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-loop: libvir-list@redhat.com Cc: mprivozn@redhat.com, Han Han X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Unlike the file based disk, NVME disk cannot be pre-created by libvirt. So skip the step of pre-creation. https://bugzilla.redhat.com/show_bug.cgi?id=3D1823639 Signed-off-by: Han Han --- src/qemu/qemu_migration.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index 02e8271e..e4bd9077 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -221,13 +221,13 @@ qemuMigrationDstPrecreateDisk(virConnectPtr conn, break; =20 case VIR_STORAGE_TYPE_NETWORK: - VIR_DEBUG("Skipping creation of network disk '%s'", + case VIR_STORAGE_TYPE_NVME: + VIR_DEBUG("Skipping creation of disk '%s'", disk->dst); return 0; =20 case VIR_STORAGE_TYPE_BLOCK: case VIR_STORAGE_TYPE_DIR: - case VIR_STORAGE_TYPE_NVME: case VIR_STORAGE_TYPE_NONE: case VIR_STORAGE_TYPE_LAST: virReportError(VIR_ERR_INTERNAL_ERROR, --=20 2.25.0