From nobody Mon Feb 9 19:06:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588765385; cv=none; d=zohomail.com; s=zohoarc; b=dvPJjA8UD8JTmQ7WvFCmQjiWixpKVj71icDcXatGxzqapbHpyrDYmrYWfLW6sBfEwMD6imKLRxOIc4H2DeGiILXP0PIllchaCG9dzjBanBENrprrKGccA6D/CWUzlT4OAQF/G1CNjxDARgWTxvSKByiWLmu2r8jE8slC3eQ0r4E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588765385; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1a5SiXJy/T2COg9U3vTwwRuS1kMVa1/eUUjRFVLTfwU=; b=KY0Cd9pZoWhl9m/KAZBZUBDNEOeSx/RPAT09sN8ZzfduXg0b4qFSExR4X0g4Y/gFsdN81GA0OCt7jcoJGNOJtpz0+nZrMfUwxu42ou+YJN2V3QqDJ3YBhKdc/6QpvA+BTNhcGg1sxnrofFfIiwvnsZd/mKXuNcBt9sd7O8UYPd0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1588765385386220.9133199192903; Wed, 6 May 2020 04:43:05 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-233-d4R3Pl4DPCCE_jLxD123Jg-1; Wed, 06 May 2020 07:43:02 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 82EEC100D02E; Wed, 6 May 2020 11:42:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3B0ED1036D11; Wed, 6 May 2020 11:42:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id EA0784CAA8; Wed, 6 May 2020 11:42:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 046BgdeZ026833 for ; Wed, 6 May 2020 07:42:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id C623D1000079; Wed, 6 May 2020 11:42:39 +0000 (UTC) Received: from ibm-p8-15-fsp.mgmt.pnr.lab.eng.rdu2.redhat.com (unknown [10.40.195.180]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1091810013D9; Wed, 6 May 2020 11:42:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588765384; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=1a5SiXJy/T2COg9U3vTwwRuS1kMVa1/eUUjRFVLTfwU=; b=AyXE/GmlyxgE6UgABTb+72Ncm3fxUt5JE8QODGg4HKvogKW34261NqCYf9HRC/jqXwh/fc vub5xbDLUZiU2K91y6D1VFbY9rMBVXd/14IAHI8QaCJs8cNNoLAH3tZbNWZqJFOkrgJ11M DMvYpCqruwCDRslbR7hdTjZ/vPSlrBQ= X-MC-Unique: d4R3Pl4DPCCE_jLxD123Jg-1 From: Pavel Mores To: libvir-list@redhat.com Subject: [libvirt PATCH v2 10/10] qemu: block: add actual invocation of external snapshot-delete Date: Wed, 6 May 2020 13:42:26 +0200 Message-Id: <20200506114226.2538196-11-pmores@redhat.com> In-Reply-To: <20200506114226.2538196-1-pmores@redhat.com> References: <20200506114226.2538196-1-pmores@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: Pavel Mores X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Plug in the external snapshot deletion framework built in previous commits. Signed-off-by: Pavel Mores --- src/qemu/qemu_driver.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 57e81e3720..34c0e27eb9 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -17106,10 +17106,8 @@ qemuDomainSnapshotDelete(virDomainSnapshotPtr snap= shot, qemuDomainSnapshotCountExtern= al, &external); if (external) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("deletion of %d external disk snapshots not " - "supported yet"), external); - goto endjob; + if (qemuDomainSnapshotDeleteExternal(vm, driver, snap, flags) = < 0) + goto endjob; } } =20 --=20 2.24.1