From nobody Sun May 5 14:23:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588630252; cv=none; d=zohomail.com; s=zohoarc; b=NFEPAQWEwTkBMHNo9L1aTcEmV04y7BqlBjbuTA4aRjvqb7Gcq76awS/mwhY//FNCInjLYQyNhYdbsrlsKiUjZSIMwoI8m25xHwhboeKnQEjMBjECwNA/Ub4ZciqaW5qQ5QjZNM47bfKGeIxmVHyRiscOJpH4ts0lFJzhC7uxmdg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588630252; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Zens3A6o9NbP9daceIxMloBRDfkdvy6RIdAPVUIe6Gs=; b=OCGsM4BK2BRzIoobL00zVnVEc4a7B0ybA6iVg2PBH71mM+2UyXEcmv8LRo3zqfCkXyw1JpagjAJvMfqWb9lsDdnObXl0X2JD7Ey0f8/DwGp8skNO7qeC4mEmniyXycAH2/nbM5XJ1VPVLnMPboSn4/RfwIeEv7duvueOW4EW+1s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1588630252192822.3083221008957; Mon, 4 May 2020 15:10:52 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-5vuJp52lNRO2X1cG0hSH1A-1; Mon, 04 May 2020 18:10:45 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BFDDA1895A2B; Mon, 4 May 2020 22:10:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BF117053A; Mon, 4 May 2020 22:10:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 505C84CA94; Mon, 4 May 2020 22:10:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 044MAMjc010278 for ; Mon, 4 May 2020 18:10:22 -0400 Received: by smtp.corp.redhat.com (Postfix) id 94E0BB0793; Mon, 4 May 2020 22:10:22 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8BE75B17E6 for ; Mon, 4 May 2020 22:10:18 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9BEE88007C8 for ; Mon, 4 May 2020 22:10:18 +0000 (UTC) Received: from m4a0072g.houston.softwaregrp.com (m4a0072g.houston.softwaregrp.com [15.124.2.130]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-AuawdrsqN3KZfUd63m7dWQ-1; Mon, 04 May 2020 18:10:16 -0400 Received: FROM m4a0072g.houston.softwaregrp.com (15.120.17.147) BY m4a0072g.houston.softwaregrp.com WITH ESMTP FOR libvir-list@redhat.com; Mon, 4 May 2020 22:09:12 +0000 Received: from M9W0068.microfocus.com (2002:f79:bf::f79:bf) by M4W0335.microfocus.com (2002:f78:1193::f78:1193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 4 May 2020 22:09:42 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.124.72.14) by M9W0068.microfocus.com (15.121.0.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Mon, 4 May 2020 22:09:42 +0000 Received: from CY4PR1801MB2071.namprd18.prod.outlook.com (2603:10b6:910:79::35) by CY4PR1801MB2021.namprd18.prod.outlook.com (2603:10b6:910:7d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Mon, 4 May 2020 22:09:41 +0000 Received: from CY4PR1801MB2071.namprd18.prod.outlook.com ([fe80::ed4d:fafd:1763:cc9c]) by CY4PR1801MB2071.namprd18.prod.outlook.com ([fe80::ed4d:fafd:1763:cc9c%3]) with mapi id 15.20.2958.030; Mon, 4 May 2020 22:09:41 +0000 Received: from linux-tbji.provo.novell.com (75.169.7.53) by SN4PR0701CA0009.namprd07.prod.outlook.com (2603:10b6:803:28::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19 via Frontend Transport; Mon, 4 May 2020 22:09:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588630250; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Zens3A6o9NbP9daceIxMloBRDfkdvy6RIdAPVUIe6Gs=; b=EKSiHKYPtkH2TRl3KJD3UK+NckwCDQzNokO9Nd1d1q4F4i97sCmLkAmm+5hsjZsxRKV6Et bHdk0Hkixgv+1BzLir665IPzdr/EzXXSa33dyd61G0Bx+rxIaihYbn10qBv78QXigyeSrE ct84nR9wfdDFex5xzHPsFWAx5netGWs= X-MC-Unique: 5vuJp52lNRO2X1cG0hSH1A-1 X-MC-Unique: AuawdrsqN3KZfUd63m7dWQ-1 From: Jim Fehlig To: Subject: [PATCH 1/3] libxl: Use the name 'Xen' in driver tables Date: Mon, 4 May 2020 16:09:17 -0600 Message-ID: <20200504220919.23636-2-jfehlig@suse.com> In-Reply-To: <20200504220919.23636-1-jfehlig@suse.com> References: <20200504220919.23636-1-jfehlig@suse.com> X-ClientProxiedBy: SN4PR0701CA0009.namprd07.prod.outlook.com (2603:10b6:803:28::19) To CY4PR1801MB2071.namprd18.prod.outlook.com (2603:10b6:910:79::35) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Originating-IP: [75.169.7.53] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4edae50a-eff1-4c73-2773-08d7f077d818 X-MS-TrafficTypeDiagnostic: CY4PR1801MB2021: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-Forefront-PRVS: 03932714EB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WJ9xVmZMhGwJjKqlsQExRw14qM0twVMvQ7RyMadDOEuQz4t6/l6UlFMBPfJHh2ksyW/dFVfvY0kiGZlvXXmXcEojmmiMJzzAVZoW4Ryy74dITYARm6Yf2vPWpgyXV4XxW39+MJKVC+i5qma9r31L9LoJclijP7f10yYO8iOH+d7x8osPY2c8h+yxAsCAsAIP4yK191Y4fXLpGv32++Bk7lxak7ZhBYwL26tn41cyK154c6ciI4NxGEO7zKpOvAmI/Dy9AmW0xTOohcCWgg1/Mpw8yNgHDlpGuCz8lDVZ+1N1iyd+42YLY071iWJT/1uI4M1Z72+VlWMrMW/04HfMMiNuaf8q7aKflBw46zv/x9nraoTx8Lrt00qSdDEp7fmbrauvNcSc1JVnE4GvKSxtEkjiMn/FIw58Tp5KKkhxnA5tWCL65mwxYW+dBpi4vKbxJkwzmvgvGNSho4pfAan5tLDvCu4wcUoMLri6QyEIy/7VsbyCjcWWaB1oQKWeiQBLXvU1HmOxTsTCRXAj2WekbA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1801MB2071.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(33430700001)(1076003)(2906002)(6486002)(6916009)(8676002)(52116002)(6512007)(478600001)(33440700001)(6506007)(66946007)(4326008)(66556008)(5660300002)(66476007)(316002)(16526019)(956004)(26005)(8936002)(2616005)(36756003)(186003)(6666004)(107886003)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: 9IUqS1WkkxudbFUil49HLAe2MfuOMT/xPWTIMQ8T6aj2ZPS8lviIOwdYivoIGkWtLMQlg8pOhRSYl+EUgoKwGdgHJuuvl3dt5As5js+ccTc+mb6N+OQDM94lYnV7kuhx/HKZIRadMAeIVLngl4Dk7RhOghz+abxjtrks6Wh57HGBgof6XITJyE7gR1fm5U9ZUVv4FfrUJG0/mw3KysmeJS8JPsNc4u18R7/WKr1D8fcT2jikeZ0AAzyCC7BQPmZjN5tzxtNnLtW6WGVb+bg8RnwunbduJUVQnlcu9xaWKnjcc4uRzv18Kqa0pwykC3S4XRrk28/4OhGlIraA752muoB3jt8N5+hOQzNm9+VNo8kKkJdlFkFFmwimiQGRpOK1M1ZjqXExEofpWK4czzKda1Bug5NNjGkBSRqa2nXpG49z3YfvvhAVBtnz8YQDvG8m7CpcQyyDCtgNfP+WArfvNlig1piDIKz3ccKvjJlRcnGfzzzvoD5j7o1WBAgIuL/QZStqGhBHq1yxQ1fEVeCXHGiKRbiNGPBgU8L+Dny+FAPrfKArWHnaYrHn/mBeApeiOePgWfJaLGraprIfZZF2a6fWVdI7E8qaZExz6pMj9igABya5l62kbCTjJHWLRajChHQZT4e8ldry/FDoB9f8qLM0Liv00oDfuWc61+OVrMLKuH5k+jf3IX4bR9KPTYL6Dqz7DZfp99DbeVR5S4AyDWEFXwn8CJiPI3+aE+TmCAPlqTefKdt0T0BGBYRpANfSgqGdOiJqeLxRYTiJehA/W3hXKppnvOhfQDLqM3O7ofA= X-MS-Exchange-CrossTenant-Network-Message-Id: 4edae50a-eff1-4c73-2773-08d7f077d818 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2020 22:09:41.6428 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: izG1rNTiTgLxFIVWON55buyFWJ9owxELKFdHJo3Z8SXnAv1bXtB4odF4OMo5jiKyTJOgV9En6qSC+L+6/31r1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2021 X-OriginatorOrg: suse.com X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 044MAMjc010278 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The libxl driver declares its name as 'Xen' through the public virConnectGetType() API. In the virHypervisorDriver table the name is set to 'xenlight'. To add more confusion, the name is set to 'LIBXL' in the virStateDriver. For consistency, use the same name in the driver tables as reported in the public virConnectGetType() API. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrang=C3=A9 --- src/libxl/libxl_conf.h | 1 + src/libxl/libxl_driver.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index 07b3373170..11a922b10a 100644 --- a/src/libxl/libxl_conf.h +++ b/src/libxl/libxl_conf.h @@ -38,6 +38,7 @@ #include "libxl_capabilities.h" #include "libxl_logger.h" =20 +#define LIBXL_DRIVER_EXTERNAL_NAME "Xen" #define LIBXL_DRIVER_NAME "xenlight" #define LIBXL_VNC_PORT_MIN 5900 #define LIBXL_VNC_PORT_MAX 65535 diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index 980984b199..ebeb91af3c 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -911,7 +911,7 @@ libxlConnectGetType(virConnectPtr conn) if (virConnectGetTypeEnsureACL(conn) < 0) return NULL; =20 - return "Xen"; + return LIBXL_DRIVER_EXTERNAL_NAME; } =20 static int @@ -6608,7 +6608,7 @@ libxlDomainGetMetadata(virDomainPtr dom, } =20 static virHypervisorDriver libxlHypervisorDriver =3D { - .name =3D LIBXL_DRIVER_NAME, + .name =3D LIBXL_DRIVER_EXTERNAL_NAME, .connectURIProbe =3D libxlConnectURIProbe, .connectOpen =3D libxlConnectOpen, /* 0.9.0 */ .connectClose =3D libxlConnectClose, /* 0.9.0 */ @@ -6732,7 +6732,7 @@ static virConnectDriver libxlConnectDriver =3D { }; =20 static virStateDriver libxlStateDriver =3D { - .name =3D "LIBXL", + .name =3D LIBXL_DRIVER_EXTERNAL_NAME, .stateInitialize =3D libxlStateInitialize, .stateCleanup =3D libxlStateCleanup, .stateReload =3D libxlStateReload, --=20 2.26.0 From nobody Sun May 5 14:23:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588630233; cv=none; d=zohomail.com; s=zohoarc; b=Efuguzeg2fsIs1qKEPpWnXzORX6w93LjCQScTIkS3w3SEOPic4aqpogZvVl4fnBQcYYD3zbS80KcfUEbBqswwRhjAHCRKDLhcqgsj/Bbg65PzWZwQTDq1ITCGiFY4fiRJJfCvwjYj8P9c/a+vJDdAbOUXFxtbp8fSKeKQdmAqxg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588630233; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zH4Tp1nXd5ImuI02Wheo5e9yRe7a6pEcbzzeajZgi0o=; b=Ei7O179UAziC7NwGAqrn4oHsxkkA++1zgmtgip6X/uaMKHRcYWka/2jhPR+duWfKFXDXNl8X8TfjR6lvc4Lk4Av6UT4PjsjEPpKF/2bNxutbKZH+WVP9IDhat6XOB6bdQ2LihmiwG42sMJdcJy6ISp90x27AVlw3GTxA7MB8oCs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1588630232975917.9790941076053; Mon, 4 May 2020 15:10:32 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-373-x-drbIgLOfO3u_3o5KBQbQ-1; Mon, 04 May 2020 18:10:29 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 205A9100A625; Mon, 4 May 2020 22:10:24 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3B33605DC; Mon, 4 May 2020 22:10:23 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7C9B9180954D; Mon, 4 May 2020 22:10:22 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 044MAKg7010267 for ; Mon, 4 May 2020 18:10:20 -0400 Received: by smtp.corp.redhat.com (Postfix) id 64E1FB17D2; Mon, 4 May 2020 22:10:20 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 605F6B07BE for ; Mon, 4 May 2020 22:10:20 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 41899101A525 for ; Mon, 4 May 2020 22:10:20 +0000 (UTC) Received: from m4a0072g.houston.softwaregrp.com (m4a0072g.houston.softwaregrp.com [15.124.2.130]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-129-m_C5GqI8N0q8-z4BQmyfEg-1; Mon, 04 May 2020 18:10:18 -0400 Received: FROM m4a0072g.houston.softwaregrp.com (15.120.17.147) BY m4a0072g.houston.softwaregrp.com WITH ESMTP FOR libvir-list@redhat.com; Mon, 4 May 2020 22:09:14 +0000 Received: from M4W0334.microfocus.com (2002:f78:1192::f78:1192) by M4W0335.microfocus.com (2002:f78:1193::f78:1193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 4 May 2020 22:09:43 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.124.8.14) by M4W0334.microfocus.com (15.120.17.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Mon, 4 May 2020 22:09:43 +0000 Received: from CY4PR1801MB2071.namprd18.prod.outlook.com (2603:10b6:910:79::35) by CY4PR1801MB2021.namprd18.prod.outlook.com (2603:10b6:910:7d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Mon, 4 May 2020 22:09:42 +0000 Received: from CY4PR1801MB2071.namprd18.prod.outlook.com ([fe80::ed4d:fafd:1763:cc9c]) by CY4PR1801MB2071.namprd18.prod.outlook.com ([fe80::ed4d:fafd:1763:cc9c%3]) with mapi id 15.20.2958.030; Mon, 4 May 2020 22:09:42 +0000 Received: from linux-tbji.provo.novell.com (75.169.7.53) by SN4PR0701CA0009.namprd07.prod.outlook.com (2603:10b6:803:28::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19 via Frontend Transport; Mon, 4 May 2020 22:09:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588630231; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=zH4Tp1nXd5ImuI02Wheo5e9yRe7a6pEcbzzeajZgi0o=; b=hjG/XNzkv8iYZtxN3HPKGmwupuy3sghZJz3u0olpBhiT5xIUZP8YmNcGQz9Q0EbWf8Yz21 /yg7mocHhnyZk3tydQIXVA7gLp70IjcXLI0v37NMIiQQGs6vNEYGq3dmOYQ2P7XQoRqNGK kr6WbWz/MDhMpHhgu8ryh+LmVgaEwa8= X-MC-Unique: x-drbIgLOfO3u_3o5KBQbQ-1 X-MC-Unique: m_C5GqI8N0q8-z4BQmyfEg-1 From: Jim Fehlig To: Subject: [PATCH 2/3] libxl: Clarify that 'xenlight' should only be used internally Date: Mon, 4 May 2020 16:09:18 -0600 Message-ID: <20200504220919.23636-3-jfehlig@suse.com> In-Reply-To: <20200504220919.23636-1-jfehlig@suse.com> References: <20200504220919.23636-1-jfehlig@suse.com> X-ClientProxiedBy: SN4PR0701CA0009.namprd07.prod.outlook.com (2603:10b6:803:28::19) To CY4PR1801MB2071.namprd18.prod.outlook.com (2603:10b6:910:79::35) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Originating-IP: [75.169.7.53] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 53bddf8b-4abf-4d1d-5ea9-08d7f077d8a5 X-MS-TrafficTypeDiagnostic: CY4PR1801MB2021: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 03932714EB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P0zI424eVxb3allQqknoQ3weFwKvDWCrhXLJVTyYrrBGRJTANloNNeh6G9WbQy/lkz9jO3pRswnLPMWUaNRy4c27cKTqn7cYn/p26LBr66G2xqnXtWYIiWwCOT8HsiqG9NW3mKQX740noybx+VUqXkN0LKH7B1Fwf+D3Yy7lKPDWAZmsH9s8qoHaZL7dyi8RQBiSfpphiloKwEU51N1LPNR4TmAigszH35z+TETDT8dGo62o95JatE1HyEftfZGKT3gp+dJi7/m4EyGcGMOm0MSeU5lDzGXGn3/o06OKZlgRM8yAzqXIy04jptAEyGGHh7KvtUAuqZAlFc0WST0IA5fgX7RelEFYhX26mC/yvYVY9dLut23sKv/vJZsGK9mf1sQDZ11yCoHj7XlYGJmI3HnLeyVIYGnGjfgaherNL5zBUhs7+08rOuosuMkPvVI/kniHNO9Gc3H2pmbiiI+NENyUyPuc02tYD8NZzIkGPspxXHU5yuds4et0gVTfQLW6Qbox9opad50ZRLiohOhwtQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1801MB2071.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(396003)(346002)(136003)(39860400002)(376002)(33430700001)(1076003)(2906002)(6486002)(6916009)(8676002)(52116002)(6512007)(478600001)(33440700001)(6506007)(66946007)(4326008)(66556008)(5660300002)(66476007)(316002)(16526019)(956004)(26005)(8936002)(2616005)(36756003)(186003)(6666004)(107886003)(86362001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: dKlci+STqJE2b/qTvynHOWiypTTe93yRR8ebJvNlh/twdHq0NRDSyG8po9wgfP++wKmzxFAuzuAafKDk+QwdFspv7mw6uxxTnn0s/nbF9cE/pnN5ntQ4PXQNV0YzNFlseWIneGiSB9XIurL9jweRtYihmaYwzMvNnx1r9eIvWl80bqt0hnaYgSD32I0vFaJzRG7zlq+siRcGwHc0muAGsneD4SDZCIagztEcae9CfnCl4zstXN2aHTVkyMu/t2FmJ4Cxabn1+cfYPIkp3vLRdFFqugDIC2FQ8Dtku+zNmmb67zpp7j4VgT4z1P3BUyJWX3EPX55ROT5xYrEqPwAJdd58jYdx+bn6JKbeGZrYNXFf/2zkqug5G6AG1V5Hw4vshRcmotPaXtQYQMUALCJGTLV185Mg/+SVJYOWZhPmoEW8Vl6yGazWQ0VXFwsJ6/oSFrMauNQjihOM62TRvPj9zCgGUV1F094Cs6KlZQ+CiIpxcOBbpPwYdV4bHpr+XVtOk/aqLDP7ZFEMbvLPnOdvuKlkkiLgDYqNwEg4fS53Dfl1PXkUhrwWUeNPqTwhzxp8xda0lMHXzTEOh/jc75rpwSZp8JCGnoMAZhSqSinB81bciCiOxjRc4cP0FIVc7ATtRP/zsCs/N7ToM2WkDHsy1TM8f2Q2OmpKWfWpHBd57OX0HBoAyw7WCNH4U2aGXzO1BipvdznP91OR64lVvR4AjNYhTto//KcjeOv4zi1a38ttk3mboj+X5HXYkWj0gHokxZO0YHVcTwb1f3wUl7loOkD557tmV9/gbn9sjqI6J4I= X-MS-Exchange-CrossTenant-Network-Message-Id: 53bddf8b-4abf-4d1d-5ea9-08d7f077d8a5 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2020 22:09:42.5343 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3TyAZMUTmQitjOS6OC9pjQSkNLWG7bo+pPfP9nBRfPW58Xng8hEwlxXl0YLA74ZUXa7D/WKvFYiEkE8Y8cTG8Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB2021 X-OriginatorOrg: suse.com X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 044MAKg7010267 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The libxl driver has suffered an identity crisis since its introduction. It took on the name 'libxl' since at the time libvirt already contained a 'xen' driver for the old Xen toolstack implementation. 'libxl' is short for libxenlight, which is often called xenlight. Unfortunately all forms of the name are used in the libxl driver. The only remaining use of the 'xenlight' form is when interacting with the host device manager, which is difficult to change since it would cause problems when upgrading the driver. Rename the #define to make it clear the 'xenlight' form is internal and add a comment describing why the name exists and that its use should be discouraged. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrang=C3=A9 --- src/libxl/libxl_conf.h | 7 ++++++- src/libxl/libxl_domain.c | 4 ++-- src/libxl/libxl_driver.c | 14 +++++++------- 3 files changed, 15 insertions(+), 10 deletions(-) diff --git a/src/libxl/libxl_conf.h b/src/libxl/libxl_conf.h index 11a922b10a..b057a9e4ba 100644 --- a/src/libxl/libxl_conf.h +++ b/src/libxl/libxl_conf.h @@ -39,7 +39,12 @@ #include "libxl_logger.h" =20 #define LIBXL_DRIVER_EXTERNAL_NAME "Xen" -#define LIBXL_DRIVER_NAME "xenlight" +/* + * We are stuck with the 'xenlight' name since it is used by the hostdev + * manager. Changing it would break management of any host devices previou= sly + * managed under the name 'xenlight'. + */ +#define LIBXL_DRIVER_INTERNAL_NAME "xenlight" #define LIBXL_VNC_PORT_MIN 5900 #define LIBXL_VNC_PORT_MAX 65535 =20 diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c index cc53a765e1..d9fcde4364 100644 --- a/src/libxl/libxl_domain.c +++ b/src/libxl/libxl_domain.c @@ -873,7 +873,7 @@ libxlDomainCleanup(libxlDriverPrivatePtr driver, VIR_FREE(xml); } =20 - virHostdevReAttachDomainDevices(hostdev_mgr, LIBXL_DRIVER_NAME, + virHostdevReAttachDomainDevices(hostdev_mgr, LIBXL_DRIVER_INTERNAL_NAM= E, vm->def, hostdev_flags, NULL); =20 VIR_FREE(priv->lockState); @@ -1370,7 +1370,7 @@ libxlDomainStart(libxlDriverPrivatePtr driver, if (cfg->autoballoon && libxlDomainFreeMem(cfg->ctx, &d_config) < 0) goto cleanup_dom; =20 - if (virHostdevPrepareDomainDevices(hostdev_mgr, LIBXL_DRIVER_NAME, + if (virHostdevPrepareDomainDevices(hostdev_mgr, LIBXL_DRIVER_INTERNAL_= NAME, vm->def, hostdev_flags) < 0) goto cleanup_dom; =20 diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index ebeb91af3c..63ec0a2188 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -431,7 +431,7 @@ libxlReconnectDomain(virDomainObjPtr vm, libxlLoggerOpenFile(cfg->logger, vm->def->id, vm->def->name, NULL); =20 /* Update hostdev state */ - if (virHostdevUpdateActiveDomainDevices(hostdev_mgr, LIBXL_DRIVER_NAME, + if (virHostdevUpdateActiveDomainDevices(hostdev_mgr, LIBXL_DRIVER_INTE= RNAL_NAME, vm->def, hostdev_flags) < 0) goto error; =20 @@ -3127,7 +3127,7 @@ libxlDomainAttachHostPCIDevice(libxlDriverPrivatePtr = driver, if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs + 1) < 0) goto cleanup; =20 - if (virHostdevPreparePCIDevices(hostdev_mgr, LIBXL_DRIVER_NAME, + if (virHostdevPreparePCIDevices(hostdev_mgr, LIBXL_DRIVER_INTERNAL_NAM= E, vm->def->name, vm->def->uuid, &hostdev, 1, 0) < 0) goto cleanup; @@ -3149,7 +3149,7 @@ libxlDomainAttachHostPCIDevice(libxlDriverPrivatePtr = driver, goto cleanup; =20 error: - virHostdevReAttachPCIDevices(hostdev_mgr, LIBXL_DRIVER_NAME, + virHostdevReAttachPCIDevices(hostdev_mgr, LIBXL_DRIVER_INTERNAL_NAME, vm->def->name, &hostdev, 1, NULL); =20 cleanup: @@ -3264,7 +3264,7 @@ libxlDomainAttachHostUSBDevice(libxlDriverPrivatePtr = driver, if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs + 1) < 0) goto cleanup; =20 - if (virHostdevPrepareUSBDevices(hostdev_mgr, LIBXL_DRIVER_NAME, + if (virHostdevPrepareUSBDevices(hostdev_mgr, LIBXL_DRIVER_INTERNAL_NAM= E, vm->def->name, &hostdev, 1, 0) < 0) goto cleanup; =20 @@ -3284,7 +3284,7 @@ libxlDomainAttachHostUSBDevice(libxlDriverPrivatePtr = driver, goto cleanup; =20 reattach: - virHostdevReAttachUSBDevices(hostdev_mgr, LIBXL_DRIVER_NAME, + virHostdevReAttachUSBDevices(hostdev_mgr, LIBXL_DRIVER_INTERNAL_NAME, vm->def->name, &hostdev, 1); =20 cleanup: @@ -3689,7 +3689,7 @@ libxlDomainDetachHostPCIDevice(libxlDriverPrivatePtr = driver, =20 virDomainHostdevRemove(vm->def, idx); =20 - virHostdevReAttachPCIDevices(hostdev_mgr, LIBXL_DRIVER_NAME, + virHostdevReAttachPCIDevices(hostdev_mgr, LIBXL_DRIVER_INTERNAL_NAME, vm->def->name, &hostdev, 1, NULL); =20 ret =3D 0; @@ -3811,7 +3811,7 @@ libxlDomainDetachHostUSBDevice(libxlDriverPrivatePtr = driver, =20 virDomainHostdevRemove(vm->def, idx); =20 - virHostdevReAttachUSBDevices(hostdev_mgr, LIBXL_DRIVER_NAME, + virHostdevReAttachUSBDevices(hostdev_mgr, LIBXL_DRIVER_INTERNAL_NAME, vm->def->name, &hostdev, 1); =20 ret =3D 0; --=20 2.26.0 From nobody Sun May 5 14:23:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588630231; cv=none; d=zohomail.com; s=zohoarc; b=fEcGzfgPo/Cv+/xCeoCmCIiKRSamI7kgvf8bYk2aJD1dSxg6wltQUvIjkObPqRKOsJueDB+pVvHDM86O0IAb9VDN0nY4RkqBcrJfGIiZU8OvuJPqx1vwsajAmr7GVswgth7/qg1mwhGJbqhEmMB3SCYNT41Y+PZpB42OL7AsNjo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588630231; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XlLQdZrdUWW47GDSThn/KA10yG7v7wLzH1bGsDvU7HQ=; b=fugMJzqtddtpKmNVuZGIGow8vbWpwhQ69pwVL5zAa0dkqdCwq3c71lHus02WqQquf6KT0aPrluqYvDMJQZgN5m6Mvd4BKrtPxgQFEwa5uLt8jONOjzx1Qj9FYX257bMBThgRfUkqyajgDiXaxY7MVvLDwpTVIgEoYn+BwxHuodE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1588630231442293.97808654726373; Mon, 4 May 2020 15:10:31 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-witQx8wxPPa7ylZyOzh8kQ-1; Mon, 04 May 2020 18:10:27 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 64FF08014D9; Mon, 4 May 2020 22:10:21 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A7265C1B2; Mon, 4 May 2020 22:10:19 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8DE4D1809542; Mon, 4 May 2020 22:10:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 044MAE0B010240 for ; Mon, 4 May 2020 18:10:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 6E756B0793; Mon, 4 May 2020 22:10:14 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 697DBB07BE for ; Mon, 4 May 2020 22:10:09 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B1D721859160 for ; Mon, 4 May 2020 22:10:09 +0000 (UTC) Received: from m9a0014g.houston.softwaregrp.com (m9a0014g.houston.softwaregrp.com [15.124.64.90]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-459-_NYJA-RDPyqrnDy-6pXD1Q-1; Mon, 04 May 2020 18:10:07 -0400 Received: FROM m9a0014g.houston.softwaregrp.com (15.121.0.190) BY m9a0014g.houston.softwaregrp.com WITH ESMTP FOR libvir-list@redhat.com; Mon, 4 May 2020 22:09:27 +0000 Received: from M9W0067.microfocus.com (2002:f79:be::f79:be) by M9W0067.microfocus.com (2002:f79:be::f79:be) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 4 May 2020 22:09:44 +0000 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (15.124.72.14) by M9W0067.microfocus.com (15.121.0.190) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Mon, 4 May 2020 22:09:44 +0000 Received: from CY4PR1801MB2071.namprd18.prod.outlook.com (2603:10b6:910:79::35) by CY4PR1801MB1927.namprd18.prod.outlook.com (2603:10b6:910:79::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Mon, 4 May 2020 22:09:43 +0000 Received: from CY4PR1801MB2071.namprd18.prod.outlook.com ([fe80::ed4d:fafd:1763:cc9c]) by CY4PR1801MB2071.namprd18.prod.outlook.com ([fe80::ed4d:fafd:1763:cc9c%3]) with mapi id 15.20.2958.030; Mon, 4 May 2020 22:09:43 +0000 Received: from linux-tbji.provo.novell.com (75.169.7.53) by SN4PR0701CA0009.namprd07.prod.outlook.com (2603:10b6:803:28::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.19 via Frontend Transport; Mon, 4 May 2020 22:09:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588630230; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=XlLQdZrdUWW47GDSThn/KA10yG7v7wLzH1bGsDvU7HQ=; b=CLIbS6JqnNxYHcGYYjZ0RakWAKyYfKiFhdxt5WUWOkMBgjT3+g8p0q40FlpCyO0u1jJarG WNDH6U3hqixnU+POXRpsKs6eFzJpLZOV7/TDOqPvLsVYNL0f9oXi8cg7ZRH9XboNExbRSl 0ugqVFuTP1iwYEjqBguG+bie7IJK+6k= X-MC-Unique: witQx8wxPPa7ylZyOzh8kQ-1 X-MC-Unique: _NYJA-RDPyqrnDy-6pXD1Q-1 From: Jim Fehlig To: Subject: [PATCH 3/3] docs: Xen improvements Date: Mon, 4 May 2020 16:09:19 -0600 Message-ID: <20200504220919.23636-4-jfehlig@suse.com> In-Reply-To: <20200504220919.23636-1-jfehlig@suse.com> References: <20200504220919.23636-1-jfehlig@suse.com> X-ClientProxiedBy: SN4PR0701CA0009.namprd07.prod.outlook.com (2603:10b6:803:28::19) To CY4PR1801MB2071.namprd18.prod.outlook.com (2603:10b6:910:79::35) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Originating-IP: [75.169.7.53] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d49c56cf-fd65-45c4-9d96-08d7f077d940 X-MS-TrafficTypeDiagnostic: CY4PR1801MB1927: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-Forefront-PRVS: 03932714EB X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TVpzexM8NpgmyoJrXxXC36wmbhoijv9rO1eeXf9+rfsu23IlsDn5Z7QP8i/2HFpte/D2ys3Hw/0kSZNVOX6GYJ2dMvNb4bEy05Q9+7OeK4l6xNP156DWFWsKv/F2uDu2K2n4j9sl+TH8rv4gk6dekUp2coMAeJ4BcWLGPyyMmAhY19WitA94zQcxg26GzbuhGiBjhWJH4e3Gwrp9s4RqxeOJNRrutmtP8vSAczYcv7/4qttK0OkK2YlzTy4mVNDZspMbcSRks3VZQlR7omSmS1cTp46djv9ZT1iVhhd2zjP9RQTEY5FzTh4qtnSAJR8igrPuoFck5Nxo9XwNH/i/KLvaaxVuoY8CTmBl3T34WxgZOX+TFeE6zEdWPS04MwfyAvOFElig+a5lN+L3YtcX+8MDNH3zeE2JyOS3ajOXyDMWGCIbYrckIAo9EVg9V1PNKjCGrnHqr87MtDmWsLYZvJsNLn2+lfstkaPQD39dg1V8gB7ZnhX39iHSWgtTZ/ECwXLcIjXsZQ+hS1sB9R+pHw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR1801MB2071.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(376002)(396003)(136003)(39860400002)(366004)(33430700001)(6666004)(66476007)(52116002)(478600001)(86362001)(36756003)(8676002)(33440700001)(26005)(6486002)(6506007)(316002)(107886003)(4326008)(956004)(1076003)(5660300002)(186003)(8936002)(2616005)(16526019)(66556008)(66946007)(6512007)(6916009)(2906002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: zmNb2QC8Mse9cAFirPKvbcgjCAR3x4uld07yYYaPsO4Jx96V2v81oC/QvVnMJHQO9t482vQl84WZdWagfi5GXtNXA464K1nAuxQtQsBn3brt/q1NtmFxjCfHy+7NN6fupv+xJDA0vJFkMveSo85wkZO+ZH5f7iLeiC+OnK01MqB1pPSUc8KcnLCbx44lmPDGRe621wqzu7pWlRQXqCH2YNlon05yZY/q2EQ9T+pC1kL7Whv/urpN1a59xGBuSjZkgn5hlgoppPt0N/MylEBoLXnW0KUs/mklYWwUGiD0aoyD3p7jhpLyOF4UB+rz/Id8RxNyQHzfnfm/6WqJ9j9HhwYj+C7ZVaY/uyxMakk/7icagWAzekLnUTY8cJ+uadoIFFfteyTgNV9SqD9bPj3qMPVwGnVgUUNfDpK+ymybSXGajBvE4UKIA5DM8cZezl8dnxhRnH1rEi4uobFo6Xl4F2UvceBL1sPLvw1nIRHQBDgGmbmG6JQyxFx+5G9aXl2IB64HDWdCVWLmyWmiqqQM+Y5/ZJdE8+IcCsQt6HH34MDx/1IZTc2bAh7T1OEBJmYDA/gsSocWzM39hyGvSXNWyZCEtgfah4I1RWG9l5ufU05kbLzmBfSaToLG1KY3xhtqYLrDXnlcvOrhqTaPhlK0aDXGsYGvkgxk5m4lzkNAm4LDcUp542NBDAhOq7XtkttUnue6fX/XaMdupcrKiBbWAwXtyClJsS+NafzV/MxwjJu4ykoE7yEkBwnKFQg361TcPQpqYCEHPSc4nwgi/SUjlBtS48UTpEsQiK4P1XNyyUs= X-MS-Exchange-CrossTenant-Network-Message-Id: d49c56cf-fd65-45c4-9d96-08d7f077d940 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 May 2020 22:09:43.4958 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KZbqhRPr+EZwPdEHl1FK+T+vnnT8TOVbpkmyRaz8YKTmd6dFqhP5qbdfhkPoPhszfeacyWcMokT+NGu0GmdAwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1927 X-OriginatorOrg: suse.com X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 044MAE0B010240 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" In formatdomain, using 'libxl' and 'xen' is redundant since they now both refer to the same driver. 'xen' predates 'libxl' and unambiguously identifies the Xen hypervisor, so drop the use of 'libxl'. In aclpolkit, the connection URI was erroneously identified as 'libxl' and the name 'xenlight'. Change the URI to 'xen' and driver name to 'Xen'. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrang=C3=A9 --- docs/aclpolkit.html.in | 4 ++-- docs/formatdomain.html.in | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/aclpolkit.html.in b/docs/aclpolkit.html.in index 04cb39006a..3e5d30a5dd 100644 --- a/docs/aclpolkit.html.in +++ b/docs/aclpolkit.html.in @@ -342,8 +342,8 @@ interface - libxl - xenlight + xen + Xen lxc diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 91d6f6c0d3..23eb029234 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -2533,8 +2533,8 @@ The name attribute selects which timer is being modified, and can be one of "platform" (currently unsupported), - "hpet" (libxl, xen, qemu, lxc), "kvmclock" (qemu), - "pit" (qemu), "rtc" (qemu, lxc), "tsc" (libxl, qemu - + "hpet" (xen, qemu, lxc), "kvmclock" (qemu), + "pit" (qemu), "rtc" (qemu, lxc), "tsc" (xen, qemu - since 3.2.0), "hypervclock" (qemu - since 1.2.2) or "armvtimer" (qemu - since 6.1.0). @@ -7518,7 +7518,7 @@ qemu-kvm -net nic,model=3D? /dev/null

You can provide the amount of video memory in kibibytes (blocks = of 1024 bytes) using vram. This is supported only for = guest - type of "libxl", "vz", "qemu", "vbox", "vmx" and "xen". If no + type of "vz", "qemu", "vbox", "vmx" and "xen". If no value is provided the default is used. If the size is not a powe= r of two it will be rounded to closest one.

--=20 2.26.0