From nobody Mon May 6 18:55:08 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1588610922; cv=none; d=zohomail.com; s=zohoarc; b=Ps2MwhwYGRHQ6DF0yFkvGJLMA1j+R2nQZK4l3a/z7tIapelw22xHehlTVxhB29yilj+uaCojQAJ/Y44P9kV6Iu8HfSnBBRukyR7d6sxCMJQQd/+/B6Hc6y1uvZpFiq58htjIQVFI4XL/UkreSX9GGQCVIy2M5g3ZFARSVPDVh1U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1588610922; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Esf3cwj6HyfxdWJ4RV/bKcLsKQxPKbEXkTQIE0DQu7E=; b=g2y9R8vykfuPuggC/T6ObAH9DmWlx7c6ZkHrNo07qkbhAntrm2Mm4/SiscEtw+hoOfvjHVb15molJoZEGrsNobTXTwnSqrqVJDvbfndOmk+a8fEb52TShV49C5zWW6CfRqXPECBrOAJlBZYQIcIDpF/r7UPFsToSB7V4z1rL5CQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1588610922435900.0361502499917; Mon, 4 May 2020 09:48:42 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-KaybhO7bOh-UNgou6W70mQ-1; Mon, 04 May 2020 12:48:37 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B5A6B1840422; Mon, 4 May 2020 16:48:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A02D5C1BD; Mon, 4 May 2020 16:48:29 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 72ADC1809542; Mon, 4 May 2020 16:48:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 044GmOXQ010782 for ; Mon, 4 May 2020 12:48:24 -0400 Received: by smtp.corp.redhat.com (Postfix) id E735770525; Mon, 4 May 2020 16:48:24 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.36.110.51]) by smtp.corp.redhat.com (Postfix) with ESMTP id CD6016F133; Mon, 4 May 2020 16:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588610921; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Esf3cwj6HyfxdWJ4RV/bKcLsKQxPKbEXkTQIE0DQu7E=; b=SpniJYIH5hRt/PIf6Kfg1VCzjlOy3I8YZ2XfwoR+5xrbXckwbx8dzBmgiPl7xGHfnBWyqj +LA7wmF8Av7als7IqgnLXuUAfGHzYx+FPPUTYmIjvin6xXHEIuNo0LPKkhPO15RuxVvzlh hwq2MRM1/B+9IBPBMV1Ukv9NczvjoNQ= X-MC-Unique: KaybhO7bOh-UNgou6W70mQ-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH] remote: fix driver name check for libxl driver Date: Mon, 4 May 2020 17:48:18 +0100 Message-Id: <20200504164818.758508-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: PGNet Dev X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The virConnectGetType() returns "xenlight" for libxl, not "LIBXL". This prevents users opening a connection to the libxl driver when using the modular daemons. Signed-off-by: Daniel P. Berrang=C3=A9 --- src/remote/remote_daemon_dispatch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon= _dispatch.c index 5d1c6971c0..a8ac795d71 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -2111,7 +2111,7 @@ remoteDispatchConnectOpen(virNetServerPtr server G_GN= UC_UNUSED, =20 VIR_DEBUG("Primary driver type is '%s'", type); if (STREQ(type, "QEMU") || - STREQ(type, "LIBXL") || + STREQ(type, "xenlight") || STREQ(type, "LXC") || STREQ(type, "VBOX") || STREQ(type, "bhyve") || --=20 2.26.2