From nobody Sun Apr 28 20:09:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1587984884; cv=none; d=zohomail.com; s=zohoarc; b=kHmfS3DUgv2B71kec/KjeyOhJh+4J0gzRoMxNzWRk5cN5KWhKP3UARZM7DXozfq72+0SqAucW4oGd7r1sQcPr+JXHUYkBDMNKFm1Vx2dyiOOWk9t2oRwPOUPd7uP249wWyHJC5Uy3QiFO7zdvogeH9n2q65s8u60n9lMxr3b1oA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587984884; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VUuehnNqkkZf0nBlZp4XSJ2hP6a71enznW77+DSNNx4=; b=TgmepoV8LRrY6YyxLw5F1i/7SmS+hotszFKgC+769MW46aKlD2qDKlNrDSqaNzsPOJmo6goSHDOH1HUW5fcjXxZhhH/Vl9vS9M7DVZ8oPMQUVAQP3JRYT1Zq/yfEypSvlVar58XMeU+TTMS9+Bxzk6QV6g7QdJqI7T/B17+I/LU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1587984884148119.90837111920314; Mon, 27 Apr 2020 03:54:44 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-153-REX-x5-4OPK47OoqwuDvSQ-1; Mon, 27 Apr 2020 06:54:40 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 60EAD1005510; Mon, 27 Apr 2020 10:54:35 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C68915D9DA; Mon, 27 Apr 2020 10:54:34 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8F2824CA95; Mon, 27 Apr 2020 10:54:33 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 03RAsVJG031990 for ; Mon, 27 Apr 2020 06:54:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 0E6F5196B8; Mon, 27 Apr 2020 10:54:31 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.40.195.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3167A60F8A for ; Mon, 27 Apr 2020 10:54:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587984882; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=VUuehnNqkkZf0nBlZp4XSJ2hP6a71enznW77+DSNNx4=; b=dc8lJ2hAVaCTc8xShoG4ZvE4mhQUWTGdBP69nEdU/8njNSq7UQEvKD9UedGvbvRIJM36Fn wfFebMtiSHQNcM2wEeYImxM0L0f+sgYkZ8K8hTGSWELPCO5UslKkU50JcTc+SPy02uRER1 66KFiEsH6qsjXl8PG4RUFx1sf/F944Y= X-MC-Unique: REX-x5-4OPK47OoqwuDvSQ-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 1/2] CONTRIBUTING: Indent command by three spaces Date: Mon, 27 Apr 2020 12:54:20 +0200 Message-Id: <20200427105421.59888-2-abologna@redhat.com> In-Reply-To: <20200427105421.59888-1-abologna@redhat.com> References: <20200427105421.59888-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" This is the proper way to do it according to our reStructuredText style guidelines. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- CONTRIBUTING.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index f476700fdd..12b6e3f0e8 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -12,9 +12,9 @@ your git clone run: =20 :: =20 - $ mkdir build && cd build - $ ../autogen.sh - $ make + $ mkdir build && cd build + $ ../autogen.sh + $ make =20 You'll find the freshly-built document in ``docs/contribute.html``. =20 @@ -23,13 +23,13 @@ up your system by calling =20 :: =20 - $ sudo dnf builddep libvirt + $ sudo dnf builddep libvirt =20 if you're on a RHEL-based distribution or =20 :: =20 - $ sudo apt-get build-dep libvirt + $ sudo apt-get build-dep libvirt =20 if you're on a Debian-based one. =20 --=20 2.25.4 From nobody Sun Apr 28 20:09:23 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1587984897; cv=none; d=zohomail.com; s=zohoarc; b=YsraPpCCloq3T/j0A78sIUROYfQXE1Nxn+uVUL4RvUcbGoW23hjqX0coNq3ps+oKiKktD4awIz3sWOY2F0U8EJyLJrJFdSmTaPjveDS+9X5GwYKNXSNZxI+DFOnVIiWYfMXouRSVNRQFf14MPRpeBfuJ4FXtIkqZcPIBCqjtpPY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1587984897; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2bhCzdM6bCdACXgoKHp4WpsAMB+/5HfULS6Np7mCUec=; b=HGEfE/VI6WAMvn7Qb8FmKRa4SQBTOcws++E2Kvjbnl8IIyJgFPPeCPhLZCTOp5xujycZoFH/D/EL1dNdSywMxLIu+lfw6t+XksFnEBl8EvZSahg0bDX1boAffQMKATDMGKlI5/oQIDiS7bh6ntuxCpsGkt8puA5ihyPYglu6CLQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1587984897279369.9959672241355; Mon, 27 Apr 2020 03:54:57 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-1bgcNUK5NcmHAKuV17PzxQ-1; Mon, 27 Apr 2020 06:54:53 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 74072800685; Mon, 27 Apr 2020 10:54:48 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BF3C5C221; Mon, 27 Apr 2020 10:54:48 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F3EBB4A71F; Mon, 27 Apr 2020 10:54:47 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 03RAsXWL032001 for ; Mon, 27 Apr 2020 06:54:33 -0400 Received: by smtp.corp.redhat.com (Postfix) id E058060F8A; Mon, 27 Apr 2020 10:54:33 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.40.195.42]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DFC31610B0 for ; Mon, 27 Apr 2020 10:54:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587984895; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2bhCzdM6bCdACXgoKHp4WpsAMB+/5HfULS6Np7mCUec=; b=V83Q4qgp2tcL7PdZRb0fzdcuMdXmUyf/AMt5UJX7msJL5OWWhuAJYBNBxI/gpn/wGFiPan PM8srvweGj904SYpIOWtuXSx05iADn8joaIjhIDjS7pOCuPbuja9hcq/k0FgFgJgXGggWn 7tqM2ZhFMyPZXRWkTc5kJ6S0HkjuG3g= X-MC-Unique: 1bgcNUK5NcmHAKuV17PzxQ-1 From: Andrea Bolognani To: libvir-list@redhat.com Subject: [libvirt PATCH 2/2] CONTRIBUTING: Include note about build system tools Date: Mon, 27 Apr 2020 12:54:21 +0200 Message-Id: <20200427105421.59888-3-abologna@redhat.com> In-Reply-To: <20200427105421.59888-1-abologna@redhat.com> References: <20200427105421.59888-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Debian always runs autoreconf at package build time, which means that apt-get build-dep will bring in everything that's needed to build libvirt from a git clone; Fedora and RHEL, however, skip this step, so we have to install some extra packages manually. Signed-off-by: Andrea Bolognani --- CONTRIBUTING.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst index 12b6e3f0e8..32829b1d96 100644 --- a/CONTRIBUTING.rst +++ b/CONTRIBUTING.rst @@ -33,6 +33,15 @@ if you're on a RHEL-based distribution or =20 if you're on a Debian-based one. =20 +Note that, for the RHEL-based case, if you're on a machine where you +haven't done any C development before, you will probably also need +to run + +:: + + $ sudo dnf groupinstall "C Development Tools and Libraries" + $ sudo dnf install rpm-build + You might still be missing some dependencies if your distribution is shipping an old libvirt version, but that will get you much closer to where you need to be to build successfully from source. --=20 2.25.4