From nobody Mon Feb 9 08:24:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1586366661; cv=none; d=zohomail.com; s=zohoarc; b=KB0s1u0ndtkYuHoL/tgre5OKJlEi/LRWbpI1cBHQ2rtyqFYavw0J8jSK4N7o9UCh/73V5EpZtgoODBQzOixHUMcHDO2TgbUaOMMYFd0AyLb/ruPiE3lrg9cgEJhRGH+2aIGR7mfqKXyoKq0ps4m2O8ECXXauX8/3QzhX56iZz6k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586366661; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xYISHm4kUvPDwcjvyKDDp3goK3Kj5c5qXXOzVwoR88g=; b=m0E2Me2UIO0oxvL1kWPCHn2SrrfAnQANlIutlCRz3FI0ihTkNk+dWMPiQ+SvBDYXbJ5rNncXLRN/ZdOkUoDhDXleCyJibaXZPN/BYX0ZnklqE724dCFau+fUsmBy0OSZj/DXJXcbV/kRtv+xrDfCcBpdsLpFvyBvEijxEDVSAIc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1586366661739943.2282132072612; Wed, 8 Apr 2020 10:24:21 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-69-RqA5jIzsMlK24aKEph7V2Q-1; Wed, 08 Apr 2020 13:24:14 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6873A1005F84; Wed, 8 Apr 2020 17:24:08 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 396EC5D9CA; Wed, 8 Apr 2020 17:24:08 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id DAC6F93A94; Wed, 8 Apr 2020 17:24:07 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 038HO63u026742 for ; Wed, 8 Apr 2020 13:24:06 -0400 Received: by smtp.corp.redhat.com (Postfix) id B12DE9DD75; Wed, 8 Apr 2020 17:24:06 +0000 (UTC) Received: from localhost (unknown [10.36.110.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 57E159DD6B; Wed, 8 Apr 2020 17:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586366660; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=xYISHm4kUvPDwcjvyKDDp3goK3Kj5c5qXXOzVwoR88g=; b=KfVedCzzKCsB0gSpr85q1L6FiYni8+EnEw0/Lfgv9NzJsjaozReB7XFjVjcFmEptxOd/aU CSz7UI/+/fRAWg6E5xaLImJmSNbDbEdXk9w5PJ7Ssyopi3fHYMrl4qbwd8mq7VutNFE3oQ qAkJn/1cZGQlVKQBv4/H4/jhpduJeKI= X-MC-Unique: RqA5jIzsMlK24aKEph7V2Q-1 From: marcandre.lureau@redhat.com To: libvir-list@redhat.com Subject: [libvirt PATCH 1/6] slirp: leave the dbus daemon running on error Date: Wed, 8 Apr 2020 19:23:46 +0200 Message-Id: <20200408172351.4103413-2-marcandre.lureau@redhat.com> In-Reply-To: <20200408172351.4103413-1-marcandre.lureau@redhat.com> References: <20200408172351.4103413-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , phrdina@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau Don't stop the DBus daemon if a slirp helper failed to start, as it may be shared with other helpers. Signed-off-by: Marc-Andr=C3=A9 Lureau Reviewed-by: Michal Privoznik --- src/qemu/qemu_slirp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_slirp.c b/src/qemu/qemu_slirp.c index 09c1247892..49bffa01b8 100644 --- a/src/qemu/qemu_slirp.c +++ b/src/qemu/qemu_slirp.c @@ -355,6 +355,6 @@ qemuSlirpStart(qemuSlirpPtr slirp, virProcessKillPainfully(pid, true); if (pidfile) unlink(pidfile); - qemuDBusStop(driver, vm); + /* leave dbus daemon running, it may be used by others */ return -1; } --=20 2.26.0.106.g9fadedd637 From nobody Mon Feb 9 08:24:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1586366666; cv=none; d=zohomail.com; s=zohoarc; b=RbnxvwS1mle8ygMYIyzACokD1bLJ43VojkDtmIhNRm5pFyau8VLMXGao+5/EekVVe17f5/UHcUA5bXEX77LpkQJctIe4tz7awlOYUR+4AbH1a/XngO8VHoTQQb7SVmUpfoGOF9Tt0loFzdjGaN1mU0Z6FTvxdP+bX9uXvCkGOrQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586366666; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BRu/GbJJ5klRbVJBWFTLZHlnHlqAubVHQ43TdJ1A4YQ=; b=IdrWiV+s+KWTe6iIn+hNLLNXYXTci7vbIEfHdACtJUnahHtItedwMtuAaeGiXa3C+VnsmV58Rxf9eUy2yxp0o2RfouOQoGbVYAVUgzjuJzgB6D4rOdd8QVVSXOlSvf+79zqrKUJgT/EfM98CVglQ7zITybF+6U5S7YqrwVgPUDc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1586366666203258.04748264750424; Wed, 8 Apr 2020 10:24:26 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-3W4V3yBeNiiuVr3b1sPSwA-1; Wed, 08 Apr 2020 13:24:22 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C3CAA18FE863; Wed, 8 Apr 2020 17:24:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 958315DA84; Wed, 8 Apr 2020 17:24:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 3A71018089CD; Wed, 8 Apr 2020 17:24:16 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 038HOE5W026767 for ; Wed, 8 Apr 2020 13:24:14 -0400 Received: by smtp.corp.redhat.com (Postfix) id 5159C5DA88; Wed, 8 Apr 2020 17:24:14 +0000 (UTC) Received: from localhost (unknown [10.36.110.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 18C525DA84; Wed, 8 Apr 2020 17:24:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586366664; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=BRu/GbJJ5klRbVJBWFTLZHlnHlqAubVHQ43TdJ1A4YQ=; b=LJX0RiEvnd4ziBSF8f6OVgkwFKPGs64xVFB3Me4y+h/lV/Lyc0VTpCHVgTmK7qhGMTOSBB J94QTKI/Wse3AZr34k0X0AhJM4F3v8HgXkE+YaoKv5FsSj4NIsopU8fkPmdNTGx0gC/0m4 nCKkFFKZnmFQ311GgcvYXA+yl8CVCFs= X-MC-Unique: 3W4V3yBeNiiuVr3b1sPSwA-1 From: marcandre.lureau@redhat.com To: libvir-list@redhat.com Subject: [libvirt PATCH 2/6] slirp: add helper to VM cgroup Date: Wed, 8 Apr 2020 19:23:47 +0200 Message-Id: <20200408172351.4103413-3-marcandre.lureau@redhat.com> In-Reply-To: <20200408172351.4103413-1-marcandre.lureau@redhat.com> References: <20200408172351.4103413-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , phrdina@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau The slirp helper process should be associated with the VM cgroup, like other helpers. Signed-off-by: Marc-Andr=C3=A9 Lureau --- src/qemu/qemu_extdevice.c | 8 ++++++++ src/qemu/qemu_slirp.c | 14 ++++++++++++++ src/qemu/qemu_slirp.h | 3 +++ 3 files changed, 25 insertions(+) diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c index 5a31b4d66e..dae3524307 100644 --- a/src/qemu/qemu_extdevice.c +++ b/src/qemu/qemu_extdevice.c @@ -284,6 +284,14 @@ qemuExtDevicesSetupCgroup(virQEMUDriverPtr driver, return -1; } =20 + for (i =3D 0; i < def->nnets; i++) { + virDomainNetDefPtr net =3D def->nets[i]; + qemuSlirpPtr slirp =3D QEMU_DOMAIN_NETWORK_PRIVATE(net)->slirp; + + if (slirp && qemuSlirpSetupCgroup(slirp, cgroup) < 0) + return -1; + } + if (def->tpm && qemuExtTPMSetupCgroup(driver, def, cgroup) < 0) return -1; diff --git a/src/qemu/qemu_slirp.c b/src/qemu/qemu_slirp.c index 49bffa01b8..71dbded607 100644 --- a/src/qemu/qemu_slirp.c +++ b/src/qemu/qemu_slirp.c @@ -242,6 +242,14 @@ qemuSlirpStop(qemuSlirpPtr slirp, } =20 =20 +int +qemuSlirpSetupCgroup(qemuSlirpPtr slirp, + virCgroupPtr cgroup) +{ + return virCgroupAddProcess(cgroup, slirp->pid); +} + + int qemuSlirpStart(qemuSlirpPtr slirp, virDomainObjPtr vm, @@ -249,6 +257,7 @@ qemuSlirpStart(qemuSlirpPtr slirp, virDomainNetDefPtr net, bool incoming) { + qemuDomainObjPrivatePtr priv =3D vm->privateData; g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); g_autoptr(virCommand) cmd =3D NULL; g_autofree char *pidfile =3D NULL; @@ -348,6 +357,10 @@ qemuSlirpStart(qemuSlirpPtr slirp, } =20 slirp->pid =3D pid; + + if (priv->cgroup && qemuSlirpSetupCgroup(slirp, priv->cgroup) < 0) + goto error; + return 0; =20 error: @@ -355,6 +368,7 @@ qemuSlirpStart(qemuSlirpPtr slirp, virProcessKillPainfully(pid, true); if (pidfile) unlink(pidfile); + slirp->pid =3D 0; /* leave dbus daemon running, it may be used by others */ return -1; } diff --git a/src/qemu/qemu_slirp.h b/src/qemu/qemu_slirp.h index 5bf9596053..e1db908814 100644 --- a/src/qemu/qemu_slirp.h +++ b/src/qemu/qemu_slirp.h @@ -75,4 +75,7 @@ void qemuSlirpStop(qemuSlirpPtr slirp, =20 int qemuSlirpGetFD(qemuSlirpPtr slirp); =20 +int qemuSlirpSetupCgroup(qemuSlirpPtr slirp, + virCgroupPtr cgroup); + G_DEFINE_AUTOPTR_CLEANUP_FUNC(qemuSlirp, qemuSlirpFree); --=20 2.26.0.106.g9fadedd637 From nobody Mon Feb 9 08:24:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1586366668; cv=none; d=zohomail.com; s=zohoarc; b=dbS6FS83kCxb0wWsm+G0lhj907CpB1uFKtTJq+4FD3aH67gSw+i8a+0xBprx9ccvlwDIFgLWy0zUdjdHe0gzZ2PYUMck3va1AFn0LiQobieo38vjxIAWzk44hmfE5LSMDRJxUqTmOaJAWspwmErlmLpd5RxUhEMsKEFDMW+w3Sg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586366668; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NWRI1wuInJmyCPKwdX9JpPMR94vN57VM0/CpS1n2D08=; b=ny79dmSi4J6h9QfL27v5HIdbOca/RcVkatTG5Q/XmQO0Q+QajkpEP31evvheYcmWAsdjquSipG6h3D5s7gQlUs4ul+Ar5p7x2llxTMPufyX66cKsSKAW5tgyqEhX2BR4DPnKOd72OkhAhviLuhSEC4sUWDJ+W6nzZVxvVQz5Y7M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1586366668734811.8887570839731; Wed, 8 Apr 2020 10:24:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-462-iwR9dT6FMmyXlRhKhqsDow-1; Wed, 08 Apr 2020 13:24:23 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 782C810CE784; Wed, 8 Apr 2020 17:24:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 495EB277AD; Wed, 8 Apr 2020 17:24:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id F2D6718089CE; Wed, 8 Apr 2020 17:24:17 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 038HOGk3026780 for ; Wed, 8 Apr 2020 13:24:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id ABC3699E03; Wed, 8 Apr 2020 17:24:16 +0000 (UTC) Received: from localhost (unknown [10.36.110.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D1A95C1C6; Wed, 8 Apr 2020 17:24:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586366666; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=NWRI1wuInJmyCPKwdX9JpPMR94vN57VM0/CpS1n2D08=; b=Ri5cZdWvx0wdPt4qZ8DVPbNZd/LPT0jdbGkXAfkrt3r2HfSQ83fMjXne+5xwYi21bemeDF OA7SCD3vXk4dUoVX4TU5eoJrPwtQyI5e0540msB2tOfCOIt1iHC4t4Nevw8xZaib4wEseN B+6ihAsXBUNxOToVDBhvVVDX0QqG+cs= X-MC-Unique: iwR9dT6FMmyXlRhKhqsDow-1 From: marcandre.lureau@redhat.com To: libvir-list@redhat.com Subject: [libvirt PATCH 3/6] qemu-dbus: prevent double start of the bus daemon Date: Wed, 8 Apr 2020 19:23:48 +0200 Message-Id: <20200408172351.4103413-4-marcandre.lureau@redhat.com> In-Reply-To: <20200408172351.4103413-1-marcandre.lureau@redhat.com> References: <20200408172351.4103413-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , phrdina@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau Allow calling qemuDBusStart() multiple times (as may be done by qemu-slirp already). Signed-off-by: Marc-Andr=C3=A9 Lureau --- src/qemu/qemu_dbus.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c index f3e6f3ee37..ae55bbb299 100644 --- a/src/qemu/qemu_dbus.c +++ b/src/qemu/qemu_dbus.c @@ -177,6 +177,9 @@ qemuDBusStart(virQEMUDriverPtr driver, pid_t cpid =3D -1; int ret =3D -1; =20 + if (priv->dbusDaemonRunning) + return 0; + if (!virFileIsExecutable(cfg->dbusDaemonName)) { virReportSystemError(errno, _("'%s' is not a suitable dbus-daemon"), --=20 2.26.0.106.g9fadedd637 From nobody Mon Feb 9 08:24:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) client-ip=205.139.110.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1586366671; cv=none; d=zohomail.com; s=zohoarc; b=IesKpN8eDASwWqK9mFc/4mRxtl1RoX0P/bwkBoKvUCMwXLX07XUZCSIY/rgEG6epKfGhnJjf7ZiGeAKme+wJ5r/2f2MEyYqcAh4okY4oKhGjmrKSuLBK70JgYIx02wWG60ox8fzrx/AXxhEfcnkorlHzaBgApEk3Bw7HPPukwD4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586366671; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5mLmsiPiVvdJ5i5+/tn7aam6C/eZ9ZtS+1vky4GYNd4=; b=a6qoitgio8WkarmaYoet3pOntP3xB75nVZS48j0Fji56Q1Pyv2MSE7UGzI2Uyb1dHRHcV8ZGKkjsQX1brB1c4pIFJ6KhvOnYj5QT8dusJzUSf27uv+aDG1ZdNkQq3bEKa+yOvQ/b0rg++TB9rtjR2yfpzwvHWPc315f0tcwzWoU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by mx.zohomail.com with SMTPS id 1586366671625476.9007592867607; Wed, 8 Apr 2020 10:24:31 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-RoGlAef0MwKkBRMKu9qnlw-1; Wed, 08 Apr 2020 13:24:27 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 510DD801FA0; Wed, 8 Apr 2020 17:24:22 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1C4BDC0DA3; Wed, 8 Apr 2020 17:24:22 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id B0CCB18089D6; Wed, 8 Apr 2020 17:24:21 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 038HOIKK026792 for ; Wed, 8 Apr 2020 13:24:18 -0400 Received: by smtp.corp.redhat.com (Postfix) id B500599E03; Wed, 8 Apr 2020 17:24:18 +0000 (UTC) Received: from localhost (unknown [10.36.110.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 380305C1C6; Wed, 8 Apr 2020 17:24:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586366670; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=5mLmsiPiVvdJ5i5+/tn7aam6C/eZ9ZtS+1vky4GYNd4=; b=itu6ECyZ7nNkNodPnn969WHCzBOLWypz7xxUpMdsj/qLGviTprw92DfYsuIYNSDgd9VhnU XeYCVdKw2QVVLmzUHZ8V1e5NkHc66tg9+GU7/rFfGUTTl8IcY1GVT7lq7V4stwAfWLvhZ9 8Ni0fywLkavlPOyNHRU0lzVxLKIhcSE= X-MC-Unique: RoGlAef0MwKkBRMKu9qnlw-1 From: marcandre.lureau@redhat.com To: libvir-list@redhat.com Subject: [libvirt PATCH 4/6] qemu-dbus: remove unused variable Date: Wed, 8 Apr 2020 19:23:49 +0200 Message-Id: <20200408172351.4103413-5-marcandre.lureau@redhat.com> In-Reply-To: <20200408172351.4103413-1-marcandre.lureau@redhat.com> References: <20200408172351.4103413-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , phrdina@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau Signed-off-by: Marc-Andr=C3=A9 Lureau --- src/qemu/qemu_dbus.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c index ae55bbb299..02dc3ebf07 100644 --- a/src/qemu/qemu_dbus.c +++ b/src/qemu/qemu_dbus.c @@ -142,13 +142,11 @@ qemuDBusStop(virQEMUDriverPtr driver, qemuDomainObjPrivatePtr priv =3D vm->privateData; g_autofree char *shortName =3D NULL; g_autofree char *pidfile =3D NULL; - g_autofree char *configfile =3D NULL; =20 if (!(shortName =3D virDomainDefGetShortName(vm->def))) return; =20 pidfile =3D qemuDBusCreatePidFilename(cfg, shortName); - configfile =3D qemuDBusCreateConfPath(cfg, shortName); =20 if (virPidFileForceCleanupPath(pidfile) < 0) { VIR_WARN("Unable to kill dbus-daemon process"); --=20 2.26.0.106.g9fadedd637 From nobody Mon Feb 9 08:24:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1586366707; cv=none; d=zohomail.com; s=zohoarc; b=UmpEM83AbYTcKJ7MLK60UZV+aR0tnQPvJq9jCnccClJxU41qW6lq7lgQtGrelhoJAt+wL6LbcNMWbFP5Auv3kLeU19xXtFxT8VCU1IY8AyWJSn8waGwbb/FKOWdNDXXxleqjbouAuJKMMsq4/u7iiepdwKV5AWR9QQ5IBBUpKIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586366707; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8DKZrjPBDZy+ixYyo//Ukwt6VvkmYVC73EzGoFDuvZw=; b=Oy4grZC68z7/7fpbYTNGqG6rY7IugIFDk8ERNbUwckn1pNfp8Zn3YUs6/epomaJmcoWpTHs+XaZl3TKR4EaZ0Qw6mRzI/pObx7PIyF1dkP9va+hwZRZPmYITyEYRG0j+p/OFMdbrfT4AWNC2TFedosJLVyXjnw1kkUI6N92fizs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1586366707673853.1788175884531; Wed, 8 Apr 2020 10:25:07 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-ziK5NG5mMOyU-gB4wOZVaA-1; Wed, 08 Apr 2020 13:24:34 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7075C801FB1; Wed, 8 Apr 2020 17:24:28 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 320A0277C1; Wed, 8 Apr 2020 17:24:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D231193A9D; Wed, 8 Apr 2020 17:24:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 038HOQgE026808 for ; Wed, 8 Apr 2020 13:24:26 -0400 Received: by smtp.corp.redhat.com (Postfix) id AF3CC1195B3; Wed, 8 Apr 2020 17:24:26 +0000 (UTC) Received: from localhost (unknown [10.36.110.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5CCF31195AF; Wed, 8 Apr 2020 17:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586366706; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8DKZrjPBDZy+ixYyo//Ukwt6VvkmYVC73EzGoFDuvZw=; b=UOPzRyQmc0mN4T30sNeJ2QbrvYYzQWc2qjp1RcHVwNIX61HQheH+YDU6fVJAO02nXCvorX 1qd4yh0pXnJNY2MQwHNfCi/7XdU708sEcy7GAyyX2gTDEcfiCtn0wD/NPEsU1nSbt9aZSG WuafO8F5V1cs4GaRgGHyWBOLn5J4V+g= X-MC-Unique: ziK5NG5mMOyU-gB4wOZVaA-1 From: marcandre.lureau@redhat.com To: libvir-list@redhat.com Subject: [libvirt PATCH 5/6] qemu-dbus: register DBus bus to the VM cgroup Date: Wed, 8 Apr 2020 19:23:50 +0200 Message-Id: <20200408172351.4103413-6-marcandre.lureau@redhat.com> In-Reply-To: <20200408172351.4103413-1-marcandre.lureau@redhat.com> References: <20200408172351.4103413-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , phrdina@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau External devices are started before cgroup is created. Add the DBus daemon to the VM cgroup with the rest of the external devices. Signed-off-by: Marc-Andr=C3=A9 Lureau --- src/qemu/qemu_dbus.c | 24 ++++++++++++++++++++++++ src/qemu/qemu_dbus.h | 3 +++ src/qemu/qemu_extdevice.c | 4 ++++ 3 files changed, 31 insertions(+) diff --git a/src/qemu/qemu_dbus.c b/src/qemu/qemu_dbus.c index 02dc3ebf07..53f6c45986 100644 --- a/src/qemu/qemu_dbus.c +++ b/src/qemu/qemu_dbus.c @@ -156,6 +156,30 @@ qemuDBusStop(virQEMUDriverPtr driver, } =20 =20 +int +qemuDBusSetupCgroup(virQEMUDriverPtr driver, + virDomainObjPtr vm) +{ + g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); + qemuDomainObjPrivatePtr priv =3D vm->privateData; + g_autofree char *shortName =3D NULL; + g_autofree char *pidfile =3D NULL; + pid_t cpid =3D -1; + + if (!priv->dbusDaemonRunning) + return 0; + + if (!(shortName =3D virDomainDefGetShortName(vm->def))) + return -1; + pidfile =3D qemuDBusCreatePidFilename(cfg, shortName); + if (virPidFileReadPath(pidfile, &cpid) < 0) { + VIR_WARN("Unable to get DBus PID"); + return -1; + } + + return virCgroupAddProcess(priv->cgroup, cpid); +} + int qemuDBusStart(virQEMUDriverPtr driver, virDomainObjPtr vm) diff --git a/src/qemu/qemu_dbus.h b/src/qemu/qemu_dbus.h index a96f19ac0d..474eb1058b 100644 --- a/src/qemu/qemu_dbus.h +++ b/src/qemu/qemu_dbus.h @@ -35,3 +35,6 @@ void qemuDBusStop(virQEMUDriverPtr driver, int qemuDBusVMStateAdd(virDomainObjPtr vm, const char *id); =20 void qemuDBusVMStateRemove(virDomainObjPtr vm, const char *id); + +int qemuDBusSetupCgroup(virQEMUDriverPtr driver, + virDomainObjPtr vm); diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c index dae3524307..2096272761 100644 --- a/src/qemu/qemu_extdevice.c +++ b/src/qemu/qemu_extdevice.c @@ -23,6 +23,7 @@ #include "qemu_command.h" #include "qemu_extdevice.h" #include "qemu_vhost_user_gpu.h" +#include "qemu_dbus.h" #include "qemu_domain.h" #include "qemu_tpm.h" #include "qemu_slirp.h" @@ -276,6 +277,9 @@ qemuExtDevicesSetupCgroup(virQEMUDriverPtr driver, virDomainDefPtr def =3D vm->def; size_t i; =20 + if (qemuDBusSetupCgroup(driver, vm) < 0) + return -1; + for (i =3D 0; i < def->nvideos; i++) { virDomainVideoDefPtr video =3D def->videos[i]; =20 --=20 2.26.0.106.g9fadedd637 From nobody Mon Feb 9 08:24:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1586366688; cv=none; d=zohomail.com; s=zohoarc; b=J6aLXV/m7h2heBCe1UnOhmEYSsuMyR4EupO2tDQRERrRsOCj8ldKT4rKtojTn8NlezLxAavPSkDZR7B2mQV7Oz7vrz2w2MG+36axIPjnR4qQRBgnc/fw2Ds7xlrlUD0JCs7lD67BVvtspadT7YkjUFo+CRpHoPsaOGyZs22jw0c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586366688; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Jbm4Uy6oH4IBtJSspavYwEDDhW0Nsqh8bS9ogF0PJ48=; b=TEsVYdDpyFkobT8ga3HAmFMvKxvAkCxNjBgCXbbcRqKr73IsH8syixmkJxWFUM8mynTlOlhkYqst6BP1msUtYjtMv3upXjUQ1Jj+EvgBkx9Su6c8TkIiH0je6Gdmwrz8o0HWXZze+dumitq4KormePfNWCmhv5LKotFC+LTcKSI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1586366688271903.1358642292713; Wed, 8 Apr 2020 10:24:48 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-285-TbtOyDnVMhmqmh5jMoPXjg-1; Wed, 08 Apr 2020 13:24:44 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F416D800D53; Wed, 8 Apr 2020 17:24:37 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CB3EF5DA81; Wed, 8 Apr 2020 17:24:37 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8534218089C8; Wed, 8 Apr 2020 17:24:37 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 038HOaPg026831 for ; Wed, 8 Apr 2020 13:24:36 -0400 Received: by smtp.corp.redhat.com (Postfix) id D0A95C0DAA; Wed, 8 Apr 2020 17:24:36 +0000 (UTC) Received: from localhost (unknown [10.36.110.2]) by smtp.corp.redhat.com (Postfix) with ESMTP id DB02CC0DAB; Wed, 8 Apr 2020 17:24:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586366687; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=Jbm4Uy6oH4IBtJSspavYwEDDhW0Nsqh8bS9ogF0PJ48=; b=doOefm4/qZk2gg1YzROVJviVqHCMgX6jthNCNlw/qxxVhn8dADdZG/FS/j+WFkHwabnWN9 GIC19Cb8vqnZO5q7i9FlUAI4H0ANUAqSASWZc9XFQUQq9X2ScxH2DRF0F5Z+42PrzjujNz 5IfFK+IL6rHf10yHbQmXvni+8VxUWbk= X-MC-Unique: TbtOyDnVMhmqmh5jMoPXjg-1 From: marcandre.lureau@redhat.com To: libvir-list@redhat.com Subject: [libvirt PATCH 6/6] qemu-cgroup: remove unnecessary include Date: Wed, 8 Apr 2020 19:23:51 +0200 Message-Id: <20200408172351.4103413-7-marcandre.lureau@redhat.com> In-Reply-To: <20200408172351.4103413-1-marcandre.lureau@redhat.com> References: <20200408172351.4103413-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , phrdina@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau The file doesn't use virSystemd functions directly. Signed-off-by: Marc-Andr=C3=A9 Lureau --- src/qemu/qemu_cgroup.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2afe22f177..2e019b64af 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -36,7 +36,6 @@ #include "virfile.h" #include "virtypedparam.h" #include "virnuma.h" -#include "virsystemd.h" #include "virdevmapper.h" #include "virutil.h" =20 --=20 2.26.0.106.g9fadedd637