From nobody Tue Feb 10 01:35:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) client-ip=207.211.31.120; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1586208508; cv=none; d=zohomail.com; s=zohoarc; b=CQjSHT0FyL7WMSi5/gn8zKmzCsoXOEVF+E9tQalQtc89s0czVJGbL3pHxejueo/vdlnGqgdXShSzMQG3o9GgQ+fsJWhS3rCrXdOX0PZEuJKrZasFdXyC1c8jpl1TJwzyNitMTpqptEmd2pjCa8wf0XWUMnaerorAsU6MPRdgyic= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586208508; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ifmBDePo6CRQEH8xeA6Qk5cQpUvsn0SHZia40yXwpVk=; b=Zdk+cf8+9vvz9AcYTG2/w6WC2F+pVVGwWqCi2oQ7UApd3RQwStagT+azmUt3UBCq8+uywWZYwYAoVnbw5TmIZg5a86ejLo7V2qzIwAtJC+g22lwm/PjbLXr6+RwznDbr8YZxH/ofpQPANT1vkQ+iHmmC4vq46ZKC3yCtd/Xgpqk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by mx.zohomail.com with SMTPS id 1586208508199761.2537591107283; Mon, 6 Apr 2020 14:28:28 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-J4X91-nEPBqZska-yZZ1KQ-1; Mon, 06 Apr 2020 17:28:24 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 98FD4149C2; Mon, 6 Apr 2020 21:28:18 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 62F829D379; Mon, 6 Apr 2020 21:28:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1009B18089D5; Mon, 6 Apr 2020 21:28:18 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 036LSGe6015807 for ; Mon, 6 Apr 2020 17:28:16 -0400 Received: by smtp.corp.redhat.com (Postfix) id 91CFE10372C4; Mon, 6 Apr 2020 21:28:16 +0000 (UTC) Received: from localhost (unknown [10.36.110.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 01BF71036B47; Mon, 6 Apr 2020 21:28:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586208507; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ifmBDePo6CRQEH8xeA6Qk5cQpUvsn0SHZia40yXwpVk=; b=TKIQSr1uKQ0xXGFj1CWEiz7srXRfyTF6AHopeIPgYulnBmC2bRN+eqk7wO0HFbtifCEkK2 6mDKDSo8Wcmnn3hM+F6DIpOhDn8mJ8Ae06PEcntRk3REs6WkHlFwR6OQIHb/u9/L2COiAB sZrna7SXsnPi3zMFm9YfWSvh4lM+Yj4= X-MC-Unique: J4X91-nEPBqZska-yZZ1KQ-1 From: marcandre.lureau@redhat.com To: libvir-list@redhat.com Subject: [libvirt PATCH 09/15] systemd: check org.freedesktop.machine1 registration Date: Mon, 6 Apr 2020 23:27:06 +0200 Message-Id: <20200406212712.1315604-10-marcandre.lureau@redhat.com> In-Reply-To: <20200406212712.1315604-1-marcandre.lureau@redhat.com> References: <20200406212712.1315604-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-loop: libvir-list@redhat.com Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , phrdina@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Marc-Andr=C3=A9 Lureau Since commit f10bd740e178c89f24d0b0298d0b5413537d0699 ("Cache the presence of machine1 service"), the code checks for systemd1 registration. Not totally unreasonable, but that seems odd since we actually check machined presence in this function. Signed-off-by: Marc-Andr=C3=A9 Lureau --- src/util/virsystemd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virsystemd.c b/src/util/virsystemd.c index 9a659dad84..74d0d15ca7 100644 --- a/src/util/virsystemd.c +++ b/src/util/virsystemd.c @@ -163,7 +163,7 @@ virSystemdHasMachined(void) return ret; } =20 - if ((ret =3D virDBusSystemIsServiceRegistered("org.freedesktop.systemd= 1")) =3D=3D -1) + if ((ret =3D virDBusSystemIsServiceRegistered("org.freedesktop.machine= 1")) =3D=3D -1) return ret; g_atomic_int_set(&virSystemdHasMachinedCachedValue, ret); return ret; --=20 2.26.0.rc2.42.g98cedd0233