From nobody Tue Feb 10 00:21:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1586181128; cv=none; d=zohomail.com; s=zohoarc; b=NtJ1XqpqoRSQkbpqylFVL82BLIhkM7FWviD6VWO18N3VcNYXY88+24hGZLa4qfQpMj4BKp9nkUI6t8IyYMpqQuWwKtnBQljFV6/xh+rUDFzSKat7mOLk/Y8HwXGZB5eRX6DMLm4GQtQCegKGwebBgyif0yT4JBpPBrbm4HGK7ZY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1586181128; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0VqjLvdQt1sdVFlWPUlxYQVgn6oNO/kFyysbrHGVAhY=; b=LSJa/o2RO/bomA9j2WEJC+ANcX9paVs77o3NypxdEbqiiRFAMQDrZu2Y17eC5TOYqiQi8x8Eg4yKe2bOeacCO5eFyj7YaclH9lOOcbtIrxm1KYj1drcoqUxXUn3CjvxkgSZTqUcvHiZqz1y1ioyPDXXgsbdBcqxnZy7CeULVX10= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1586181128495863.1472843369429; Mon, 6 Apr 2020 06:52:08 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-293-nM4icadrNKWBXaaBLKSbaQ-1; Mon, 06 Apr 2020 09:52:05 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0790D18B9FC7; Mon, 6 Apr 2020 13:51:59 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D422662697; Mon, 6 Apr 2020 13:51:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9460318089CF; Mon, 6 Apr 2020 13:51:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 036DpiNj018404 for ; Mon, 6 Apr 2020 09:51:44 -0400 Received: by smtp.corp.redhat.com (Postfix) id D99FE5C1BB; Mon, 6 Apr 2020 13:51:44 +0000 (UTC) Received: from vhost2.laine.org (ovpn-112-243.phx2.redhat.com [10.3.112.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8E25D5C1B0 for ; Mon, 6 Apr 2020 13:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586181127; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=0VqjLvdQt1sdVFlWPUlxYQVgn6oNO/kFyysbrHGVAhY=; b=dDH9XFqyCHm8o/ndDgbHtJz2e9XKQ0FznjDctagJxa9qD7HtGwu3F/6OgyUvlIPhrKZRKB 829wHnCAy6yYL1nKEJppcfeFcndc3E4/gjZneOAea9Y5Ogst6a84fIY8vwvgkp54rsBnMT T54SC6gpmUM0CX+LXHelJdBZ23Y89Eo= X-MC-Unique: nM4icadrNKWBXaaBLKSbaQ-1 From: Laine Stump To: libvir-list@redhat.com Subject: [libvirt PATCH 10/10] conf: during PCI hotplug, require that the controller support hotplug Date: Mon, 6 Apr 2020 09:51:30 -0400 Message-Id: <20200406135130.3080946-11-laine@redhat.com> In-Reply-To: <20200406135130.3080946-1-laine@redhat.com> References: <20200406135130.3080946-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Before this patch we would simply rely on QEMU failing to attach the device. Since we have a flag in the address set telling us which controllers support hotplug, we can fail the operation sooner. This also assures that when hotplugging with no provided PCI address, that we skip any controllers with hotplug=3D'off', and attempt to assign the device to a controller that not only supports hotplug, but also has it enabled. Signed-off-by: Laine Stump --- src/conf/domain_addr.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 580cf7e64d..5652bc9a33 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -931,6 +931,11 @@ virDomainPCIAddressEnsureAddr(virDomainPCIAddressSetPt= r addrs, if (!flags) return 0; =20 + /* This function is only called during hotplug, so we require hotplug + * support from the controller. + */ + flags |=3D VIR_PCI_CONNECT_HOTPLUGGABLE; + if (!(addrStr =3D virPCIDeviceAddressAsString(&dev->addr.pci))) return -1; =20 --=20 2.25.2