From nobody Wed May 15 14:12:07 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
207.211.31.120 as permitted sender) client-ip=207.211.31.120;
envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail(p=none dis=none) header.from=linux.ibm.com
ARC-Seal: i=1; a=rsa-sha256; t=1586178837; cv=none;
d=zohomail.com; s=zohoarc;
b=Ba1nlmd9vRCpKqwYR3jIWF+n5pCSeDD9hGNCLwOXh7ygP3zqh+YokGpeLDYliG5Cqcg6gbPyL3apb+tx05nZC0wvCmGhrxVs6HFTGLD2TNKxSDdh22BZoIoB6gFesXNKE5Fj1PexLEpvzZbss9lEj2SLaDJCenm7Doci5ncnUAE=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1586178837;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=Z83mxLdMo8Ik+uwQo2qJm41jWzrwdCFb13JAk9MnGzE=;
b=fFig8piDam4iTjGolufjuObxcTHW+ZpU6j7mhsrEi3WCSPszrUxulgDwT9wsuFBgpkpkQ5cDoaiup5zQFu9JXP4loJpwtNhvuhxM50Z6D6PuPLBEidWhViUjtwVy/c+9io+k+S1QbtNdJ9jy6afgTWH/BMwXCsR8vDn1VxBsrVg=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[207.211.31.120]) by mx.zohomail.com
with SMTPS id 1586178837446566.0351504411739;
Mon, 6 Apr 2020 06:13:57 -0700 (PDT)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-495-4hkQMtNePaaW_ciH3aCiZA-1; Mon, 06 Apr 2020 09:13:52 -0400
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
[10.5.11.13])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0A291DBAA;
Mon, 6 Apr 2020 13:13:47 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
by smtp.corp.redhat.com (Postfix) with ESMTPS id AAEF19D378;
Mon, 6 Apr 2020 13:13:46 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id 5335B93A71;
Mon, 6 Apr 2020 13:13:43 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
[10.11.54.3])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 036DDfLt015063 for ;
Mon, 6 Apr 2020 09:13:41 -0400
Received: by smtp.corp.redhat.com (Postfix)
id 5E1E8100321B; Mon, 6 Apr 2020 13:13:41 +0000 (UTC)
Received: from mimecast-mx02.redhat.com
(mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 5A741100333B
for ; Mon, 6 Apr 2020 13:13:38 +0000 (UTC)
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[205.139.110.120])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD3888FF67D
for ; Mon, 6 Apr 2020 13:13:38 +0000 (UTC)
Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com
[148.163.158.5]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-344-TvZigVAgNd6pM21_K1z7Qg-1; Mon, 06 Apr 2020 09:13:36 -0400
Received: from pps.filterd (m0098421.ppops.net [127.0.0.1])
by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
036D3hmA127996
for ; Mon, 6 Apr 2020 09:13:36 -0400
Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99])
by mx0a-001b2d01.pphosted.com with ESMTP id 3082n8vjr5-1
(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)
for ; Mon, 06 Apr 2020 09:13:35 -0400
Received: from localhost
by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
Only! Violators will be prosecuted
for from ;
Mon, 6 Apr 2020 14:13:22 +0100
Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194)
by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway:
Authorized Use Only! Violators will be prosecuted;
(version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256)
Mon, 6 Apr 2020 14:13:21 +0100
Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com
[9.149.105.61])
by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
ESMTP id 036DDVYR65208456
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
verify=OK); Mon, 6 Apr 2020 13:13:31 GMT
Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id E6B8C11C05C;
Mon, 6 Apr 2020 13:13:30 +0000 (GMT)
Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id C44BB11C058;
Mon, 6 Apr 2020 13:13:30 +0000 (GMT)
Received: from m46lp64.lnxne.boe (unknown [9.152.108.100])
by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;
Mon, 6 Apr 2020 13:13:30 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1586178836;
h=from:from:sender:sender:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:list-id:list-help:
list-unsubscribe:list-subscribe:list-post;
bh=Z83mxLdMo8Ik+uwQo2qJm41jWzrwdCFb13JAk9MnGzE=;
b=HoN0HPg6hnOQLCyvngxcTlCfkPm2+Q9L4N/MTHOHy34laJKv6riCigO/6AIiH7Qwx9WB5J
XMnq8WL+2vxQdOD1SPAqjIw6gcE/+k4u3yg8xzuK7xhRAbmG1UVAYYTFykKzO31LNlrXbQ
tO+Sf+uWZXC6yzwZQUeEbl3yfAnKWhw=
X-MC-Unique: 4hkQMtNePaaW_ciH3aCiZA-1
X-MC-Unique: TvZigVAgNd6pM21_K1z7Qg-1
From: Bjoern Walk
To: libvir-list@redhat.com
Subject: [PATCH v2 1/4] qemu: capabilities: add 'packed' capability
Date: Mon, 6 Apr 2020 15:13:24 +0200
In-Reply-To: <20200406131327.780751-1-bwalk@linux.ibm.com>
References: <20200406131327.780751-1-bwalk@linux.ibm.com>
MIME-Version: 1.0
X-TM-AS-GCONF: 00
x-cbid: 20040613-0012-0000-0000-0000039F57E3
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 20040613-0013-0000-0000-000021DC75CD
Message-Id: <20200406131327.780751-2-bwalk@linux.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676
definitions=2020-04-06_07:2020-04-06,
2020-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
bulkscore=0
priorityscore=1501 suspectscore=1 mlxscore=0 phishscore=0 spamscore=0
malwarescore=0 clxscore=1015 impostorscore=0 mlxlogscore=999
adultscore=0
lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2003020000 definitions=main-2004060109
X-MIME-Autoconverted: from 8bit to quoted-printable by
mx0a-001b2d01.pphosted.com id 036D3hmA127996
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-MIME-Autoconverted: from quoted-printable to 8bit by
lists01.pubmisc.prod.ext.phx2.redhat.com id 036DDfLt015063
X-loop: libvir-list@redhat.com
Cc: Bjoern Walk
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"
Add the capability for QEMU's packed virtqueues for virtio that supposedly =
have
better cache utilization and performance compared to the default split queu=
es.
Reviewed-by: J=C3=A1n Tomko
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
Reviewed-by: Marc Hartmayer
---
src/qemu/qemu_capabilities.c | 6 ++++++
src/qemu/qemu_capabilities.h | 1 +
tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml | 1 +
tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml | 1 +
tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 +
tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 1 +
7 files changed, 12 insertions(+)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 994f1fd1..ae1aefec 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -571,6 +571,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
=20
/* 360 */
"fsdev.multidevs",
+ "virtio.packed",
);
=20
=20
@@ -1295,6 +1296,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic=
ePropsVirtioBalloon[] =3D {
{ "disable-legacy", QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY },
{ "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM },
{ "ats", QEMU_CAPS_VIRTIO_PCI_ATS },
+ { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES },
};
=20
static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVirtioBlk[] =3D=
{
@@ -1309,6 +1311,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic=
ePropsVirtioBlk[] =3D {
{ "ats", QEMU_CAPS_VIRTIO_PCI_ATS },
{ "write-cache", QEMU_CAPS_DISK_WRITE_CACHE },
{ "werror", QEMU_CAPS_STORAGE_WERROR },
+ { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES },
};
=20
static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVirtioNet[] =3D=
{
@@ -1321,6 +1324,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic=
ePropsVirtioNet[] =3D {
{ "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM },
{ "ats", QEMU_CAPS_VIRTIO_PCI_ATS },
{ "failover", QEMU_CAPS_VIRTIO_NET_FAILOVER },
+ { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES },
};
=20
static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsSpaprPCIHostBri=
dge[] =3D {
@@ -1332,6 +1336,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic=
ePropsVirtioSCSI[] =3D {
{ "disable-legacy", QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY },
{ "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM },
{ "ats", QEMU_CAPS_VIRTIO_PCI_ATS },
+ { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES },
};
=20
static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVfioPCI[] =3D {
@@ -1401,6 +1406,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic=
ePropsVirtioGpu[] =3D {
{ "disable-legacy", QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY },
{ "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM },
{ "ats", QEMU_CAPS_VIRTIO_PCI_ATS },
+ { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES },
};
=20
static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsICH9[] =3D {
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index d247e197..47767938 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -552,6 +552,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for =
syntax-check */
=20
/* 360 */
QEMU_CAPS_FSDEV_MULTIDEVS, /* fsdev.multidevs */
+ QEMU_CAPS_VIRTIO_PACKED_QUEUES, /* virtio.packed */
=20
QEMU_CAPS_LAST /* this must always be the last item */
} virQEMUCapsFlags;
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml b/tests/qemu=
capabilitiesdata/caps_4.2.0.aarch64.xml
index eac189c4..e994aa79 100644
--- a/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml
@@ -181,6 +181,7 @@
+ 4001050061700242
diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml b/tests/qemuc=
apabilitiesdata/caps_4.2.0.x86_64.xml
index ad904d86..a1994603 100644
--- a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml
@@ -225,6 +225,7 @@
+ 4002000043100242
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml b/tests/qemu=
capabilitiesdata/caps_5.0.0.aarch64.xml
index 30664c62..3876d08c 100644
--- a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml
@@ -183,6 +183,7 @@
+ 4002050061700241
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml b/tests/qemuca=
pabilitiesdata/caps_5.0.0.ppc64.xml
index a6800482..b0891613 100644
--- a/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml
@@ -191,6 +191,7 @@
+ 4002050042900241
diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml b/tests/qemuc=
apabilitiesdata/caps_5.0.0.x86_64.xml
index df3557d1..b73c4efd 100644
--- a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml
@@ -228,6 +228,7 @@
+ 4002091043100241
--=20
2.24.1
From nobody Wed May 15 14:12:07 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
207.211.31.120 as permitted sender) client-ip=207.211.31.120;
envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail(p=none dis=none) header.from=linux.ibm.com
ARC-Seal: i=1; a=rsa-sha256; t=1586178848; cv=none;
d=zohomail.com; s=zohoarc;
b=BIhIxW63SCY9uqdM2r5f3lFLhaxh2S+1d9XNMjOyjfvqvn0pkKtlJ8Wla51jePHbASklLMITi8v6/gGX85HvzCnf6gzeO4O1XYf3bl6rrTAlh3yWU1TqB9PpWN+IbPLew8PqcfYPcCiDJg/N/Ir7xIlkdo4g9fRhA6cIUyFkj6Y=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1586178848;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=/+q7yfYdE78tn8o+FykL+tXqVEO5z5oQ5WEn0LBnWuc=;
b=jQsfKMdEy0qL0Vayrvsf4L4K+JvrPjdRmocB2Egx4dsYdXf0jrNm4M3gKMypUZYUSZGeCaBJvjQBgdn4tdLhEJdkESD50Zg5aQe5DEWM4KbVvWqFMAg9Cd8kNtKc53D6YKKFrB4lI/YTQVXPgKhTsb3Sr26hQjyLh/epjDTgrU8=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[207.211.31.120]) by mx.zohomail.com
with SMTPS id 1586178848101769.0635658964592;
Mon, 6 Apr 2020 06:14:08 -0700 (PDT)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-435-oyKe2mwFOK6SlKQcF2P0eA-1; Mon, 06 Apr 2020 09:14:05 -0400
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6E3B718A8C81;
Mon, 6 Apr 2020 13:13:59 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 3A6971036D33;
Mon, 6 Apr 2020 13:13:59 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id E2DEE93A75;
Mon, 6 Apr 2020 13:13:58 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
[10.11.54.3])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 036DDf3G015068 for ;
Mon, 6 Apr 2020 09:13:42 -0400
Received: by smtp.corp.redhat.com (Postfix)
id DE27A100321B; Mon, 6 Apr 2020 13:13:41 +0000 (UTC)
Received: from mimecast-mx02.redhat.com
(mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22])
by smtp.corp.redhat.com (Postfix) with ESMTPS id DA4C3100333B
for ; Mon, 6 Apr 2020 13:13:41 +0000 (UTC)
Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com
[205.139.110.61])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C118B185A795
for ; Mon, 6 Apr 2020 13:13:41 +0000 (UTC)
Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com
[148.163.158.5]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-310-1u4d1-oJNsGiX8pqEoLqOA-1; Mon, 06 Apr 2020 09:13:39 -0400
Received: from pps.filterd (m0098421.ppops.net [127.0.0.1])
by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
036D3hw4128038
for ; Mon, 6 Apr 2020 09:13:37 -0400
Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100])
by mx0a-001b2d01.pphosted.com with ESMTP id 3082n8vjs9-1
(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)
for ; Mon, 06 Apr 2020 09:13:37 -0400
Received: from localhost
by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
Only! Violators will be prosecuted
for from ;
Mon, 6 Apr 2020 14:13:13 +0100
Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197)
by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway:
Authorized Use Only! Violators will be prosecuted;
(version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256)
Mon, 6 Apr 2020 14:13:11 +0100
Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com
[9.149.105.61])
by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
ESMTP id 036DDWWH34275452
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
verify=OK); Mon, 6 Apr 2020 13:13:32 GMT
Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id 473A311C04C;
Mon, 6 Apr 2020 13:13:32 +0000 (GMT)
Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id 2493011C058;
Mon, 6 Apr 2020 13:13:32 +0000 (GMT)
Received: from m46lp64.lnxne.boe (unknown [9.152.108.100])
by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;
Mon, 6 Apr 2020 13:13:32 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1586178846;
h=from:from:sender:sender:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:list-id:list-help:
list-unsubscribe:list-subscribe:list-post;
bh=/+q7yfYdE78tn8o+FykL+tXqVEO5z5oQ5WEn0LBnWuc=;
b=hNlqymHAVAq4siWO+EIIE7ByicI/RVCC2kS2pReTpy3caxs7v79it4tnmfEsHyGUPgVU+G
UZGAWpTBN63yrvzWJ27MYVSeu+tiRSAFxk2WbSVtzfG45kGR82OXvGIsvFLdiemEUCzEck
4dK0aMy7rptg/OIG8uYzuKjaB80boh8=
X-MC-Unique: oyKe2mwFOK6SlKQcF2P0eA-1
X-MC-Unique: 1u4d1-oJNsGiX8pqEoLqOA-1
From: Bjoern Walk
To: libvir-list@redhat.com
Subject: [PATCH v2 2/4] conf: domain: support for virtio packed option
Date: Mon, 6 Apr 2020 15:13:25 +0200
In-Reply-To: <20200406131327.780751-1-bwalk@linux.ibm.com>
References: <20200406131327.780751-1-bwalk@linux.ibm.com>
MIME-Version: 1.0
X-TM-AS-GCONF: 00
x-cbid: 20040613-0016-0000-0000-000002FF61A8
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 20040613-0017-0000-0000-0000336337F0
Message-Id: <20200406131327.780751-3-bwalk@linux.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676
definitions=2020-04-06_07:2020-04-06,
2020-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
bulkscore=0
priorityscore=1501 suspectscore=3 mlxscore=0 phishscore=0 spamscore=0
malwarescore=0 clxscore=1015 impostorscore=0 mlxlogscore=999
adultscore=0
lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2003020000 definitions=main-2004060109
X-MIME-Autoconverted: from 8bit to quoted-printable by
mx0a-001b2d01.pphosted.com id 036D3hw4128038
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-MIME-Autoconverted: from quoted-printable to 8bit by
lists01.pubmisc.prod.ext.phx2.redhat.com id 036DDf3G015068
X-loop: libvir-list@redhat.com
Cc: Bjoern Walk
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"
Expose the virtio parameter for packed virtqueues as an optional libvirt
XML attribute to virtio-backed devices, e.g.:
If the attribute is omitted, the default value for this attribute is 'off' =
and
regular split virtqueues are used.
Reviewed-by: J=C3=A1n Tomko
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
Reviewed-by: Marc Hartmayer
---
docs/schemas/domaincommon.rng | 5 +++++
src/conf/domain_conf.c | 28 ++++++++++++++++++++++++++++
src/conf/domain_conf.h | 1 +
3 files changed, 34 insertions(+)
diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
index dcf2e09d..12e842ce 100644
--- a/docs/schemas/domaincommon.rng
+++ b/docs/schemas/domaincommon.rng
@@ -5961,6 +5961,11 @@
+
+
+
+
+
=20
diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index 460f8064..51fd5f15 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -1513,6 +1513,16 @@ virDomainVirtioOptionsParseXML(xmlNodePtr driver,
}
res->ats =3D val;
}
+ VIR_FREE(str);
+
+ if ((str =3D virXMLPropString(driver, "packed"))) {
+ if ((val =3D virTristateSwitchTypeFromString(str)) <=3D 0) {
+ virReportError(VIR_ERR_XML_ERROR, "%s",
+ _("invalid packed value"));
+ return -1;
+ }
+ res->packed =3D val;
+ }
=20
return 0;
}
@@ -5092,6 +5102,12 @@ virDomainCheckVirtioOptions(virDomainVirtioOptionsPt=
r virtio)
"for virtio devices"));
return -1;
}
+ if (virtio->packed !=3D VIR_TRISTATE_SWITCH_ABSENT) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+ _("packed driver option is only supported "
+ "for virtio devices"));
+ return -1;
+ }
return 0;
}
=20
@@ -7378,6 +7394,10 @@ virDomainVirtioOptionsFormat(virBufferPtr buf,
virBufferAsprintf(buf, " ats=3D'%s'",
virTristateSwitchTypeToString(virtio->ats));
}
+ if (virtio->packed !=3D VIR_TRISTATE_SWITCH_ABSENT) {
+ virBufferAsprintf(buf, " packed=3D'%s'",
+ virTristateSwitchTypeToString(virtio->packed));
+ }
}
=20
=20
@@ -22416,6 +22436,14 @@ virDomainVirtioOptionsCheckABIStability(virDomainV=
irtioOptionsPtr src,
virTristateSwitchTypeToString(src->ats));
return false;
}
+ if (src->packed !=3D dst->packed) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+ _("Target device packed option '%s' does not "
+ "match source '%s'"),
+ virTristateSwitchTypeToString(dst->packed),
+ virTristateSwitchTypeToString(src->packed));
+ return false;
+ }
return true;
}
=20
diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 2038b54c..22f6990e 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -2417,6 +2417,7 @@ struct _virDomainVsockDef {
struct _virDomainVirtioOptions {
virTristateSwitch iommu;
virTristateSwitch ats;
+ virTristateSwitch packed;
};
=20
/*
--=20
2.24.1
From nobody Wed May 15 14:12:07 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
207.211.31.120 as permitted sender) client-ip=207.211.31.120;
envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail(p=none dis=none) header.from=linux.ibm.com
ARC-Seal: i=1; a=rsa-sha256; t=1586178851; cv=none;
d=zohomail.com; s=zohoarc;
b=neUjfuS/IGkc1tYEpjteNTB+DtSX5BYh2YiMIk2ZXr4l/yrF0cjDTXUHdrxCCairNdi7wF6NWb/egMnDrXS981eerzmo9p5yvQOFxK1LCvNcIy+wUcNDeRjwsmgqt3pMrw6C3p7tgKsNbK2PVFUSKLprP7PDeMnmjI0TcJSeVJI=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1586178851;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=VF/6Qh7VrriX4DsGDzZTn90VgpCSsNZqUIZtWZTdF+w=;
b=fpV5qPOcE4Jz4cE9OOSj7M0U94YwNdqV8uhcj6kUiAiICGBxI2hIcGM9RRpMstjsVo42YrB86fNrr5BMMVpeLjpG6qeCiBV/GuaDeFaNGxmgEz2+GQObq9AHHL8pATKR8mFeNz+ahgSfrS6efoXvD4KSzhryajkyLBR+rUUOmmw=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.120 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com
[207.211.31.120]) by mx.zohomail.com
with SMTPS id 15861788513161016.4074181362793;
Mon, 6 Apr 2020 06:14:11 -0700 (PDT)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-447-24M2kxaaPRam_Nmwmr3Ssg-1; Mon, 06 Apr 2020 09:14:06 -0400
Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com
[10.5.11.11])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C9FC0DBD0;
Mon, 6 Apr 2020 13:14:00 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id A53871195AD;
Mon, 6 Apr 2020 13:14:00 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id 53D2B18089D7;
Mon, 6 Apr 2020 13:14:00 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
[10.11.54.5])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 036DDgK6015077 for ;
Mon, 6 Apr 2020 09:13:43 -0400
Received: by smtp.corp.redhat.com (Postfix)
id D8783B17D1; Mon, 6 Apr 2020 13:13:42 +0000 (UTC)
Received: from mimecast-mx02.redhat.com
(mimecast06.extmail.prod.ext.rdu2.redhat.com [10.11.55.22])
by smtp.corp.redhat.com (Postfix) with ESMTPS id D3999B17EC
for ; Mon, 6 Apr 2020 13:13:42 +0000 (UTC)
Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 80E04185A78E
for ; Mon, 6 Apr 2020 13:13:42 +0000 (UTC)
Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com
[148.163.158.5]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-389-y9L884VfMgiPy9BCSKY-Eg-1; Mon, 06 Apr 2020 09:13:40 -0400
Received: from pps.filterd (m0098420.ppops.net [127.0.0.1])
by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
036D3I8e141900
for ; Mon, 6 Apr 2020 09:13:40 -0400
Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103])
by mx0b-001b2d01.pphosted.com with ESMTP id 3082cgw30j-1
(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)
for ; Mon, 06 Apr 2020 09:13:39 -0400
Received: from localhost
by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
Only! Violators will be prosecuted
for from ;
Mon, 6 Apr 2020 14:13:35 +0100
Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198)
by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway:
Authorized Use Only! Violators will be prosecuted;
(version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256)
Mon, 6 Apr 2020 14:13:32 +0100
Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com
[9.149.105.61])
by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
ESMTP id 036DDXtt42402034
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
verify=OK); Mon, 6 Apr 2020 13:13:33 GMT
Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id 5F09111C050;
Mon, 6 Apr 2020 13:13:33 +0000 (GMT)
Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id 40E4111C058;
Mon, 6 Apr 2020 13:13:33 +0000 (GMT)
Received: from m46lp64.lnxne.boe (unknown [9.152.108.100])
by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;
Mon, 6 Apr 2020 13:13:33 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1586178850;
h=from:from:sender:sender:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:list-id:list-help:
list-unsubscribe:list-subscribe:list-post;
bh=VF/6Qh7VrriX4DsGDzZTn90VgpCSsNZqUIZtWZTdF+w=;
b=SxpYmvwk/QY5r3ZBddsxXlWlB3brqWnfTFXqt1UKmoPqDFOVL/7B6OPKp+F/nHBgc4qFo+
5MzVmT5IMw1UMS9UZ9/GVYoNfHcQIYspaEBG4a8W5kHiNvh8KavZd/kIhZOeb4iA6vS1Zk
XOhsjZFVbcxMq6BOsqnVOFivJ9YDKCc=
X-MC-Unique: 24M2kxaaPRam_Nmwmr3Ssg-1
X-MC-Unique: y9L884VfMgiPy9BCSKY-Eg-1
From: Bjoern Walk
To: libvir-list@redhat.com
Subject: [PATCH v2 3/4] qemu: command: support for virtio packed option
Date: Mon, 6 Apr 2020 15:13:26 +0200
In-Reply-To: <20200406131327.780751-1-bwalk@linux.ibm.com>
References: <20200406131327.780751-1-bwalk@linux.ibm.com>
MIME-Version: 1.0
X-TM-AS-GCONF: 00
x-cbid: 20040613-0028-0000-0000-000003F314F3
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 20040613-0029-0000-0000-000024B8A902
Message-Id: <20200406131327.780751-4-bwalk@linux.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676
definitions=2020-04-06_07:2020-04-06,
2020-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
priorityscore=1501
lowpriorityscore=0 suspectscore=1 spamscore=0 clxscore=1015 mlxscore=0
bulkscore=0 malwarescore=0 adultscore=0 mlxlogscore=999 impostorscore=0
phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2003020000 definitions=main-2004060109
X-MIME-Autoconverted: from 8bit to quoted-printable by
mx0b-001b2d01.pphosted.com id 036D3I8e141900
X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5
X-MIME-Autoconverted: from quoted-printable to 8bit by
lists01.pubmisc.prod.ext.phx2.redhat.com id 036DDgK6015077
X-loop: libvir-list@redhat.com
Cc: Bjoern Walk
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"
Pass the packed option on the QEMU command line of the capability for
packed virtqueues is detected and the parameter is set explicitly.
Reviewed-by: J=C3=A1n Tomko
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
Reviewed-by: Marc Hartmayer
---
src/qemu/qemu_command.c | 10 +++++++
tests/qemuxml2argvdata/virtio-options.args | 32 ++++++++++++----------
tests/qemuxml2argvdata/virtio-options.xml | 26 +++++++++---------
tests/qemuxml2argvtest.c | 3 +-
tests/qemuxml2xmltest.c | 3 +-
5 files changed, 44 insertions(+), 30 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index df90f5ed..da9450fe 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -614,6 +614,16 @@ qemuBuildVirtioOptionsStr(virBufferPtr buf,
virBufferAsprintf(buf, ",ats=3D%s",
virTristateSwitchTypeToString(virtio->ats));
}
+ if (virtio->packed !=3D VIR_TRISTATE_SWITCH_ABSENT) {
+ if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_PACKED_QUEUES)) {
+ virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
+ _("the packed setting is not supported with thi=
s "
+ "QEMU binary"));
+ return -1;
+ }
+ virBufferAsprintf(buf, ",packed=3D%s",
+ virTristateSwitchTypeToString(virtio->packed));
+ }
=20
return 0;
}
diff --git a/tests/qemuxml2argvdata/virtio-options.args b/tests/qemuxml2arg=
vdata/virtio-options.args
index 33ecd8f4..8253a788 100644
--- a/tests/qemuxml2argvdata/virtio-options.args
+++ b/tests/qemuxml2argvdata/virtio-options.args
@@ -24,36 +24,38 @@ server,nowait \
-rtc base=3Dutc \
-no-shutdown \
-no-acpi \
--device virtio-scsi-pci,iommu_platform=3Don,ats=3Don,id=3Dscsi0,bus=3Dpci.=
0,addr=3D0x8 \
--device virtio-serial-pci,id=3Dvirtio-serial0,iommu_platform=3Don,ats=3Don=
,bus=3Dpci.0,\
-addr=3D0x9 \
+-device virtio-scsi-pci,iommu_platform=3Don,ats=3Don,packed=3Don,id=3Dscsi=
0,bus=3Dpci.0,\
+addr=3D0x8 \
+-device virtio-serial-pci,id=3Dvirtio-serial0,iommu_platform=3Don,ats=3Don=
,packed=3Don,\
+bus=3Dpci.0,addr=3D0x9 \
-usb \
-drive file=3D/var/lib/libvirt/images/img1,format=3Draw,if=3Dnone,\
id=3Ddrive-virtio-disk0 \
--device virtio-blk-pci,iommu_platform=3Don,ats=3Don,bus=3Dpci.0,addr=3D0xa=
,\
+-device virtio-blk-pci,iommu_platform=3Don,ats=3Don,packed=3Don,bus=3Dpci.=
0,addr=3D0xa,\
drive=3Ddrive-virtio-disk0,id=3Dvirtio-disk0,bootindex=3D1 \
-fsdev local,security_model=3Dpassthrough,id=3Dfsdev-fs0,path=3D/export/fs=
1 \
-device virtio-9p-pci,id=3Dfs0,fsdev=3Dfsdev-fs0,mount_tag=3Dfs1,iommu_pla=
tform=3Don,\
-ats=3Don,bus=3Dpci.0,addr=3D0x3 \
+ats=3Don,packed=3Don,bus=3Dpci.0,addr=3D0x3 \
-fsdev local,security_model=3Dmapped,writeout=3Dimmediate,id=3Dfsdev-fs1,\
path=3D/export/fs2 \
-device virtio-9p-pci,id=3Dfs1,fsdev=3Dfsdev-fs1,mount_tag=3Dfs2,iommu_pla=
tform=3Don,\
-ats=3Don,bus=3Dpci.0,addr=3D0x4 \
+ats=3Don,packed=3Don,bus=3Dpci.0,addr=3D0x4 \
-netdev user,id=3Dhostnet0 \
-device virtio-net-pci,netdev=3Dhostnet0,id=3Dnet0,mac=3D52:54:56:58:5a:5c=
,bus=3Dpci.0,\
-addr=3D0x6,iommu_platform=3Don,ats=3Don \
--device virtio-mouse-pci,id=3Dinput0,bus=3Dpci.0,addr=3D0xe,iommu_platform=
=3Don,ats=3Don \
+addr=3D0x6,iommu_platform=3Don,ats=3Don,packed=3Don \
+-device virtio-mouse-pci,id=3Dinput0,bus=3Dpci.0,addr=3D0xe,iommu_platform=
=3Don,ats=3Don,\
+packed=3Don \
-device virtio-keyboard-pci,id=3Dinput1,bus=3Dpci.0,addr=3D0x10,iommu_plat=
form=3Don,\
-ats=3Don \
+ats=3Don,packed=3Don \
-device virtio-tablet-pci,id=3Dinput2,bus=3Dpci.0,addr=3D0x11,iommu_platfo=
rm=3Don,\
-ats=3Don \
+ats=3Don,packed=3Don \
-device virtio-input-host-pci,id=3Dinput3,evdev=3D/dev/input/event1234,bus=
=3Dpci.0,\
-addr=3D0x12,iommu_platform=3Don,ats=3Don \
+addr=3D0x12,iommu_platform=3Don,ats=3Don,packed=3Don \
-chardev socket,id=3Dchr-vu-video0,fd=3D1729 \
-device vhost-user-gpu-pci,id=3Dvideo0,max_outputs=3D1,chardev=3Dchr-vu-vi=
deo0,\
-bus=3Dpci.0,addr=3D0x2,iommu_platform=3Don,ats=3Don \
+bus=3Dpci.0,addr=3D0x2,iommu_platform=3Don,ats=3Don,packed=3Don \
-device virtio-balloon-pci,id=3Dballoon0,bus=3Dpci.0,addr=3D0xc,iommu_plat=
form=3Don,\
-ats=3Don \
+ats=3Don,packed=3Don \
-object rng-random,id=3Dobjrng0,filename=3D/dev/random \
--device virtio-rng-pci,rng=3Dobjrng0,id=3Drng0,iommu_platform=3Don,ats=3Do=
n,bus=3Dpci.0,\
-addr=3D0xd
+-device virtio-rng-pci,rng=3Dobjrng0,id=3Drng0,iommu_platform=3Don,ats=3Do=
n,packed=3Don,\
+bus=3Dpci.0,addr=3D0xd
diff --git a/tests/qemuxml2argvdata/virtio-options.xml b/tests/qemuxml2argv=
data/virtio-options.xml
index dd9a4f4a..3ca27840 100644
--- a/tests/qemuxml2argvdata/virtio-options.xml
+++ b/tests/qemuxml2argvdata/virtio-options.xml
@@ -15,7 +15,7 @@
/usr/bin/qemu-system-x86_64
-
+
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c
index fdeb3c2e..405227fd 100644
--- a/tests/qemuxml2argvtest.c
+++ b/tests/qemuxml2argvtest.c
@@ -2989,7 +2989,8 @@ mymain(void)
QEMU_CAPS_OBJECT_RNG_RANDOM,
QEMU_CAPS_DEVICE_VIDEO_PRIMARY,
QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM,
- QEMU_CAPS_VIRTIO_PCI_ATS);
+ QEMU_CAPS_VIRTIO_PCI_ATS,
+ QEMU_CAPS_VIRTIO_PACKED_QUEUES);
=20
DO_TEST("fd-memory-numa-topology", QEMU_CAPS_OBJECT_MEMORY_FILE,
QEMU_CAPS_KVM);
diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
index b4c83fcc..756d4e2c 100644
--- a/tests/qemuxml2xmltest.c
+++ b/tests/qemuxml2xmltest.c
@@ -1291,7 +1291,8 @@ mymain(void)
QEMU_CAPS_DEVICE_VIDEO_PRIMARY,
QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM,
QEMU_CAPS_VIRTIO_PCI_ATS,
- QEMU_CAPS_DEVICE_VHOST_USER_GPU);
+ QEMU_CAPS_DEVICE_VHOST_USER_GPU,
+ QEMU_CAPS_VIRTIO_PACKED_QUEUES);
=20
DO_TEST("fd-memory-numa-topology", QEMU_CAPS_OBJECT_MEMORY_FILE,
QEMU_CAPS_KVM);
--=20
2.24.1
From nobody Wed May 15 14:12:07 2024
Delivered-To: importer@patchew.org
Received-SPF: pass (zohomail.com: domain of redhat.com designates
207.211.31.81 as permitted sender) client-ip=207.211.31.81;
envelope-from=libvir-list-bounces@redhat.com;
helo=us-smtp-delivery-1.mimecast.com;
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail(p=none dis=none) header.from=linux.ibm.com
ARC-Seal: i=1; a=rsa-sha256; t=1586178836; cv=none;
d=zohomail.com; s=zohoarc;
b=BzxaRTGpaJ86vzaW5ZDAOgVbiKJyRqbYqVwCxYDowh8+3raKSF74ZBokgcl/YfrkUrjnssIZHjxZrfpF0dIustMsADkCZowGLy7imJAFMRBZB2YvAeuqbCYimhRpXWGT70w7IGPVYh+t5+ZiwgiUykLgycHsg4jW8xLJwvxE+aQ=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1586178836;
h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=B1bl+wX1kN82eKe4w/22rOnhOOSrDY3gfXhjDAvWeFA=;
b=EtKpSQknf6GZXU0DLyn+kLiWjXEGpNnfJ0KIMuP7fSnrlDfpKqQIM8gUfE02IKzXMMNVbS+t/53YDq1tiNNBThMzxZ7zUvZFMI9Tuf+o3hKA1YWVzlckfRQRv0x7ezVA5ujTSfIYXIbLOAV3qj4lxkwzDDut+aM5T40CJ0P2Fh0=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as
permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com;
dmarc=fail header.from= (p=none dis=none)
header.from=
Return-Path:
Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com
[207.211.31.81]) by mx.zohomail.com
with SMTPS id 1586178836780591.5823194933531;
Mon, 6 Apr 2020 06:13:56 -0700 (PDT)
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-65-jn41Bsq_M8iM8Ry3xVWnrA-1; Mon, 06 Apr 2020 09:13:53 -0400
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
[10.5.11.13])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 970F8800D4E;
Mon, 6 Apr 2020 13:13:47 +0000 (UTC)
Received: from colo-mx.corp.redhat.com
(colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 68AF59D378;
Mon, 6 Apr 2020 13:13:47 +0000 (UTC)
Received: from lists01.pubmisc.prod.ext.phx2.redhat.com
(lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33])
by colo-mx.corp.redhat.com (Postfix) with ESMTP id 95CAE18089C8;
Mon, 6 Apr 2020 13:13:46 +0000 (UTC)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
[10.11.54.3])
by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP
id 036DDiTU015095 for ;
Mon, 6 Apr 2020 09:13:44 -0400
Received: by smtp.corp.redhat.com (Postfix)
id 29A41100333B; Mon, 6 Apr 2020 13:13:44 +0000 (UTC)
Received: from mimecast-mx02.redhat.com
(mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 25B6F100321B
for ; Mon, 6 Apr 2020 13:13:44 +0000 (UTC)
Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com
[205.139.110.61])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0D4988FF663
for ; Mon, 6 Apr 2020 13:13:44 +0000 (UTC)
Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com
[148.163.156.1]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-502-ZZYjc0eLO4er0cUuE-Ehtw-1; Mon, 06 Apr 2020 09:13:41 -0400
Received: from pps.filterd (m0098399.ppops.net [127.0.0.1])
by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id
036D3SNU086871
for ; Mon, 6 Apr 2020 09:13:40 -0400
Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103])
by mx0a-001b2d01.pphosted.com with ESMTP id 3082hwd2xn-1
(version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT)
for ; Mon, 06 Apr 2020 09:13:40 -0400
Received: from localhost
by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
Only! Violators will be prosecuted
for from ;
Mon, 6 Apr 2020 14:13:35 +0100
Received: from b06avi18626390.portsmouth.uk.ibm.com (9.149.26.192)
by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway:
Authorized Use Only! Violators will be prosecuted;
(version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256)
Mon, 6 Apr 2020 14:13:33 +0100
Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com
[9.149.105.61])
by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
ESMTP id 036DCU3H11534612
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
verify=OK); Mon, 6 Apr 2020 13:12:30 GMT
Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id 2995811C05E;
Mon, 6 Apr 2020 13:13:35 +0000 (GMT)
Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1])
by IMSVA (Postfix) with ESMTP id EF87911C058;
Mon, 6 Apr 2020 13:13:34 +0000 (GMT)
Received: from m46lp64.lnxne.boe (unknown [9.152.108.100])
by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP;
Mon, 6 Apr 2020 13:13:34 +0000 (GMT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1586178835;
h=from:from:sender:sender:reply-to:subject:subject:date:date:
message-id:message-id:to:to:cc:cc:mime-version:mime-version:
content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references:list-id:list-help:
list-unsubscribe:list-subscribe:list-post;
bh=B1bl+wX1kN82eKe4w/22rOnhOOSrDY3gfXhjDAvWeFA=;
b=Uj8/r3DqCAKNH076oqEWW0hdxdsVuz9PLBqig4XYQS7jNMsk/+YifapVbpcgobIqKt8m3R
1Cd+mXkCAGAEVJQAbkmxjC+/racl/X3YGwvREiYrrPFUB+2vERJBrYzSrW4WnrzGZAMxOR
7O8n91gJr9DfOP+fVrhMN1KAaOglvyM=
X-MC-Unique: jn41Bsq_M8iM8Ry3xVWnrA-1
X-MC-Unique: ZZYjc0eLO4er0cUuE-Ehtw-1
From: Bjoern Walk
To: libvir-list@redhat.com
Subject: [PATCH v2 4/4] docs: documentation for virtio packed option
Date: Mon, 6 Apr 2020 15:13:27 +0200
In-Reply-To: <20200406131327.780751-1-bwalk@linux.ibm.com>
References: <20200406131327.780751-1-bwalk@linux.ibm.com>
MIME-Version: 1.0
X-TM-AS-GCONF: 00
x-cbid: 20040613-0028-0000-0000-000003F314F5
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 20040613-0029-0000-0000-000024B8A905
Message-Id: <20200406131327.780751-5-bwalk@linux.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676
definitions=2020-04-06_07:2020-04-06,
2020-04-06 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
mlxscore=0 impostorscore=0
malwarescore=0 phishscore=0 mlxlogscore=999 spamscore=0 clxscore=1015
adultscore=0 bulkscore=0 priorityscore=1501 suspectscore=15
lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2003020000 definitions=main-2004060112
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3
X-MIME-Autoconverted: from quoted-printable to 8bit by
lists01.pubmisc.prod.ext.phx2.redhat.com id 036DDiTU015095
X-loop: libvir-list@redhat.com
Cc: Bjoern Walk
X-BeenThere: libvir-list@redhat.com
X-Mailman-Version: 2.1.12
Precedence: junk
List-Id: Development discussions about the libvirt library & tools
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Sender: libvir-list-bounces@redhat.com
Errors-To: libvir-list-bounces@redhat.com
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: quoted-printable
X-ZohoMail-DKIM: pass (identity @redhat.com)
Content-Type: text/plain; charset="utf-8"
Reviewed-by: Boris Fiuczynski
Signed-off-by: Bjoern Walk
Reviewed-by: J=C3=A1n Tomko
---
docs/formatdomain.html.in | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index fbffb168..f0252a34 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -4372,6 +4372,16 @@
Possible values are on or off.
Since 3.5.0
+
+ The attribute packed controls if QEMU should try to use
+ packed virtqueues. Compared to regular split queues, packed queues
+ consist of only a single descriptor ring replacing available and used
+ ring, index and descriptor buffer. This can result in better cache
+ utilization and performance. If packed virtqueues are actually used
+ depends on the feature negotiation between QEMU, vhost backends and =
guest
+ drivers. Possible values are on or off.
+ Since 6.3.0 (QEMU and KVM only)
+