From nobody Fri Dec 19 22:03:25 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) client-ip=207.211.31.81; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1585927038; cv=none; d=zohomail.com; s=zohoarc; b=IoRE+B+K1mYIfNR/g600PMPj+1faGtbbgrTlOvlyzssUYeZ5BQzYfeedvOX4oAgkRFQDs7VO7o+Alc41HUXU51qLgEaq0XMNFWSzk6ZFE/D/STQpKvJj+ScavFR04IPKGvz3ylKPR5YI+u0Au56vBQoU7QjspPCl7AQLpJxk6Uc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585927038; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EhRvX/2G+j7ZaAy9SIV6pXnXYP6LFRDbViwLYuPGk/c=; b=BufhFjbtkQXMq1G2p19gyLVWBEpacY/nfNDnxIol4uuR9v3bUsWTiKJwCfYFUdpVOMt98hZPRbIIpvSsBoAOjW28oSFNSpxxoJDdoeBPiKvc+onsLaBWs/B3/jJWhGVE0N6GJuJsCjlDJ5bkgLXdFo+/FVDdSVra8zT1QdBRK2w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 207.211.31.81 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by mx.zohomail.com with SMTPS id 1585927038803654.1923997737912; Fri, 3 Apr 2020 08:17:18 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-105-qxzo0eW_P5iyZBWxGnQjyQ-1; Fri, 03 Apr 2020 11:17:15 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17A7518C35BD; Fri, 3 Apr 2020 15:17:07 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C60FB1036D13; Fri, 3 Apr 2020 15:17:06 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1D9E34E45F; Fri, 3 Apr 2020 15:17:06 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 033FGr04028296 for ; Fri, 3 Apr 2020 11:16:53 -0400 Received: by smtp.corp.redhat.com (Postfix) id 12C442166B2E; Fri, 3 Apr 2020 15:16:53 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F02B2166B2C for ; Fri, 3 Apr 2020 15:16:53 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E42B68007AC for ; Fri, 3 Apr 2020 15:16:52 +0000 (UTC) Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-EDZQbtaKM_-GIJLZvNwmKQ-1; Fri, 03 Apr 2020 11:16:50 -0400 Received: by mail-wr1-f42.google.com with SMTP id t7so8924745wrw.12 for ; Fri, 03 Apr 2020 08:16:50 -0700 (PDT) Received: from localhost.localdomain (public-gprs375156.centertel.pl. [37.47.96.181]) by smtp.gmail.com with ESMTPSA id p13sm12331045wru.3.2020.04.03.08.16.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Apr 2020 08:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585927037; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=EhRvX/2G+j7ZaAy9SIV6pXnXYP6LFRDbViwLYuPGk/c=; b=S5vQacDsyW8GOa/0O0w5HibrOZJZ290esRmne8DV4jfF6B+S0zcPuic3gVnVLOkdCaMeaU Xvmqi/in1QHP/nTylN2wT4TLN83RigplFes3hv5fw440ObgAc9L+pj3sksTzMmxY5IBowr Ks0eKNLCWXdDOnDe5vwP1AtGIdxujDs= X-MC-Unique: qxzo0eW_P5iyZBWxGnQjyQ-1 X-MC-Unique: EDZQbtaKM_-GIJLZvNwmKQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Ww84VSZO0XgYXafTNnTyvKT1Oa7bAs772XA4YaM2FM=; b=n324xoswmZFLrCP/rq6NaIqYAPt/LJ0hyHJOWzaGrf2d9dQZhMG88e4rMbbNSRYLl7 +CDqFdDcXNoIL6l9OfVFApmP4Qt6xYaPjp+66Ntim1/GoK2u9c7+3EL96vyV3AAL4n+E xcqR63XOHcFZCsO+0zYbdV3/R+5Ttwis38mK3KHrS4JmQMQsH9itq/BSsPH/AdKS7BnB tejGW4Ne0ev7uF/AFIkEm4DGt+SYmeXY2Ykas+hbbWb6XCfsQbucOfvH/tva/p+4vLWA yHuEFvoxY0FS01O5ELum8Nv3e/y56253QvGqIN/KMydc/TYHdzYqx8y3hTMQ7hYr2tge qVzw== X-Gm-Message-State: AGi0PuYuIVdz7qNLszvsWEoBtQEaeArkCgrUYqRqeiYMrXhv0lWCCoTN s/cuflBV3Sil+Ff9o2Ki/RVcnJmgBho= X-Google-Smtp-Source: APiQypLvSys20oh6IDPDtglXw31zciHkRnjcLf8amjGnPTzpI7xsxRrKuc5knOJabL17eD5FL5i5jA== X-Received: by 2002:a5d:4bc1:: with SMTP id l1mr10262237wrt.103.1585927008785; Fri, 03 Apr 2020 08:16:48 -0700 (PDT) From: Rafael Fonseca To: libvir-list@redhat.com Subject: [PATCH 22/36] datatypes: convert virStoragePool to GObject Date: Fri, 3 Apr 2020 17:15:50 +0200 Message-Id: <20200403151604.106616-23-r4f4rfs@gmail.com> In-Reply-To: <20200403151604.106616-1-r4f4rfs@gmail.com> References: <20200403151604.106616-1-r4f4rfs@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 033FGr04028296 X-loop: libvir-list@redhat.com Cc: Rafael Fonseca X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Signed-off-by: Rafael Fonseca --- src/conf/storage_event.c | 15 ++++------ src/conf/virstorageobj.c | 8 ++++- src/datatypes.c | 46 ++++++++++++++++++----------- src/datatypes.h | 15 +++++----- src/libvirt-storage.c | 6 ++-- src/libvirt_private.syms | 1 - src/qemu/qemu_migration.c | 3 +- src/remote/remote_daemon_dispatch.c | 2 +- src/remote/remote_driver.c | 4 +-- src/vz/vz_sdk.c | 3 +- 10 files changed, 57 insertions(+), 46 deletions(-) diff --git a/src/conf/storage_event.c b/src/conf/storage_event.c index de36ec3af9..e18069f718 100644 --- a/src/conf/storage_event.c +++ b/src/conf/storage_event.c @@ -110,10 +110,10 @@ virStoragePoolEventDispatchDefaultFunc(virConnectPtr = conn, virConnectObjectEventGenericCallbac= k cb, void *cbopaque) { - virStoragePoolPtr pool =3D virGetStoragePool(conn, - event->meta.name, - event->meta.uuid, - NULL, NULL); + g_autoptr(virStoragePool) pool =3D virGetStoragePool(conn, + event->meta.name, + event->meta.uuid, + NULL, NULL); if (!pool) return; =20 @@ -127,23 +127,20 @@ virStoragePoolEventDispatchDefaultFunc(virConnectPtr = conn, storagePoolL= ifecycleEvent->type, storagePoolL= ifecycleEvent->detail, cbopaque); - goto cleanup; + return; } =20 case VIR_STORAGE_POOL_EVENT_ID_REFRESH: { ((virConnectStoragePoolEventGenericCallback)cb)(conn, pool, cbopaque); - goto cleanup; + return; } =20 case VIR_STORAGE_POOL_EVENT_ID_LAST: break; } VIR_WARN("Unexpected event ID %d", event->eventID); - - cleanup: - virObjectUnref(pool); } =20 =20 diff --git a/src/conf/virstorageobj.c b/src/conf/virstorageobj.c index 5cbd30f93c..bff6eb6ae1 100644 --- a/src/conf/virstorageobj.c +++ b/src/conf/virstorageobj.c @@ -2095,6 +2095,12 @@ virStoragePoolObjListExport(virConnectPtr conn, return data.nPools; =20 error: - virObjectListFree(data.pools); + if (data.pools) { + while (data.nPools--) { + if (data.pools[data.nPools]) + g_object_unref(data.pools[data.nPools]); + } + } + VIR_FREE(data.pools); return -1; } diff --git a/src/datatypes.c b/src/datatypes.c index f1bcca44f1..e434c31785 100644 --- a/src/datatypes.c +++ b/src/datatypes.c @@ -40,7 +40,6 @@ virClassPtr virNodeDeviceClass; virClassPtr virSecretClass; virClassPtr virStreamClass; virClassPtr virStorageVolClass; -virClassPtr virStoragePoolClass; =20 static void virConnectDispose(void *obj); static void virConnectCloseCallbackDataDispose(void *obj); @@ -49,7 +48,6 @@ static void virNodeDeviceDispose(void *obj); static void virSecretDispose(void *obj); static void virStreamDispose(void *obj); static void virStorageVolDispose(void *obj); -static void virStoragePoolDispose(void *obj); =20 G_DEFINE_TYPE(virDomainCheckpoint, vir_domain_checkpoint, G_TYPE_OBJECT); static void virDomainCheckpointFinalize(GObject *obj); @@ -163,6 +161,22 @@ vir_nw_filter_binding_class_init(virNWFilterBindingCla= ss *klass) obj->finalize =3D virNWFilterBindingFinalize; } =20 +G_DEFINE_TYPE(virStoragePool, vir_storage_pool, G_TYPE_OBJECT); +static void virStoragePoolFinalize(GObject *obj); + +static void +vir_storage_pool_init(virStoragePool *pool G_GNUC_UNUSED) +{ +} + +static void +vir_storage_pool_class_init(virStoragePoolClass *klass) +{ + GObjectClass *obj =3D G_OBJECT_CLASS(klass); + + obj->finalize =3D virStoragePoolFinalize; +} + virClassPtr virAdmConnectClass; virClassPtr virAdmConnectCloseCallbackDataClass; =20 @@ -219,7 +233,6 @@ virDataTypesOnceInit(void) DECLARE_CLASS(virSecret); DECLARE_CLASS(virStream); DECLARE_CLASS(virStorageVol); - DECLARE_CLASS(virStoragePool); =20 DECLARE_CLASS_LOCKABLE(virAdmConnect); DECLARE_CLASS_LOCKABLE(virAdmConnectCloseCallbackData); @@ -628,7 +641,7 @@ virInterfaceFinalize(GObject *obj) * @freeFunc: private data cleanup function pointer specific to driver * * Allocates a new storage pool object. When the object is no longer neede= d, - * virObjectUnref() must be called in order to not leak data. + * g_object_unref() must be called in order to not leak data. * * Returns a pointer to the storage pool object, or NULL on error. */ @@ -637,17 +650,16 @@ virGetStoragePool(virConnectPtr conn, const char *nam= e, const unsigned char *uuid, void *privateData, virFreeCallback freeFunc) { - virStoragePoolPtr ret =3D NULL; + g_autoptr(virStoragePool) ret =3D NULL; =20 if (virDataTypesInitialize() < 0) return NULL; =20 - virCheckConnectGoto(conn, error); - virCheckNonNullArgGoto(name, error); - virCheckNonNullArgGoto(uuid, error); + virCheckConnectReturn(conn, NULL); + virCheckNonNullArgReturn(name, NULL); + virCheckNonNullArgReturn(uuid, NULL); =20 - if (!(ret =3D virObjectNew(virStoragePoolClass))) - goto error; + ret =3D VIR_STORAGE_POOL(g_object_new(VIR_TYPE_STORAGE_POOL, NULL)); =20 ret->name =3D g_strdup(name); =20 @@ -658,16 +670,12 @@ virGetStoragePool(virConnectPtr conn, const char *nam= e, ret->privateData =3D privateData; ret->privateDataFreeFunc =3D freeFunc; =20 - return ret; - - error: - virObjectUnref(ret); - return NULL; + return g_steal_pointer(&ret); } =20 =20 /** - * virStoragePoolDispose: + * virStoragePoolFinalize: * @obj: the storage pool to release * * Unconditionally release all memory associated with a pool. @@ -677,9 +685,9 @@ virGetStoragePool(virConnectPtr conn, const char *name, * which may also be released if its ref count hits zero. */ static void -virStoragePoolDispose(void *obj) +virStoragePoolFinalize(GObject *obj) { - virStoragePoolPtr pool =3D obj; + virStoragePoolPtr pool =3D VIR_STORAGE_POOL(obj); char uuidstr[VIR_UUID_STRING_BUFLEN]; =20 virUUIDFormat(pool->uuid, uuidstr); @@ -690,6 +698,8 @@ virStoragePoolDispose(void *obj) =20 VIR_FREE(pool->name); virObjectUnref(pool->conn); + + G_OBJECT_CLASS(vir_storage_pool_parent_class)->finalize(obj); } =20 =20 diff --git a/src/datatypes.h b/src/datatypes.h index c68a0e9265..a630472f6e 100644 --- a/src/datatypes.h +++ b/src/datatypes.h @@ -36,7 +36,6 @@ extern virClassPtr virNodeDeviceClass; extern virClassPtr virSecretClass; extern virClassPtr virStreamClass; extern virClassPtr virStorageVolClass; -extern virClassPtr virStoragePoolClass; =20 =20 #define VIR_TYPE_DOMAIN_CHECKPOINT vir_domain_checkpoint_get_type() @@ -72,6 +71,9 @@ G_DECLARE_FINAL_TYPE(virNWFilterBinding, NW_FILTER_BINDING, GObject); =20 +#define VIR_TYPE_STORAGE_POOL vir_storage_pool_get_type() +G_DECLARE_FINAL_TYPE(virStoragePool, vir_storage_pool, VIR, STORAGE_POOL, = GObject); + extern virClassPtr virAdmConnectClass; =20 #define VIR_TYPE_ADM_SERVER vir_adm_server_get_type() @@ -192,8 +194,8 @@ G_DECLARE_FINAL_TYPE(virAdmClient, vir_adm_client, VIR,= ADM_CLIENT, GObject); =20 #define virCheckStoragePoolReturn(obj, retval) \ do { \ - virStoragePoolPtr _pool =3D (obj); \ - if (!virObjectIsClass(_pool, virStoragePoolClass) || \ + virStoragePoolPtr _pool =3D VIR_STORAGE_POOL(obj); \ + if (!G_IS_OBJECT(_pool) || !(G_OBJECT_TYPE(_pool) =3D=3D VIR_TYPE_= STORAGE_POOL) || \ !virObjectIsClass(_pool->conn, virConnectClass)) { \ virReportErrorHelper(VIR_FROM_STORAGE, \ VIR_ERR_INVALID_STORAGE_POOL, \ @@ -206,8 +208,8 @@ G_DECLARE_FINAL_TYPE(virAdmClient, vir_adm_client, VIR,= ADM_CLIENT, GObject); =20 #define virCheckStoragePoolGoto(obj, label) \ do { \ - virStoragePoolPtr _pool=3D (obj); \ - if (!virObjectIsClass(_pool, virStoragePoolClass) || \ + virStoragePoolPtr _pool=3D VIR_STORAGE_POOL(obj); \ + if (!G_IS_OBJECT(_pool) || !(G_OBJECT_TYPE(_pool) =3D=3D VIR_TYPE_= STORAGE_POOL) || \ !virObjectIsClass(_pool->conn, virConnectClass)) { \ virReportErrorHelper(VIR_FROM_STORAGE, \ VIR_ERR_INVALID_STORAGE_POOL, \ @@ -684,7 +686,7 @@ struct _virInterface { * Internal structure associated to a storage pool */ struct _virStoragePool { - virObject parent; + GObject parent; virConnectPtr conn; /* pointer back to the connection= */ char *name; /* the storage pool external name= */ unsigned char uuid[VIR_UUID_BUFLEN]; /* the storage pool unique identi= fier */ @@ -697,7 +699,6 @@ struct _virStoragePool { virFreeCallback privateDataFreeFunc; }; =20 -G_DEFINE_AUTOPTR_CLEANUP_FUNC(virStoragePool, virObjectUnref); =20 =20 /** diff --git a/src/libvirt-storage.c b/src/libvirt-storage.c index 0406fe84d3..b88b2162de 100644 --- a/src/libvirt-storage.c +++ b/src/libvirt-storage.c @@ -846,7 +846,7 @@ virStoragePoolFree(virStoragePoolPtr pool) =20 virCheckStoragePoolReturn(pool, -1); =20 - virObjectUnref(pool); + g_object_unref(pool); return 0; =20 } @@ -872,13 +872,13 @@ virStoragePoolFree(virStoragePoolPtr pool) int virStoragePoolRef(virStoragePoolPtr pool) { - VIR_DEBUG("pool=3D%p refs=3D%d", pool, pool ? pool->parent.u.s.refs : = 0); + VIR_DEBUG("pool=3D%p", pool); =20 virResetLastError(); =20 virCheckStoragePoolReturn(pool, -1); =20 - virObjectRef(pool); + g_object_ref(pool); return 0; } =20 diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index a5e4b00a0e..f48ed05684 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -1367,7 +1367,6 @@ virGetStream; virNewConnectCloseCallbackData; virNodeDeviceClass; virSecretClass; -virStoragePoolClass; virStorageVolClass; virStreamClass; =20 diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index bc280e856a..de65c730f7 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -174,7 +174,7 @@ qemuMigrationDstPrecreateDisk(virConnectPtr conn, unsigned long long capacity) { int ret =3D -1; - virStoragePoolPtr pool =3D NULL; + g_autoptr(virStoragePool) pool =3D NULL; virStorageVolPtr vol =3D NULL; char *volName =3D NULL, *basePath =3D NULL; char *volStr =3D NULL; @@ -269,7 +269,6 @@ qemuMigrationDstPrecreateDisk(virConnectPtr conn, VIR_FREE(basePath); VIR_FREE(volStr); virObjectUnref(vol); - virObjectUnref(pool); return ret; } =20 diff --git a/src/remote/remote_daemon_dispatch.c b/src/remote/remote_daemon= _dispatch.c index 9f5aee07cd..9f367bc515 100644 --- a/src/remote/remote_daemon_dispatch.c +++ b/src/remote/remote_daemon_dispatch.c @@ -6196,7 +6196,7 @@ remoteDispatchConnectStoragePoolEventRegisterAny(virN= etServerPtr server G_GNUC_U remoteEventCallbackFree(callback); if (rv < 0) virNetMessageSaveError(rerr); - virObjectUnref(pool); + g_object_unref(pool); return rv; } =20 diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index f19061200c..f5d7842104 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -5493,7 +5493,7 @@ remoteStoragePoolBuildEventLifecycle(virNetClientProg= ramPtr prog G_GNUC_UNUSED, =20 event =3D virStoragePoolEventLifecycleNew(pool->name, pool->uuid, msg-= >event, msg->detail); - virObjectUnref(pool); + g_object_unref(pool); =20 virObjectEventStateQueueRemote(priv->eventState, event, msg->callbackI= D); } @@ -5514,7 +5514,7 @@ remoteStoragePoolBuildEventRefresh(virNetClientProgra= mPtr prog G_GNUC_UNUSED, return; =20 event =3D virStoragePoolEventRefreshNew(pool->name, pool->uuid); - virObjectUnref(pool); + g_object_unref(pool); =20 virObjectEventStateQueueRemote(priv->eventState, event, msg->callbackI= D); } diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index 9cee6f1fde..ed3d5ee2c0 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -4081,7 +4081,7 @@ prlsdkCreateVm(vzDriverPtr driver, virDomainDefPtr de= f) static int virStorageTranslatePoolLocal(virConnectPtr conn, virStorageSourcePtr src) { - virStoragePoolPtr pool =3D NULL; + g_autoptr(virStoragePool) pool =3D NULL; virStorageVolPtr vol =3D NULL; virStorageVolInfo info; int ret =3D -1; @@ -4115,7 +4115,6 @@ virStorageTranslatePoolLocal(virConnectPtr conn, virS= torageSourcePtr src) ret =3D 0; =20 cleanup: - virObjectUnref(pool); virObjectUnref(vol); return ret; } --=20 2.25.1