From nobody Sun Feb 8 03:33:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1585258345; cv=none; d=zohomail.com; s=zohoarc; b=eHRc2QbUXnGQ9tgs4oE/4M72EclAqaioWwkH8mPYVZ33vQLhGkhgOeS/7W4dsJAIZwVNf/6TYviwPbHElESA1RLNd4snuoZ/FhX8SV8rTn69RL6J8NCWM9P469RTuJGaovZU18mLT+JlPhDJr0eea9FV8Tn6uj9bvUGr0eYguYc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585258345; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+oLwDpvRp/miMOkH+DYuYNqF+ngg9sMrm/icH209cck=; b=QQbQ5LijCSgSgAUH6sibrgnxiepuGmEBSR8mtHcdUACzn8rQIIhPkerzek6g74yX6lLLYsx6kT/rnoqk3YV5pnMhMp7qvv2OxojuHyfXJECpp2qR/yu6IP6UobIo8tqtIWy7a7DKV1zwne0l/V4nfn28YSsFCXCpsjnDUtUYdcU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 1585258345381910.06527140194; Thu, 26 Mar 2020 14:32:25 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-GkIHNvgRNjyKZsT0nr6x-A-1; Thu, 26 Mar 2020 17:32:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42EF0100551A; Thu, 26 Mar 2020 21:32:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E610B60BF4; Thu, 26 Mar 2020 21:32:15 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 908148A042; Thu, 26 Mar 2020 21:32:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02QLVnm4010221 for ; Thu, 26 Mar 2020 17:31:49 -0400 Received: by smtp.corp.redhat.com (Postfix) id 22BCD6C330; Thu, 26 Mar 2020 21:31:49 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1E69211F4C2 for ; Thu, 26 Mar 2020 21:31:49 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E450E80028B for ; Thu, 26 Mar 2020 21:31:48 +0000 (UTC) Received: from mail-qt1-f193.google.com (mail-qt1-f193.google.com [209.85.160.193]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-kLlWcOJHM4GxCbq7Tk10ZA-1; Thu, 26 Mar 2020 17:31:44 -0400 Received: by mail-qt1-f193.google.com with SMTP id t17so6860829qtn.12; Thu, 26 Mar 2020 14:31:44 -0700 (PDT) Received: from rekt.redhat.com ([2804:431:c7c6:e1ce:90c:c960:468:c347]) by smtp.gmail.com with ESMTPSA id x37sm2357719qtc.90.2020.03.26.14.31.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Mar 2020 14:31:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585258344; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=+oLwDpvRp/miMOkH+DYuYNqF+ngg9sMrm/icH209cck=; b=Sdh7eN13JawkMPPZkpiFKUwMmZm6GS3OmJitoonQ1yn6KXaMmDZTEgyr6LMjArRnELmsTA gvlvNHWVAg6q6Q8HmwOyoi6NcclAd6twWwbeWM6kJN2vTSA7mcuJGpRT49WZIQ6EVMOdKs yfqY7iwSPClLef6hRSjIw1xsUyWOxMk= X-MC-Unique: GkIHNvgRNjyKZsT0nr6x-A-1 X-MC-Unique: kLlWcOJHM4GxCbq7Tk10ZA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4QLHbOaXiR2UNvxeRpLaGDjK82Lcaa4GbQR/TSzxFYE=; b=ELPMmWR6HKwVgzdcLDBktImfrY36oBuZY3YIHqC9I+L5phu2IvBy8ktSfeTFcYf0JW xjg7xKBqcsOYUAkBhI2ji9aLmeDw27ATdmKZcFfoSL4cdN9TTt4Q1noQ6uaf5mQ6eeKZ 3JAWf0HkKB34qamir/no8yz4r1bXZfwW7LdbWeX7PdojpGSei9yukrpf6Rc1a4tPZ/zt EhRYwx39T7kZRKHQP+s//hceNkeYgkh+PFQmKVK45qk02KrD9532YGfFwjvrFQJAYQdw o6P5NggjEgh26cSbpZleXzc6qjYg/FyJb7Gw8w8rQXESzDO+WQQIppxF4vCaD3RnJKHM psew== X-Gm-Message-State: ANhLgQ3YOL0pmsqE/Rfr1+F00I3EkPyipCs6ImDnhDu1EF+bvpiFzjLF r7HTTqiTYtgwaZzfs0mQP6CcRskG X-Google-Smtp-Source: ADFU+vsTNpl4LEgDrOBA6vGiBTfMAWE4h5QjHssnCcYkLuJii8y8yP2Q/bt31YEkBRcLZBHq8BNQdQ== X-Received: by 2002:aed:2f01:: with SMTP id l1mr10970253qtd.37.1585258303271; Thu, 26 Mar 2020 14:31:43 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH 03/15] qemu: move qemuDomainValidateDef() to qemu_validate.c Date: Thu, 26 Mar 2020 18:31:13 -0300 Message-Id: <20200326213125.2306013-4-danielhb413@gmail.com> In-Reply-To: <20200326213125.2306013-1-danielhb413@gmail.com> References: <20200326213125.2306013-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02QLVnm4010221 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza , pkrempa@redhat.com, crobinso@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" After moving most of static functions qemuDomainValidateDef() uses, move the last remaining static and qemuDomainValidateDef() itself to qemu_validation.c. Signed-off-by: Daniel Henrique Barboza Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_domain.c | 254 +----------------------------------- src/qemu/qemu_validate.c | 269 +++++++++++++++++++++++++++++++++++++-- src/qemu/qemu_validate.h | 19 +-- 3 files changed, 263 insertions(+), 279 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 413ce4a2dc..84212f7441 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5007,39 +5007,6 @@ qemuDomainDefPostParse(virDomainDefPtr def, } =20 =20 -/** - * qemuDomainDefGetVcpuHotplugGranularity: - * @def: domain definition - * - * With QEMU 2.7 and newer, vCPUs can only be hotplugged in groups that - * respect the guest's hotplug granularity; because of that, QEMU will - * not allow guests to start unless the initial number of vCPUs is a - * multiple of the hotplug granularity. - * - * Returns the vCPU hotplug granularity. - */ -static unsigned int -qemuDomainDefGetVcpuHotplugGranularity(const virDomainDef *def) -{ - /* If the guest CPU topology has not been configured, assume we - * can hotplug vCPUs one at a time */ - if (!def->cpu || def->cpu->sockets =3D=3D 0) - return 1; - - /* For pSeries guests, hotplug can only be performed one core - * at a time, so the vCPU hotplug granularity is the number - * of threads per core */ - if (qemuDomainIsPSeries(def)) - return def->cpu->threads; - - /* In all other cases, we can hotplug vCPUs one at a time */ - return 1; -} - - -#define QEMU_MAX_VCPUS_WITHOUT_EIM 255 - - static int qemuDomainDeviceDefValidateNVRAM(virDomainNVRAMDefPtr nvram, const virDomainDef *def, @@ -5182,225 +5149,6 @@ qemuDomainDeviceDefValidateMemory(virDomainMemoryDe= fPtr mem, return 0; } =20 -static int -qemuDomainDefValidate(const virDomainDef *def, - void *opaque) -{ - virQEMUDriverPtr driver =3D opaque; - g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); - g_autoptr(virQEMUCaps) qemuCaps =3D NULL; - size_t i; - - if (!(qemuCaps =3D virQEMUCapsCacheLookup(driver->qemuCapsCache, - def->emulator))) - return -1; - - if (def->os.type !=3D VIR_DOMAIN_OSTYPE_HVM) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Emulator '%s' does not support os type '%s'"), - def->emulator, virDomainOSTypeToString(def->os.type= )); - return -1; - } - - if (!virQEMUCapsIsArchSupported(qemuCaps, def->os.arch)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Emulator '%s' does not support arch '%s'"), - def->emulator, virArchToString(def->os.arch)); - return -1; - } - - if (!virQEMUCapsIsVirtTypeSupported(qemuCaps, def->virtType)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Emulator '%s' does not support virt type '%s'"), - def->emulator, virDomainVirtTypeToString(def->virtT= ype)); - return -1; - } - - if (qemuCaps && - !virQEMUCapsIsMachineSupported(qemuCaps, def->virtType, def->os.ma= chine)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Emulator '%s' does not support machine type '%s'= "), - def->emulator, def->os.machine); - return -1; - } - - if (def->mem.min_guarantee) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Parameter 'min_guarantee' not supported by QEMU.= ")); - return -1; - } - - /* On x86, UEFI requires ACPI */ - if ((def->os.firmware =3D=3D VIR_DOMAIN_OS_DEF_FIRMWARE_EFI || - virDomainDefHasOldStyleUEFI(def)) && - ARCH_IS_X86(def->os.arch) && - def->features[VIR_DOMAIN_FEATURE_ACPI] !=3D VIR_TRISTATE_SWITCH_ON= ) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("UEFI requires ACPI on this architecture")); - return -1; - } - - /* On aarch64, ACPI requires UEFI */ - if (def->features[VIR_DOMAIN_FEATURE_ACPI] =3D=3D VIR_TRISTATE_SWITCH_= ON && - def->os.arch =3D=3D VIR_ARCH_AARCH64 && - (def->os.firmware !=3D VIR_DOMAIN_OS_DEF_FIRMWARE_EFI && - !virDomainDefHasOldStyleUEFI(def))) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("ACPI requires UEFI on this architecture")); - return -1; - } - - if (def->os.loader && - def->os.loader->secure =3D=3D VIR_TRISTATE_BOOL_YES) { - /* These are the QEMU implementation limitations. But we - * have to live with them for now. */ - - if (!qemuDomainIsQ35(def)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Secure boot is supported with q35 machine ty= pes only")); - return -1; - } - - /* Now, technically it is possible to have secure boot on - * 32bits too, but that would require some -cpu xxx magic - * too. Not worth it unless we are explicitly asked. */ - if (def->os.arch !=3D VIR_ARCH_X86_64) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Secure boot is supported for x86_64 architec= ture only")); - return -1; - } - - /* SMM will be enabled by qemuFirmwareFillDomain() if needed. */ - if (def->os.firmware =3D=3D VIR_DOMAIN_OS_DEF_FIRMWARE_NONE && - def->features[VIR_DOMAIN_FEATURE_SMM] !=3D VIR_TRISTATE_SWITCH= _ON) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("Secure boot requires SMM feature enabled")); - return -1; - } - } - - if (def->genidRequested && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VMGENID)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("this QEMU does not support the 'genid' capabilit= y")); - return -1; - } - - /* Serial graphics adapter */ - if (def->os.bios.useserial =3D=3D VIR_TRISTATE_BOOL_YES) { - if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SGA)) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("qemu does not support SGA")); - return -1; - } - if (!def->nserials) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("need at least one serial port to use SGA")); - return -1; - } - } - - if (qemuValidateDomainDefClockTimers(def, qemuCaps) < 0) - return -1; - - if (qemuValidateDomainDefPM(def, qemuCaps) < 0) - return -1; - - if (qemuValidateDomainDefBoot(def, qemuCaps) < 0) - return -1; - - /* QEMU 2.7 (detected via the availability of query-hotpluggable-cpus) - * enforces stricter rules than previous versions when it comes to gue= st - * CPU topology. Verify known constraints are respected */ - if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_HOTPLUGGABLE_CPUS)) { - unsigned int topologycpus; - unsigned int granularity; - unsigned int numacpus; - - /* Starting from QEMU 2.5, max vCPU count and overall vCPU topology - * must agree. We only actually enforce this with QEMU 2.7+, due - * to the capability check above */ - if (virDomainDefGetVcpusTopology(def, &topologycpus) =3D=3D 0) { - if (topologycpus !=3D virDomainDefGetVcpusMax(def)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("CPU topology doesn't match maximum vcpu = count")); - return -1; - } - - numacpus =3D virDomainNumaGetCPUCountTotal(def->numa); - if ((numacpus !=3D 0) && (topologycpus !=3D numacpus)) { - VIR_WARN("CPU topology doesn't match numa CPU count; " - "partial NUMA mapping is obsoleted and will " - "be removed in future"); - } - } - - /* vCPU hotplug granularity must be respected */ - granularity =3D qemuDomainDefGetVcpuHotplugGranularity(def); - if ((virDomainDefGetVcpus(def) % granularity) !=3D 0) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("vCPUs count must be a multiple of the vCPU " - "hotplug granularity (%u)"), - granularity); - return -1; - } - } - - if (qemuValidateDomainCpuCount(def, qemuCaps) < 0) - return -1; - - if (ARCH_IS_X86(def->os.arch) && - virDomainDefGetVcpusMax(def) > QEMU_MAX_VCPUS_WITHOUT_EIM) { - if (!qemuDomainIsQ35(def)) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("more than %d vCPUs are only supported on " - "q35-based machine types"), - QEMU_MAX_VCPUS_WITHOUT_EIM); - return -1; - } - if (!def->iommu || def->iommu->eim !=3D VIR_TRISTATE_SWITCH_ON) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("more than %d vCPUs require extended interrup= t " - "mode enabled on the iommu device"), - QEMU_MAX_VCPUS_WITHOUT_EIM); - return -1; - } - } - - if (def->nresctrls && - def->virtType !=3D VIR_DOMAIN_VIRT_KVM) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("cachetune is only supported for KVM domains")); - return -1; - } - - if (qemuValidateDomainDefFeatures(def, qemuCaps) < 0) - return -1; - - if (qemuValidateDomainDefMemory(def, qemuCaps) < 0) - return -1; - - if (qemuValidateDomainDefNuma(def, qemuCaps) < 0) - return -1; - - if (qemuValidateDomainDefConsole(def, qemuCaps) < 0) - return -1; - - if (cfg->vncTLS && cfg->vncTLSx509secretUUID && - !virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_TLS_CREDS_X509)) { - for (i =3D 0; i < def->ngraphics; i++) { - if (def->graphics[i]->type =3D=3D VIR_DOMAIN_GRAPHICS_TYPE_VNC= ) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("encrypted VNC TLS keys are not supported= with " - "this QEMU binary")); - return -1; - } - } - } - - return 0; -} - =20 static bool qemuDomainNetSupportsCoalesce(virDomainNetType type) @@ -8919,7 +8667,7 @@ virDomainDefParserConfig virQEMUDriverDomainDefParser= Config =3D { .devicesPostParseCallback =3D qemuDomainDeviceDefPostParse, .domainPostParseCallback =3D qemuDomainDefPostParse, .assignAddressesCallback =3D qemuDomainDefAssignAddresses, - .domainValidateCallback =3D qemuDomainDefValidate, + .domainValidateCallback =3D qemuValidateDomainDef, .deviceValidateCallback =3D qemuDomainDeviceDefValidate, =20 .features =3D VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG | diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index b2a8c3c0b5..27e0558770 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -22,9 +22,13 @@ =20 #include "qemu_validate.h" #include "qemu_domain.h" +#include "virlog.h" #include "virutil.h" =20 #define VIR_FROM_THIS VIR_FROM_QEMU +#define QEMU_MAX_VCPUS_WITHOUT_EIM 255 + +VIR_LOG_INIT("qemu.qemu_validate"); =20 =20 static int @@ -136,7 +140,7 @@ qemuValidateDomainDefPSeriesFeature(const virDomainDef = *def, } =20 =20 -int +static int qemuValidateDomainDefFeatures(const virDomainDef *def, virQEMUCapsPtr qemuCaps) { @@ -311,7 +315,7 @@ qemuValidateDomainDefFeatures(const virDomainDef *def, } =20 =20 -int +static int qemuValidateDomainDefClockTimers(const virDomainDef *def, virQEMUCapsPtr qemuCaps) { @@ -449,7 +453,7 @@ qemuValidateDomainDefClockTimers(const virDomainDef *de= f, } =20 =20 -int +static int qemuValidateDomainDefPM(const virDomainDef *def, virQEMUCapsPtr qemuCaps) { @@ -481,7 +485,7 @@ qemuValidateDomainDefPM(const virDomainDef *def, } =20 =20 -int +static int qemuValidateDomainDefBoot(const virDomainDef *def, virQEMUCapsPtr qemuCaps) { @@ -507,7 +511,7 @@ qemuValidateDomainDefBoot(const virDomainDef *def, } =20 =20 -int +static int qemuValidateDomainCpuCount(const virDomainDef *def, virQEMUCapsPtr qemuCap= s) { unsigned int maxCpus =3D virQEMUCapsGetMachineMaxCpus(qemuCaps, def->v= irtType, @@ -530,7 +534,7 @@ qemuValidateDomainCpuCount(const virDomainDef *def, vir= QEMUCapsPtr qemuCaps) } =20 =20 -int +static int qemuValidateDomainDefMemory(const virDomainDef *def, virQEMUCapsPtr qemuCaps) { @@ -585,7 +589,7 @@ qemuValidateDomainDefMemory(const virDomainDef *def, } =20 =20 -int +static int qemuValidateDomainDefNuma(const virDomainDef *def, virQEMUCapsPtr qemuCaps) { @@ -648,7 +652,7 @@ qemuValidateDomainDefNuma(const virDomainDef *def, } =20 =20 -int +static int qemuValidateDomainDefConsole(const virDomainDef *def, virQEMUCapsPtr qemuCaps) { @@ -689,3 +693,252 @@ qemuValidateDomainDefConsole(const virDomainDef *def, =20 return 0; } + + +/** + * qemuValidateDefGetVcpuHotplugGranularity: + * @def: domain definition + * + * With QEMU 2.7 and newer, vCPUs can only be hotplugged in groups that + * respect the guest's hotplug granularity; because of that, QEMU will + * not allow guests to start unless the initial number of vCPUs is a + * multiple of the hotplug granularity. + * + * Returns the vCPU hotplug granularity. + */ +static unsigned int +qemuValidateDefGetVcpuHotplugGranularity(const virDomainDef *def) +{ + /* If the guest CPU topology has not been configured, assume we + * can hotplug vCPUs one at a time */ + if (!def->cpu || def->cpu->sockets =3D=3D 0) + return 1; + + /* For pSeries guests, hotplug can only be performed one core + * at a time, so the vCPU hotplug granularity is the number + * of threads per core */ + if (qemuDomainIsPSeries(def)) + return def->cpu->threads; + + /* In all other cases, we can hotplug vCPUs one at a time */ + return 1; +} + + +int +qemuValidateDomainDef(const virDomainDef *def, void *opaque) +{ + virQEMUDriverPtr driver =3D opaque; + g_autoptr(virQEMUDriverConfig) cfg =3D virQEMUDriverGetConfig(driver); + g_autoptr(virQEMUCaps) qemuCaps =3D NULL; + size_t i; + + if (!(qemuCaps =3D virQEMUCapsCacheLookup(driver->qemuCapsCache, + def->emulator))) + return -1; + + if (def->os.type !=3D VIR_DOMAIN_OSTYPE_HVM) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Emulator '%s' does not support os type '%s'"), + def->emulator, virDomainOSTypeToString(def->os.type= )); + return -1; + } + + if (!virQEMUCapsIsArchSupported(qemuCaps, def->os.arch)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Emulator '%s' does not support arch '%s'"), + def->emulator, virArchToString(def->os.arch)); + return -1; + } + + if (!virQEMUCapsIsVirtTypeSupported(qemuCaps, def->virtType)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Emulator '%s' does not support virt type '%s'"), + def->emulator, virDomainVirtTypeToString(def->virtT= ype)); + return -1; + } + + if (qemuCaps && + !virQEMUCapsIsMachineSupported(qemuCaps, def->virtType, def->os.ma= chine)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Emulator '%s' does not support machine type '%s'= "), + def->emulator, def->os.machine); + return -1; + } + + if (def->mem.min_guarantee) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Parameter 'min_guarantee' not supported by QEMU.= ")); + return -1; + } + + /* On x86, UEFI requires ACPI */ + if ((def->os.firmware =3D=3D VIR_DOMAIN_OS_DEF_FIRMWARE_EFI || + virDomainDefHasOldStyleUEFI(def)) && + ARCH_IS_X86(def->os.arch) && + def->features[VIR_DOMAIN_FEATURE_ACPI] !=3D VIR_TRISTATE_SWITCH_ON= ) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("UEFI requires ACPI on this architecture")); + return -1; + } + + /* On aarch64, ACPI requires UEFI */ + if (def->features[VIR_DOMAIN_FEATURE_ACPI] =3D=3D VIR_TRISTATE_SWITCH_= ON && + def->os.arch =3D=3D VIR_ARCH_AARCH64 && + (def->os.firmware !=3D VIR_DOMAIN_OS_DEF_FIRMWARE_EFI && + !virDomainDefHasOldStyleUEFI(def))) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("ACPI requires UEFI on this architecture")); + return -1; + } + + if (def->os.loader && + def->os.loader->secure =3D=3D VIR_TRISTATE_BOOL_YES) { + /* These are the QEMU implementation limitations. But we + * have to live with them for now. */ + + if (!qemuDomainIsQ35(def)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Secure boot is supported with q35 machine ty= pes only")); + return -1; + } + + /* Now, technically it is possible to have secure boot on + * 32bits too, but that would require some -cpu xxx magic + * too. Not worth it unless we are explicitly asked. */ + if (def->os.arch !=3D VIR_ARCH_X86_64) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Secure boot is supported for x86_64 architec= ture only")); + return -1; + } + + /* SMM will be enabled by qemuFirmwareFillDomain() if needed. */ + if (def->os.firmware =3D=3D VIR_DOMAIN_OS_DEF_FIRMWARE_NONE && + def->features[VIR_DOMAIN_FEATURE_SMM] !=3D VIR_TRISTATE_SWITCH= _ON) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("Secure boot requires SMM feature enabled")); + return -1; + } + } + + if (def->genidRequested && + !virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_VMGENID)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("this QEMU does not support the 'genid' capabilit= y")); + return -1; + } + + /* Serial graphics adapter */ + if (def->os.bios.useserial =3D=3D VIR_TRISTATE_BOOL_YES) { + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_SGA)) { + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", + _("qemu does not support SGA")); + return -1; + } + if (!def->nserials) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("need at least one serial port to use SGA")); + return -1; + } + } + + if (qemuValidateDomainDefClockTimers(def, qemuCaps) < 0) + return -1; + + if (qemuValidateDomainDefPM(def, qemuCaps) < 0) + return -1; + + if (qemuValidateDomainDefBoot(def, qemuCaps) < 0) + return -1; + + /* QEMU 2.7 (detected via the availability of query-hotpluggable-cpus) + * enforces stricter rules than previous versions when it comes to gue= st + * CPU topology. Verify known constraints are respected */ + if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_QUERY_HOTPLUGGABLE_CPUS)) { + unsigned int topologycpus; + unsigned int granularity; + unsigned int numacpus; + + /* Starting from QEMU 2.5, max vCPU count and overall vCPU topology + * must agree. We only actually enforce this with QEMU 2.7+, due + * to the capability check above */ + if (virDomainDefGetVcpusTopology(def, &topologycpus) =3D=3D 0) { + if (topologycpus !=3D virDomainDefGetVcpusMax(def)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("CPU topology doesn't match maximum vcpu = count")); + return -1; + } + + numacpus =3D virDomainNumaGetCPUCountTotal(def->numa); + if ((numacpus !=3D 0) && (topologycpus !=3D numacpus)) { + VIR_WARN("CPU topology doesn't match numa CPU count; " + "partial NUMA mapping is obsoleted and will " + "be removed in future"); + } + } + + /* vCPU hotplug granularity must be respected */ + granularity =3D qemuValidateDefGetVcpuHotplugGranularity(def); + if ((virDomainDefGetVcpus(def) % granularity) !=3D 0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("vCPUs count must be a multiple of the vCPU " + "hotplug granularity (%u)"), + granularity); + return -1; + } + } + + if (qemuValidateDomainCpuCount(def, qemuCaps) < 0) + return -1; + + if (ARCH_IS_X86(def->os.arch) && + virDomainDefGetVcpusMax(def) > QEMU_MAX_VCPUS_WITHOUT_EIM) { + if (!qemuDomainIsQ35(def)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("more than %d vCPUs are only supported on " + "q35-based machine types"), + QEMU_MAX_VCPUS_WITHOUT_EIM); + return -1; + } + if (!def->iommu || def->iommu->eim !=3D VIR_TRISTATE_SWITCH_ON) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("more than %d vCPUs require extended interrup= t " + "mode enabled on the iommu device"), + QEMU_MAX_VCPUS_WITHOUT_EIM); + return -1; + } + } + + if (def->nresctrls && + def->virtType !=3D VIR_DOMAIN_VIRT_KVM) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("cachetune is only supported for KVM domains")); + return -1; + } + + if (qemuValidateDomainDefFeatures(def, qemuCaps) < 0) + return -1; + + if (qemuValidateDomainDefMemory(def, qemuCaps) < 0) + return -1; + + if (qemuValidateDomainDefNuma(def, qemuCaps) < 0) + return -1; + + if (qemuValidateDomainDefConsole(def, qemuCaps) < 0) + return -1; + + if (cfg->vncTLS && cfg->vncTLSx509secretUUID && + !virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_TLS_CREDS_X509)) { + for (i =3D 0; i < def->ngraphics; i++) { + if (def->graphics[i]->type =3D=3D VIR_DOMAIN_GRAPHICS_TYPE_VNC= ) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("encrypted VNC TLS keys are not supported= with " + "this QEMU binary")); + return -1; + } + } + } + + return 0; +} diff --git a/src/qemu/qemu_validate.h b/src/qemu/qemu_validate.h index 85d1bc07cb..b6a6466a24 100644 --- a/src/qemu/qemu_validate.h +++ b/src/qemu/qemu_validate.h @@ -25,21 +25,4 @@ #include "domain_conf.h" #include "qemu_capabilities.h" =20 -int qemuValidateDomainDefFeatures(const virDomainDef *def, - virQEMUCapsPtr qemuCaps); -int qemuValidateDomainDefClockTimers(const virDomainDef *def, - virQEMUCapsPtr qemuCaps); -int qemuValidateDomainDefPM(const virDomainDef *def, - virQEMUCapsPtr qemuCaps); -int qemuValidateDomainDefBoot(const virDomainDef *def, - virQEMUCapsPtr qemuCaps); -int qemuValidateDomainCpuCount(const virDomainDef *def, - virQEMUCapsPtr qemuCaps); -int qemuValidateDomainCpuCount(const virDomainDef *def, - virQEMUCapsPtr qemuCaps); -int qemuValidateDomainDefMemory(const virDomainDef *def, - virQEMUCapsPtr qemuCaps); -int qemuValidateDomainDefNuma(const virDomainDef *def, - virQEMUCapsPtr qemuCaps); -int qemuValidateDomainDefConsole(const virDomainDef *def, - virQEMUCapsPtr qemuCaps); +int qemuValidateDomainDef(const virDomainDef *def, void *opaque); --=20 2.25.1