From nobody Fri Apr 19 09:54:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) client-ip=216.205.24.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1585218786; cv=none; d=zohomail.com; s=zohoarc; b=R6ROGG3dp0Bu5rUX6grni7Xkf+kjwQkkl9mrjiTRzrZHABKJ0OmtL9CrWU7BQ93mzCxBzH/68bffb7t7FwcLczXUw+k6nVJz7ptC1giFEl7b2R6KAGhvPo1f+wlpUYOBTMY/qU5yfwmpBSNtK7EiQPUOnZMo33ROP9hUlHzK+V0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585218786; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MaoguvIrC0OZsrgT1xrarj7C3w+72YD/1wQzHyr/7to=; b=eZf8h1uSA4t5VCQrYRXWj8QK9jqjqxp+JvboUnfOJZi8Nd4zRyAaykf5f7gZdn3n7v0EaH15XdFId6LpoDbfP1X8RLHG3rPMXjM5LcZX1IIHQE5V/ZdsJc066sR1wZyeiIWFp3YkHnVWbgpnKXteVasgKRJxXvFotJnifNwSd6w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.zohomail.com with SMTPS id 1585218786722265.9848755314132; Thu, 26 Mar 2020 03:33:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-367-BN4D2Z7VNxCu3KSO-XcTsA-1; Thu, 26 Mar 2020 06:32:59 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 1C36A18A6ECB; Thu, 26 Mar 2020 10:32:51 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DA3165C1D4; Thu, 26 Mar 2020 10:32:50 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 881FE18089D7; Thu, 26 Mar 2020 10:32:50 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02QAWe84016559 for ; Thu, 26 Mar 2020 06:32:40 -0400 Received: by smtp.corp.redhat.com (Postfix) id 41E572022EA5; Thu, 26 Mar 2020 10:32:40 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3DAF52026D67 for ; Thu, 26 Mar 2020 10:32:40 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1B1F18FF663 for ; Thu, 26 Mar 2020 10:32:40 +0000 (UTC) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-5pDoPNr3NbydftpAnKzGOw-1; Thu, 26 Mar 2020 06:32:37 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02QAWHCp016263 for ; Thu, 26 Mar 2020 06:32:37 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ywbuxvcx3-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Mar 2020 06:32:36 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Mar 2020 10:32:28 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 26 Mar 2020 10:32:26 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02QAWRe040304884 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Mar 2020 10:32:28 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DB4B711C050; Thu, 26 Mar 2020 10:32:27 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ACE6711C05B; Thu, 26 Mar 2020 10:32:27 +0000 (GMT) Received: from m46lp64.lnxne.boe (unknown [9.152.108.100]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 26 Mar 2020 10:32:27 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585218785; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=MaoguvIrC0OZsrgT1xrarj7C3w+72YD/1wQzHyr/7to=; b=LK3d8dKI1xBKiSP7EP33q2hoJ8LutXW9/rRvYS/aPx6xFhRTtcOX7Xr32KY50FD+auPKb0 GwDVtZlTjEWRLluicnBDRDjS5NpLwBcViXlVkplv5o0V+Uv6vcGHLmWgSWZhP5yxcDFgqc FF2i62r4rlQUsnO6M0E4uQOnQrPG6hE= X-MC-Unique: BN4D2Z7VNxCu3KSO-XcTsA-1 X-MC-Unique: 5pDoPNr3NbydftpAnKzGOw-1 From: Bjoern Walk To: libvir-list@redhat.com Subject: [PATCH 1/4] qemu: capabilities: add 'packed' capability Date: Thu, 26 Mar 2020 11:32:11 +0100 In-Reply-To: <20200326103214.2137298-1-bwalk@linux.ibm.com> References: <20200326103214.2137298-1-bwalk@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 20032610-0012-0000-0000-000003986917 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20032610-0013-0000-0000-000021D56465 Message-Id: <20200326103214.2137298-2-bwalk@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645 definitions=2020-03-26_02:2020-03-24, 2020-03-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 suspectscore=1 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003260075 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02QAWe84016559 X-loop: libvir-list@redhat.com Cc: Bjoern Walk , pasic@linux.vnet.ibm.com, fiuczy@linux.ibm.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Add the capability for QEMU's packed virtqueues for virtio that supposedly = have better cache utilization and performance compared to the default split queu= es. Signed-off-by: Bjoern Walk Reviewed-by: Boris Fiuczynski Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_capabilities.c | 6 ++++++ src/qemu/qemu_capabilities.h | 1 + tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml | 1 + tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml | 1 + 7 files changed, 12 insertions(+) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index a95a60c3..3bc876d7 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -567,6 +567,7 @@ VIR_ENUM_IMPL(virQEMUCaps, "query-named-block-nodes.flat", "blockdev-snapshot.allow-write-only-overlay", "blockdev-reopen", + "virtio.packed", ); =20 =20 @@ -1291,6 +1292,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic= ePropsVirtioBalloon[] =3D { { "disable-legacy", QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY }, { "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM }, { "ats", QEMU_CAPS_VIRTIO_PCI_ATS }, + { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES }, }; =20 static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVirtioBlk[] =3D= { @@ -1304,6 +1306,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic= ePropsVirtioBlk[] =3D { { "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM }, { "ats", QEMU_CAPS_VIRTIO_PCI_ATS }, { "write-cache", QEMU_CAPS_DISK_WRITE_CACHE }, + { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES }, }; =20 static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVirtioNet[] =3D= { @@ -1316,6 +1319,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic= ePropsVirtioNet[] =3D { { "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM }, { "ats", QEMU_CAPS_VIRTIO_PCI_ATS }, { "failover", QEMU_CAPS_VIRTIO_NET_FAILOVER }, + { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES }, }; =20 static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsSpaprPCIHostBri= dge[] =3D { @@ -1327,6 +1331,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic= ePropsVirtioSCSI[] =3D { { "disable-legacy", QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY }, { "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM }, { "ats", QEMU_CAPS_VIRTIO_PCI_ATS }, + { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES }, }; =20 static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsVfioPCI[] =3D { @@ -1395,6 +1400,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsDevic= ePropsVirtioGpu[] =3D { { "disable-legacy", QEMU_CAPS_VIRTIO_PCI_DISABLE_LEGACY }, { "iommu_platform", QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM }, { "ats", QEMU_CAPS_VIRTIO_PCI_ATS }, + { "packed", QEMU_CAPS_VIRTIO_PACKED_QUEUES }, }; =20 static struct virQEMUCapsStringFlags virQEMUCapsDevicePropsICH9[] =3D { diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index f0961e27..21c09974 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -548,6 +548,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for = syntax-check */ QEMU_CAPS_QMP_QUERY_NAMED_BLOCK_NODES_FLAT, /* query-named-block-nodes= supports the 'flat' option */ QEMU_CAPS_BLOCKDEV_SNAPSHOT_ALLOW_WRITE_ONLY, /* blockdev-snapshot has= the 'allow-write-only-overlay' feature */ QEMU_CAPS_BLOCKDEV_REOPEN, /* 'blockdev-reopen' qmp command is support= ed */ + QEMU_CAPS_VIRTIO_PACKED_QUEUES, /* virtio packed virtqueue support */ =20 QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml b/tests/qemu= capabilitiesdata/caps_4.2.0.aarch64.xml index 640ce29c..f1b7fbbe 100644 --- a/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_4.2.0.aarch64.xml @@ -179,6 +179,7 @@ + 4001050 0 61700242 diff --git a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_4.2.0.x86_64.xml index 83e804ea..15388967 100644 --- a/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_4.2.0.x86_64.xml @@ -223,6 +223,7 @@ + 4002000 0 43100242 diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml b/tests/qemu= capabilitiesdata/caps_5.0.0.aarch64.xml index e52c6060..9ef8564a 100644 --- a/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml +++ b/tests/qemucapabilitiesdata/caps_5.0.0.aarch64.xml @@ -181,6 +181,7 @@ + 4002050 0 61700241 diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml b/tests/qemuca= pabilitiesdata/caps_5.0.0.ppc64.xml index 85fdb21c..a2d78ac0 100644 --- a/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml +++ b/tests/qemucapabilitiesdata/caps_5.0.0.ppc64.xml @@ -189,6 +189,7 @@ + 4002050 0 42900241 diff --git a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml b/tests/qemuc= apabilitiesdata/caps_5.0.0.x86_64.xml index d773f7e3..b6a6b3be 100644 --- a/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml +++ b/tests/qemucapabilitiesdata/caps_5.0.0.x86_64.xml @@ -226,6 +226,7 @@ + 4002050 0 43100241 --=20 2.24.1 From nobody Fri Apr 19 09:54:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1585218773; cv=none; d=zohomail.com; s=zohoarc; b=eNiQzXd8BlffnyrKsq79UqD/JltH6qCODHYEuMtoDHWzzsTpzqY5ly7H7/lTuvkNa93GD2n+lolJt0s+x9fpttHvwZuGN+4/l0rEdKTzE3/mSjhFXPmw+woJn6XOCEJwhJBU467kEczy06IZtb7MhXdLE3lgRRKeiFLGTgfW4GU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585218773; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=V8FGANX/oACcssB3TA6WbBpUzjJWKTeASKyXEL2z9Oc=; b=lyTsvdXtP+ThJ4jd0ZNBck2/Bha/NS4a1Vg2Nuq9FwK07c/JdtFAUw2ri70vyQQdkJoKoZv69tyroDGxaXmSOXvK/mR5sVlM1WqrYpGOzpn8DPTT95tZHGvJErrOSlOV+FXeToYJH0t3uRdLzTZEC2XtbGk6wvNRGcej74csiV0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 1585218773683102.56214009277835; Thu, 26 Mar 2020 03:32:53 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-I3GU8DlgPU-LYD272q9NAg-1; Thu, 26 Mar 2020 06:32:49 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A8D111005510; Thu, 26 Mar 2020 10:32:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7D9B760BF7; Thu, 26 Mar 2020 10:32:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1E41318089CD; Thu, 26 Mar 2020 10:32:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02QAWdrY016542 for ; Thu, 26 Mar 2020 06:32:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id F0B822028CD4; Thu, 26 Mar 2020 10:32:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ECD132026D67 for ; Thu, 26 Mar 2020 10:32:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D26D68FF665 for ; Thu, 26 Mar 2020 10:32:38 +0000 (UTC) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-oL--juy9M1SAPxm71yISFg-1; Thu, 26 Mar 2020 06:32:36 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02QAW8Xe002273 for ; Thu, 26 Mar 2020 06:32:35 -0400 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0a-001b2d01.pphosted.com with ESMTP id 2ywe7vrfwf-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Mar 2020 06:32:34 -0400 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Mar 2020 10:32:28 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 26 Mar 2020 10:32:26 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02QAWSTb50135054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Mar 2020 10:32:28 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1740E11C04C; Thu, 26 Mar 2020 10:32:28 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E670B11C052; Thu, 26 Mar 2020 10:32:27 +0000 (GMT) Received: from m46lp64.lnxne.boe (unknown [9.152.108.100]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 26 Mar 2020 10:32:27 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585218772; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=V8FGANX/oACcssB3TA6WbBpUzjJWKTeASKyXEL2z9Oc=; b=UvOk+ucMFWY8m4V02Y+6k0MfwvTzBo/ckUJyq3zJXT5WzTNLyh2C4+9ESC6ar71+Lhyw/Z m3JnEngLolPWPx9GrEnouUDq0qeWrw4HELcEkjHpDABwNZIwaYY/XPSIvcydAAeqL8mqoH 8vUMz7xSSfvdG3AZlOdBb9qdDpldo5I= X-MC-Unique: I3GU8DlgPU-LYD272q9NAg-1 X-MC-Unique: oL--juy9M1SAPxm71yISFg-1 From: Bjoern Walk To: libvir-list@redhat.com Subject: [PATCH 2/4] conf: domain: support for virtio packed option Date: Thu, 26 Mar 2020 11:32:12 +0100 In-Reply-To: <20200326103214.2137298-1-bwalk@linux.ibm.com> References: <20200326103214.2137298-1-bwalk@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 20032610-0008-0000-0000-000003649557 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20032610-0009-0000-0000-00004A8608A4 Message-Id: <20200326103214.2137298-3-bwalk@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645 definitions=2020-03-26_02:2020-03-24, 2020-03-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 impostorscore=0 bulkscore=0 phishscore=0 spamscore=0 adultscore=0 mlxscore=0 lowpriorityscore=0 suspectscore=3 malwarescore=0 priorityscore=1501 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003260075 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02QAWdrY016542 X-loop: libvir-list@redhat.com Cc: Bjoern Walk , pasic@linux.vnet.ibm.com, fiuczy@linux.ibm.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Expose the virtio parameter for packed virtqueues as a optional libvirt XML attribute to virtio-backed devices, e.g.: If the attribute is omitted, the default value for this attribute is 'off' = and regular split virtqueues are used. Reviewed-by: Boris Fiuczynski Signed-off-by: Bjoern Walk Reviewed-by: J=C3=A1n Tomko --- docs/schemas/domaincommon.rng | 5 +++++ src/conf/domain_conf.c | 28 ++++++++++++++++++++++++++++ src/conf/domain_conf.h | 1 + 3 files changed, 34 insertions(+) diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng index d79dee65..b6d7297b 100644 --- a/docs/schemas/domaincommon.rng +++ b/docs/schemas/domaincommon.rng @@ -5921,6 +5921,11 @@ + + + + + =20 diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 27bc5a79..ca45a6a5 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -1505,6 +1505,16 @@ virDomainVirtioOptionsParseXML(xmlNodePtr driver, } res->ats =3D val; } + VIR_FREE(str); + + if ((str =3D virXMLPropString(driver, "packed"))) { + if ((val =3D virTristateSwitchTypeFromString(str)) <=3D 0) { + virReportError(VIR_ERR_XML_ERROR, "%s", + _("invalid packed value")); + return -1; + } + res->packed =3D val; + } =20 return 0; } @@ -5084,6 +5094,12 @@ virDomainCheckVirtioOptions(virDomainVirtioOptionsPt= r virtio) "for virtio devices")); return -1; } + if (virtio->packed !=3D VIR_TRISTATE_SWITCH_ABSENT) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("packed driver option is only supported " + "for virtio devices")); + return -1; + } return 0; } =20 @@ -7370,6 +7386,10 @@ virDomainVirtioOptionsFormat(virBufferPtr buf, virBufferAsprintf(buf, " ats=3D'%s'", virTristateSwitchTypeToString(virtio->ats)); } + if (virtio->packed !=3D VIR_TRISTATE_SWITCH_ABSENT) { + virBufferAsprintf(buf, " packed=3D'%s'", + virTristateSwitchTypeToString(virtio->packed)); + } } =20 =20 @@ -22392,6 +22412,14 @@ virDomainVirtioOptionsCheckABIStability(virDomainV= irtioOptionsPtr src, virTristateSwitchTypeToString(src->ats)); return false; } + if (src->packed !=3D dst->packed) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Target device packed option '%s' does not " + "match source '%s'"), + virTristateSwitchTypeToString(dst->packed), + virTristateSwitchTypeToString(src->packed)); + return false; + } return true; } =20 diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h index 33875d94..ef322593 100644 --- a/src/conf/domain_conf.h +++ b/src/conf/domain_conf.h @@ -2404,6 +2404,7 @@ struct _virDomainVsockDef { struct _virDomainVirtioOptions { virTristateSwitch iommu; virTristateSwitch ats; + virTristateSwitch packed; }; =20 /* --=20 2.24.1 From nobody Fri Apr 19 09:54:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1585218786; cv=none; d=zohomail.com; s=zohoarc; b=Tz3CMvhoo65HIdk1wdj2pQJAGefbCUfedY6IN64rNHOGEu9mJsaqvaT/V1Dj2JXjih/CdmrEGifB56NhlaqBqYmKqJopGpG430F/z3yIQqJwVYHp0OK+io4yjlCW6vEe8QclmxLVNhJfayliQIdXMnbHkgrJLMgrUteNhC8RhnQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585218786; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=JdxLE+VS6UkPzHiqyi1+H7fHzf546t0WJnGpeWUcqW4=; b=ANpkVN414sSTj6SrSXlXe/jU0cGfMp2RIxMRmOH1ov27NRQglhNx7tHiLtNuHPDy31Mt7tjEwScwWqQ7Vny0C0A8B5egckOsECaI1y4waFTiSHV0drprm4lDH2KKv71y0ohd2Sg5vF5wrMJu6IhVOiTwtbfHjNTRwAcLFBeHgGQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 158521878653646.076539066221926; Thu, 26 Mar 2020 03:33:06 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-98-B-h1XYWyMG-NiDi4WKJQRg-1; Thu, 26 Mar 2020 06:32:49 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8935107ACCA; Thu, 26 Mar 2020 10:32:43 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9AD1F60C18; Thu, 26 Mar 2020 10:32:43 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9AC0B18089CE; Thu, 26 Mar 2020 10:32:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02QAWcPY016541 for ; Thu, 26 Mar 2020 06:32:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id BF58D2028CD2; Thu, 26 Mar 2020 10:32:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BB3192026D67 for ; Thu, 26 Mar 2020 10:32:38 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 94BE180028B for ; Thu, 26 Mar 2020 10:32:38 +0000 (UTC) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-TFNCc1j-MMWFLmvVHYuUWQ-1; Thu, 26 Mar 2020 06:32:36 -0400 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02QAW1OY133604 for ; Thu, 26 Mar 2020 06:32:35 -0400 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 2yxw7fs9gc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Mar 2020 06:32:35 -0400 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Mar 2020 10:32:29 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 26 Mar 2020 10:32:27 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02QAWShR38273234 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Mar 2020 10:32:28 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5DFFD11C04A; Thu, 26 Mar 2020 10:32:28 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BD0E11C05B; Thu, 26 Mar 2020 10:32:28 +0000 (GMT) Received: from m46lp64.lnxne.boe (unknown [9.152.108.100]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 26 Mar 2020 10:32:28 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585218785; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=JdxLE+VS6UkPzHiqyi1+H7fHzf546t0WJnGpeWUcqW4=; b=UD0t9QDoklPBN5lY43TQQfBKTeRwpn5Stqw6UE7Ry1ZPaTiqEYWhuDY4C514UtMmYJZutT EMXuzvp9d0pi5Qojz0h+zS8uGYbCowqt/snROqmaXr8tvFqhri480Xc14BuCbNpX9cDoeo sFL8z0jfhQAR4eAbi1CUciYkh3YvIQ4= X-MC-Unique: B-h1XYWyMG-NiDi4WKJQRg-1 X-MC-Unique: TFNCc1j-MMWFLmvVHYuUWQ-1 From: Bjoern Walk To: libvir-list@redhat.com Subject: [PATCH 3/4] qemu: command: support for virtio packed option Date: Thu, 26 Mar 2020 11:32:13 +0100 In-Reply-To: <20200326103214.2137298-1-bwalk@linux.ibm.com> References: <20200326103214.2137298-1-bwalk@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 20032610-0012-0000-0000-000003986918 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20032610-0013-0000-0000-000021D56466 Message-Id: <20200326103214.2137298-4-bwalk@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645 definitions=2020-03-26_02:2020-03-24, 2020-03-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 suspectscore=1 bulkscore=0 priorityscore=1501 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003260075 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02QAWcPY016541 X-loop: libvir-list@redhat.com Cc: Bjoern Walk , pasic@linux.vnet.ibm.com, fiuczy@linux.ibm.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Pass the packed option on the QEMU command line of the capability for packed virtqueues is detected and the parameter is set explicitly. Signed-off-by: Bjoern Walk Reviewed-by: Boris Fiuczynski Reviewed-by: J=C3=A1n Tomko --- src/qemu/qemu_command.c | 10 +++++++ tests/qemuxml2argvdata/virtio-options.args | 32 ++++++++++++---------- tests/qemuxml2argvdata/virtio-options.xml | 26 +++++++++--------- tests/qemuxml2argvtest.c | 3 +- tests/qemuxml2xmltest.c | 3 +- 5 files changed, 44 insertions(+), 30 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index d1b689df..81f089ba 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -614,6 +614,16 @@ qemuBuildVirtioOptionsStr(virBufferPtr buf, virBufferAsprintf(buf, ",ats=3D%s", virTristateSwitchTypeToString(virtio->ats)); } + if (virtio->packed !=3D VIR_TRISTATE_SWITCH_ABSENT) { + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_VIRTIO_PACKED_QUEUES)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("the packed setting is not supported with thi= s " + "QEMU binary")); + return -1; + } + virBufferAsprintf(buf, ",packed=3D%s", + virTristateSwitchTypeToString(virtio->packed)); + } =20 return 0; } diff --git a/tests/qemuxml2argvdata/virtio-options.args b/tests/qemuxml2arg= vdata/virtio-options.args index 33ecd8f4..8253a788 100644 --- a/tests/qemuxml2argvdata/virtio-options.args +++ b/tests/qemuxml2argvdata/virtio-options.args @@ -24,36 +24,38 @@ server,nowait \ -rtc base=3Dutc \ -no-shutdown \ -no-acpi \ --device virtio-scsi-pci,iommu_platform=3Don,ats=3Don,id=3Dscsi0,bus=3Dpci.= 0,addr=3D0x8 \ --device virtio-serial-pci,id=3Dvirtio-serial0,iommu_platform=3Don,ats=3Don= ,bus=3Dpci.0,\ -addr=3D0x9 \ +-device virtio-scsi-pci,iommu_platform=3Don,ats=3Don,packed=3Don,id=3Dscsi= 0,bus=3Dpci.0,\ +addr=3D0x8 \ +-device virtio-serial-pci,id=3Dvirtio-serial0,iommu_platform=3Don,ats=3Don= ,packed=3Don,\ +bus=3Dpci.0,addr=3D0x9 \ -usb \ -drive file=3D/var/lib/libvirt/images/img1,format=3Draw,if=3Dnone,\ id=3Ddrive-virtio-disk0 \ --device virtio-blk-pci,iommu_platform=3Don,ats=3Don,bus=3Dpci.0,addr=3D0xa= ,\ +-device virtio-blk-pci,iommu_platform=3Don,ats=3Don,packed=3Don,bus=3Dpci.= 0,addr=3D0xa,\ drive=3Ddrive-virtio-disk0,id=3Dvirtio-disk0,bootindex=3D1 \ -fsdev local,security_model=3Dpassthrough,id=3Dfsdev-fs0,path=3D/export/fs= 1 \ -device virtio-9p-pci,id=3Dfs0,fsdev=3Dfsdev-fs0,mount_tag=3Dfs1,iommu_pla= tform=3Don,\ -ats=3Don,bus=3Dpci.0,addr=3D0x3 \ +ats=3Don,packed=3Don,bus=3Dpci.0,addr=3D0x3 \ -fsdev local,security_model=3Dmapped,writeout=3Dimmediate,id=3Dfsdev-fs1,\ path=3D/export/fs2 \ -device virtio-9p-pci,id=3Dfs1,fsdev=3Dfsdev-fs1,mount_tag=3Dfs2,iommu_pla= tform=3Don,\ -ats=3Don,bus=3Dpci.0,addr=3D0x4 \ +ats=3Don,packed=3Don,bus=3Dpci.0,addr=3D0x4 \ -netdev user,id=3Dhostnet0 \ -device virtio-net-pci,netdev=3Dhostnet0,id=3Dnet0,mac=3D52:54:56:58:5a:5c= ,bus=3Dpci.0,\ -addr=3D0x6,iommu_platform=3Don,ats=3Don \ --device virtio-mouse-pci,id=3Dinput0,bus=3Dpci.0,addr=3D0xe,iommu_platform= =3Don,ats=3Don \ +addr=3D0x6,iommu_platform=3Don,ats=3Don,packed=3Don \ +-device virtio-mouse-pci,id=3Dinput0,bus=3Dpci.0,addr=3D0xe,iommu_platform= =3Don,ats=3Don,\ +packed=3Don \ -device virtio-keyboard-pci,id=3Dinput1,bus=3Dpci.0,addr=3D0x10,iommu_plat= form=3Don,\ -ats=3Don \ +ats=3Don,packed=3Don \ -device virtio-tablet-pci,id=3Dinput2,bus=3Dpci.0,addr=3D0x11,iommu_platfo= rm=3Don,\ -ats=3Don \ +ats=3Don,packed=3Don \ -device virtio-input-host-pci,id=3Dinput3,evdev=3D/dev/input/event1234,bus= =3Dpci.0,\ -addr=3D0x12,iommu_platform=3Don,ats=3Don \ +addr=3D0x12,iommu_platform=3Don,ats=3Don,packed=3Don \ -chardev socket,id=3Dchr-vu-video0,fd=3D1729 \ -device vhost-user-gpu-pci,id=3Dvideo0,max_outputs=3D1,chardev=3Dchr-vu-vi= deo0,\ -bus=3Dpci.0,addr=3D0x2,iommu_platform=3Don,ats=3Don \ +bus=3Dpci.0,addr=3D0x2,iommu_platform=3Don,ats=3Don,packed=3Don \ -device virtio-balloon-pci,id=3Dballoon0,bus=3Dpci.0,addr=3D0xc,iommu_plat= form=3Don,\ -ats=3Don \ +ats=3Don,packed=3Don \ -object rng-random,id=3Dobjrng0,filename=3D/dev/random \ --device virtio-rng-pci,rng=3Dobjrng0,id=3Drng0,iommu_platform=3Don,ats=3Do= n,bus=3Dpci.0,\ -addr=3D0xd +-device virtio-rng-pci,rng=3Dobjrng0,id=3Drng0,iommu_platform=3Don,ats=3Do= n,packed=3Don,\ +bus=3Dpci.0,addr=3D0xd diff --git a/tests/qemuxml2argvdata/virtio-options.xml b/tests/qemuxml2argv= data/virtio-options.xml index dd9a4f4a..3ca27840 100644 --- a/tests/qemuxml2argvdata/virtio-options.xml +++ b/tests/qemuxml2argvdata/virtio-options.xml @@ -15,7 +15,7 @@ /usr/bin/qemu-system-x86_64 - +
@@ -27,22 +27,22 @@
- +
- +
- +
- +
@@ -50,30 +50,30 @@ - +
- +
- +
- +
- +
- + /dev/random - +
diff --git a/tests/qemuxml2argvtest.c b/tests/qemuxml2argvtest.c index 4d44286b..f66c9854 100644 --- a/tests/qemuxml2argvtest.c +++ b/tests/qemuxml2argvtest.c @@ -2987,7 +2987,8 @@ mymain(void) QEMU_CAPS_OBJECT_RNG_RANDOM, QEMU_CAPS_DEVICE_VIDEO_PRIMARY, QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM, - QEMU_CAPS_VIRTIO_PCI_ATS); + QEMU_CAPS_VIRTIO_PCI_ATS, + QEMU_CAPS_VIRTIO_PACKED_QUEUES); =20 DO_TEST("fd-memory-numa-topology", QEMU_CAPS_OBJECT_MEMORY_FILE, QEMU_CAPS_KVM); diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c index a3c25b4a..5675957d 100644 --- a/tests/qemuxml2xmltest.c +++ b/tests/qemuxml2xmltest.c @@ -1289,7 +1289,8 @@ mymain(void) QEMU_CAPS_DEVICE_VIDEO_PRIMARY, QEMU_CAPS_VIRTIO_PCI_IOMMU_PLATFORM, QEMU_CAPS_VIRTIO_PCI_ATS, - QEMU_CAPS_DEVICE_VHOST_USER_GPU); + QEMU_CAPS_DEVICE_VHOST_USER_GPU, + QEMU_CAPS_VIRTIO_PACKED_QUEUES); =20 DO_TEST("fd-memory-numa-topology", QEMU_CAPS_OBJECT_MEMORY_FILE, QEMU_CAPS_KVM); --=20 2.24.1 From nobody Fri Apr 19 09:54:29 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=linux.ibm.com ARC-Seal: i=1; a=rsa-sha256; t=1585218778; cv=none; d=zohomail.com; s=zohoarc; b=KXZDvYBKf/Ev7kUAqRF7/7WusPHmQ1HRy2VTIH/0GkNFwNmtBNoLFGmlT+A6UTNqZTG0ACuvBvR5AUVcyDTDYG+wbKGY+Tee53mjM9WPHYQ8MFs5xvRGyosFDAkVeFDTL8m5M8ASVoNQGw08L+Xgcgc2763uMvQvukMqSZJSr8c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585218778; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yepY0fBG30wMmDDwKBmiYCSUXjQT9bd4vvdgmAzWJVc=; b=D1BiAISmQ5+f19rHYgVhk1yt92DvchzAS6EufILz04/Z8QaP12683I8pn+XoRUD55PbeFV7twPBF+d+m+kz4zfaWsIX4c43X05A2r0+dSREOmXNqRkQCnN8AzY5ifRr8zNXglhkKChHqhvJ4L0Fa+L+uVtN/t2RCoYm66RA3bM4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 158521877870280.13617902944122; Thu, 26 Mar 2020 03:32:58 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-H5prDTpKM3yGLh9o0x8DVQ-1; Thu, 26 Mar 2020 06:32:55 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 08CB42F2B; Thu, 26 Mar 2020 10:32:50 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2E135C1D4; Thu, 26 Mar 2020 10:32:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8DF5D8A03E; Thu, 26 Mar 2020 10:32:49 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02QAWdID016547 for ; Thu, 26 Mar 2020 06:32:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id 167F9114D17; Thu, 26 Mar 2020 10:32:39 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11C4A114D03 for ; Thu, 26 Mar 2020 10:32:37 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1E5D7800294 for ; Thu, 26 Mar 2020 10:32:37 +0000 (UTC) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-140-qK0swqQdOiqE0dGsG8Gesw-1; Thu, 26 Mar 2020 06:32:34 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 02QAWH1J016244 for ; Thu, 26 Mar 2020 06:32:34 -0400 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0b-001b2d01.pphosted.com with ESMTP id 2ywbuxvcxt-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 26 Mar 2020 06:32:33 -0400 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Mar 2020 10:32:26 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 26 Mar 2020 10:32:24 -0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 02QAWS2d38273238 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 26 Mar 2020 10:32:28 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A12D711C04A; Thu, 26 Mar 2020 10:32:28 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 68FAF11C04C; Thu, 26 Mar 2020 10:32:28 +0000 (GMT) Received: from m46lp64.lnxne.boe (unknown [9.152.108.100]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 26 Mar 2020 10:32:28 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585218777; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=yepY0fBG30wMmDDwKBmiYCSUXjQT9bd4vvdgmAzWJVc=; b=aV4OFuhbMM9rVLQgykhLbhPDjzf+IFJ+FufHRK1iutpnf11XZmkBcW/InUEQuVk9FF7nDZ wMA4LeEem7oKnvLV3cprXLFOmFBV1odJkynLSvJKcVN4j49On2HoWU79TVI5ICLtEYTGzV +faChhhBLuTS9y0HWXp6UQz3QQivNIM= X-MC-Unique: H5prDTpKM3yGLh9o0x8DVQ-1 X-MC-Unique: qK0swqQdOiqE0dGsG8Gesw-1 From: Bjoern Walk To: libvir-list@redhat.com Subject: [PATCH 4/4] docs: documentation for virtio packed option Date: Thu, 26 Mar 2020 11:32:14 +0100 In-Reply-To: <20200326103214.2137298-1-bwalk@linux.ibm.com> References: <20200326103214.2137298-1-bwalk@linux.ibm.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 20032610-0020-0000-0000-000003BBB7C9 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20032610-0021-0000-0000-0000221441D9 Message-Id: <20200326103214.2137298-5-bwalk@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.645 definitions=2020-03-26_02:2020-03-24, 2020-03-26 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 malwarescore=0 bulkscore=0 adultscore=0 mlxscore=0 phishscore=0 impostorscore=0 mlxlogscore=999 suspectscore=15 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003260075 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02QAWdID016547 X-loop: libvir-list@redhat.com Cc: Bjoern Walk , pasic@linux.vnet.ibm.com, fiuczy@linux.ibm.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Reviewed-by: Boris Fiuczynski Signed-off-by: Bjoern Walk --- docs/formatdomain.html.in | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index fb07d107..f8bfef7d 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -4321,6 +4321,14 @@ Possible values are on or off. Since 3.5.0

+

+ The attribute packed controls the usage of packed + virtqueues. Compared to regular split queues, packed queues consist = of + only a single descriptor ring replacing available and used ring, ind= ex + and descriptor buffer. This can result in better cache utilization a= nd + performance. Possible values are on or off. + Since 6.3.0 (QEMU and KVM only) +

=20

Virtio transitional devices

=20 --=20 2.24.1