From nobody Thu Mar 28 23:12:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1585005179; cv=none; d=zohomail.com; s=zohoarc; b=dirYPUyA4PtlspF2pDskyymIUd/cd+Jx7trbprIhbp6tGlBhQSj35LF2+F5nqS8ejW8yiz6c/8gwfdImbKCGGKqE/rALJGXugqmLPwO/xiKZ3k/8nF28AMrGrnEZlKzVXxf7AZ7Xs+WuS9fCnhqW80vn2GgWp+yTptSYVhY8sIk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1585005179; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ceWFg8C2zyVqg084FIQaNe7RfSMMfXXzEHYn1KMhjHE=; b=MBp9qs6rTmQs67DBegUingQ78xybkuIro9LzpzO5JFkPrVlMQpEmb2WI+QfjWZz7oWiM6kPiDFCXbF/N0M+WASPDxveJUHUummv+9AXcFRZaoNRhEin6XkRos193pID3Oh+994F16rbjQHbiUfq34mjNokb8wBCMhVMx7GO4/sA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 1585005179665701.6826863753321; Mon, 23 Mar 2020 16:12:59 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-70-Z84v0MSaP3Wne07avUhbtw-1; Mon, 23 Mar 2020 19:12:55 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0EB6C1050943; Mon, 23 Mar 2020 23:12:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id BF4A619C4F; Mon, 23 Mar 2020 23:12:47 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 1EE8D1809567; Mon, 23 Mar 2020 23:12:42 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02NNCfgl019246 for ; Mon, 23 Mar 2020 19:12:41 -0400 Received: by smtp.corp.redhat.com (Postfix) id 82787100D7C; Mon, 23 Mar 2020 23:12:41 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7E24EF1011 for ; Mon, 23 Mar 2020 23:12:39 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 31B2D800297 for ; Mon, 23 Mar 2020 23:12:39 +0000 (UTC) Received: from m4a0072g.houston.softwaregrp.com (m4a0072g.houston.softwaregrp.com [15.124.2.130]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-468-lMK0DUHFOe-DjFWnpDaDRA-1; Mon, 23 Mar 2020 19:12:36 -0400 Received: FROM m4a0072g.houston.softwaregrp.com (15.120.17.146) BY m4a0072g.houston.softwaregrp.com WITH ESMTP FOR libvir-list@redhat.com; Mon, 23 Mar 2020 23:11:18 +0000 Received: from M4W0334.microfocus.com (2002:f78:1192::f78:1192) by M4W0334.microfocus.com (2002:f78:1192::f78:1192) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Mon, 23 Mar 2020 23:09:43 +0000 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (15.124.8.10) by M4W0334.microfocus.com (15.120.17.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Mon, 23 Mar 2020 23:09:43 +0000 Received: from BY5PR18MB3315.namprd18.prod.outlook.com (2603:10b6:a03:196::12) by BY5PR18MB3204.namprd18.prod.outlook.com (2603:10b6:a03:1a9::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.20; Mon, 23 Mar 2020 23:09:42 +0000 Received: from BY5PR18MB3315.namprd18.prod.outlook.com ([fe80::6157:7c41:b13d:23f5]) by BY5PR18MB3315.namprd18.prod.outlook.com ([fe80::6157:7c41:b13d:23f5%3]) with mapi id 15.20.2835.021; Mon, 23 Mar 2020 23:09:42 +0000 Received: from linux-tbji.provo.novell.com (75.169.23.17) by SN6PR16CA0056.namprd16.prod.outlook.com (2603:10b6:805:ca::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2835.18 via Frontend Transport; Mon, 23 Mar 2020 23:09:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585005178; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=ceWFg8C2zyVqg084FIQaNe7RfSMMfXXzEHYn1KMhjHE=; b=Y+9Dn7xp2W/mTPLWqtx0UNesRRnqwyuXQjmtYRXE2P9Q8tWlYGijCbyblMjZMq3tEobjA5 Om4fFRcsUVnLMYSrZwPeYWscTpL3i3Z7NPoRbAByXe+I4EJZN2MqZkVbEdNIOMqmcU75Wk OlYSIce3WCa5pciPCwiVsaciHpi/P9Y= X-MC-Unique: Z84v0MSaP3Wne07avUhbtw-1 X-MC-Unique: lMK0DUHFOe-DjFWnpDaDRA-1 From: Jim Fehlig To: Subject: [libvirt-tck] scripts: fix disk media change test Date: Mon, 23 Mar 2020 17:09:24 -0600 Message-ID: <20200323230924.5161-1-jfehlig@suse.com> X-ClientProxiedBy: SN6PR16CA0056.namprd16.prod.outlook.com (2603:10b6:805:ca::33) To BY5PR18MB3315.namprd18.prod.outlook.com (2603:10b6:a03:196::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-Originating-IP: [75.169.23.17] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a07abe5b-8540-406b-2576-08d7cf7f44ff X-MS-TrafficTypeDiagnostic: BY5PR18MB3204: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-Forefront-PRVS: 0351D213B3 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4636009)(376002)(39840400004)(136003)(396003)(346002)(366004)(26005)(4326008)(186003)(6916009)(16526019)(8936002)(107886003)(81156014)(6486002)(52116002)(6506007)(86362001)(8676002)(81166006)(36756003)(66556008)(316002)(5660300002)(1076003)(66476007)(66946007)(6666004)(956004)(2616005)(4744005)(6512007)(478600001)(2906002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY5PR18MB3204; H:BY5PR18MB3315.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B6RQYXd3xGlXEZah7fGOzI/N+xWU1SGCBKRakTLOmggMoBKI9tOsnboZvDJMeKxtigk5uadnYLzyYHNZHm8u6x3AWhCg+cmX/IBHonrt47OkOQeinr3kNYbu+SInCUEdLrqvp+xe+WYDF4myyS40yj0NRvv1pt3+zXugzHekh09X3RP2WMlHOznamIHmMWiIfGQoPPGV1UhNqc9CQTdGJUU+LVhmIBnN7iV48d844x2PwBsJQPGsdqJBSzOP9xrwcZgE7dSYjo7F3fTW6QXPcrwWY7nf66j89WC1bI/jJPvyGr2xdgmtAIS1Fo/0QvbC2n4ZPbWnN+lXpHu1+QpYhazdGuOn3fbSVuQOgLipYPo3SgMdKzFmuNEkgtOEoQhUrcn8YJczlQh8Rc0JNlX2nDiA0eI//w3f38rfJ6LgLz2X8fDDOVko61qDoQZG5/P1 X-MS-Exchange-AntiSpam-MessageData: /udo1KSF8zHtYxurhgtnvBWeDn10L5+w40i+i5vlWbcZMhDSYnX5v56TA9BJMilJR05WVdVsGXOZA9151YMdQiS/xTqkhUCB7ANeQxkPSkn16hLGc9vtl2ofGiAoig6UfJuE4I9oKlka66xkpC2Niw== X-MS-Exchange-CrossTenant-Network-Message-Id: a07abe5b-8540-406b-2576-08d7cf7f44ff X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2020 23:09:42.4540 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JJwEVFIaH0wbsuv2vrqSrGgRWAoyB8mmX7gD93dib5dKn39Bqwlplg+hDcsR3AatO82KBa070/pBNCQ91TcIWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3204 X-OriginatorOrg: suse.com X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02NNCfgl019246 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Since the introduction of the 'index' attribute of a disk's element, test 207-disk-media-change.t is failing. The test is a bit flawed in that it compares initial and final domXML after changing the media of a cdrom disk device. The test only needs to check the final domXML to ensure the correct path exists at the end of the test. Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Erik Skultety --- scripts/domain/207-disk-media-change.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/domain/207-disk-media-change.t b/scripts/domain/207-di= sk-media-change.t index dfef7c9..7a43afc 100644 --- a/scripts/domain/207-disk-media-change.t +++ b/scripts/domain/207-disk-media-change.t @@ -98,5 +98,5 @@ EOF =20 my $finalxml =3D $dom->get_xml_description; =20 - is($initialxml, $finalxml, "final XML matches initial XML"); + ok($finalxml =3D~ m|$path1|, "final XML has properly updated media"); } --=20 2.25.0