From nobody Thu Apr 25 21:49:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1584654281; cv=none; d=zohomail.com; s=zohoarc; b=H5wXm9hQchwnF2FHjzZq17821YaI4fuO7olG3/R+hYS0ZYbaErHpDhT6YTpwxLd7d8cUhPfdMrxcyAbeCTOAqyijp8lVTFOPt3fA14S+aB1K3tt+bUPnVhONKjin+yvXFpYQ0lmmWDr5ReUQRRffjE6PphdA/RyWKZMVsUfA2k4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584654281; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8Hz9G1pKEBQtx9ozU5lC8fjVDOPN3zVJIT+pgFRUFU4=; b=ZA3yJG7tiL2BRInGN8wcNSToWGlkcZHB0rHR/G2TgO/DxTf8yF3ycYtPNH/BZpXE7xPyzh2Sd4KF1o2daEi0tm286oapVBjh7Tli05Dk7V46pymIIGwoPDiw58thTF3b9x3AP87M4frVsPc8tawD3ow+2PKdJBBMjJ55Nd8HTNg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 1584654281269215.491842967774; Thu, 19 Mar 2020 14:44:41 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-2Yz4gThANXmvbnrIX1GFoQ-1; Thu, 19 Mar 2020 17:44:37 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E54E61005510; Thu, 19 Mar 2020 21:44:31 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 452175D9CA; Thu, 19 Mar 2020 21:44:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E802118089C8; Thu, 19 Mar 2020 21:44:25 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02JLiN8e024889 for ; Thu, 19 Mar 2020 17:44:23 -0400 Received: by smtp.corp.redhat.com (Postfix) id 839FB1711C7; Thu, 19 Mar 2020 21:44:23 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast04.extmail.prod.ext.rdu2.redhat.com [10.11.55.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7F7B11711C4 for ; Thu, 19 Mar 2020 21:44:23 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EE797101A55D for ; Thu, 19 Mar 2020 21:44:22 +0000 (UTC) Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101-6Uyd2H4pOFiBoYBhnCDcHw-1; Thu, 19 Mar 2020 17:44:20 -0400 Received: by mail-qk1-f196.google.com with SMTP id c145so4821947qke.12 for ; Thu, 19 Mar 2020 14:44:20 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:a54:94b:6faa:a6b0:6b1b]) by smtp.gmail.com with ESMTPSA id c12sm2316347qkg.30.2020.03.19.14.44.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 14:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584654279; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8Hz9G1pKEBQtx9ozU5lC8fjVDOPN3zVJIT+pgFRUFU4=; b=h3Nxg5KLpXyR6agJ14xocuKGKDMmxpl6VE5KCuPNrnWUV0Nx+K6BU8smvv6zUaMwaqWnZ9 m8r635EsVNTXBLpbR+hVzqMRI/hqFpgIKAsxM+Rr/91OwiRdtPjs/HJBYk2LrXKV/pCFNs Y9squwR0vAg+tI5Zbd4lFHXhw/MO4Wc= X-MC-Unique: 2Yz4gThANXmvbnrIX1GFoQ-1 X-MC-Unique: 6Uyd2H4pOFiBoYBhnCDcHw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AYzHBzBnQQ9r4RKJHSn/N46ZiVWNDM3fIUcRq5oARgU=; b=P//NBVT3CkfspIp3QLDhBNF5W5Uren/cJga6nTcWsMq2hJfOaNrdcVmOK74mGe1JZd 46K8AChjwSuIhvBLCzs0aUFx1NEejysr1LGGQfdSYDUmx+3UKmtDbQV8gMFgqkLTr6x+ uaETW0afjffd0L+pNc7aUTA5eciFOADqi5QS7RZeOJBTuBbVWmw9GR4/IwpA4a3mAY76 QBjXC/lkN0R16zeBt3nx71GBwwzlerwKuxymegl5gj+9vOjOQDDFaDuy4O5HzUPoUWFu IKgqlYZPLvnoWSn8Bz16R/I8XYFIrhFPbu/aUYIHmOVopIcKwdUCZBwVC6/8hhfEXIBA SHJg== X-Gm-Message-State: ANhLgQ1cofHjFw7QdbKq9y68crmFA+cy/tKvoCgsBwy+SM6k8z8NNN1/ qKNyR5V/NCGSw4b091TWeUOlKUzY X-Google-Smtp-Source: ADFU+vv9XVHCwRVj0M6R6umU883e8NnHiVjFmpFRNeDdroHTl/U579al73KroZ6vy3btiRhS/gshTw== X-Received: by 2002:ae9:e894:: with SMTP id a142mr5267672qkg.379.1584654259726; Thu, 19 Mar 2020 14:44:19 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v1 1/4] qemu_domain.c: do not launch ppc64 guests with APIC-EOI setting Date: Thu, 19 Mar 2020 18:44:04 -0300 Message-Id: <20200319214407.714006-2-danielhb413@gmail.com> In-Reply-To: <20200319214407.714006-1-danielhb413@gmail.com> References: <20200319214407.714006-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02JLiN8e024889 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The "" feature, although it's not available for pseries, can be declared in the domain XML of ppc64 guests without errors. But setting its 'eoi' attribute will break QEMU. For "": qemu-kvm: Expected key=3Dvalue format, found +kvm_pv_eoi A similar error happens with eoi=3D'off'. One can argue that it's better to simply forbid launching ppc64 guests with "" declared in the ppc64 XML - it is a feature that the architecture doesn't support and this would make it clearer about it. This is sensible, but there are ppc64 guests that are running with "" declared in the domain (and A LOT of guests running with "" for that matter, probably reminiscent of x86 templates that were reused for ppc64) that will stop working if we go this route. A more subtle approach is to detect if the 'eoi' element is being set for ppc64 guests, and warn the user about it with a better error message than the one QEMU provides. This is the new error message when any value is set for the 'eoi' element: error: unsupported configuration: The 'eoi' attribute of the 'apic' feature is not supported for architecture 'ppc64' or machine type 'pseries'. Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index edc8ba2ddb..381b62b96a 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5262,8 +5262,26 @@ qemuDomainDefValidateFeatures(const virDomainDef *de= f, } break; =20 - case VIR_DOMAIN_FEATURE_ACPI: case VIR_DOMAIN_FEATURE_APIC: + /* the declaration is harmless for ppc64, but + * its 'eoi' attribute isn't. To detect if 'eoi' was + * present in the XML we can check the tristate switch + * of def->apic_eoi */ + if (def->features[i] !=3D VIR_TRISTATE_SWITCH_ABSENT && + def->apic_eoi !=3D VIR_TRISTATE_SWITCH_ABSENT && + ARCH_IS_PPC64(def->os.arch)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("The 'eoi' attribute of the '%s' feature " + "is not supported for architecture '%s' o= r " + "machine type '%s'"), + featureName, + virArchToString(def->os.arch), + def->os.machine); + return -1; + } + break; + + case VIR_DOMAIN_FEATURE_ACPI: case VIR_DOMAIN_FEATURE_PAE: case VIR_DOMAIN_FEATURE_HAP: case VIR_DOMAIN_FEATURE_VIRIDIAN: --=20 2.25.1 From nobody Thu Apr 25 21:49:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) client-ip=216.205.24.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1584654298; cv=none; d=zohomail.com; s=zohoarc; b=XYXZy2I6Xftia2oiunIryts4sdwcYiHkc9z+d6F1KTO/yuL1ILq75c1NIAJqc8ZdvWh72YLPRfIx4AAshLI1r1G+bTYJBJrqlJCZhztI+3v8dIiJMiibKyXTouhGQzw6kHbKCwr9384F5fPceJfepVYZ/5I5pQJyiHo03MRHzJI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584654298; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TfSzEkHClytR7NTrJgu2H8esU+sJYY1fy98HM9oNpEo=; b=Hkc6FTd6JVJQNxpCAZTmMeBZgWR40LbyHnEGnzvWXzBx0zGNWX2yAXt9ep6lAR5b5K3N97MXC+MeuxtX3oW8LkIPqYtv7932t/MCsIIMEW9CtJCqViMzu0UXYnUMvv+XZXis86LQCE7kyWzQ4qa/PuqlbGNCqi70HgUjxmFIVvo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 216.205.24.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by mx.zohomail.com with SMTPS id 1584654298684185.73685790904813; Thu, 19 Mar 2020 14:44:58 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-369-_duHH8ysO--pmw2iCtAzVQ-1; Thu, 19 Mar 2020 17:44:55 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 55B8E100550D; Thu, 19 Mar 2020 21:44:49 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 29423579F; Thu, 19 Mar 2020 21:44:49 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id D6BAE18089C8; Thu, 19 Mar 2020 21:44:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02JLicZq024931 for ; Thu, 19 Mar 2020 17:44:39 -0400 Received: by smtp.corp.redhat.com (Postfix) id D6F8C1054598; Thu, 19 Mar 2020 21:44:38 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D2DF61054F17 for ; Thu, 19 Mar 2020 21:44:36 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0E32C8F68E1 for ; Thu, 19 Mar 2020 21:44:36 +0000 (UTC) Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-xeCGI01xO6-oWy1vijQiMA-1; Thu, 19 Mar 2020 17:44:21 -0400 Received: by mail-qk1-f195.google.com with SMTP id c145so4822055qke.12 for ; Thu, 19 Mar 2020 14:44:21 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:a54:94b:6faa:a6b0:6b1b]) by smtp.gmail.com with ESMTPSA id c12sm2316347qkg.30.2020.03.19.14.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 14:44:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584654297; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=TfSzEkHClytR7NTrJgu2H8esU+sJYY1fy98HM9oNpEo=; b=Ta+z8cS2qlwPnMovJ2iikc1ZIkXevTwzH8lonxJnzGaWZ/9JVkJKroOvIJgndvtBXHPq5y rh08K/CcjU3nLCOfj+ZwQoW8nLHZBs2C0Jkqh95m0xOLe4L75f8szRerww4DyFwCb2kL5A 3bLcwORz0xQzxfUGlwsWpRxZ5gax11o= X-MC-Unique: _duHH8ysO--pmw2iCtAzVQ-1 X-MC-Unique: xeCGI01xO6-oWy1vijQiMA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fO6KORkc7EZEogqirQdVI1dgLyZyEWEwAsWc/e87eIc=; b=t9x+LP7xTYUtIc/WMDvV6/3ZM/ZXodnc6V/6R9o4RKqzYx6t9SRahxhUhrTIF0Ph1F H7RdWbKX0WAaPfbYIVImL95qP8KolgwfvweYyq8nBeXTrfGXN320fF6dIpB5LKnvYhP6 kpB+3rj46iFM8aqvEIo3ScbedMI/zX7nlBqu6PX4V/Ge0zPNdCHPYrAH2b/j/45Kh22e tyjju1TuZdZKbSDEoM1YBuUA0/cSQ1pGjZA+EuZ8GVosFqdphUX3MmY9iP7brsLZeysQ DptW8a6ZloMYvLU2CQt2sbtW7F/6UR5lWuB1ehdqKBfyFXMUo81wbNwinOO1dk8XgPlb Jv1g== X-Gm-Message-State: ANhLgQ0RZgBLx2KjP+sKcyOrG+665HGTW4HffUMkLLSWNimdBrms83B5 n8uZA+v42Ixni1vmx1jgsEMz33OQ X-Google-Smtp-Source: ADFU+vvGKS+Zbm9899486sVMG202ciCAzbTSWdz3VPiY/1bPZaA5uxa3TfTRohslyyqi29mvLV5WQA== X-Received: by 2002:a37:4f51:: with SMTP id d78mr5148138qkb.28.1584654261225; Thu, 19 Mar 2020 14:44:21 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v1 2/4] qemu_domain.c: do not launch ppc64 guests with 'pvspinlock' setting Date: Thu, 19 Mar 2020 18:44:05 -0300 Message-Id: <20200319214407.714006-3-danielhb413@gmail.com> In-Reply-To: <20200319214407.714006-1-danielhb413@gmail.com> References: <20200319214407.714006-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02JLicZq024931 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" PowerPC does not support the 'pvspinlock' feature. The "" declaration will always have a value 'on' or 'off', and both will break QEMU when launching. This is the error message for "": qemu-kvm: Expected key=3Dvalue format, found +kvm_pv_unhalt A similar error message is thrown for "". This patch prevents the pseries guest from launching with any pvspinlock setting with a more informative error message: error: unsupported configuration: The 'pvspinlock' feature is not supported for architecture 'ppc64' or machine type 'pseries' Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 381b62b96a..c67abec778 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5281,13 +5281,25 @@ qemuDomainDefValidateFeatures(const virDomainDef *d= ef, } break; =20 + case VIR_DOMAIN_FEATURE_PVSPINLOCK: + if (def->features[i] !=3D VIR_TRISTATE_SWITCH_ABSENT && + ARCH_IS_PPC64(def->os.arch)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("The '%s' feature is not supported for " + "architecture '%s' or machine type '%s'"), + featureName, + virArchToString(def->os.arch), + def->os.machine); + return -1; + } + break; + case VIR_DOMAIN_FEATURE_ACPI: case VIR_DOMAIN_FEATURE_PAE: case VIR_DOMAIN_FEATURE_HAP: case VIR_DOMAIN_FEATURE_VIRIDIAN: case VIR_DOMAIN_FEATURE_PRIVNET: case VIR_DOMAIN_FEATURE_HYPERV: - case VIR_DOMAIN_FEATURE_PVSPINLOCK: case VIR_DOMAIN_FEATURE_CAPABILITIES: case VIR_DOMAIN_FEATURE_PMU: case VIR_DOMAIN_FEATURE_MSRS: --=20 2.25.1 From nobody Thu Apr 25 21:49:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1584654281; cv=none; d=zohomail.com; s=zohoarc; b=FGcZUvaFQD3HbN+7VFph1fraoTCT5K1nyQeajLjcDRcJEQusOrxPlEezLZupqTPJu7Y98UoxLEhRvNNVhyI1LcIu72YdN8JU/aUEsIw4iHNcrt4wOf6MgmxLvV1lXv898Snfjiv97GwYYW3kQmT5mQNyKPFOgEPtYs34aFdJ33w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584654281; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eebN6oXhWgJUdtonBWA4NDvjiQ072nTghmRLhainIrc=; b=i4yiM7G46bSa1sYNptQxDIYeL84cyBQGy5DG6kz6GGvBR9qVLIstlfUuresqJ8/ghRLAZyJfPziVUJs60MxZ14RK/Z+NAd94rKdgykZ9adI2ENi82vJ0hJBdLBZyrMwVjVnE8CWtpEyynUvvmrqWugVK5ilCT+RUTshMTtVoESQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 1584654281212480.19514277708095; Thu, 19 Mar 2020 14:44:41 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-476-QESUEhN_MluxjBW4lbWbCQ-1; Thu, 19 Mar 2020 17:44:37 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3C50F8017CC; Thu, 19 Mar 2020 21:44:32 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CF1B291295; Thu, 19 Mar 2020 21:44:31 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 34E1918089CD; Thu, 19 Mar 2020 21:44:28 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02JLiP6i024900 for ; Thu, 19 Mar 2020 17:44:26 -0400 Received: by smtp.corp.redhat.com (Postfix) id D7EEC1711C6; Thu, 19 Mar 2020 21:44:25 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D3A9516C8FF for ; Thu, 19 Mar 2020 21:44:25 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B9D388F68E1 for ; Thu, 19 Mar 2020 21:44:25 +0000 (UTC) Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-w3E1C-mLOxiAZhfwkRqJDQ-1; Thu, 19 Mar 2020 17:44:23 -0400 Received: by mail-qk1-f194.google.com with SMTP id x18so4831985qki.10 for ; Thu, 19 Mar 2020 14:44:23 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:a54:94b:6faa:a6b0:6b1b]) by smtp.gmail.com with ESMTPSA id c12sm2316347qkg.30.2020.03.19.14.44.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 14:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584654280; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=eebN6oXhWgJUdtonBWA4NDvjiQ072nTghmRLhainIrc=; b=HDPoEqAXlGEUM59DR8yPI3kpzRTx9gQFCLrYrNhw0tHW2Ik1Kxz6tN5kJIQ1nBja6eBPyZ 7F2we2W+B3MD5rcS4meKizW7sKciwmhBEijlbZtUWkNjy/wdmaItSFstTmEy7pY9bGSZzb gSm60P7HrNOjOwdiO1A1P1Q2J79oVSU= X-MC-Unique: QESUEhN_MluxjBW4lbWbCQ-1 X-MC-Unique: w3E1C-mLOxiAZhfwkRqJDQ-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/BFB8J6QWBElQrqKI1dKwrrEwmDXvUp0mleXqpa8VOo=; b=NJO79ZRjVhQ++V+fQo2eYSzZwSBlYfgtkdAr2sCvK0FrT6rW7vR7Nc2fjjw8QRQZEi 7Q4pl92rwo5kFa97GV65hQwx+M8/tUQUjuZVAqBkT6dii4tepqe65w9yKQW2m5GuUNLm XboLDHjxSjJiM89Y2r8gUa6AjpmfK71RRS9A0Dj/blCpr6sASpRwYQn497c+f+h69J5+ e+m5uPwGdPlJT5v7IRpuyouR8l9sbQ6KdNWKUIvRcKwACYFUd61qnp9iAJJwdqxSeE+s VBLvQ7yl3wLOVe+x/FhNicl06K1gEfRwLCe+sTjOLZ5ls/axZrPva+GQ0sgzsZUO8P1g /bjQ== X-Gm-Message-State: ANhLgQ1wiUKofJbb20Ro6lKnVMe2zvEDFFzdZ6Ks63xoPP5h3FoPkPwp Atg8gaBKwi1PXRTm0MHxq8sKaFBd X-Google-Smtp-Source: ADFU+vtOhMCE1kIB1qR25Y0HTT1TvAKeANEpLoPNAWZMxptIMspBu74u5wNq5pgziRBpnnfRF+2iLw== X-Received: by 2002:a37:a44b:: with SMTP id n72mr5289992qke.471.1584654262548; Thu, 19 Mar 2020 14:44:22 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v1 3/4] qemu_domain.c: do not launch ppc64 guests with 'pmu' setting Date: Thu, 19 Mar 2020 18:44:06 -0300 Message-Id: <20200319214407.714006-4-danielhb413@gmail.com> In-Reply-To: <20200319214407.714006-1-danielhb413@gmail.com> References: <20200319214407.714006-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02JLiP6i024900 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" The Perfomance Monitoring Unit (PMU) feature is not available for the Power architecture. The "" feature will always have a value 'on' or 'off' after saving the domain XML, and both will be rejected by QEMU when launching. This is the error message for "": qemu-kvm: can't apply global host-powerpc64-cpu.pmu=3Don: Property '.pmu' n= ot found A similar error message is thrown for "". This patch prevents the pseries guest from launching with any pmu setting with a more informative error message: error: unsupported configuration: The 'pmu' feature is not supported for architecture 'ppc64' or machine type 'pseries' Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index c67abec778..2e5f987a04 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5282,6 +5282,7 @@ qemuDomainDefValidateFeatures(const virDomainDef *def, break; =20 case VIR_DOMAIN_FEATURE_PVSPINLOCK: + case VIR_DOMAIN_FEATURE_PMU: if (def->features[i] !=3D VIR_TRISTATE_SWITCH_ABSENT && ARCH_IS_PPC64(def->os.arch)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, @@ -5301,7 +5302,6 @@ qemuDomainDefValidateFeatures(const virDomainDef *def, case VIR_DOMAIN_FEATURE_PRIVNET: case VIR_DOMAIN_FEATURE_HYPERV: case VIR_DOMAIN_FEATURE_CAPABILITIES: - case VIR_DOMAIN_FEATURE_PMU: case VIR_DOMAIN_FEATURE_MSRS: case VIR_DOMAIN_FEATURE_LAST: break; --=20 2.25.1 From nobody Thu Apr 25 21:49:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) client-ip=63.128.21.74; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-74.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1584654296; cv=none; d=zohomail.com; s=zohoarc; b=dn8niLrBTDXTpBFQYeDN6cmM4EdanAkWaeFnlqAJjKpnteny/2Hm3DUWu/W29duXlWHuDrC1IzbSpwbfsZjFrBVStxOpyWWdEVtvWfGPO8xN6VdPhGmfIjTQBnYJSt6tls1mKZeLo8lbXAdmnnI8CaXT2cwhTuKD1qtrmwqKDuc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584654296; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L4NW+OblgLkXP8eZSy2spnC1P6cfYVZkyM6UkeXh0oQ=; b=D0iiCT8sruhgHHSSRERxwENnjAf+3oJHLJLdyAGPI3lYnx0VqNlEivQ3o1hHYED/r4wmBmjxEMwaGtMjK2F7mk0e09QnhA3zvxnj/Fq1lQa/8qDjPtAgRFgERBTYd8hKONRPOGeKPiZ9H4zLS/ugPrSxTmqJAt6CJog9D5ikeW0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 63.128.21.74 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by mx.zohomail.com with SMTPS id 1584654296027810.2805549380611; Thu, 19 Mar 2020 14:44:56 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-454-9vGhmf-nNqKwGwc_2f4VSg-1; Thu, 19 Mar 2020 17:44:51 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A383D8010D9; Thu, 19 Mar 2020 21:44:45 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7A9EA19C58; Thu, 19 Mar 2020 21:44:45 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 32FF894293; Thu, 19 Mar 2020 21:44:45 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02JLiVNS024920 for ; Thu, 19 Mar 2020 17:44:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 247612093CC5; Thu, 19 Mar 2020 21:44:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 20A192028DCC for ; Thu, 19 Mar 2020 21:44:27 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2C50B8007A4 for ; Thu, 19 Mar 2020 21:44:27 +0000 (UTC) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-112-Z4gSoDBqNmCV99NxGibuSw-1; Thu, 19 Mar 2020 17:44:24 -0400 Received: by mail-qk1-f170.google.com with SMTP id d11so4896023qko.3 for ; Thu, 19 Mar 2020 14:44:24 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:a54:94b:6faa:a6b0:6b1b]) by smtp.gmail.com with ESMTPSA id c12sm2316347qkg.30.2020.03.19.14.44.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 14:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584654293; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=L4NW+OblgLkXP8eZSy2spnC1P6cfYVZkyM6UkeXh0oQ=; b=KoepHyof8YXMarrqHhvwaz+1Ygdet9C71jmfShvt8hl+XT0GfCEKUBXl8ZHYv295NSYjFH oSGxi3LpeemGfEy7cLBH0U68zNMO3O+woGqs/4dRqHp+BQJmgkGyQNQhGm4YYST6FQ0x7+ xwn+Gooeay3Ppaa4lDHIwUqwj4K4ROw= X-MC-Unique: 9vGhmf-nNqKwGwc_2f4VSg-1 X-MC-Unique: Z4gSoDBqNmCV99NxGibuSw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4YLnmj0TouOvET00c7pofAubmN0oM03Ah2iQapaQS1s=; b=sQrP8glcxBJxo3gxhu8aOObtRCYqtF5N3ETGSiDAS0fbZ+wy9ZAZ49LpSwg0fdQgtd WV9/w6Mh6laRtBDk4kqF4l803mjdLhr+ARnUYCDMU6h2ACsE1KfqA3rOnsG7mVNNi40Y sXbBmqu+qOEXjcPsFcv1jXM8gXMoYlBX8RqRo2JqRlRMYCuSpZZv/+J3qY49Y35htMZI HvFuXuOuSFCTGyMIqpfqoZyquUCCgop3HZBdle+tlqEYndPmoQeaNd7z5aFPOSZhefM+ zApfPlubDBnAT1+isAIxNoe3kWoYiPjBI2wVIRJVVUzhiVCcH4IW+e4nOq18vwog/Ukw JexQ== X-Gm-Message-State: ANhLgQ2xPuxT8DwwzNOl3LV6sWR6eEDePELxdGusyKJfo5fh8VDs7WGN pVPAdKV4l98IbvTLane6P/GPQIvn X-Google-Smtp-Source: ADFU+vtt0eGOtbPPCqbrdx54mV6VxmWn+QBC80TTZefsFUn9cxp0wZ8T7HfX9MaJRglDYVLLSMXhTA== X-Received: by 2002:a37:4f93:: with SMTP id d141mr5027363qkb.125.1584654264151; Thu, 19 Mar 2020 14:44:24 -0700 (PDT) From: Daniel Henrique Barboza To: libvir-list@redhat.com Subject: [PATCH v1 4/4] qemu_domain.c: do not launch ppc64 guests with Hyperv settings Date: Thu, 19 Mar 2020 18:44:07 -0300 Message-Id: <20200319214407.714006-5-danielhb413@gmail.com> In-Reply-To: <20200319214407.714006-1-danielhb413@gmail.com> References: <20200319214407.714006-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 02JLiVNS024920 X-loop: libvir-list@redhat.com Cc: Daniel Henrique Barboza X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" Hyperv features aren't supported in QEMU for ppc64. The declaration in the XML by itself is benign, but any of its 14 current features will break QEMU with an error like this: qemu-kvm: Expected key=3Dvalue format, found hv_relaxed This is a more extreme case than the one for apic eoi because we would need an extra 'switch' statement, with all current Hyperv features in the body of qemuDomainDefValidateFeatures(), to check if the user attempted to activate any of them. It's easier to simply fail to launch with any 'hyperv' declaration in the XML for ppc64 guests. A fair disclaimer about Windows and PowerPC: the last Windows version that ran in the architecture is the hall of famer Windows NT 4.0, launched in 1996 and with end of extended support for the Server version in 2004 [1]. I am acknowledging that there might be Windows NT 4.0 users running in PowerPC, but not enough people running it under KVM/QEMU to justify Libvirt allowing 'hyperv' to exist in the domain XML of ppc64 domains. [1] https://en.wikipedia.org/wiki/Windows_NT_4.0 Signed-off-by: Daniel Henrique Barboza --- src/qemu/qemu_domain.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index 2e5f987a04..ba458bfde9 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -5295,12 +5295,23 @@ qemuDomainDefValidateFeatures(const virDomainDef *d= ef, } break; =20 + case VIR_DOMAIN_FEATURE_HYPERV: + if (def->features[i] !=3D VIR_TRISTATE_SWITCH_ABSENT && + ARCH_IS_PPC64(def->os.arch)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, + _("Hyperv features are not supported for " + "architecture '%s' or machine type '%s'"), + virArchToString(def->os.arch), + def->os.machine); + return -1; + } + break; + case VIR_DOMAIN_FEATURE_ACPI: case VIR_DOMAIN_FEATURE_PAE: case VIR_DOMAIN_FEATURE_HAP: case VIR_DOMAIN_FEATURE_VIRIDIAN: case VIR_DOMAIN_FEATURE_PRIVNET: - case VIR_DOMAIN_FEATURE_HYPERV: case VIR_DOMAIN_FEATURE_CAPABILITIES: case VIR_DOMAIN_FEATURE_MSRS: case VIR_DOMAIN_FEATURE_LAST: --=20 2.25.1