From nobody Wed May 15 20:36:15 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) client-ip=205.139.110.61; envelope-from=libvir-list-bounces@redhat.com; helo=us-smtp-delivery-1.mimecast.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584124990; cv=none; d=zohomail.com; s=zohoarc; b=gcl5aw6yLqpLBwi5VqzWOQNkte11aDibrqXu0eJikqaUoKy5EL31eiljvAROYJNFhJBUOPmYCmZnzoSbjRopzeIkVLRd7DPUDcKiiP/M+VXxLC5t1dLio8wbvVOpRL1y7huALPV1n8fuuJBA72Qg3gjPBoENy4ljAmvEbBKHiu8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584124990; h=Content-Type:Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=c+iZjwPyBzVvuBAiew++05Q337mW58K0M6/dUcQ2TSs=; b=iztORzk26N0QPSsvkY6wxInzq3I9z0xU7CQLkS2uGklcsFT9AZP1cTTY4RmaTEozofks8YgEUpG5UTK2Jlu+H1G7PfmEfSORoI9ZDk+YMFTyRcnGmEPDbiOGfiWFcjFeQ2k0jXCumK3++P8q7iwu6v9Ng8GfHRMkXg3Y0jTKT48= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of redhat.com designates 205.139.110.61 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by mx.zohomail.com with SMTPS id 1584124990632146.58451018509072; Fri, 13 Mar 2020 11:43:10 -0700 (PDT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-_2dpPRQfPj6GJxijH5jlgw-1; Fri, 13 Mar 2020 14:43:00 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A98058CBA44; Fri, 13 Mar 2020 18:42:54 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E884F8FC05; Fri, 13 Mar 2020 18:42:52 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 25AFD85EC8; Fri, 13 Mar 2020 18:42:48 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 02DIgkBS014833 for ; Fri, 13 Mar 2020 14:42:46 -0400 Received: by smtp.corp.redhat.com (Postfix) id 63DC060C81; Fri, 13 Mar 2020 18:42:46 +0000 (UTC) Received: from localhost.localdomain.com (ovpn-112-40.ams2.redhat.com [10.36.112.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id ADA8360C63; Fri, 13 Mar 2020 18:42:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584124989; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=c+iZjwPyBzVvuBAiew++05Q337mW58K0M6/dUcQ2TSs=; b=hH44SXotoFsyLAbnjTlIjr9KyWGDXrbrmj70HTtiE3gmlgClD98aT8nA1BDQ1oVHDr7lGp J/WjfpRCcOjkMMR60yxqh6N+gJ2JPwEDrTtUP7oEI8XkFVbLKXRM+VjP6hkU1Q6Q7irtxJ BW/2wI3kYibjHKdJaUDmgGBsLrtSOfQ= X-MC-Unique: _2dpPRQfPj6GJxijH5jlgw-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: libvir-list@redhat.com Subject: [libvirt PATCH] build: workaround behaviour regression in gnu make 4.3 Date: Fri, 13 Mar 2020 18:42:40 +0000 Message-Id: <20200313184240.1527484-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-loop: libvir-list@redhat.com X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" We need the "$(space)" variable to contain a single whitespace character. We do this by assigning and then appending an empty string to the variable. Variable appends get separated by a single whitespace historically, but GNU make 4.3 introduced a behaviour regression. https://lists.gnu.org/archive/html/bug-make/2020-01/msg00057.html [quote] * WARNING: Backward-incompatibility! Previously appending using '+=3D' to an empty variable would result in a value starting with a space. Now the initial space is only added if the variable already contains some value. Similarly, appending an empty string does not add a trailing space. [/quote] This patch tries a new trick to get a single whitespace by getting make to expand two non-existant variables separated by a space. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Eric Blake --- build-aux/syntax-check.mk | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index b829c8a18b..3020921be8 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -687,8 +687,7 @@ msg_gen_function +=3D virLastErrorPrefixMessage # msg_gen_function +=3D vshPrint # msg_gen_function +=3D vshError =20 -space =3D -space +=3D +space =3D $(null) $(null) func_re=3D ($(subst $(space),|,$(msg_gen_function))) =20 # Look for diagnostics that aren't marked for translation. --=20 2.24.1